[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 144889. https://reviews.llvm.org/D45628 Files: packages/Python/lldbsuite/test/linux/compressed-debug-info/Makefile packages/Python/lldbsuite/test/linux/compressed-debug-info/TestCompressedDebugInfo.py

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 144834. alur edited the summary of this revision. alur added a comment. Since there was some changes to the file during the last couple of days I've updated the patches to be against HEAD again. https://reviews.llvm.org/D45628 Files:

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur added a comment. Thank you David. This is still based on the latest revision of the file (+ the non functional change patch). F6048729: nfc.patch https://reviews.llvm.org/D45628 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

davide added a comment. This is fine, I'll commit it for you today. https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

lemo added subscribers: bgianfo, clayborg, alur, labath, penryu, lemo. lemo added a comment. Hi Erik, the review is still marked as requiring changes. Once that is sorted out I'd be happy to submit this on your behalf (what is the base SVN revision for the latest patch?) Davide Italiano, is all

Re: [Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

Hi Erik, the review is still marked as requiring changes. Once that is sorted out I'd be happy to submit this on your behalf (what is the base SVN revision for the latest patch?) Davide Italiano, is all the CR feedback addressed in the latest revision? On Tue, Apr 24, 2018 at 1:38 PM, Erik

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur added a comment. Friendly ping, is there anything else I need to do for this to get submitted? https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur marked 3 inline comments as done. alur added a comment. Thank you, I do need someone to push this on my behalf. https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 142962. https://reviews.llvm.org/D45628 Files: packages/Python/lldbsuite/test/linux/compressed-debug-info/Makefile packages/Python/lldbsuite/test/linux/compressed-debug-info/TestCompressedDebugInfo.py

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Some minor comments, almost ready to go. Do you have commit access or you need somebody to push this on your behalf? Comment at:

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

clayborg accepted this revision. clayborg added a comment. Very nice! https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 142875. alur marked an inline comment as done. alur added a comment. Changed the diff to be against the NFCs. https://reviews.llvm.org/D45628 Files: packages/Python/lldbsuite/test/linux/compressed-debug-info/Makefile

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur marked an inline comment as done. alur added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1773-1781 +static SectionType getSectionType(llvm::StringRef section_name) { + llvm::StringRef mapped_name; + if (section_name.startswith(".zdebug"))

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 142869. https://reviews.llvm.org/D45628 Files: packages/Python/lldbsuite/test/linux/compressed-debug-info/Makefile packages/Python/lldbsuite/test/linux/compressed-debug-info/TestCompressedDebugInfo.py

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 142862. https://reviews.llvm.org/D45628 Files: packages/Python/lldbsuite/test/linux/compressed-debug-info/Makefile packages/Python/lldbsuite/test/linux/compressed-debug-info/TestCompressedDebugInfo.py

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

labath added a comment. Thank you for the patch. For testing I'd recommend taking a look at r320813 https://reviews.llvm.org/D40616, which implemented the SHF_COMPRESSED part of the compressed section support. It looks like we should add a new field to the "lldb-test module-sections" output,

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

davide added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1773-1781 +static SectionType getSectionType(llvm::StringRef section_name) { + llvm::StringRef mapped_name; + if (section_name.startswith(".zdebug")) { +mapped_name =

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1893 sect_type = eSectionTypeDWARFDebugAbbrev; - else if (name == g_sect_name_dwarf_debug_addr) + else if (name == g_sect_name_dwarf_debug_addr || + name ==

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 142478. alur marked 7 inline comments as done. alur added a comment. I refactored the code to address the comments on it. I'll add those tests once I get the test runner to work. https://reviews.llvm.org/D45628 Files:

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

clayborg added a comment. We should test both ways: using normal DWARF section names with SHF_COMPRESSED, and with ".zdebug" prefixed section names. https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

aprantl added a comment. Thanks for clarifying. You'll also need to add a testcase. If clang supports this then I don't have a problem with supporting this in LLDB and adding a testcase should be easy. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1893

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

dblaikie added a comment. In https://reviews.llvm.org/D45628#1067375, @aprantl wrote: > Which compilers / platforms generate / support this? Is this an ELF-only > feature? Clang/LLVM do (-Wa,--compress-debug-sections). Yeah, it's ELF only so far as I know. There's a couple of variations

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

clayborg added a comment. If this is for current and future debugging, it would be nice to change the tool to just use the normal .debug prefixes and just specify SHF_COMPRESSED??? https://reviews.llvm.org/D45628 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

clayborg added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2937-2938 { static const char *debug_prefix = ".debug"; + static const char *zdebug_prefix = ".zdebug"; Might be worth making these llvm::StringRef, then see

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

aprantl added a comment. Which compilers / platforms generate / support this? Is this an ELF-only feature? https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

davide added subscribers: jasonmolenda, davide. davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This requires an unittest (or an lldb-test test). Some comments inline. I think @clayborg or @jasonmolenda are in a better position to

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur created this revision. alur added reviewers: labath, clayborg. alur added a project: LLDB. Herald added subscribers: llvm-commits, JDevlieghere, arichardson, aprantl, emaste. Herald added a reviewer: espindola. Repository: rL LLVM https://reviews.llvm.org/D45628 Files: