[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

This revision was automatically updated to reflect the committed changes. lawrence_danna marked an inline comment as done. Closed by commit rG0f783599a4c6: delete SWIG typemaps for FILE* (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:655 + auto new_file = PythonFile::FromFile(file, mode); + if (!new_file) +

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:655 + auto new_file = PythonFile::FromFile(file, mode); + if (!new_file) +return false;

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

lawrence_danna updated this revision to Diff 225081. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. put in missing consumeError() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68963/new/

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

labath added a comment.  Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:655 + auto new_file = PythonFile::FromFile(file, mode); + if (!new_file) +return false; You'll need to handle the error here. (And it would be

[Lldb-commits] [PATCH] D68963: delete SWIG typemaps for FILE*

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added parent revisions: D68962: update ScriptInterpreterPython to use File, not FILE*, D68960: remove FILE* usage from SBStream.i. The SWIG