[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

labath added a comment. (Btw, if you're looking for things to FileCheck-ify, I think the stuff under `lldb/unittests/UnwindAssembly` is a prime candidate and has a much higher bang/buck ratio.) https://reviews.llvm.org/D43048 ___ lldb-commits

[Lldb-commits] [PATCH] D43099: Make LLDB's clang module cache path customizable

labath added a comment. There are several components in the "command line parsing" 1. argparse: parsing a single string into the individual words (processing quotes, backslashes, etc.) 2. resolving the "command" part of the command line (the "frame variable" part of "frame variable

[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

labath added inline comments. Comment at: CMakeLists.txt:73-80 + if ("${LLDB_TEST_C_COMPILER}" STREQUAL "") +set(LLDB_TESTING_DEFAULT_C_COMPILER ON) + endif() + + if ("${LLDB_TEST_CXX_COMPILER}" STREQUAL "") +set(LLDB_TESTING_DEFAULT_CXX_COMPILER ON) + endif()

[Lldb-commits] [lldb] r324870 - Skip TestTargetXMLArch on non-darwin OSs

Author: labath Date: Mon Feb 12 01:46:06 2018 New Revision: 324870 URL: http://llvm.org/viewvc/llvm-project?rev=324870=rev Log: Skip TestTargetXMLArch on non-darwin OSs This test uses XML packets, but libxml is an optional dependency of lldb, and this test fails if it is not present. I'm

Re: [Lldb-commits] [lldb] r324743 - [Testsuite] Remove leak tests, it's not useful anymore.

I think you misunderstood the purpose the purpose of this test. The test was there to make sure that *lldb* does not leak file descriptors into the inferior (when I wrote it a couple of years ago, we were leaking about half a dozen of them). The python version check was added there just because we

[Lldb-commits] [PATCH] D42955: Make Module::GetSectionList output consistent

clayborg added inline comments. Herald added a subscriber: arichardson. Comment at: source/Core/Module.cpp:1286 +if (SymbolVendor *vendor = GetSymbolVendor()) + vendor->CreateSections(*GetUnifiedSectionList()); } should we pass "obj_file" down into

Re: [Lldb-commits] [lldb] r324743 - [Testsuite] Remove leak tests, it's not useful anymore.

Apologies, I clearly misunderstood. I'll add this again. On Mon, Feb 12, 2018 at 2:52 AM, Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > I think you misunderstood the purpose the purpose of this test. The > test was there to make sure that *lldb* does not leak file

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide added a comment. In https://reviews.llvm.org/D43048#1004807, @labath wrote: > (Btw, if you're looking for things to FileCheck-ify, I think the stuff under > `lldb/unittests/UnwindAssembly` is a prime candidate and has a much higher > bang/buck ratio.) If you have ideas on how to

[Lldb-commits] [lldb] r324919 - [testsuite] Reintroduce test to check leaking.

Author: davide Date: Mon Feb 12 10:06:34 2018 New Revision: 324919 URL: http://llvm.org/viewvc/llvm-project?rev=324919=rev Log: [testsuite] Reintroduce test to check leaking. It wasn't python leaking, it was lldb. Thanks to Pavel for the explanation. Pointy-hat to me. Added:

[Lldb-commits] [PATCH] D43202: Remove dead code for handling DWARF pubnames

This revision was automatically updated to reflect the committed changes. Closed by commit rL324925: Remove dead code for handling DWARF pubnames (authored by amccarth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r324925 - Remove dead code for handling DWARF pubnames

Author: amccarth Date: Mon Feb 12 11:19:04 2018 New Revision: 324925 URL: http://llvm.org/viewvc/llvm-project?rev=324925=rev Log: Remove dead code for handling DWARF pubnames Summary: LLDB doesn't use this code, the code has no tests, and the code does suspicious things like hashing pointers to

[Lldb-commits] [PATCH] D43096: [lit] Update how clang and other binaries are found in per-configuration directories

asmith updated this revision to Diff 133899. Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43096 Files: CMakeLists.txt lit/CMakeLists.txt lit/lit.site.cfg.in Index: lit/lit.site.cfg.in

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

Ah, no. Pavel suggested that the unwind plan unittests should be turned into FileCheck tests, and then Davide suggested that he'd heard unwind testing is difficult (he was conflating the unwind sources -> UnwindPlan IR conversions and the runtime use of UnwindPlans to walk the stack & find

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

Sure I don’t think anyone disputes that, but I thought we were discussing an ideal end state On Mon, Feb 12, 2018 at 1:31 PM Jason Molenda wrote: > > > > On Feb 12, 2018, at 12:59 PM, Zachary Turner wrote: > > > > > > > > On Mon, Feb 12, 2018 at 12:52 PM

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

zturner added a comment. In https://reviews.llvm.org/D43048#1005513, @jasonmolenda wrote: > No, the unwind unittests that exist today should stay written as unit tests. > These are testing the conversion of native unwind formats -- for instance, > eh_frame, compact unwind, or instruction

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

jasonmolenda added a comment. No, the unwind unittests that exist today should stay written as unit tests. These are testing the conversion of native unwind formats -- for instance, eh_frame, compact unwind, or instruction analysis -- into the intermediate UnwindPlan representation in lldb.

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

On Mon, Feb 12, 2018 at 12:52 PM Jason Molenda wrote: > > > > On Feb 12, 2018, at 12:48 PM, Zachary Turner via Phabricator < > revi...@reviews.llvm.org> wrote: > > > > zturner added a comment. > > > > In https://reviews.llvm.org/D43048#1005513, @jasonmolenda wrote: > > > > I

[Lldb-commits] [PATCH] D43202: Remove dead code for handling DWARF pubnames

jingham added a comment. I also had to remove them from the Xcode project. With that done everything looks good. Repository: rL LLVM https://reviews.llvm.org/D43202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

> On Feb 12, 2018, at 12:48 PM, Zachary Turner via Phabricator > wrote: > > zturner added a comment. > > In https://reviews.llvm.org/D43048#1005513, @jasonmolenda wrote: > >> No, the unwind unittests that exist today should stay written as unit tests. >> These

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

> On Feb 12, 2018, at 12:59 PM, Zachary Turner wrote: > > > > On Mon, Feb 12, 2018 at 12:52 PM Jason Molenda wrote: >> >> >> > On Feb 12, 2018, at 12:48 PM, Zachary Turner via Phabricator >> > wrote: >> > >> > zturner

Re: [Lldb-commits] [PATCH] D43099: Make LLDB's clang module cache path customizable

Thanks for laying this out. I don't think any of us have a brief for getopt, it was the tool at hand. Getting some fuzzy match suggestions would be nice. Your comment about getopts reminds me, a more fundamental problem with lldb's command interpreter is that the CommandObject is stateful.