This revision was automatically updated to reflect the committed changes.
Closed by commit rL325504: Add SBDebugger::GetBuildConfiguration and use it to
skip an XML test (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
Author: labath
Date: Mon Feb 19 07:06:28 2018
New Revision: 325504
URL: http://llvm.org/viewvc/llvm-project?rev=325504=rev
Log:
Add SBDebugger::GetBuildConfiguration and use it to skip an XML test
Summary:
This adds a SBDebugger::GetBuildConfiguration static function, which
returns a
labath created this revision.
labath added reviewers: jingham, aprantl.
The paralelization patch exposed a bunch of cases where we were still
touching the source tree (as these tests were now stepping on each
others toes and being flaky).
This patch removes such issues from breakpoint command
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for doing this :)
https://reviews.llvm.org/D43464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: labath
Date: Mon Feb 19 05:53:12 2018
New Revision: 325495
URL: http://llvm.org/viewvc/llvm-project?rev=325495=rev
Log:
Make gdb-client tests generate binaries in the build tree
These were missed in the great refactor because they were added
concurrently with it. Since we started running
Author: labath
Date: Mon Feb 19 07:42:48 2018
New Revision: 325511
URL: http://llvm.org/viewvc/llvm-project?rev=325511=rev
Log:
Fix TestStopReplyContainsThreadPcs on 32-bit x86 (pr36013)
Summary:
The issue was that we were parsing the registers into 64-bit integers
and the calling swapByteOrder
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325511: Fix TestStopReplyContainsThreadPcs on 32-bit x86
(pr36013) (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43376
aprantl added a comment.
Awesome!
https://reviews.llvm.org/D43464
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, jingham, davide, labath.
Before this patch, LLDB was not able to evaluate expressions that
resulted in a value with a typeof-type.
(lldb) p int i; __typeof__(i) j = 1; j
(typeof (i)) $0 =
This fixes that. The type is
Author: labath
Date: Mon Feb 19 09:23:13 2018
New Revision: 325519
URL: http://llvm.org/viewvc/llvm-project?rev=325519=rev
Log:
Two more dosep-paralellization fallout fixes
The first issue is about the flaky test rerun logic. This was grouping
tests by subdir and passing them into
labath added a comment.
Seems straight-forward enough, but technically Jim is the owner of the
expression evaluator these days, so I'll leave the honours to him.
Comment at:
packages/Python/lldbsuite/test/expression_command/test/TestExprs.py:270
+# output: (typeof
On Mon, Feb 19, 2018 at 9:23 AM, Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: labath
> Date: Mon Feb 19 09:23:13 2018
> New Revision: 325519
>
> URL: http://llvm.org/viewvc/llvm-project?rev=325519=rev
> Log:
> Two more dosep-paralellization fallout fixes
>
> The
JDevlieghere updated this revision to Diff 134942.
JDevlieghere added a comment.
Change to lit test
https://reviews.llvm.org/D43471
Files:
lit/Expr/TestTypeOfExpr.test
source/Symbol/ClangASTContext.cpp
Index: source/Symbol/ClangASTContext.cpp
davide added inline comments.
Comment at: lit/Expr/TestTypeOfExpr.test:2
+# RUN: %lldb -b -s %s | FileCheck %s
+
+expression int i; __typeof__(i) j = 1; j
I really really love how concise and clear the new test is!
https://reviews.llvm.org/D43471
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
Jonas, this looks a good use case for using lit.
Is it possible to reuse the machinery we use in `lldb/lit/Expr` ?
If not, well, we know there's something we can improve :)
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: source/Symbol/ClangASTContext.cpp:5264
- case clang::Type::TypeOfExpr:
- case clang::Type::TypeOf:
case clang::Type::Decltype:
case clang::Type::TemplateSpecialization:
JDevlieghere updated this revision to Diff 134965.
JDevlieghere added a comment.
Thanks for the review Jim! I've updated the test accordingly.
https://reviews.llvm.org/D43471
Files:
lit/Expr/TestTypeOfDeclTypeExpr.test
source/Symbol/ClangASTContext.cpp
Index:
jingham accepted this revision.
jingham added a comment.
Looks good
https://reviews.llvm.org/D43471
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D43471
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
JDevlieghere updated this revision to Diff 134935.
JDevlieghere added a comment.
Formatting
https://reviews.llvm.org/D43471
Files:
packages/Python/lldbsuite/test/expression_command/test/TestExprs.py
source/Symbol/ClangASTContext.cpp
Index: source/Symbol/ClangASTContext.cpp
jingham added a comment.
Oh, somehow my browser hadn't updated to show the lit test. Ignore the
previous comment.
This is fine, except can you make the test check not depend on the particular
result variable number ($0, $1, $2). You aren't testing here that the result
variable numbers are
jingham added a comment.
Other than that it's fine.
https://reviews.llvm.org/D43471
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere added a comment.
In https://reviews.llvm.org/D43471#1012484, @jingham wrote:
> The code part of this looks fine. I had a few quibbles with the test, see
> inline.
Jim, it looks like you're commenting on an older version of the diff. I've
since switched to checking this with
JDevlieghere updated this revision to Diff 134954.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
Do this for decltype too
https://reviews.llvm.org/D43471
Files:
lit/Expr/TestTypeOfDeclTypeExpr.test
source/Symbol/ClangASTContext.cpp
Index:
JDevlieghere updated this revision to Diff 134955.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
Make sure the lit test actually checks the lldb output instead of the # CHECK
lines.
Without the check-next, CHECK matches the # CHECK lines, as they are printed by
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The code part of this looks fine. I had a few quibbles with the test, see
inline.
Comment at:
26 matches
Mail list logo