[Lldb-commits] [lldb] r330066 - [debugserver] Remove dead function call. NFCI.

Author: davide Date: Fri Apr 13 13:47:25 2018 New Revision: 330066 URL: http://llvm.org/viewvc/llvm-project?rev=330066=rev Log: [debugserver] Remove dead function call. NFCI. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified:

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

aprantl added a comment. Which compilers / platforms generate / support this? Is this an ELF-only feature? https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

dblaikie added a comment. In https://reviews.llvm.org/D45628#1067375, @aprantl wrote: > Which compilers / platforms generate / support this? Is this an ELF-only > feature? Clang/LLVM do (-Wa,--compress-debug-sections). Yeah, it's ELF only so far as I know. There's a couple of variations

[Lldb-commits] [lldb] r330071 - Revert "[debugserver] Remove dead function call. NFCI."

Author: davide Date: Fri Apr 13 14:26:32 2018 New Revision: 330071 URL: http://llvm.org/viewvc/llvm-project?rev=330071=rev Log: Revert "[debugserver] Remove dead function call. NFCI." This reverts commit r330066 as it was wrong and the call was not dead. Thanks to Fred for pointing this out.

Re: [Lldb-commits] [lldb] r330066 - [debugserver] Remove dead function call. NFCI.

> On Apr 13, 2018, at 1:47 PM, Davide Italiano via lldb-commits > wrote: > > Author: davide > Date: Fri Apr 13 13:47:25 2018 > New Revision: 330066 > > URL: http://llvm.org/viewvc/llvm-project?rev=330066=rev > Log: > [debugserver] Remove dead function call. NFCI.

[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first

eugene added a comment. Well, I agree that breakpoints, locations and sites could benefit from ownership refactoring. shared_ptr cycles are bad. Let's discuss it at lldb-dev. Meanwhile I think it's still ok to fix this bug right now, by doing what has already been done in other places.

[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first

jingham added a comment. That sounds like a good plan to me. https://reviews.llvm.org/D45554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r330066 - [debugserver] Remove dead function call. NFCI.

davide@Davidinos-Mac-Pro ~/w/l/llvm-project-20170507> git llvm push Pushing 1 commit: deaca6ae380 Revert "[debugserver] Remove dead function call. NFCI." On Fri, Apr 13, 2018 at 2:21 PM, Davide Italiano wrote: > Oops. Sorry. Fixing this now. > > On Fri, Apr 13, 2018 at

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

aprantl added a comment. Thanks for clarifying. You'll also need to add a testcase. If clang supports this then I don't have a problem with supporting this in LLDB and adding a testcase should be easy. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1893

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

clayborg added a comment. We should test both ways: using normal DWARF section names with SHF_COMPRESSED, and with ".zdebug" prefixed section names. https://reviews.llvm.org/D45628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

davide added subscribers: jasonmolenda, davide. davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. This requires an unittest (or an lldb-test test). Some comments inline. I think @clayborg or @jasonmolenda are in a better position to

[Lldb-commits] [PATCH] D45547: [Command] Implement `stats`

davide added a comment. In https://reviews.llvm.org/D45547#1066044, @xiaobai wrote: > I really like this idea! It will be very helpful for @sas and I. I'd like to > +1 creating a separate `stats dump` subcommand instead of dumping stats on > `stats disable`. Thanks! If you has ideas or want

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur created this revision. alur added reviewers: labath, clayborg. alur added a project: LLDB. Herald added subscribers: llvm-commits, JDevlieghere, arichardson, aprantl, emaste. Herald added a reviewer: espindola. Repository: rL LLVM https://reviews.llvm.org/D45628 Files:

[Lldb-commits] [lldb] r330043 - [Command] Implement `statistics` command.

Author: davide Date: Fri Apr 13 11:02:39 2018 New Revision: 330043 URL: http://llvm.org/viewvc/llvm-project?rev=330043=rev Log: [Command] Implement `statistics` command. This allows us to collect useful metrics about lldb debugging sessions. I thought that an example would be better than a

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

davide added subscribers: clayborg, jingham, jasonmolenda, labath. davide added a comment. thanks! Repository: rL LLVM https://reviews.llvm.org/D45592 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first

jingham added a comment. Sure, if somebody has the time fixing this to use weak pointers would be great. But that doesn't seem like the real issue to me. When a breakpoint gets removed from the Target BreakpointList(s), regardless of who else is holding onto it, it needs to get its breakpoint

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

clayborg added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2937-2938 { static const char *debug_prefix = ".debug"; + static const char *zdebug_prefix = ".zdebug"; Might be worth making these llvm::StringRef, then see

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

clayborg added a comment. If this is for current and future debugging, it would be nice to change the tool to just use the normal .debug prefixes and just specify SHF_COMPRESSED??? https://reviews.llvm.org/D45628 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

thanks! On Fri, Apr 13, 2018 at 8:10 AM, Greg Clayton via Phabricator wrote: > clayborg marked 2 inline comments as done. > clayborg added a comment. > > Didn't update the diffs, but I did fix the things Davide requested before > submission > > > Repository: > rL

[Lldb-commits] [lldb] r330047 - [Command] Simplify the code and make it less error prone. NFCI.

Author: davide Date: Fri Apr 13 11:37:14 2018 New Revision: 330047 URL: http://llvm.org/viewvc/llvm-project?rev=330047=rev Log: [Command] Simplify the code and make it less error prone. NFCI. Pointed out by Jim. Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

davide added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1773-1781 +static SectionType getSectionType(llvm::StringRef section_name) { + llvm::StringRef mapped_name; + if (section_name.startswith(".zdebug")) { +mapped_name =

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1893 sect_type = eSectionTypeDWARFDebugAbbrev; - else if (name == g_sect_name_dwarf_debug_addr) + else if (name == g_sect_name_dwarf_debug_addr || + name ==

[Lldb-commits] [PATCH] D45628: [LLDB] Support compressed debug info sections (.zdebug*)

alur updated this revision to Diff 142478. alur marked 7 inline comments as done. alur added a comment. I refactored the code to address the comments on it. I'll add those tests once I get the test runner to work. https://reviews.llvm.org/D45628 Files:

[Lldb-commits] [lldb] r330002 - Prevent deadlock in OS Plugins

Author: jdevlieghere Date: Fri Apr 13 03:25:23 2018 New Revision: 330002 URL: http://llvm.org/viewvc/llvm-project?rev=330002=rev Log: Prevent deadlock in OS Plugins Summary: When performing a synchronous resume, the API mutex is held until the process is stopped. This is fine, except for when

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

clayborg marked 2 inline comments as done. clayborg added a comment. Didn't update the diffs, but I did fix the things Davide requested before submission Repository: rL LLVM https://reviews.llvm.org/D45592 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r330005 - Re-land "Don't assume backing thread shares protocol ID."

Author: jdevlieghere Date: Fri Apr 13 04:31:34 2018 New Revision: 330005 URL: http://llvm.org/viewvc/llvm-project?rev=330005=rev Log: Re-land "Don't assume backing thread shares protocol ID." When we're dealing with virtual (memory) threads created by the OS plugins, there's no guarantee that

[Lldb-commits] [PATCH] D45554: Make sure deleting all breakpoints clears their sites first

clayborg added a comment. In https://reviews.llvm.org/D45554#1066730, @eugene wrote: > There is an ownership cycle between BreakpointSite::m_owners and > BreakpointLocation::m_bp_site_sp. > We should probably make m_owners a collection of weak references. > But currently most of the code

[Lldb-commits] [PATCH] D45592: Allow relative file paths when settings source breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL330028: Allow relative file paths when settings source breakpoints (authored by gclayton, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: