[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

labath added a comment. In D53368#1313145 , @zturner wrote: > In D53368#1313124 , @labath wrote: > > > I've recently started looking at adding a new symbol file format (breakpad > > symbols). While researching the

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

Yes, I agree that the current model of object files - symbol files - symtabs is not clear and orthogonal for cases like PDB, and I think that it requires some redesign too. But can we commit this patch now to proceed with several dependent (and not directly related to the theme) patches? When a

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

labath added a comment. On 29/11/2018 21:29, Leonard Mosescu wrote: > Hi Aleksandr, yes, no objections to this patch. > > I was responding to Pavel's comments, which I also assume are > forward-looking as well, not strictly related to this patch. Agreed, and I apologise for hijacking your

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

Hi Aleksandr, yes, no objections to this patch. I was responding to Pavel's comments, which I also assume are forward-looking as well, not strictly related to this patch. On Thu, Nov 29, 2018 at 12:08 PM Aleksandr Urakov < aleksandr.ura...@jetbrains.com> wrote: > Yes, I agree that the current

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

labath added a comment. > Great observations Pavel! I think it's really important to have > orthogonal/composable abstractions here: the symbols should be decoupled > from the container format IMO. > > You know more about the ObjectFile than me so I can't say if > ObjectFileBreakpad is the

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

labath added a comment. I've recently started looking at adding a new symbol file format (breakpad symbols). While researching the best way to achieve that, I started comparing the operation of PDB and DWARF symbol files. I noticed a very important difference there, and I think that is the

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

Great observations Pavel! I think it's really important to have orthogonal/composable abstractions here: the symbols should be decoupled from the container format IMO. You know more about the ObjectFile than me so I can't say if ObjectFileBreakpad is the best interface, but here are my initial

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

zturner added a comment. In D53368#1313124 , @labath wrote: > I've recently started looking at adding a new symbol file format (breakpad > symbols). While researching the best way to achieve that, I started comparing > the operation of PDB and DWARF

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

zturner added a comment. If there are no further comments I'd like to get this in later today. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54914/new/ https://reviews.llvm.org/D54914 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r347952 - Fix the Xcode project (pt. 2)

Author: jdevlieghere Date: Thu Nov 29 18:44:16 2018 New Revision: 347952 URL: http://llvm.org/viewvc/llvm-project?rev=347952=rev Log: Fix the Xcode project (pt. 2) Apparently LLVM's libSupport depends on libDemangle to print the stack trace. I'm not sure if this is desired but for now we don't

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

JDevlieghere updated this revision to Diff 175993. JDevlieghere marked 12 inline comments as done. JDevlieghere added a comment. Address feedback from Pavel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55038/new/ https://reviews.llvm.org/D55038 Files: include/lldb/API/SBDebugger.h

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

JDevlieghere added inline comments. Comment at: source/Utility/Reproducer.cpp:41-42 +Reproducer::Reproducer(ReproducerMode mode, llvm::Optional root) { + // It's unfortunate that we have to do so much I/O here that can fail. The + // best we can do is not initialize the

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB347842: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used… (authored by grimar, committed by ). Herald added subscribers: lldb-commits, teemperor, abidh. Repository:

[Lldb-commits] [lldb] r347842 - [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

Author: grimar Date: Thu Nov 29 00:16:07 2018 New Revision: 347842 URL: http://llvm.org/viewvc/llvm-project?rev=347842=rev Log: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable. The issue happens because starting from DWARF v5

[Lldb-commits] [PATCH] D55084: [CMake] Add RPATHS parameter to llvm_add_executable/library

sgraenitz created this revision. Herald added a subscriber: mgorny. This allows to set target-specific LC_RPATH load commands on macOS. It would be useful to locate LLDB.framework in LLDB tools. Repository: rL LLVM https://reviews.llvm.org/D55084 Files: cmake/modules/AddLLVM.cmake

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

> On Nov 29, 2018, at 10:55 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > I've recently started looking at adding a new symbol file format (breakpad > symbols). While researching the best way to achieve that, I started comparing > the operation of PDB and DWARF

[Lldb-commits] [lldb] r347924 - [lldbsuite] Build with -gdwarf on Windows

Author: stella.stamenova Date: Thu Nov 29 14:15:23 2018 New Revision: 347924 URL: http://llvm.org/viewvc/llvm-project?rev=347924=rev Log: [lldbsuite] Build with -gdwarf on Windows Earlier this month there was a change in clang that defaulted to using codeview rather than dwarf on Windows. Since

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

Objects have a symbol table, but a Module is just a loaded object file. And a loaded object file can have multiple symbol tables (from the object file, or symbol file, etc). Would it make sense to have Module provide a GetSymtab method that can find all appropriate Symtabs and present a unified

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

zturner added a comment. In D53368#1313238 , @labath wrote: > In D53368#1313145 , @zturner wrote: > > > In D53368#1313124 , @labath wrote: > > > > > I've recently started

[Lldb-commits] [PATCH] D44072: [lldb] Retrieve currently handled Obj-C exception via __cxa_current_exception_type

kubamracek updated this revision to Diff 175961. Herald added a subscriber: jfb. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D44072/new/ https://reviews.llvm.org/D44072 Files: include/lldb/API/SBThread.h include/lldb/Target/LanguageRuntime.h include/lldb/Target/Thread.h

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

> On Nov 29, 2018, at 2:02 PM, Zachary Turner via Phabricator > wrote: > > zturner added a comment. > > In D53368#1313238 , @labath wrote: > >> In D53368#1313145 , @zturner wrote: >> >>> In D53368#1313124

[Lldb-commits] [lldb] r347936 - Fix the Xcode project

Author: jdevlieghere Date: Thu Nov 29 16:09:04 2018 New Revision: 347936 URL: http://llvm.org/viewvc/llvm-project?rev=347936=rev Log: Fix the Xcode project This fixes the driver with the Xcode project. We need to link the driver against the correct LLVM libraries and make sure we're disabling

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

> On Nov 29, 2018, at 3:31 PM, Zachary Turner wrote: > > Objects have a symbol table, but a Module is just a loaded object file. And a > loaded object file can have multiple symbol tables (from the object file, or > symbol file, etc). > > Would it make sense to have Module provide a

[Lldb-commits] [PATCH] D54617: [wip][Reproducers] Add file provider

JDevlieghere updated this revision to Diff 176035. JDevlieghere added a comment. - Get the external path with modifying the VFS in LLVM. - Integrate with the new integration logic. - Add a test. (that doesn't work yet, still WIP) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54617/new/

[Lldb-commits] [lldb] r347962 - [PDB] Support PDB-backed expressions evaluation

Author: aleksandr.urakov Date: Thu Nov 29 23:12:22 2018 New Revision: 347962 URL: http://llvm.org/viewvc/llvm-project?rev=347962=rev Log: [PDB] Support PDB-backed expressions evaluation Summary: This patch contains several small fixes, which makes it possible to evaluate expressions on Windows

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

This revision was automatically updated to reflect the committed changes. aleksandr.urakov marked an inline comment as done. Closed by commit rL347962: [PDB] Support PDB-backed expressions evaluation (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

This revision was automatically updated to reflect the committed changes. Closed by commit rL347960: [Symbol] Search symbols with name and type in a symbol file (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

JDevlieghere updated this revision to Diff 176034. JDevlieghere added a comment. Test didn't run. Is there a way to REQUIRE either darwin or linux? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55038/new/ https://reviews.llvm.org/D55038 Files: include/lldb/API/SBDebugger.h

[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

labath added a comment. I have a lot of comments, but I think they're mostly cosmetic. I think the general idea here is good. Comment at: include/lldb/API/SBInitializerOptions.h:15 +#include "lldb/API/SBFileSpec.h" +#include "lldb/Initialization/SystemInitializer.h" +

[Lldb-commits] [lldb] r347846 - Remove getopt includes from the driver

Author: labath Date: Thu Nov 29 02:45:41 2018 New Revision: 347846 URL: http://llvm.org/viewvc/llvm-project?rev=347846=rev Log: Remove getopt includes from the driver They are not needed now that we use LLVMOption for command-line parsing thank you, Jonas). This also allows us to avoid linking

[Lldb-commits] [lldb] r347855 - Fix windows build broken by r347846

Author: labath Date: Thu Nov 29 03:53:12 2018 New Revision: 347855 URL: http://llvm.org/viewvc/llvm-project?rev=347855=rev Log: Fix windows build broken by r347846 The changed order of includes caused compile errors on MSVC due to snprintf macro definition. snprintf should available since

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

labath added a comment. In D54914#1311492 , @zturner wrote: > I think it would be good to use the way dotest works as a starting point. > You can specify --arch, and then you can run the test on multiple arches this > way by running dotest several

[Lldb-commits] [lldb] r347869 - [CMake] Fix standalone build for debugserver on macOS

Author: stefan.graenitz Date: Thu Nov 29 06:51:49 2018 New Revision: 347869 URL: http://llvm.org/viewvc/llvm-project?rev=347869=rev Log: [CMake] Fix standalone build for debugserver on macOS Summary: Quick-fix to avoid CMake config issue: ``` CMake Error at

[Lldb-commits] [PATCH] D55032: [CMake] Fix standalone build for debugserver on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL347869: [CMake] Fix standalone build for debugserver on macOS (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D54844: [LLDB] - Improve the support of .debug_str_offsets/.debug_str_offsets.dwo

This revision was automatically updated to reflect the committed changes. Closed by commit rL347859: [LLDB] - Improve the support of .debug_str_offsets/.debug_str_offsets.dwo (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r347859 - [LLDB] - Improve the support of .debug_str_offsets/.debug_str_offsets.dwo

Author: grimar Date: Thu Nov 29 04:44:10 2018 New Revision: 347859 URL: http://llvm.org/viewvc/llvm-project?rev=347859=rev Log: [LLDB] - Improve the support of .debug_str_offsets/.debug_str_offsets.dwo A skeleton compilation unit may contain the DW_AT_str_offsets_base attribute that points to

[Lldb-commits] [PATCH] D55032: [CMake] Fix standalone build for debugserver on macOS

sgraenitz added a comment. Thought about it, but yes, at the moment it looks like overkill. I'd go on duplicating options to debugserver for now and change the approach if it gets unpractical. There are some more changes to come. I want to upstream these first and see how it looks then.

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz added inline comments. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING JDevlieghere wrote: > sgraenitz