[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen abandoned this revision. devnexen added a comment. Just realised there was an existing PR addressing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen accepted this revision. devnexen added a comment. This revision is now accepted and ready to land. LGTM otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added inline comments. Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:733 // Finally, start monitoring the child process for change in state. - m_monitor_thread = Host::StartMonitoringChildProcess( + auto monitor_thread =

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen created this revision. devnexen added reviewers: dim, jbeich. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, JDevlieghere, emaste. Herald added a project: LLDB. devnexen added a comment. With this I do not get segfault anymore. @dim I

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen updated this revision to Diff 224256. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762 Files: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp Index: lldb/source/Plugins/Process/FreeBSD/ProcessMonitor.cpp

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

MaskRay added a comment. This was probably due to: Expected(Error Err) : HasError(true) #if LLVM_ENABLE_ABI_BREAKING_CHECKS // Expected is unchecked upon construction in Debug builds. , Unchecked(true) #endif { assert(Err && "Cannot create Expected

[Lldb-commits] [PATCH] D68762: [LLDB] Fix when building with strict LLVM assertion checking on FreeBSD

devnexen added a comment. With this I do not get segfault anymore. @dim I just looked up the patch on FreeBSD, if this approach is preferred, I ll go along. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68762/new/ https://reviews.llvm.org/D68762

[Lldb-commits] [PATCH] D68731: Remove CC autodetection from Makefile.rules

labath accepted this revision. labath added a comment. Yay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68731/new/ https://reviews.llvm.org/D68731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68750: Implement serialization and deserialization of scripted points

teemperor added a comment. LGTM, thanks a lot! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68750/new/ https://reviews.llvm.org/D68750 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. In D68723#1703098 , @MaskRay wrote: > In D68723#1703051 , @devnexen wrote: > > > LGTM otherwise. > > > I don't think this change should be reverted. It can just be repaired by > adding

[Lldb-commits] [PATCH] D68773: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function.

This revision was automatically updated to reflect the committed changes. Closed by commit rG067bb1f546ef: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

MaskRay accepted this revision. MaskRay added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:111 + + explicit MemoryInfoListStream(std::vector Infos) + : Stream(StreamKind::MemoryInfoList, grimar wrote: > Maybe be more explicit here,

[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I don't see harm in adding this, but I am curious about what are you planning to use this for. My takeaway from all of the pexpect discussions we've had in the past was that pexpect should

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks fine to me. The public-consumptionness of the FileSP overloads was also discussed in D68546 , and I currently do not see a better solution than this

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

labath added a comment. I don't think having Expected members is a reasonable thing to do. If we want to keep the notion of validity explicit (which is consistent with the direction lldb is moving in), then I think the members should be Optional. The initialization code can take the Expected

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

teemperor added a comment. Thanks for the explanation! Doesn't seem like removing this breaks Swift, so I'll land this. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68696/new/ https://reviews.llvm.org/D68696 ___

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. In D68723#1703379 , @MaskRay wrote: > In D68723#1703322 , @devnexen wrote: > > > @dim I LGTMed this but would it a real issue for you to take on a less > > disruptive approach proposed by

[Lldb-commits] [lldb] r374289 - [lldb][NFC] Use unique_ptr in DiagnosticManager to express ownership

Author: teemperor Date: Thu Oct 10 01:30:10 2019 New Revision: 374289 URL: http://llvm.org/viewvc/llvm-project?rev=374289=rev Log: [lldb][NFC] Use unique_ptr in DiagnosticManager to express ownership Modified: lldb/trunk/include/lldb/Expression/DiagnosticManager.h

[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

mstorsjo created this revision. mstorsjo added reviewers: labath, amccarth, rnk. Herald added a project: LLDB. This avoids the currently MSVC specific codepath of using the wchar entry point and converting that to utf8. In the main lldb driver, we had this MSVC specific codepath, but in other

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

devnexen added a comment. @dim I LGTMed this but would it a real issue for you to take on a less disruptive approach proposed by MaskRay ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___

[Lldb-commits] [PATCH] D68773: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add actually unit test that function.

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere, abidh. Herald added a project: LLDB. The `if (*cstr_end == '\0')` in the previous code checked if the previous loop terminated because it found a null terminator or because

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

MaskRay added a comment. In D68723#1703322 , @devnexen wrote: > @dim I LGTMed this but would it a real issue for you to take on a less > disruptive approach proposed by MaskRay ? I think we should do what @labath suggested (changing Expected to

[Lldb-commits] [lldb] r374307 - [lldb][NFC] Use llvm::all_of instead of std::all_of in CppModuleConfiguration

Author: teemperor Date: Thu Oct 10 03:56:12 2019 New Revision: 374307 URL: http://llvm.org/viewvc/llvm-project?rev=374307=rev Log: [lldb][NFC] Use llvm::all_of instead of std::all_of in CppModuleConfiguration Modified:

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

MaskRay added a comment. In D68723#1703051 , @devnexen wrote: > LGTM otherwise. I don't think this change should be reverted. It can just be repaired by adding some `(void)!xxx;` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/

[Lldb-commits] [lldb] r374299 - s/@expectedFailure/@expectedFailureAll in TestFileHandle

Author: labath Date: Thu Oct 10 02:52:32 2019 New Revision: 374299 URL: http://llvm.org/viewvc/llvm-project?rev=374299=rev Log: s/@expectedFailure/@expectedFailureAll in TestFileHandle The test isn't using @expectedFailure correctly, which causes weird errors, at least with python2, at least

[Lldb-commits] [lldb] r374311 - [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function.

Author: teemperor Date: Thu Oct 10 04:15:38 2019 New Revision: 374311 URL: http://llvm.org/viewvc/llvm-project?rev=374311=rev Log: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function. Summary: The `if (*cstr_end == '\0')` in the previous code checked if the

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68738/new/ https://reviews.llvm.org/D68738

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

labath added a comment. It looks pretty straight-forward. The two main comments I have are: - implement rtti to get rid of the `GetPythonObject` method on the base class - it looks like the implementations of new apis you're adding (GetOptions, mainly) have to go out of their way to ignore

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:316 -# Use a shared module cache when building in the default test build directory. -CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed

[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

jarin added a comment. Thank you for the review! Could you also possibly commit the change for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68454/new/ https://reviews.llvm.org/D68454 ___

[Lldb-commits] [PATCH] D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

This revision was automatically updated to reflect the committed changes. Closed by commit rG95e264fc8a93: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r374325 - [Windows] Introduce a switch for the `lldb-server` mode on Windows

Author: aleksandr.urakov Date: Thu Oct 10 05:21:04 2019 New Revision: 374325 URL: http://llvm.org/viewvc/llvm-project?rev=374325=rev Log: [Windows] Introduce a switch for the `lldb-server` mode on Windows Summary: This patch introduces a switch, based on the environment variable

[Lldb-commits] [lldb] r374331 - File: Handle more cases in GetOptionsFromMode

Author: labath Date: Thu Oct 10 05:40:27 2019 New Revision: 374331 URL: http://llvm.org/viewvc/llvm-project?rev=374331=rev Log: File: Handle more cases in GetOptionsFromMode The "b" (binary) flag is meaningless most of the time, but the relevant standars allow it. The standards permit one to

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. Yeah, as Jan mentions, I've had to make some tweaks (r374331, r374322, r374299) in order to get this passing on all python and swig versions. Let me know if you have questions/issues/etc about any of those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] r374335 - [lldb] Make sure import-std-module/sysroot actually passes for the right reasons

Author: teemperor Date: Thu Oct 10 05:57:14 2019 New Revision: 374335 URL: http://llvm.org/viewvc/llvm-project?rev=374335=rev Log: [lldb] Make sure import-std-module/sysroot actually passes for the right reasons This test was previously passing because myabs was actually emitted into the debug

[Lldb-commits] [lldb] r374313 - [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback

Author: teemperor Date: Thu Oct 10 04:26:51 2019 New Revision: 374313 URL: http://llvm.org/viewvc/llvm-project?rev=374313=rev Log: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback Summary: The SearchCallback has a bool parameter that we always set to false, we never use

[Lldb-commits] [lldb] r374342 - Fix the unwinding plan augmentation from x86 assembly

Author: labath Date: Thu Oct 10 06:23:09 2019 New Revision: 374342 URL: http://llvm.org/viewvc/llvm-project?rev=374342=rev Log: Fix the unwinding plan augmentation from x86 assembly Unwind plan augmentation should compute the plan row at offset x from the instruction before offset x, but

[Lldb-commits] [lldb] r374341 - Fix some dangling else warnings

Author: labath Date: Thu Oct 10 06:23:02 2019 New Revision: 374341 URL: http://llvm.org/viewvc/llvm-project?rev=374341=rev Log: Fix some dangling else warnings EXPECT_EQ contains an if-else statement. It also contains some magic to suppress the dangling else warnings, but it seems that some new

[Lldb-commits] [lldb] r374352 - [lldb] Fix minidebuginfo-set-and-hit-breakpoint.test

Author: teemperor Date: Thu Oct 10 07:00:32 2019 New Revision: 374352 URL: http://llvm.org/viewvc/llvm-project?rev=374352=rev Log: [lldb] Fix minidebuginfo-set-and-hit-breakpoint.test This was failing for me because of this error: llvm-objcopy: error:

[Lldb-commits] [PATCH] D68734: update SBDebugger::SetInputFile() etc to work on native Files

clayborg added a comment. Sounds good. LGTM then. Thanks for the explanation. I was out on vacation for a week and catching up on email. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68734/new/ https://reviews.llvm.org/D68734

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

labath marked 3 inline comments as done. labath added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:116 + + MemoryInfoListStream() + : Stream(StreamKind::MemoryInfoList, MaskRay wrote: > Move default constructor above. Done, I've also

[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

labath closed this revision. labath added a comment. I can do *that*: r374342 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68454/new/ https://reviews.llvm.org/D68454 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r374322 - TestFileHandle.py: relax exception type checks

Author: labath Date: Thu Oct 10 05:07:30 2019 New Revision: 374322 URL: http://llvm.org/viewvc/llvm-project?rev=374322=rev Log: TestFileHandle.py: relax exception type checks the exceptions returned differ between swig4 (TypeError) and swig<=3 (NotImplementedError). Just check for the base

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

jankratochvil added a comment. Fixed now by rL374322 , there was a regression - Linux Fedora 30 x86_64: == ERROR: test_exceptions (TestFileHandle.FileHandleTestCase)

[Lldb-commits] [PATCH] D68258: [Windows] Introduce a switch for the `lldb-server` mode on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG0891366571b2: [Windows] Introduce a switch for the `lldb-server` mode on Windows (authored by aleksandr.urakov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG3aa7e76677f1: MinidumpYAML: Add support for the memory info list stream (authored by labath). Herald added a subscriber: hiraditya. Changed prior to commit:

[Lldb-commits] [lldb] r374350 - [lldb] Add log output for the support files we pass to the CppModuleConfiguration

Author: teemperor Date: Thu Oct 10 06:43:37 2019 New Revision: 374350 URL: http://llvm.org/viewvc/llvm-project?rev=374350=rev Log: [lldb] Add log output for the support files we pass to the CppModuleConfiguration CppModuleConfiguration is the most likely point of failure when we have weird

[Lldb-commits] [lldb] r374353 - unwind-via-stack-win.yaml: update for changes in yaml format

Author: labath Date: Thu Oct 10 07:01:59 2019 New Revision: 374353 URL: http://llvm.org/viewvc/llvm-project?rev=374353=rev Log: unwind-via-stack-win.yaml: update for changes in yaml format Modified: lldb/trunk/test/Shell/SymbolFile/Breakpad/Inputs/unwind-via-stack-win.yaml Modified:

[Lldb-commits] [PATCH] D68727: Allow pexpect tests to work in remote testsuite runs

friss added a comment. In D68727#1703073 , @labath wrote: > I don't see harm in adding this, but I am curious about what are you planning > to use this for. My takeaway from all of the pexpect discussions we've had in > the past was that pexpect should

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

friss added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:316 -# Use a shared module cache when building in the default test build directory. -CLANG_MODULE_CACHE_DIR := $(shell echo "$(BUILDDIR)" | sed

[Lldb-commits] [PATCH] D68658: LLDB: Use LLVM's type for minidump ExceptionStream [NFC]

JosephTremoulet updated this revision to Diff 224356. JosephTremoulet added a comment. - Define DumpRequested constant in-line, per feedback in D68656 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68658/new/

[Lldb-commits] false alarm [Re: [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.]

On Thu, 10 Oct 2019 00:22:09 +0200, Jan Kratochvil wrote: > -- > There are now: > Failing Tests (5): > lldb-api :: > commands/expression/multiline-completion/TestMultilineCompletion.py > lldb-api ::

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

JDevlieghere updated this revision to Diff 224394. JDevlieghere added a comment. - Rebased on top of D68812 . - Pass the module cache on the command line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68755/new/ https://reviews.llvm.org/D68755 Files:

[Lldb-commits] [lldb] r374382 - [test] Trim the symbtab test case (NFC)

Author: jdevlieghere Date: Thu Oct 10 10:12:57 2019 New Revision: 374382 URL: http://llvm.org/viewvc/llvm-project?rev=374382=rev Log: [test] Trim the symbtab test case (NFC) We don't actually need the section content for this tests. Modified:

[Lldb-commits] [lldb] r374386 - [test] Use a different module cache for Shell and API tests.

Author: jdevlieghere Date: Thu Oct 10 10:27:09 2019 New Revision: 374386 URL: http://llvm.org/viewvc/llvm-project?rev=374386=rev Log: [test] Use a different module cache for Shell and API tests. Before the test reorganization, everything was part of a single test suite with a single module

[Lldb-commits] [lldb] r374385 - [test] Pass DSYMUTIL and SDKROOT as part of the Make invocation.

Author: jdevlieghere Date: Thu Oct 10 10:27:06 2019 New Revision: 374385 URL: http://llvm.org/viewvc/llvm-project?rev=374385=rev Log: [test] Pass DSYMUTIL and SDKROOT as part of the Make invocation. Pass the DSYMUTIL and SDKROOT variables on the command line instead of the environment. This

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl updated this revision to Diff 224407. aprantl added a comment. Address feedback from Greg. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 Files: lldb/packages/Python/lldbsuite/test/lang/cpp/accelerator-table/Makefile

[Lldb-commits] [lldb] r374371 - Increase timeout in gdbclientutils.py to decrease chance of test failing under ASAN.

Author: adrian Date: Thu Oct 10 08:59:17 2019 New Revision: 374371 URL: http://llvm.org/viewvc/llvm-project?rev=374371=rev Log: Increase timeout in gdbclientutils.py to decrease chance of test failing under ASAN. Modified:

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

clayborg added a comment. So now we are doing two lookups each time we are doing a lookup? One idea to improve upon this would be to do this search a bit later on after we lookup "iterator" and only do this extra context matching if we find at last a certain number of results? So the flow

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

tatyana-krasnukha added a comment. Please see my comment D68719#1703785 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68728/new/ https://reviews.llvm.org/D68728

[Lldb-commits] [lldb] r374394 - Implement serializing scripted breakpoints and their extra args.

Author: jingham Date: Thu Oct 10 10:44:50 2019 New Revision: 374394 URL: http://llvm.org/viewvc/llvm-project?rev=374394=rev Log: Implement serializing scripted breakpoints and their extra args. Differential Revision: https://reviews.llvm.org/D68750 Added:

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl marked an inline comment as done. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:138-143 } else if (has_tag) { if (log) m_module.LogMessage(log, "FindByNameAndTag()");

[Lldb-commits] [PATCH] D68010: [lldb] Fix string summary of an empty NSPathStore2

shafik added inline comments. Comment at: lldb/source/DataFormatters/StringPrinter.cpp:544 bool is_truncated = false; const auto max_size = process_sp->GetTarget().GetMaximumSizeOfStringSummary(); Why not just make this `uint32_t` making this `auto`

[Lldb-commits] [PATCH] D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation.

JDevlieghere added a comment. In D68812#1704235 , @clayborg wrote: > It would be great if we could ensure that if a test fails, that the "dotest" > command line text has everything it needs as well, including the options and > paths to lldb, framework,

[Lldb-commits] [lldb] r374375 - Increase timeout in pexpect to lower chances of tests failing under ASAN.

Author: adrian Date: Thu Oct 10 09:16:49 2019 New Revision: 374375 URL: http://llvm.org/viewvc/llvm-project?rev=374375=rev Log: Increase timeout in pexpect to lower chances of tests failing under ASAN. If this doesn't actually work, I'll revert the change and just disable the remaining thee

[Lldb-commits] [PATCH] D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d2cf936ac6c: [test] Pass DSYMUTIL and SDKROOT as part of the Make invocation. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG27c23653aec7: [test] Use a different module cache for Shell and API tests. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [Lldb-commits] [lldb] r374335 - [lldb] Make sure import-std-module/sysroot actually passes for the right reasons

> On Oct 10, 2019, at 5:57 AM, Raphael Isemann via lldb-commits > wrote: > > Author: teemperor > Date: Thu Oct 10 05:57:14 2019 > New Revision: 374335 > > URL: http://llvm.org/viewvc/llvm-project?rev=374335=rev > Log: > [lldb] Make sure import-std-module/sysroot actually passes for the right

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

aprantl added a comment. I think this addresses all outstanding questions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation.

JDevlieghere created this revision. JDevlieghere added reviewers: labath, friss, aprantl. Herald added a project: LLDB. Pass the DSYMUTIL and SDKROOT variables on the command line instead of the environment. This makes it easier to reproduce the make invocation during development. Repository:

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/make/Makefile.rules:316 -# Use a shared module cache when building in the default test build directory. -CLANG_MODULE_CACHE_DIR := $(shell echo

[Lldb-commits] [PATCH] D68719: Fix build with Visual Studio

tatyana-krasnukha added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) This command produces an incorrect path

[Lldb-commits] [PATCH] D68719: Fix build with Visual Studio

tatyana-krasnukha added a comment. Hi Haibo, Sadly, D68628 doesn't fix the issue. It adds "Debug" to the python path, but the script still tries to find 'liblldb.dll' in the wrong location. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68755: [test] Use a different module cache for Shell and API tests.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM, apart from the outstanding comments. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68755/new/ https://reviews.llvm.org/D68755

[Lldb-commits] [PATCH] D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation.

clayborg added a comment. It would be great if we could ensure that if a test fails, that the "dotest" command line text has everything it needs as well, including the options and paths to lldb, framework, shared library and other settings. If I "ninja check-lldb", I have to manually insert

[Lldb-commits] [PATCH] D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! It was so annoying having to manually specify DSYMUTIL=dsymutil when reproducing builds. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68812/new/

[Lldb-commits] [PATCH] D68750: Implement serialization and deserialization of scripted points

This revision was automatically updated to reflect the committed changes. Closed by commit rG47b33dcc0df8: Implement serializing scripted breakpoints and their extra args. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68812: [test] Pass DSYMUTIL and SDKROOT as part of the make invocation.

clayborg added a comment. In D68812#1704275 , @JDevlieghere wrote: > In D68812#1704235 , @clayborg wrote: > > > It would be great if we could ensure that if a test fails, that the > > "dotest" command line text

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/AppleDWARFIndex.cpp:116 // "std::vector::const_iterator") searching for the innermost // name alone ("const_iterator) could yield many false positives. By // searching for the parent

[Lldb-commits] [PATCH] D68678: Speed up accelerator table lookups

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Sounds good, thanks for entertaining the extra fix and proving it didn't work! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68678/new/ https://reviews.llvm.org/D68678

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

This revision was automatically updated to reflect the committed changes. Closed by commit rGab1cd65f1914: update TestRunCommandInterpreterAPI to use SBFile (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68738/new/

[Lldb-commits] [lldb] r374434 - [test] Cleanup top-level lit.cfg.py

Author: jdevlieghere Date: Thu Oct 10 12:51:47 2019 New Revision: 374434 URL: http://llvm.org/viewvc/llvm-project?rev=374434=rev Log: [test] Cleanup top-level lit.cfg.py Modified: lldb/trunk/test/lit.cfg.py Modified: lldb/trunk/test/lit.cfg.py URL:

[Lldb-commits] [lldb] r374435 - [test] Add timeout to API tests.

Author: jdevlieghere Date: Thu Oct 10 12:51:50 2019 New Revision: 374435 URL: http://llvm.org/viewvc/llvm-project?rev=374435=rev Log: [test] Add timeout to API tests. Before the reorganiziation, the API tests were inheriting the timeout from the top-level lit file. Now that this is no longer the

[Lldb-commits] [lldb] r374444 - Fix process launch failure on FreeBSD after r365761

Author: dim Date: Thu Oct 10 13:26:59 2019 New Revision: 37 URL: http://llvm.org/viewvc/llvm-project?rev=37=rev Log: Fix process launch failure on FreeBSD after r365761 Summary: After rLLDB365761, and with `LLVM_ENABLE_ABI_BREAKING_CHECKS` enabled, launching any process on FreeBSD

[Lldb-commits] [lldb] r374451 - TestMTCSimple: Make Makefile portable.

Author: friss Date: Thu Oct 10 14:21:16 2019 New Revision: 374451 URL: http://llvm.org/viewvc/llvm-project?rev=374451=rev Log: TestMTCSimple: Make Makefile portable. r374262 left out the Makefile changes needed to cross compile this test. Modified:

[Lldb-commits] [PATCH] D67994: Modify lldb-test to print out ASTs from symbol file

shafik added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:9195 + GetAsEnumDecl(type->GetFullCompilerType())) + enum_decl->dump(s.AsRawOstream()); +else { teemperor wrote: > shafik wrote: > > aprantl wrote: > > > is an

[Lldb-commits] [lldb] r374461 - [test] Reduce inconsistency between lit configuration files.

Author: jdevlieghere Date: Thu Oct 10 14:49:22 2019 New Revision: 374461 URL: http://llvm.org/viewvc/llvm-project?rev=374461=rev Log: [test] Reduce inconsistency between lit configuration files. Add the Python extension to the configuration files in the API directory to match the other test

[Lldb-commits] [lldb] r374462 - [Make] Remove spurious line break

Author: jdevlieghere Date: Thu Oct 10 14:49:25 2019 New Revision: 374462 URL: http://llvm.org/viewvc/llvm-project?rev=374462=rev Log: [Make] Remove spurious line break This test is disabled upstream and therefore this went unnoticed. Modified:

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/Host/File.h:56 static bool DescriptorIsValid(int descriptor) { return descriptor >= 0; }; + static const char *GetStreamOpenModeFromOptions(uint32_t options);

[Lldb-commits] [lldb] r374468 - [lldb-test] Remove unused header

Author: xiaobai Date: Thu Oct 10 15:43:03 2019 New Revision: 374468 URL: http://llvm.org/viewvc/llvm-project?rev=374468=rev Log: [lldb-test] Remove unused header Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp Modified: lldb/trunk/tools/lldb-test/lldb-test.cpp URL:

[Lldb-commits] [PATCH] D68842: Clean up format in cmake file

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Makes the indent consistent to other part of the file. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68842 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

hhb added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) hhb wrote: > tatyana-krasnukha wrote: > > This command

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

aprantl added a comment. I wouldn't call it a bug, but if we changed dsymutil to always rewrite DW_AT_low_pc into DW_AT_ranges, we could trust the .debug_ranges section to be complete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68655/new/

[Lldb-commits] [lldb] r374483 - Clean up format in cmake file

Author: hhb Date: Thu Oct 10 17:12:20 2019 New Revision: 374483 URL: http://llvm.org/viewvc/llvm-project?rev=374483=rev Log: Clean up format in cmake file Summary: Makes the indent consistent to other part of the file. Subscribers: mgorny, lldb-commits Tags: #lldb Differential Revision:

[Lldb-commits] [PATCH] D68842: Clean up format in cmake file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG7b9900dff3c0: Clean up format in cmake file (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] r374414 - Remove merge marker :-)

Author: adrian Date: Thu Oct 10 11:30:47 2019 New Revision: 374414 URL: http://llvm.org/viewvc/llvm-project?rev=374414=rev Log: Remove merge marker :-) Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoint/serialize/TestBreakpointSerialization.py Modified:

[Lldb-commits] [lldb] r374424 - update TestRunCommandInterpreterAPI to use SBFile

Author: lawrence_danna Date: Thu Oct 10 12:24:07 2019 New Revision: 374424 URL: http://llvm.org/viewvc/llvm-project?rev=374424=rev Log: update TestRunCommandInterpreterAPI to use SBFile Summary: If you look at what this test is doing, it's actually quite mysterious why it works at all. It sets

[Lldb-commits] [PATCH] D68770: [LLDB] [Driver] Use llvm::InitLLVM to do unicode argument conversion on Windows

mstorsjo added a comment. In D68770#1704663 , @amccarth wrote: > Cool. I didn't know about InitLLVM. That makes things much cleaner. > > Though I do recall recently seeing another complaint about `argv[0]` not > being preserved as typed but being

[Lldb-commits] [PATCH] D68096: ProcessMinidump: Suppress reporting stop for signal '0'

clayborg added a comment. We should add a test that has no exception info and verify we get a stopped process if we don't already have a test like this. LLDB doesn't like it when there is no stop reason and might try to resume the process and might not print out the stop and backtrace?

[Lldb-commits] [lldb] r374402 - Remove CC autodetection from Makefile.rules

Author: adrian Date: Thu Oct 10 10:59:18 2019 New Revision: 374402 URL: http://llvm.org/viewvc/llvm-project?rev=374402=rev Log: Remove CC autodetection from Makefile.rules Auto-detecting CC in Makefile.rules is no longer useful. Ever since out-of-tree builds we are better off just running

  1   2   >