[Lldb-commits] [lldb] c988965 - Temporarily XFAIL libcxx tests.

Author: Adrian Prantl Date: 2022-09-09T10:43:03-07:00 New Revision: c988965efb2ce8fd867b86d4b893654943d11642 URL: https://github.com/llvm/llvm-project/commit/c988965efb2ce8fd867b86d4b893654943d11642 DIFF: https://github.com/llvm/llvm-project/commit/c988965efb2ce8fd867b86d4b893654943d11642.diff

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValueChar.h:34-37 +if (m_current_value != '\0') + return m_current_value; +else + return "(null)"; clayborg wrote: > Since this is actually a character, it should

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu added a comment. In D133446#3779600 , @labath wrote: > I believe that this fixes the crash, but the names of generated functions > still look fairly weird. Could we create them using their mangled name > instead? That way, someone might

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

kastiglione added a comment. Herald added a reviewer: ributzka. @clayborg friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.org/D114288 ___ lldb-commits

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked 8 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:870-874 + virtual bool LoadSpecialBinaryAndSetDynamicLoader(Process *process, +lldb::addr_t

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 459191. jasonmolenda marked 5 inline comments as done. jasonmolenda added a comment. Update patch to incorporate Jonas & Pavel's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133534/new/

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg added a comment. In D114288#3781084 , @kastiglione wrote: > @clayborg friendly ping Do you have an repro case that will show this issue? I would need to debug it. The main issue is ObjectFileJIT::ParseSymtab() is doing global lookups when it

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

zequanwu updated this revision to Diff 459145. zequanwu added a comment. Update test case after moving the check into `CreateDeclInfoForUndecoratedName`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133446/new/ https://reviews.llvm.org/D133446

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. In D111509#3778883 , @MaskRay wrote: > Sorry, I just reverted it:) You may check whether the fix fixes GCC > libstdc++-v3/src/c++98/complex_io.cc I confirm it does not crash on my system with this patch. Repository: rG

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 459094. jasonmolenda added a comment. Update patch to include more surrounding context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133534/new/ https://reviews.llvm.org/D133534 Files:

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

JDevlieghere added a comment. The current patch didn't have context so I just left a bunch of nits. Comment at: lldb/include/lldb/Target/Platform.h:870-874 + virtual bool LoadSpecialBinaryAndSetDynamicLoader(Process *process, +

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan updated this revision to Diff 459120. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i

[Lldb-commits] [lldb] 1b988ff - [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

Author: Jordan Rupprecht Date: 2022-09-09T14:00:35-07:00 New Revision: 1b988ff092a0a713f0bb4712bfe6cb5ba85b725c URL: https://github.com/llvm/llvm-project/commit/1b988ff092a0a713f0bb4712bfe6cb5ba85b725c DIFF:

[Lldb-commits] [PATCH] D133393: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b988ff092a0: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A small comment but otherwise this LGTM. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:924 +

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda marked 2 inline comments as done. jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:924 + addr_t input_addr) { + Status error; + WritableDataBufferSP

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

jingham added a comment. In D133129#3780028 , @labath wrote: > In D133129#3778125 , @jingham wrote: > >> To be clear, I'm not trying to implement a preemptive interrupt using these >> callbacks. There are so

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset thakis wrote: > This causes a dependency cycle: > >

[Lldb-commits] [lldb] 1f47352 - Document some of the clang-specific DWARF extensions supported by LLDB

Author: Adrian Prantl Date: 2022-09-09T17:49:11-07:00 New Revision: 1f47352ce7e84b2d2692aecdab19932f7abff589 URL: https://github.com/llvm/llvm-project/commit/1f47352ce7e84b2d2692aecdab19932f7abff589 DIFF: https://github.com/llvm/llvm-project/commit/1f47352ce7e84b2d2692aecdab19932f7abff589.diff

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f47352ce7e8: Document some of the clang-specific DWARF extensions supported by LLDB (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D133618: Adapt LLDB dataformatters for libcxx change D129386

aprantl updated this revision to Diff 459214. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133618/new/ https://reviews.llvm.org/D133618 Files: lldb/include/lldb/DataFormatters/VectorIterator.h lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp

[Lldb-commits] [PATCH] D133618: Adapt LLDB dataformatters for libcxx change D129386

ldionne accepted this revision. ldionne added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:1004 + auto dataobj = GetChildMemberWithName( + valobj, {ConstString("__data_"),

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

zequanwu marked 2 inline comments as done. zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/blocks.cpp:17 + +// CHECK: Function: id = {{.*}}, name = "main", range = [0x000140001000-0x00014000104b) +// CHECK-NEXT: FuncType: id =

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan updated this revision to Diff 459208. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset jasonmolenda wrote: > thakis wrote: > > This causes a

[Lldb-commits] [PATCH] D133618: Adapt LLDB dataformatters for libcxx change D129386

aprantl created this revision. aprantl added reviewers: Michael137, fdeazeve, ldionne, philnik. Herald added a project: All. aprantl requested review of this revision. We at first misattributed this to a CMake configuration change that happened on green dragon at the same time, hence the delay.

[Lldb-commits] [lldb] 6037936 - [LLDB][NativePDB] Replace blocks.cpp with blocks.s so the test won't be affected by codegen changes.

Author: Zequan Wu Date: 2022-09-09T15:47:27-07:00 New Revision: 603793698928c1f32772248840a45ddcf4914bd2 URL: https://github.com/llvm/llvm-project/commit/603793698928c1f32772248840a45ddcf4914bd2 DIFF: https://github.com/llvm/llvm-project/commit/603793698928c1f32772248840a45ddcf4914bd2.diff

[Lldb-commits] [lldb] 30578c0 - dependency cycle fix in DynamicLoaderDarwinKernel

Author: Jason Molenda Date: 2022-09-09T17:37:46-07:00 New Revision: 30578c08568bc8de79dea72e41f49899ba10ea55 URL: https://github.com/llvm/llvm-project/commit/30578c08568bc8de79dea72e41f49899ba10ea55 DIFF: https://github.com/llvm/llvm-project/commit/30578c08568bc8de79dea72e41f49899ba10ea55.diff

[Lldb-commits] [PATCH] D133628: [lldb/test][TestingSupport] Add a helper class to send all LLDB logs to stderr in unit tests.

rupprecht created this revision. Herald added a subscriber: mgorny. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This helper class can be useful to see what `LLDB_LOG` messages are happening when

[Lldb-commits] [PATCH] D133618: Adapt LLDB dataformatters for libcxx change D129386

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:1004 + auto dataobj = GetChildMemberWithName( + valobj, {ConstString("__data_"), ConstString("__data")}); + auto sizeobj = GetChildMemberWithName( ldionne wrote:

[Lldb-commits] [PATCH] D133618: Adapt LLDB dataformatters for libcxx change D129386

Michael137 added a comment. Herald added a subscriber: JDevlieghere. LGTM thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133618/new/ https://reviews.llvm.org/D133618 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D133626: [LLDB][NativePDB] Add local variables with no location info.

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we don't add local variables with no location info, when trying to print it,

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

This revision was automatically updated to reflect the committed changes. jasonmolenda marked an inline comment as done. Closed by commit rG1a608cfb5ca8: Recognize a platform binary in ProcessGDBRemote which determines plugins (authored by jasonmolenda). Changed prior to commit:

[Lldb-commits] [lldb] 1a608cf - Recognize a platform binary in ProcessGDBRemote which determines plugins

Author: Jason Molenda Date: 2022-09-09T14:57:08-07:00 New Revision: 1a608cfb5ca81d7b1d8ebd6b21c6be9db59c837a URL: https://github.com/llvm/llvm-project/commit/1a608cfb5ca81d7b1d8ebd6b21c6be9db59c837a DIFF: https://github.com/llvm/llvm-project/commit/1a608cfb5ca81d7b1d8ebd6b21c6be9db59c837a.diff

[Lldb-commits] [lldb] 2f4a66e - Adapt LLDB dataformatters for libcxx change D129386

Author: Adrian Prantl Date: 2022-09-09T15:58:55-07:00 New Revision: 2f4a66eed68804929efa1ad3c10fc040a67fb3ff URL: https://github.com/llvm/llvm-project/commit/2f4a66eed68804929efa1ad3c10fc040a67fb3ff DIFF: https://github.com/llvm/llvm-project/commit/2f4a66eed68804929efa1ad3c10fc040a67fb3ff.diff

[Lldb-commits] [PATCH] D133618: Adapt LLDB dataformatters for libcxx change D129386

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f4a66eed688: Adapt LLDB dataformatters for libcxx change D129386 (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, aprantl. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Debugging some DWARF5 binaries was causing errors to appear when

[Lldb-commits] [PATCH] D133623: Fix DW_OP_convert to resolve the CU relative offset correctly.

clayborg added a comment. Herald added a subscriber: Michael137. Adrian: not sure how to test this. This all seems to be unit tested with your unit tests. If you have any ideas of how to modify the tests to verify this let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a comment fix and allow the "char" option value to be saved as zero and this will be good to go. Comment at: lldb/include/lldb/API/SBDebugger.h:120-121 +

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9af089f5179d: Add the ability to show when variables fails to be available when debug info is… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 9af089f - Add the ability to show when variables fails to be available when debug info is valid.

Author: Greg Clayton Date: 2022-09-09T16:14:46-07:00 New Revision: 9af089f5179d52c6561ec27532880edcfb6253af URL: https://github.com/llvm/llvm-project/commit/9af089f5179d52c6561ec27532880edcfb6253af DIFF: https://github.com/llvm/llvm-project/commit/9af089f5179d52c6561ec27532880edcfb6253af.diff

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset This causes a dependency cycle:

[Lldb-commits] [PATCH] D133601: [LLDB][NativePDB] ResolveSymbolContext should return the innermost block

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before, it returns the outermost blocks if nested blocks have the same address

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/API/SBDebugger.h:119 + /// Get all settings into SBStructuredData. + lldb::SBStructuredData GetSetting(); +

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

jasonmolenda updated this revision to Diff 458970. jasonmolenda added a comment. Update the patch to address Jim's comments/suggestions. Biggest change was to clean up how DynamicLoaderDarwinKernel filters out any kernels in the Target that don't match the UUID of the actually running kernel.

[Lldb-commits] [PATCH] D133393: [test] Use either `127.0.0.1` or `[::1]` to run in ipv6-only environments.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D133393#3775995 , @rupprecht wrote: > In D133393#3773793 , @labath wrote: > >> I believe the reasons are

[Lldb-commits] [PATCH] D133530: [lldb] Add zstd support

labath added a comment. Seems fine to me, though you may want to have a llvm test for the new functionality, given that the patch is exclusively changing llvm code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133530/new/

[Lldb-commits] [lldb] 89a3691 - [lldb] Fix ThreadedCommunication races

Author: Pavel Labath Date: 2022-09-09T15:10:38+02:00 New Revision: 89a3691b794cee20187e14a750ecde8b6d3f7e71 URL: https://github.com/llvm/llvm-project/commit/89a3691b794cee20187e14a750ecde8b6d3f7e71 DIFF: https://github.com/llvm/llvm-project/commit/89a3691b794cee20187e14a750ecde8b6d3f7e71.diff

[Lldb-commits] [lldb] 681d0d9 - [lldb-server] Report launch error in vRun packets

Author: Pavel Labath Date: 2022-09-09T15:10:38+02:00 New Revision: 681d0d9e5f05405e4d0048e40796c5d08e85db93 URL: https://github.com/llvm/llvm-project/commit/681d0d9e5f05405e4d0048e40796c5d08e85db93 DIFF: https://github.com/llvm/llvm-project/commit/681d0d9e5f05405e4d0048e40796c5d08e85db93.diff

[Lldb-commits] [PATCH] D133410: [lldb] Fix ThreadedCommunication races

This revision was automatically updated to reflect the committed changes. Closed by commit rG89a3691b794c: [lldb] Fix ThreadedCommunication races (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133410/new/

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

This revision was automatically updated to reflect the committed changes. Closed by commit rG681d0d9e5f05: [lldb-server] Report launch error in vRun packets (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133352/new/

[Lldb-commits] [PATCH] D132954: lldb: Add support for R_386_32 relocations to ObjectFileELF

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Cool. Thanks for figuring this out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132954/new/ https://reviews.llvm.org/D132954 ___

[Lldb-commits] [PATCH] D133427: [gdb-remote] Move broadcasting logic down to GDBRemoteClientBase

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. cool. Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationTest.cpp:20 public: - TestClient() - : GDBRemoteCommunication("test.client",

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

labath added a comment. In D133129#3778125 , @jingham wrote: > To be clear, I'm not trying to implement a preemptive interrupt using these > callbacks. There are so many places where lldb is doing work that you really > can't interrupt - e.g. we can't

[Lldb-commits] [PATCH] D133446: [LLDB][NativePDB] Global ctor and dtor should be global decls.

labath added a comment. I believe that this fixes the crash, but the names of generated functions still look fairly weird. Could we create them using their mangled name instead? That way, someone might actually call them, if he was so inclined. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133519/new/ https://reviews.llvm.org/D133519 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

Michael137 added inline comments. Comment at: lldb/docs/use/extensions.rst:84 + DW_TAG_compile_unit + DW_AT_GNU_dwo_id (0xabcdef) + DW_AT_GNU_dwo_name("M.pcm") Is it worth commenting on the difference to the `dwo` mechanism on Linux. Since we

[Lldb-commits] [PATCH] D133519: Document some of the clang-specific DWARF extensions supported by LLDB

labath accepted this revision. labath added a comment. cool Comment at: lldb/docs/use/extensions.rst:84 + DW_TAG_compile_unit + DW_AT_GNU_dwo_id (0xabcdef) + DW_AT_GNU_dwo_name("M.pcm") Michael137 wrote: > Is it worth commenting on the

[Lldb-commits] [PATCH] D133461: [LLDB][NativePDB] Set block address range.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:372 +func->GetAddressRange().GetBaseAddress().GetFileAddress(); +Block::Range range = Block::Range(block_base - func_base, block.CodeSize); +if (block_base

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

labath added inline comments. Comment at: lldb/unittests/Interpreter/CMakeLists.txt:17-18 lldbInterpreter + lldbPluginDynamicLoaderDarwinKernel + lldbPluginObjectContainerMachOFileset lldbPluginPlatformMacOSX These dependencies should be

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4161 + if (command) { +if (command->contains(" -gline-tables-only")) +

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat accepted this revision. werat added reviewers: clayborg, granata.enrico. werat added a comment. This revision is now accepted and ready to land. Nice fix! It would be nice to remove redundant parenthesis, e.g. `(*(ptr)).member -> (*ptr).member`, but I see this is non-trivial with the

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 459067. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 459070. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files:

[Lldb-commits] [PATCH] D133427: [gdb-remote] Move broadcasting logic down to GDBRemoteClientBase

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdb4468d3949: [gdb-remote] Move broadcasting logic down to GDBRemoteClientBase (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] bdb4468 - [gdb-remote] Move broadcasting logic down to GDBRemoteClientBase

Author: Michał Górny Date: 2022-09-09T17:13:08+02:00 New Revision: bdb4468d39496088fc05d8c5575647fac9c8062a URL: https://github.com/llvm/llvm-project/commit/bdb4468d39496088fc05d8c5575647fac9c8062a DIFF: https://github.com/llvm/llvm-project/commit/bdb4468d39496088fc05d8c5575647fac9c8062a.diff

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1091-1150 +QualType fpTy = ComplexTy->castAs()->getElementType(); IntExpr = S.ImpCastExprToType(IntExpr.get(), fpTy, CK_IntegralToFloating); IntExpr = S.ImpCastExprToType(IntExpr.get(),