[Lldb-commits] [lldb] r255097 - wire timeouts and exceptional inferior process exits through the test event system

2015-12-08 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Wed Dec 9 00:45:43 2015 New Revision: 255097 URL: http://llvm.org/viewvc/llvm-project?rev=255097&view=rev Log: wire timeouts and exceptional inferior process exits through the test event system The results formatter system is now fed timeouts and exceptional process exits (

Re: [Lldb-commits] [PATCH] D15273: [LLDB][MIPS] Handle PIC calling convention for MIPS32

2015-12-08 Thread Bhushan Attarde via lldb-commits
bhushan closed this revision. bhushan added a comment. Closed by commit http://reviews.llvm.org/rL255005 Repository: rL LLVM http://reviews.llvm.org/D15273 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] r255093 - Add some additional safety checks to the StructuredData access

2015-12-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Dec 8 22:15:47 2015 New Revision: 255093 URL: http://llvm.org/viewvc/llvm-project?rev=255093&view=rev Log: Add some additional safety checks to the StructuredData access methods - lldb can still crash pretty easily on corrupt JSON text, and these will help eliminate a b

[Lldb-commits] [lldb] r255090 - When printing warnings, the repeat_key should be

2015-12-08 Thread Sean Callanan via lldb-commits
Author: spyffe Date: Tue Dec 8 19:25:01 2015 New Revision: 255090 URL: http://llvm.org/viewvc/llvm-project?rev=255090&view=rev Log: When printing warnings, the repeat_key should be const void * because the data is never accessed, the pointer is the only useful piece of data. Modified: lldb/t

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

2015-12-08 Thread Dawn Perchik via lldb-commits
dawn marked an inline comment as done. dawn added a comment. Thanks Greg. Will fix comment in commit. @Jim, can you accept please? Repository: rL LLVM http://reviews.llvm.org/D15326 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

Re: [Lldb-commits] [PATCH] D15359: Fix DoReadMemory for Windows mini dumps.

2015-12-08 Thread Adrian McCarthy via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255083: Fix DoReadMemory for Windows mini dumps. (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D15359?vs=42243&id=42246#toc Repository: rL LLVM http://reviews.llvm.org/D15

[Lldb-commits] [lldb] r255083 - Fix DoReadMemory for Windows mini dumps.

2015-12-08 Thread Adrian McCarthy via lldb-commits
Author: amccarth Date: Tue Dec 8 18:29:38 2015 New Revision: 255083 URL: http://llvm.org/viewvc/llvm-project?rev=255083&view=rev Log: Fix DoReadMemory for Windows mini dumps. Differential Revision: http://reviews.llvm.org/D15359 Modified: lldb/trunk/source/Plugins/Process/Windows/MiniDump/P

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

2015-12-08 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. Just fix the comment as mentioned in the inline comments and this is ready. Jim should OK this as well. Comment at: include/lldb/Target/Language.h:176 @@ -175,1 +175,3 @@ +// return the primary language, so if

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

2015-12-08 Thread Dawn Perchik via lldb-commits
dawn requested a review of this revision. dawn added a comment. Please reconsider. Thanks. Repository: rL LLVM http://reviews.llvm.org/D15326 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

2015-12-08 Thread Dawn Perchik via lldb-commits
dawn added a reviewer: clayborg. dawn added a comment. (Added Greg - he wrote Mangled::GetLanguage - now GuessLanguage). This patch removes the dependence on determining language from the name mangling for 99% of cases (there's still the much less common problem for symbols since Symbol 's GetL

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Greg Clayton via lldb-commits
clayborg added a comment. In http://reviews.llvm.org/D15312#305392, @dawn wrote: > > Greg: But going forward I would like to see more of "find a struct named 'X' > > > in CompilerDeclContext 'Y'" queries, instead of ... > > I think lldb should have both, a "search for anything named foo in my sco

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

2015-12-08 Thread Dawn Perchik via lldb-commits
dawn added a comment. In http://reviews.llvm.org/D15326#305163, @jingham wrote: > The part of this fix which is using info in the SymbolContext to make the > language detection more accurate is fine. > > We have to do something better about how we detect the language from a > mangled name. The

[Lldb-commits] [PATCH] D15357: Update code to silent some ARM/ARM64 specific compiler warnings

2015-12-08 Thread Muhammad Omair Javaid via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. Herald added subscribers: rengolin, aemerson. Following changes remove conditions where an unsigned integer is being tested to be greater or equal to zero. These conditions will alw

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Dawn Perchik via lldb-commits
dawn added a comment. > Greg: But going forward I would like to see more of "find a struct named 'X' in CompilerDeclContext 'Y'" queries, instead of ... I think lldb should have both, a "search for anything named foo in my scope context" (for when a user does "p foo"), and a "search for a thin

[Lldb-commits] [PATCH] D15355: Add failure paths to a few JSONNumber members

2015-12-08 Thread Muhammad Omair Javaid via lldb-commits
omjavaid created this revision. omjavaid added a reviewer: tberghammer. omjavaid added a subscriber: lldb-commits. This patch updates GetAsUnsigned(), GetAsSigned(), and GetAsDouble() JSONNumber functions to add failure check. The previous code was generating compiler warnings for not being able

[Lldb-commits] [lldb] r255060 - Remove the -c option from dotest.py.

2015-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Dec 8 16:15:48 2015 New Revision: 255060 URL: http://llvm.org/viewvc/llvm-project?rev=255060&view=rev Log: Remove the -c option from dotest.py. This seems to be a legacy relic from days gone by where the remote test suite runner operated completely differently than it d

[Lldb-commits] [PATCH] D15347: Add Hexagon ABI to System Initialization

2015-12-08 Thread Ted Woodward via lldb-commits
ted created this revision. ted added a reviewer: clayborg. ted added a subscriber: lldb-commits. When the Hexagon ABI was added, it was inadvertently left out of initialization/termination. This patch adds it. http://reviews.llvm.org/D15347 Files: source/API/SystemInitializerFull.cpp Index:

[Lldb-commits] [lldb] r255049 - Remove default case in switch which covers all enumeration values

2015-12-08 Thread Ed Maste via lldb-commits
Author: emaste Date: Tue Dec 8 14:50:35 2015 New Revision: 255049 URL: http://llvm.org/viewvc/llvm-project?rev=255049&view=rev Log: Remove default case in switch which covers all enumeration values This also conveniently eliminates another warning from the unintentional use of a trigraph: warni

[Lldb-commits] [lldb] r255048 - Remove the -X option from dotest.py

2015-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Dec 8 14:36:22 2015 New Revision: 255048 URL: http://llvm.org/viewvc/llvm-project?rev=255048&view=rev Log: Remove the -X option from dotest.py This removes the option to exclude a single directory. This is part of an effort to remove unused options and cleanup the inte

Re: [Lldb-commits] [PATCH] D15326: Rework breakpoint language filtering to use the symbol context's language.

2015-12-08 Thread Jim Ingham via lldb-commits
jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. The part of this fix which is using info in the SymbolContext to make the language detection more accurate is fine. We have to do something better about how we detect the language

[Lldb-commits] [lldb] r255041 - Remove the -g option from dotest.py

2015-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Dec 8 12:48:53 2015 New Revision: 255041 URL: http://llvm.org/viewvc/llvm-project?rev=255041&view=rev Log: Remove the -g option from dotest.py This removes the non-exclusive filterspec option as part of an effort to remove unused / deprecated command line options from d

[Lldb-commits] [lldb] r255040 - Remove the -b option from dotest.py

2015-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Dec 8 12:43:16 2015 New Revision: 255040 URL: http://llvm.org/viewvc/llvm-project?rev=255040&view=rev Log: Remove the -b option from dotest.py This removes the blacklist option as part of an effort to remove unused / unmaintained command line options from the test suite

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Greg Clayton via lldb-commits
clayborg added a comment. BTW: I fixed DeclContextFindDeclByName to return a vector of CompilerDecl objects: % svn commit Sendinginclude/lldb/Symbol/ClangASTContext.h Sendinginclude/lldb/Symbol/GoASTContext.h Sendinginclude/lldb/Symbol/TypeSystem.h Sendingsource/

[Lldb-commits] [lldb] r255038 - Change DeclContextFindDeclByName to return a vector of CompilerDecl objects. Opaque pointers should only be used for the decl context object. Also made a default implem

2015-12-08 Thread Greg Clayton via lldb-commits
Author: gclayton Date: Tue Dec 8 12:39:50 2015 New Revision: 255038 URL: http://llvm.org/viewvc/llvm-project?rev=255038&view=rev Log: Change DeclContextFindDeclByName to return a vector of CompilerDecl objects. Opaque pointers should only be used for the decl context object. Also made a default

[Lldb-commits] [lldb] r255037 - Remove +b option from dotest.py

2015-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Dec 8 12:36:05 2015 New Revision: 255037 URL: http://llvm.org/viewvc/llvm-project?rev=255037&view=rev Log: Remove +b option from dotest.py Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py lldb/trunk/packages/Python/lldbsuite/test/dotest.py

[Lldb-commits] [lldb] r255035 - Remove the -D option from dotest.py.

2015-12-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Dec 8 12:25:38 2015 New Revision: 255035 URL: http://llvm.org/viewvc/llvm-project?rev=255035&view=rev Log: Remove the -D option from dotest.py. This removes the option to dump Python sys.path variable as part of an effort to remove unused options. Modified: lldb/tr

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Greg Clayton via lldb-commits
clayborg added a comment. In http://reviews.llvm.org/D15312#304652, @dawn wrote: > Thanks Greg! To address your main point: > > > So either make it generic, or clang specific. > > > DeclContextCountDeclLevels's interface follows DeclContextFindDeclByName > (authored by Paul Herman). If DeclCon

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Greg Clayton via lldb-commits
clayborg added a comment. That does make sense. Lets ignore the partial parsing until we find a performance problem that needs to be fixed. By I really do want to see the API on CompilerDeclContext and CompilerDecl get a lot more member functions that can do useful things now that we have this

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Tamas Berghammer via lldb-commits
tberghammer added a comment. I am not sure if doing all of the parsing lazily is the good approach because of speed considerations. The problem is that if we do everything lazily then in one side we are parsing only the information what we need but on the other side it is very difficult (or im

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Greg Clayton via lldb-commits
clayborg added a comment. So one thing I don't want to propagate here is the "go parse everything inside a decl context" if we can avoid it. I believe the first CompilerDeclContext patch did this, but I don't remember the exact details so I could be wrong. But going forward I would like to see

[Lldb-commits] [lldb] r255025 - flip on executable bit on test runner tests

2015-12-08 Thread Todd Fiala via lldb-commits
Author: tfiala Date: Tue Dec 8 10:22:27 2015 New Revision: 255025 URL: http://llvm.org/viewvc/llvm-project?rev=255025&view=rev Log: flip on executable bit on test runner tests Modified: lldb/trunk/packages/Python/lldbsuite/test/test_runner/test/inferior.py (contents, props changed) l

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-08 Thread Todd Fiala via lldb-commits
> I just got a clean build And by that, I mean a clean test run. On Tue, Dec 8, 2015 at 8:17 AM, Todd Fiala wrote: > Okay cool. > > I just got a clean build here on a local OS X machine. Thanks for > addressing that, Pavel! I looked at the diffs and they made sense vs. the > behavior I saw la

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-08 Thread Todd Fiala via lldb-commits
Okay cool. I just got a clean build here on a local OS X machine. Thanks for addressing that, Pavel! I looked at the diffs and they made sense vs. the behavior I saw last night. On Tue, Dec 8, 2015 at 7:58 AM, Pavel Labath wrote: > I'm still waiting for the buildbots to finish, but yeah, it's

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-08 Thread Pavel Labath via lldb-commits
I'm still waiting for the buildbots to finish, but yeah, it's looking good so far. On 8 December 2015 at 15:51, Todd Fiala via lldb-commits wrote: > I think Pavel cleared this up. I'm checking now. If there's anything > remaining, I'll resolve it after I see what happens. > > On Mon, Dec 7, 201

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-08 Thread Todd Fiala via lldb-commits
tfiala added a subscriber: tfiala. tfiala added a comment. I think Pavel cleared this up. I'm checking now. If there's anything remaining, I'll resolve it after I see what happens. http://reviews.llvm.org/D15318 ___ lldb-commits mailing list lldb-

Re: [Lldb-commits] [PATCH] D15318: Get rid of global variables in dotest.py

2015-12-08 Thread Todd Fiala via lldb-commits
I think Pavel cleared this up. I'm checking now. If there's anything remaining, I'll resolve it after I see what happens. On Mon, Dec 7, 2015 at 9:59 PM, Zachary Turner wrote: > zturner added a comment. > > To be clear, we explicitly set the LLDB_TEST environment variable as part > of initiali

Re: [Lldb-commits] [lldb] r254979 - Refactor ResultsFormatter creation into result_formatter.

2015-12-08 Thread Todd Fiala via lldb-commits
Perfect. I have a few things I'm trying to work in - finishing up wiring things up (timeouts and exceptional process exits) to the new basic formatter, then getting the low-load, single worker test runner pass up for review. I have most of the first one done, should have that in today. The secon

[Lldb-commits] [lldb] r255017 - Fix MSVC build after rL255016

2015-12-08 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Dec 8 08:27:40 2015 New Revision: 255017 URL: http://llvm.org/viewvc/llvm-project?rev=255017&view=rev Log: Fix MSVC build after rL255016 Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp Modified: lldb/trunk/sourc

Re: [Lldb-commits] [PATCH] D14952: Modify "platform connect" to connect to processes as well

2015-12-08 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255016: Modify "platform connect" to connect to processes as well (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D14952?vs=42063&id=42170#toc Repository: rL LLVM http://

[Lldb-commits] [lldb] r255016 - Modify "platform connect" to connect to processes as well

2015-12-08 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Dec 8 08:08:19 2015 New Revision: 255016 URL: http://llvm.org/viewvc/llvm-project?rev=255016&view=rev Log: Modify "platform connect" to connect to processes as well The standard remote debugging workflow with gdb is to start the application on the remote host under

[Lldb-commits] [lldb] r255014 - Add a new option to Platform::LoadImage to install the image

2015-12-08 Thread Tamas Berghammer via lldb-commits
Author: tberghammer Date: Tue Dec 8 07:43:59 2015 New Revision: 255014 URL: http://llvm.org/viewvc/llvm-project?rev=255014&view=rev Log: Add a new option to Platform::LoadImage to install the image This change introduce 3 different working mode for Platform::LoadImage depending on the file specs

Re: [Lldb-commits] [PATCH] D15152: Add a new option to Platform::LoadImage to install the image

2015-12-08 Thread Tamas Berghammer via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL255014: Add a new option to Platform::LoadImage to install the image (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D15152?vs=42055&id=42166#toc Repository: rL LLVM http

[Lldb-commits] [lldb] r255013 - Fixup dotest.py on mac for the configuration package

2015-12-08 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Dec 8 07:32:07 2015 New Revision: 255013 URL: http://llvm.org/viewvc/llvm-project?rev=255013&view=rev Log: Fixup dotest.py on mac for the configuration package Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py lldb/trunk/packages/Python/lldbsui

[Lldb-commits] [lldb] r255009 - Fixup dotest.py after the configuration package introduction

2015-12-08 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Dec 8 06:09:56 2015 New Revision: 255009 URL: http://llvm.org/viewvc/llvm-project?rev=255009&view=rev Log: Fixup dotest.py after the configuration package introduction Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified: lldb/trunk/packages/Python

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Tamas Berghammer via lldb-commits
tberghammer added a subscriber: tberghammer. tberghammer added a comment. Paul is not working on LLDB anymore so I added Siva who took over most of his work. Repository: rL LLVM http://reviews.llvm.org/D15312 ___ lldb-commits mailing list lldb-c

Re: [Lldb-commits] [PATCH] D15312: Fix scope-based lookup when more than one function is found.

2015-12-08 Thread Dawn Perchik via lldb-commits
dawn added a comment. bloodbath:~% exit Thanks Greg! To address your main point: > So either make it generic, or clang specific. DeclContextCountDeclLevels's interface follows DeclContextFindDeclByName (authored by Paul Herman). If DeclContextCountDeclLevels is to change, then DeclContextFi