[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f1e7b3d01e1: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70979/new/

[Lldb-commits] [lldb] 2f1e7b3 - [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

Author: Raphael Isemann Date: 2019-12-04T08:28:52+01:00 New Revision: 2f1e7b3d01e176e912477d52847c19d3847a43a0 URL: https://github.com/llvm/llvm-project/commit/2f1e7b3d01e176e912477d52847c19d3847a43a0 DIFF:

[Lldb-commits] [PATCH] D70992: Replacing to use of ul suffix in GetMaxU64Bitfield since it not guarenteed to be 64 bit

shafik created this revision. shafik added reviewers: aprantl, teemperor, JDevlieghere. `GetMaxU64Bitfield(...)` uses the `ul` suffix but we require a 64 bit unsigned integer and `ul` could be 32 bit. So this replacing it with a explicit cast and refactors the code around it to use an early

[Lldb-commits] [lldb] cec8263 - [Process] GetLanguageRuntimes() takes an argument that's always constant.

Author: Davide Italiano Date: 2019-12-03T16:54:55-08:00 New Revision: cec82634a4034b1528940487349be14b0c405d2d URL: https://github.com/llvm/llvm-project/commit/cec82634a4034b1528940487349be14b0c405d2d DIFF:

[Lldb-commits] [PATCH] D70663: [lldb] Remove lldb's own ASTDumper

shafik added a comment. Yeah, there was indeed some ugly code there, nice work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70663/new/ https://reviews.llvm.org/D70663 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 11ae9dd - [ClangASTContext] Remove a very old hack.

Author: Davide Italiano Date: 2019-12-03T16:32:21-08:00 New Revision: 11ae9dd6576e02223e6eb10568af9e5cb45b7bc6 URL: https://github.com/llvm/llvm-project/commit/11ae9dd6576e02223e6eb10568af9e5cb45b7bc6 DIFF:

[Lldb-commits] [PATCH] D70989: [TypeCategory] IsApplicable doesn't seem to apply.

davide abandoned this revision. davide added a comment. Nevermind, I found a better way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70989/new/ https://reviews.llvm.org/D70989 ___ lldb-commits

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

clayborg added a comment. We could just add a new flag to lldb-vscode like "--no-lldb-init" and always pass that when we run our test suite? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70886/new/ https://reviews.llvm.org/D70886

[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

clayborg added inline comments. Comment at: lldb/include/lldb/Utility/ArchSpec.h:436 - void DumpTriple(Stream ) const; + void DumpTriple(llvm::raw_ostream ) const; Should we just make a static operator << function for this instead so we can use in

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

clayborg added a comment. Although I am ok with this patch, it will only work if the unexpected output comes before we expect any packets or perfectly in between packets. Not sure we should do this. For example this would work: random outut Content Length:2 {} And this would work:

[Lldb-commits] [lldb] 2bb19f9 - [TypeCategory] HasLanguage() is now unused.

Author: Davide Italiano Date: 2019-12-03T15:45:23-08:00 New Revision: 2bb19f93f6a8d0c7ceaa41df744803480c95fe9a URL: https://github.com/llvm/llvm-project/commit/2bb19f93f6a8d0c7ceaa41df744803480c95fe9a DIFF:

[Lldb-commits] [PATCH] D70989: [TypeCategory] IsApplicable doesn't seem to apply.

clayborg added a comment. This seems like it will make a lot more work happen. Many C++ formatters are regex based and are quite expensive to compare against type names. Seems worthwhile to skip if the language doesn't match? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D70989: [TypeCategory] IsApplicable doesn't seem to apply.

davide added a comment. Please don't merge this yet. I'm mostly trying to understand if this is dead code or not. @jingham , this is one of the places in generic code where we hardcode knowledge about the languages. Needless to say, it causes conflicts downstream and feels wrong anyway. After

[Lldb-commits] [PATCH] D70989: [TypeCategory] IsApplicable doesn't seem to apply.

davide created this revision. davide added reviewers: teemperor, friss, jingham. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70989 Files: lldb/include/lldb/DataFormatters/TypeCategory.h lldb/source/DataFormatters/TypeCategory.cpp Index:

[Lldb-commits] [lldb] 0cfb4a6 - [FormatManager] Provide only one variant of EnableCategory.

Author: Davide Italiano Date: 2019-12-03T15:03:25-08:00 New Revision: 0cfb4a6b3d9556c8fc55766bce47cbb433ff19fe URL: https://github.com/llvm/llvm-project/commit/0cfb4a6b3d9556c8fc55766bce47cbb433ff19fe DIFF:

[Lldb-commits] [lldb] 89618a7 - [DataVisualization] Simplify. NFCI.

Author: Davide Italiano Date: 2019-12-03T15:03:25-08:00 New Revision: 89618a7ce1c13dcb540d925626638c93cc85a553 URL: https://github.com/llvm/llvm-project/commit/89618a7ce1c13dcb540d925626638c93cc85a553 DIFF:

[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70979/new/ https://reviews.llvm.org/D70979 ___

[Lldb-commits] [PATCH] D70983: [TypeCategory] Nothing passes down a list of languages.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15a172bebbc5: [TypeCategory] Nothing passes down a list of languages. (authored by davide). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70983/new/

[Lldb-commits] [lldb] 15a172b - [TypeCategory] Nothing passes down a list of languages.

Author: Davide Italiano Date: 2019-12-03T13:57:58-08:00 New Revision: 15a172bebbc5b95d05733ef842fcdbd14e9d441d URL: https://github.com/llvm/llvm-project/commit/15a172bebbc5b95d05733ef842fcdbd14e9d441d DIFF:

[Lldb-commits] [PATCH] D70983: [TypeCategory] Nothing passes down a list of languages.

davide created this revision. davide added reviewers: teemperor, jingham, friss. Herald added a project: LLDB. This should allow further simplifications, but it's a first step. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70983 Files:

[Lldb-commits] [PATCH] D70979: [lldb][NFC] Migrate to raw_ostream in ArchSpec::DumpTriple

teemperor created this revision. teemperor added a reviewer: labath. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D70979 Files: lldb/include/lldb/Core/ModuleSpec.h lldb/include/lldb/Utility/ArchSpec.h

[Lldb-commits] [PATCH] D70883: [vscode.py] Make read_packet only return None when EOF

MaskRay added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py:58 +while True: +line = f.readline().decode("utf-8") +if len(line) == 0: Prefer single quotes. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

aadsm added a comment. > Maybe you could do something similar to LocalLLDBInit.test ? That test uses the `lldb` `-S` (and others) flags that `lldb-vscode` doesn't support :(. These flags should really be added to the initialize packet but they're very specific to lldb and the DAP doesn't

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. FYI I am investigating it. I have found 2019-09-26-raspbian-buster.zip really can run in chroot on Fedora 31 armv7hl so I should be able to reproduce it. It is building LLDB now, that takes about 6 hours.

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1767049 , @labath wrote: > In D70840#1767028 , @mstorsjo wrote: > > > In D70840#1765373 , @clayborg > > wrote: > > > > > So some

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

compnerd added a comment. In D70764#1767395 , @JDevlieghere wrote: > Having one canonical variable controlling zlib support seems indeed desirable. > > In D70519#1754618 , @labath wrote: > > > With this patch,

[Lldb-commits] [PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

vsk added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp:159 // FUNC11-BT: func11_tailcalled{{.*}} // FUNC11-BT-NEXT: func12{{.*}} [artificial] use(x); The failure

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

JDevlieghere added a comment. Having one canonical variable controlling zlib support seems indeed desirable. In D70519#1754618 , @labath wrote: > With this patch, what is the output of `llvm-config --system-libs` ? @compnerd What's the answer to this

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jasonmolenda added a comment. In D63540#1766693 , @omjavaid wrote: > Hi Jan, > > I have done further investigation on this with new ampere arm server. This > problem manifests itself on all kind of Debian flavors and is not related to > underlying

[Lldb-commits] [PATCH] D70721: [lldb/cpluspluslanguage] Add constructor substitutor

shafik added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:327 + bool trySubstitute(llvm::StringRef From, llvm::StringRef To) { +if (!llvm::StringRef(this->First, this->numLeft()).startswith(From))

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

labath added a comment. I guess you were building darwin binaries, right? If that's the case, then you weren't using this code at all, as apple uses AppleIndex by default. The test in question uses all three indexes (it forces their generation by altering compile flags) and the failures you

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

shafik added a comment. In D70846#1766598 , @labath wrote: > In D70846#1766204 , @shafik wrote: > > > In D70846#1763731 , @labath wrote: > > > > > There's `lldb-shell ::

[Lldb-commits] [PATCH] D70851: [lldb] s/FileSpec::Equal/FileSpec::Match

clayborg added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70851/new/ https://reviews.llvm.org/D70851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D70907: Change Target::FindBreakpointsByName to return Expected

JosephTremoulet marked 2 inline comments as done. JosephTremoulet added inline comments. Comment at: lldb/source/Breakpoint/BreakpointList.cpp:136 +"FindBreakpointsByName requires a name", +llvm::inconvertibleErrorCode()); JDevlieghere wrote: >

[Lldb-commits] [PATCH] D70907: Change Target::FindBreakpointsByName to return Expected

JosephTremoulet updated this revision to Diff 231931. JosephTremoulet added a comment. - Use invalid_argument error code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70907/new/ https://reviews.llvm.org/D70907 Files:

[Lldb-commits] [PATCH] D70907: Change Target::FindBreakpointsByName to return Expected

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Breakpoint/BreakpointList.cpp:136 +"FindBreakpointsByName requires a name", +llvm::inconvertibleErrorCode());

[Lldb-commits] [PATCH] D70851: [lldb] s/FileSpec::Equal/FileSpec::Match

JDevlieghere added a comment. Okay, sound sensible. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70851/new/ https://reviews.llvm.org/D70851 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e9b0b6d11e8: [EditLine] Fix RecallHistory to make it go in the right direction. (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 0e9b0b6 - [EditLine] Fix RecallHistory to make it go in the right direction.

Author: Jonas Devlieghere Date: 2019-12-03T08:12:10-08:00 New Revision: 0e9b0b6d11e882efec8505d97c4b65e1562e6715 URL: https://github.com/llvm/llvm-project/commit/0e9b0b6d11e882efec8505d97c4b65e1562e6715 DIFF:

[Lldb-commits] [PATCH] D70907: Change Target::FindBreakpointsByName to use a vector

JosephTremoulet updated this revision to Diff 231914. JosephTremoulet added a comment. - Change signature to return Expected> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70907/new/ https://reviews.llvm.org/D70907 Files:

[Lldb-commits] [PATCH] D70851: [lldb] s/FileSpec::Equal/FileSpec::Match

labath marked 5 inline comments as done. labath added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:196 static bool Equal(const FileSpec , const FileSpec , bool full); clayborg wrote: > JDevlieghere wrote: > > Why do we still need the

[Lldb-commits] [PATCH] D70934: [Reproducer] Add version check

This revision was automatically updated to reflect the committed changes. Closed by commit rG62827737acd8: [lldb/Reproducer] Add version check (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70934/new/

[Lldb-commits] [lldb] 6282773 - [lldb/Reproducer] Add version check

Author: Jonas Devlieghere Date: 2019-12-03T07:54:42-08:00 New Revision: 62827737acd878af6cd8930758b0d6f297173f40 URL: https://github.com/llvm/llvm-project/commit/62827737acd878af6cd8930758b0d6f297173f40 DIFF:

[Lldb-commits] [lldb] ad5bb05 - [lldb] Remove unneeded semicolon in IOHandlerCursesGUI

Author: Pavel Labath Date: 2019-12-03T16:22:52+01:00 New Revision: ad5bb05405c0ea8fc82fae240e2006d241799cf6 URL: https://github.com/llvm/llvm-project/commit/ad5bb05405c0ea8fc82fae240e2006d241799cf6 DIFF: https://github.com/llvm/llvm-project/commit/ad5bb05405c0ea8fc82fae240e2006d241799cf6.diff

[Lldb-commits] [lldb] 159641d - [lldb] Use llvm range functions in LineTable.cpp

Author: Pavel Labath Date: 2019-12-03T16:22:52+01:00 New Revision: 159641d710b074b6d89e3aced179f9a2229e4eb0 URL: https://github.com/llvm/llvm-project/commit/159641d710b074b6d89e3aced179f9a2229e4eb0 DIFF: https://github.com/llvm/llvm-project/commit/159641d710b074b6d89e3aced179f9a2229e4eb0.diff

[Lldb-commits] [PATCH] D70954: [lldb] Don't put compile unit name into the support file list

labath updated this revision to Diff 231904. labath added a comment. Add the dwarf5 part + a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70954/new/ https://reviews.llvm.org/D70954 Files:

[Lldb-commits] [PATCH] D70830: [LLDB] Disable MSVC warning C4190

This revision was automatically updated to reflect the committed changes. Closed by commit rG1cc0ba4cbdc5: [LLDB] Disable MSVC warning C4190: LLDBSwigPythonBreakpointCallbackFunction… (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1cc0ba4 - [LLDB] Disable MSVC warning C4190: 'LLDBSwigPythonBreakpointCallbackFunction' has C-linkage specified, but returns UDT 'llvm::Expected' which is incompatible with

Author: Alexandre Ganea Date: 2019-12-03T09:53:26-05:00 New Revision: 1cc0ba4cbdc54200e1b3c65e83e51a5368a819ea URL: https://github.com/llvm/llvm-project/commit/1cc0ba4cbdc54200e1b3c65e83e51a5368a819ea DIFF:

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

labath added a comment. In D70840#1767028 , @mstorsjo wrote: > In D70840#1765373 , @clayborg wrote: > > > So some background on how address masks are handled in LLDB: > > > > Typically the way we have tried to take

[Lldb-commits] [PATCH] D70840: [LLDB] [DWARF] Strip out the thumb bit from addresses on ARM

mstorsjo added a comment. In D70840#1765373 , @clayborg wrote: > So some background on how address masks are handled in LLDB: > > Typically the way we have tried to take care of the extra Thumb bit for ARM > using: > > lldb::addr_t

[Lldb-commits] [PATCH] D70954: [lldb] Don't put compile unit name into the support file list

teemperor added a comment. This seems to break `Shell/SymbolFile/DWARF/debug-types-address-ranges.s` on my machine: https://teemperor.de/pub/D70954.log Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70954/new/ https://reviews.llvm.org/D70954

[Lldb-commits] [PATCH] D70954: [lldb] Don't put compile unit name into the support file list

labath planned changes to this revision. labath added a comment. It seems one dwarf5 test is failing with this change (or rather, it was accidentally passing before as it picked up the fake line 0 entry). Since this patch is not that big, I'll just fold the dwarf5 followup into it. Planning

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

labath added a comment. In D70932#1766846 , @teemperor wrote: > Yes, multiline expressions use this code, but I don't see any functional > change in this patch that could be tested? It seems to only change the bool > to an enum so that we can pass in

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Yes, multiline expressions use this code, but I don't see any functional change in this patch that could be tested? It seems to only change the bool to an enum so that we can pass in

[Lldb-commits] [PATCH] D70954: [lldb] Don't put compile unit name into the support file list

labath created this revision. labath added reviewers: clayborg, JDevlieghere. Herald added a subscriber: aprantl. Herald added a reviewer: jdoerfert. Herald added a project: LLDB. Lldb's "format-independent" debug info made use of the fact that DWARF (<=4) did not use the file index zero, and

[Lldb-commits] [PATCH] D70722: [lldb/IRExecutionUnit] Stop searching based on demangled names

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70722/new/ https://reviews.llvm.org/D70722

[Lldb-commits] [PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

labath added a comment. Hi, I'm not sure if you've noticed but the re-enabled TestBasicEntryValuesX86_64.py is failing both on linux and mac. An example of breakage can be found here: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4338/testReport/ (you can ignore the

[Lldb-commits] [PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

djtodoro added a comment. Reverted while investigating. I am not sure what happened, since the test passed on my machine. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68209/new/ https://reviews.llvm.org/D68209

[Lldb-commits] [lldb] 409350d - Revert "[LiveDebugValues] Introduce entry values of unmodified params"

Author: Djordje Todorovic Date: 2019-12-03T13:13:27+01:00 New Revision: 409350deeaf27ab767018b4c4834cfb82919e338 URL: https://github.com/llvm/llvm-project/commit/409350deeaf27ab767018b4c4834cfb82919e338 DIFF:

[Lldb-commits] [PATCH] D70532: [lldb] Improve/fix base address selection in location lists

labath added a comment. Greg, what do you make of this version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70532/new/ https://reviews.llvm.org/D70532 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 16c0653 - [lldb][NFC] Extract searching for function SymbolContexts out of ClangExpressionDeclMap::LookupFunction

Author: Raphael Isemann Date: 2019-12-03T12:33:24+01:00 New Revision: 16c0653db1150c849bb25f0547abb64349234394 URL: https://github.com/llvm/llvm-project/commit/16c0653db1150c849bb25f0547abb64349234394 DIFF:

[Lldb-commits] [PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cfceb910692: [LiveDebugValues] Introduce entry values of unmodified params (authored by djtodoro). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

djtodoro added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68209/new/ https://reviews.llvm.org/D68209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] b37a43d - [lldb] Remove all remaining tabs from TestReturnValue.py

Author: Raphael Isemann Date: 2019-12-03T12:14:40+01:00 New Revision: b37a43d93db8c5afb3b95d803638f0536608779d URL: https://github.com/llvm/llvm-project/commit/b37a43d93db8c5afb3b95d803638f0536608779d DIFF:

[Lldb-commits] [lldb] 4821d2a - [lldb][NFC] Test going up/down one line in the multiline expression editor

Author: Raphael Isemann Date: 2019-12-03T12:06:40+01:00 New Revision: 4821d2a014e02b14223676c98b2ef5244eb91da8 URL: https://github.com/llvm/llvm-project/commit/4821d2a014e02b14223676c98b2ef5244eb91da8 DIFF:

[Lldb-commits] [lldb] 057626b - Fixup 6d18e53: xfail TestShowLocationDwarf5.py properly

Author: Diana Picus Date: 2019-12-03T11:53:28+01:00 New Revision: 057626b4393836e11712bd694afda121d8309973 URL: https://github.com/llvm/llvm-project/commit/057626b4393836e11712bd694afda121d8309973 DIFF: https://github.com/llvm/llvm-project/commit/057626b4393836e11712bd694afda121d8309973.diff

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

omjavaid added a comment. Hi Jan, I have done further investigation on this with new ampere arm server. This problem manifests itself on all kind of Debian flavors and is not related to underlying libraries. I have tested LLDB on Arm 32bit host with Ubuntu Xenial, Bionic and Debian Buster all

[Lldb-commits] [lldb] 46d0ec3 - [lldb] Remove tab from TestReturnValue.py

Author: Raphael Isemann Date: 2019-12-03T11:44:24+01:00 New Revision: 46d0ec3a803021281c8d868b1487d2d5cd06f274 URL: https://github.com/llvm/llvm-project/commit/46d0ec3a803021281c8d868b1487d2d5cd06f274 DIFF:

[Lldb-commits] [PATCH] D70906: [lldb] Move register info "augmentation" from gdb-remote into ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b8db387f2a6: [lldb] Move register info augmentation from gdb-remote into ABI (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70906/new/

[Lldb-commits] [lldb] 2b8db38 - [lldb] Move register info "augmentation" from gdb-remote into ABI

Author: Pavel Labath Date: 2019-12-03T11:39:20+01:00 New Revision: 2b8db387f2a616f39a077ede18c6366f2ea9f203 URL: https://github.com/llvm/llvm-project/commit/2b8db387f2a616f39a077ede18c6366f2ea9f203 DIFF: https://github.com/llvm/llvm-project/commit/2b8db387f2a616f39a077ede18c6366f2ea9f203.diff

[Lldb-commits] [PATCH] D70946: [lldb][NFC] Move Curses interface implementation to own file

teemperor marked 2 inline comments as done. teemperor added inline comments. Comment at: lldb/include/lldb/Core/CursesInterface.h:38-51 +class IOHandlerCursesValueObjectList : public IOHandler { +public: + IOHandlerCursesValueObjectList(Debugger , +

[Lldb-commits] [PATCH] D70946: [lldb][NFC] Move Curses interface implementation to own file

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yes, this was long overdue. Comment at: lldb/include/lldb/Core/CursesInterface.h:38-51 +class IOHandlerCursesValueObjectList : public IOHandler { +public: +

[Lldb-commits] [lldb] 6d18e53 - Mark some tests as xfail on AArch64 Linux

Author: Diana Picus Date: 2019-12-03T10:57:42+01:00 New Revision: 6d18e5366c9a0bffe45b179a830483b3f2ec9fa9 URL: https://github.com/llvm/llvm-project/commit/6d18e5366c9a0bffe45b179a830483b3f2ec9fa9 DIFF: https://github.com/llvm/llvm-project/commit/6d18e5366c9a0bffe45b179a830483b3f2ec9fa9.diff

[Lldb-commits] [PATCH] D70934: [Reproducer] Add version check

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Seems legit. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70934/new/ https://reviews.llvm.org/D70934 ___

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

labath added a comment. In D70846#1766204 , @shafik wrote: > In D70846#1763731 , @labath wrote: > > > There's `lldb-shell :: SymbolFile/DWARF/find-basic-function.cpp`, which > > probably didn't get run for you as

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

anton.kolesov added a comment. In D70847#1763797 , @labath wrote: > This needs a test case, though judging by your description it looks like > pretty much every test case on affected platforms (I guess, windows) should > hit this. Can you check if any

[Lldb-commits] [PATCH] D70932: [EditLine] Fix RecallHistory that makes it move in the opposite direction.

labath added a comment. In D70932#1766190 , @JDevlieghere wrote: > ... this code is only used by the REPL) Are you sure about that? I think I was able to trigger something like this by entering the multiline expression mode (`expr`) , and then

[Lldb-commits] [PATCH] D70886: [lldb-vscode] capture the debuggers file handles before lldbinit runs

labath added a comment. In D70886#1765629 , @aadsm wrote: > The way phabricator shows the diff is tricky, this change has nothing to do > with D70882 and stands by itself. The > important part here is making the

[Lldb-commits] [PATCH] D70845: [lldb][NFC] Remove ThreadSafeSTLVector and ThreadSafeSTLMap and their use in ValueObjectSynthetic

This revision was automatically updated to reflect the committed changes. Closed by commit rG315600f48005: [lldb][NFC] Remove ThreadSafeSTLVector and ThreadSafeSTLMap and their use in… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 315600f - [lldb][NFC] Remove ThreadSafeSTLVector and ThreadSafeSTLMap and their use in ValueObjectSynthetic

Author: Raphael Isemann Date: 2019-12-03T09:18:44+01:00 New Revision: 315600f480055f5143aaa245f25bd25221edfa91 URL: https://github.com/llvm/llvm-project/commit/315600f480055f5143aaa245f25bd25221edfa91 DIFF: