[Lldb-commits] [lldb] f9568a9 - [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

Author: Raphael Isemann Date: 2020-02-18T08:58:36+01:00 New Revision: f9568a95493aea3ea813bd37cb8c084ec4294e38 URL: https://github.com/llvm/llvm-project/commit/f9568a95493aea3ea813bd37cb8c084ec4294e38 DIFF:

[Lldb-commits] [lldb] ffd78a0 - [lldb] Replace #pragma once with header guard

Author: Jonas Devlieghere Date: 2020-02-17T23:39:19-08:00 New Revision: ffd78a008ab29c399975485e86bc6bedf91c5277 URL: https://github.com/llvm/llvm-project/commit/ffd78a008ab29c399975485e86bc6bedf91c5277 DIFF:

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2814 +if (!encoding.empty()) + response.Printf("encoding=\"%s\" ", encoding.str().c_str()); + jarin wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. I think we should just have DynamicLoaderStatic disqualify itself for wasm files -- using it will never work there, so why should it pretend to support them... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72751/new/

[Lldb-commits] [lldb] 866b7a6 - [lldb] Replace empty ctor en dtor bodies with =default (NFC)

Author: Jonas Devlieghere Date: 2020-02-17T22:58:26-08:00 New Revision: 866b7a651949f373a3b191f5fee3a7fe0a2709be URL: https://github.com/llvm/llvm-project/commit/866b7a651949f373a3b191f5fee3a7fe0a2709be DIFF:

[Lldb-commits] [PATCH] D74743: [lldb] Make header guards consistent across LLDB

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wuzish. Yeah, let's do what LLVM is doing. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74743/new/

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

jarin added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2814 + +if (reg_info->invalidate_regs && reg_info->invalidate_regs[0]) { + response.PutCString("invalidate_regnums=\""); I know this is

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

jarin added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py:69 +self.assertEqual(q_info_reg["offset"], xml_info_reg.get("offset")) +

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

jarin added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:465 + response.PutChar(','); +response.Printf("%" PRIx32, *reg_num); + } I think this is not correct: target.xml expects this to be

[Lldb-commits] [lldb] b0cb98b - [lldb/Plugins] Conditionally build OperatingSystemPython.

Author: Jonas Devlieghere Date: 2020-02-17T21:22:37-08:00 New Revision: b0cb98b1f5d53cbce66652fa2894c55db61965a4 URL: https://github.com/llvm/llvm-project/commit/b0cb98b1f5d53cbce66652fa2894c55db61965a4 DIFF:

[Lldb-commits] [lldb] aa2ae6a - [lldb/Plugins] Add missing initialize/terminate calls

Author: Jonas Devlieghere Date: 2020-02-17T21:28:16-08:00 New Revision: aa2ae6af81d73773d27d94d120056ef02ce4af6b URL: https://github.com/llvm/llvm-project/commit/aa2ae6af81d73773d27d94d120056ef02ce4af6b DIFF:

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. I have reverted this change temporarily. Please look at the test failure. I ll also do the same at my end. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] fdc122e - Revert "[lldb/lldb-server] Add target.xml support for qXfer request."

Author: Muhammad Omair Javaid Date: 2020-02-18T10:16:52+05:00 New Revision: fdc122e4ed6fd04c31595635d45675ad68d258bd URL: https://github.com/llvm/llvm-project/commit/fdc122e4ed6fd04c31595635d45675ad68d258bd DIFF:

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This breaks LLDB AArch64 Linux buildbot http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/1713 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ccad194 - [lldb/Plugins] Rename initializers to match their plugin name.

Author: Jonas Devlieghere Date: 2020-02-17T20:07:53-08:00 New Revision: ccad1948618d13a86e8a30488ba1ace8b7fd6b73 URL: https://github.com/llvm/llvm-project/commit/ccad1948618d13a86e8a30488ba1ace8b7fd6b73 DIFF:

[Lldb-commits] [lldb] bcde387 - [lldb/Plugins] Initialize all ABI plugins by their plugin name

Author: Jonas Devlieghere Date: 2020-02-17T19:55:43-08:00 New Revision: bcde387f46b74ee2954497b682425e4cac80f082 URL: https://github.com/llvm/llvm-project/commit/bcde387f46b74ee2954497b682425e4cac80f082 DIFF:

[Lldb-commits] [lldb] 478c9cc - [lldb/Plugins] Rename lldbPluginDisassemblerLLVM (NFC)

Author: Jonas Devlieghere Date: 2020-02-17T19:14:01-08:00 New Revision: 478c9cc4f5e06072d533c6b72aaa173654bee02d URL: https://github.com/llvm/llvm-project/commit/478c9cc4f5e06072d533c6b72aaa173654bee02d DIFF:

[Lldb-commits] [lldb] ac1ea0d - [lldb/Plugins] Remove PLUGIN from libraries that aren't really plugins.

Author: Jonas Devlieghere Date: 2020-02-17T19:40:00-08:00 New Revision: ac1ea0d3da1ef620a392d2e22a38c03bd844383b URL: https://github.com/llvm/llvm-project/commit/ac1ea0d3da1ef620a392d2e22a38c03bd844383b DIFF:

[Lldb-commits] [lldb] 50c9cd9 - Revert "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"

Author: Jonas Devlieghere Date: 2020-02-17T19:04:50-08:00 New Revision: 50c9cd9526a7835ad5a702471a997c30d4fc6bcc URL: https://github.com/llvm/llvm-project/commit/50c9cd9526a7835ad5a702471a997c30d4fc6bcc DIFF:

[Lldb-commits] [lldb] fcae621 - [lldb/Plugin] Unconditionally build Darwin-Kernel

Author: Jonas Devlieghere Date: 2020-02-17T18:14:24-08:00 New Revision: fcae62167e80d365e02f02175eb20de469d82755 URL: https://github.com/llvm/llvm-project/commit/fcae62167e80d365e02f02175eb20de469d82755 DIFF:

[Lldb-commits] [lldb] c8001d5 - [lldb/Plugin] Fix some issues on Windows

Author: Jonas Devlieghere Date: 2020-02-17T17:22:18-08:00 New Revision: c8001d56df620e5c961c7d459aecf1b90e7f937c URL: https://github.com/llvm/llvm-project/commit/c8001d56df620e5c961c7d459aecf1b90e7f937c DIFF:

[Lldb-commits] [PATCH] D74660: WIP: [lldb/FileSystem] Add & use CreateReadonlyDataBuffer where possible

vsk planned changes to this revision. vsk added a comment. @labath thank you for your comments. I'm not yet sure what explains the average size of the WritableMemoryBuffer's allocated on our users' machines (~ 187,918 bytes, comfortably larger than the 16K threshold in `shouldUseMmap`). I'll

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. > I think it depends on whether the `DynamicLoaderStatic` should be a fallback. > If it doesn't make sense then yes, I think we should reject that triple there. It should not be a fallback. Ok! I'll create a new patch with this change. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

JDevlieghere added a comment. In D72751#1879806 , @paolosev wrote: > @JDevlieghere added inline comments: > > > lldb/source/API/SystemInitializerFull.cpp 244 > > What's the rationale here? Plugins shouldn't rely on the order in which > > they are

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

paolosev added a comment. @JDevlieghere added inline comments: > lldb/source/API/SystemInitializerFull.cpp 244 > What's the rationale here? Plugins shouldn't rely on the order in which they > are initialized. This breaks when the initializers are auto generated. Can we > remove this

[Lldb-commits] [PATCH] D74743: [lldb] Make header guards consistent across LLDB

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor. Herald added subscribers: usaxena95, jsji, jfb, arphaman, atanasyan, MaskRay, kbarton, aheejin, sbc100, ki.stfu, nemanjai, sdardis, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. LLDB

[Lldb-commits] [lldb] 9b12dc9 - Re-land "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"

Author: Jonas Devlieghere Date: 2020-02-17T14:43:05-08:00 New Revision: 9b12dc98fd0821f8d1f7f6304a314b6417d6ae3d URL: https://github.com/llvm/llvm-project/commit/9b12dc98fd0821f8d1f7f6304a314b6417d6ae3d DIFF:

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

JDevlieghere added inline comments. Comment at: lldb/source/API/SystemInitializerFull.cpp:244 LLDB_PLUGIN_INITIALIZE(DynamicLoaderPOSIXDYLD); + LLDB_PLUGIN_INITIALIZE(DynamicLoaderWasmDYLD); // Before DynamicLoaderStatic. LLDB_PLUGIN_INITIALIZE(DynamicLoaderStatic);

[Lldb-commits] [lldb] 46c4f63 - [lldb/Plugin] Update ProcessWindows plugin for revert

Author: Jonas Devlieghere Date: 2020-02-17T13:53:07-08:00 New Revision: 46c4f63ec491948876ca3edb5343418a6719e0b2 URL: https://github.com/llvm/llvm-project/commit/46c4f63ec491948876ca3edb5343418a6719e0b2 DIFF:

[Lldb-commits] [lldb] 058cb1b - Revert "[lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin"

Author: Jonas Devlieghere Date: 2020-02-17T12:34:21-08:00 New Revision: 058cb1b47fd7fa18e75834d069ead286f6ca55a8 URL: https://github.com/llvm/llvm-project/commit/058cb1b47fd7fa18e75834d069ead286f6ca55a8 DIFF:

[Lldb-commits] [lldb] deaa691 - [lldb/Plugin] Remove PLUGIN from Process POSIX & Linux

Author: Jonas Devlieghere Date: 2020-02-17T11:20:51-08:00 New Revision: deaa6916d3424ff9c9dfd81379dc9f4906d915f4 URL: https://github.com/llvm/llvm-project/commit/deaa6916d3424ff9c9dfd81379dc9f4906d915f4 DIFF:

[Lldb-commits] [lldb] 3431dc3 - [lldb/Plugin] Fix plugin definition for ProcessWindows

Author: Jonas Devlieghere Date: 2020-02-17T10:24:18-08:00 New Revision: 3431dc32a4162c0c3e0e0cd3e9e550c5f3c57047 URL: https://github.com/llvm/llvm-project/commit/3431dc32a4162c0c3e0e0cd3e9e550c5f3c57047 DIFF:

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb edited the summary of this revision. hhb added a reviewer: labath. This change allows a hard coded relative PYTHONHOME setting. So that python can easily be packaged together with lldb.

[Lldb-commits] [lldb] 7d6da32 - [lldb/CMake] Auto-generate the Initialize and Terminate calls for plugin

Author: Jonas Devlieghere Date: 2020-02-17T09:07:00-08:00 New Revision: 7d6da329dee1eda1761430d9097d1323f32c4c0c URL: https://github.com/llvm/llvm-project/commit/7d6da329dee1eda1761430d9097d1323f32c4c0c DIFF:

[Lldb-commits] [lldb] 8f95a82 - [lldb] Fix Windows bot.

Author: Jonas Devlieghere Date: 2020-02-17T09:06:59-08:00 New Revision: 8f95a82bc04091eda40f1cd1ca6c44d14c53dd4c URL: https://github.com/llvm/llvm-project/commit/8f95a82bc04091eda40f1cd1ca6c44d14c53dd4c DIFF:

[Lldb-commits] [PATCH] D74723: [lldb/DWARF] Support the debug_str_offsets section in dwp files

labath created this revision. labath added reviewers: JDevlieghere, aprantl, clayborg. Herald added a project: LLDB. In dwp files a constant (from the debug_cu_index section) needs to be added to each reference into the debug_str_offsets section. I've tried to implement this to roughly match the

[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

jankratochvil updated this revision to Diff 244976. jankratochvil added a comment. Sorry for that `DenseMap::insert`, I see it is the same as `std::map`, I should study `DenseMap` more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74690/new/

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

This revision was automatically updated to reflect the committed changes. Closed by commit rG217808887918: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 2178088 - Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

Author: Jan Kratochvil Date: 2020-02-17T16:35:42+01:00 New Revision: 21780888791837b575d227a9a69c1afee9e4c29d URL: https://github.com/llvm/llvm-project/commit/21780888791837b575d227a9a69c1afee9e4c29d DIFF:

[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

labath added a comment. Per discussion on the other patch, I think this is fine too, just can we get rid of the DIERef default constructor? I think all you'd need is to use the insert DenseMap function instead of operator[]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D74637#1878748 , @jankratochvil wrote: > In D74637#1878720 , @labath wrote: > > > Suppose these patches

[Lldb-commits] [PATCH] D73783: [lldb/DWARF] Re-enable basic dwp support

This revision was automatically updated to reflect the committed changes. Closed by commit rG67f63f3f7c27: [lldb/DWARF] Re-enable basic dwp support (authored by labath). Changed prior to commit: https://reviews.llvm.org/D73783?vs=241712=244948#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 67f63f3 - [lldb/DWARF] Re-enable basic dwp support

Author: Pavel Labath Date: 2020-02-17T14:10:36+01:00 New Revision: 67f63f3f7c27a8438236538fdda75e32c819cc54 URL: https://github.com/llvm/llvm-project/commit/67f63f3f7c27a8438236538fdda75e32c819cc54 DIFF: https://github.com/llvm/llvm-project/commit/67f63f3f7c27a8438236538fdda75e32c819cc54.diff

[Lldb-commits] [lldb] b2d64b6 - [lldb] Fix build error from 07355c1c08b

Author: Pavel Labath Date: 2020-02-17T14:12:29+01:00 New Revision: b2d64b698f8771290e42e558a1e6cc645375b90c URL: https://github.com/llvm/llvm-project/commit/b2d64b698f8771290e42e558a1e6cc645375b90c DIFF: https://github.com/llvm/llvm-project/commit/b2d64b698f8771290e42e558a1e6cc645375b90c.diff

[Lldb-commits] [PATCH] D74244: [lldb] Delete register info definitions in the x86_64 ABI classes

This revision was automatically updated to reflect the committed changes. Closed by commit rG07355c1c08be: [lldb] Delete register info definitions in the x86_64 ABI classes (authored by labath). Changed prior to commit: https://reviews.llvm.org/D74244?vs=244624=244942#toc Repository: rG

[Lldb-commits] [lldb] 07355c1 - [lldb] Delete register info definitions in the x86_64 ABI classes

Author: Pavel Labath Date: 2020-02-17T14:01:36+01:00 New Revision: 07355c1c08be54e6fda494168724e76e7e7da8cd URL: https://github.com/llvm/llvm-project/commit/07355c1c08be54e6fda494168724e76e7e7da8cd DIFF: https://github.com/llvm/llvm-project/commit/07355c1c08be54e6fda494168724e76e7e7da8cd.diff

[Lldb-commits] [lldb] 0e1da1e - [LLDB] Fix GCC warnings about extra semicolons. NFC.

Author: Martin Storsjö Date: 2020-02-17T14:16:46+02:00 New Revision: 0e1da1ef4af24ece9db4b0467b6c1932088c951e URL: https://github.com/llvm/llvm-project/commit/0e1da1ef4af24ece9db4b0467b6c1932088c951e DIFF:

[Lldb-commits] [lldb] d41d528 - [lldb] Add @skipIfXmlSupportMissing to TestWasm.py

Author: Pavel Labath Date: 2020-02-17T13:12:52+01:00 New Revision: d41d5286485beacc06190af17b9e23767e22e7ab URL: https://github.com/llvm/llvm-project/commit/d41d5286485beacc06190af17b9e23767e22e7ab DIFF: https://github.com/llvm/llvm-project/commit/d41d5286485beacc06190af17b9e23767e22e7ab.diff

[Lldb-commits] [PATCH] D72158: [DebugInfo] Make most debug line prologue errors non-fatal to parsing

labath added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:323-325 +// Treat this error as unrecoverable - we cannot be sure what any of +// the data represents including the length field, so cannot skip it or make +// any reasonable

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

labath added a comment. In D72751#1877432 , @paolosev wrote: > In D72751#1869268 , @labath wrote: > > > yeah, go for it. > > > Hi @labath, can I ask you the favor to land this patch for me? I have > rebased it

[Lldb-commits] [PATCH] D72751: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1121908aace: [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging (authored by paolosev, committed by labath). Changed prior to commit:

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

jankratochvil added a comment. In D74637#1878720 , @labath wrote: > the MainCU is stored in the DIERef, which you now say you want to change. Just some wording: If MainCU was in `DIERef` then MainCU needs to be also in `DWARFDIE` which means `DWARFDIE`

[Lldb-commits] [lldb] c112190 - [LLDB] Add DynamicLoaderWasmDYLD plugin for WebAssembly debugging

Author: Paolo Severini Date: 2020-02-17T12:42:23+01:00 New Revision: c1121908aace019b3e31e24def58a21a978531cd URL: https://github.com/llvm/llvm-project/commit/c1121908aace019b3e31e24def58a21a978531cd DIFF:

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

labath added a comment. Committed as aedc196101e33bd58f7443c5b93398418ce55edf . I've updated the commit message to include a better description of what is being changed. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaedc196101e3: [lldb/lldb-server] Add target.xml support for qXfer request. (authored by PatriosTheGreat, committed by labath). Changed prior to commit:

[Lldb-commits] [lldb] aedc196 - [lldb/lldb-server] Add target.xml support for qXfer request.

Author: Levon Ter-Grigoryan Date: 2020-02-17T12:05:28+01:00 New Revision: aedc196101e33bd58f7443c5b93398418ce55edf URL: https://github.com/llvm/llvm-project/commit/aedc196101e33bd58f7443c5b93398418ce55edf DIFF:

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

labath added a comment. In D74637#1878704 , @jankratochvil wrote: > > I did it because it was > > b) more memory-efficient. > > Why? Both `DIERef` and `user_id_t` sizeof is 8. Ah, sorry, I misremembered that (and confused DIERef with DWARFDIE). I

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

jankratochvil added a comment. In D74637#1878655 , @labath wrote: > In fact, this field used to hold a DIERef until I changed that in D63322 > . I did not expect that. OK, this D74637 +

[Lldb-commits] [PATCH] D74690: Separate DIERef vs. user_id_t: GetForwardDeclClangTypeToDie()

labath added a comment. The thing I said on the other patch about DIERef vs user_id_t still applies. Let's continue the discussion there... Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:37 + DIERef() {} + I'd very much like to avoid a

[Lldb-commits] [PATCH] D74637: Separate DIERef vs. user_id_t: m_function_scope_qualified_name_map

labath added a subscriber: JDevlieghere. labath added a comment. + @JDevlieghere for a reason why it would be nice to have cross platform "debug map" test(s). > I have also noticed DIERef and user_id_t in fact contain the same information > which can be seen in SymbolFileDWARF::GetUID. I am

[Lldb-commits] [PATCH] D74670: Simplify user_id_t -> size_t

This revision was automatically updated to reflect the committed changes. Closed by commit rG516ba158b689: [lldb] [nfc] Simplify user_id_t - size_t (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74670/new/

[Lldb-commits] [lldb] 516ba15 - [lldb] [nfc] Simplify user_id_t -> size_t

Author: Jan Kratochvil Date: 2020-02-17T10:24:19+01:00 New Revision: 516ba158b6890bbcca71527ae0719de151b9de5f URL: https://github.com/llvm/llvm-project/commit/516ba158b6890bbcca71527ae0719de151b9de5f DIFF:

[Lldb-commits] [PATCH] D74657: [lldb/Target] Add process crash-info command

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. All of this code you're adding to Process.cpp is extremely specific to one platform's notion of "crash info". This should be factored out so that macos-specific details live inside

[Lldb-commits] [PATCH] D74660: WIP: [lldb/FileSystem] Add & use CreateReadonlyDataBuffer where possible

labath added a reviewer: labath. labath added a comment. Before you get too carried away with this, I'd like us to clarify something. Your comment seems to imply that `FileSystem::CreateDataBuffer` does not use mmap. That doesn't sound right, and it's not what I see happening on linux now (and

[Lldb-commits] [lldb] cfb29e4 - [lldb] Fix some tests failing with gmodules after change to stdlib.h

Author: Raphael Isemann Date: 2020-02-17T09:39:09+01:00 New Revision: cfb29e4a54b051c888cbff8ed100c7dff5e33d58 URL: https://github.com/llvm/llvm-project/commit/cfb29e4a54b051c888cbff8ed100c7dff5e33d58 DIFF:

[Lldb-commits] [PATCH] D74607: [lldb][NFC] Make all CompilerDeclContext parameters references instead of pointers

teemperor updated this revision to Diff 244921. teemperor added a comment. - Readded some `parent_decl_context.IsValid()` checks to SymbolFilePDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74607/new/ https://reviews.llvm.org/D74607 Files: lldb/include/lldb/Core/Module.h