[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

davide created this revision. davide added reviewers: jingham, labath. Herald added subscribers: arphaman, aprantl. davide added a comment. davide added a reviewer: friss. See also https://bugs.llvm.org/show_bug.cgi?id=45471 SymbolFileDWARF::ParseVariableDIE consider all constant variables as

[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

davide added a comment. See also https://bugs.llvm.org/show_bug.cgi?id=45471 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77698/new/ https://reviews.llvm.org/D77698 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] f30ebf4 - [ManualDWARFIndex] Remove dead code, in preparation for moving this function.

Author: Davide Italiano Date: 2020-04-07T16:28:13-07:00 New Revision: f30ebf437851d3c68fd0eee82afbc0cef7373c00 URL: https://github.com/llvm/llvm-project/commit/f30ebf437851d3c68fd0eee82afbc0cef7373c00 DIFF:

[Lldb-commits] [PATCH] D76968: [lldb-vscode] Correctly return source mapped breakpoints for setBreakpoints request

wallace added a comment. Ping ping. This will fix some existing issues reported by users :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76968/new/ https://reviews.llvm.org/D76968 ___ lldb-commits

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

jingham added a comment. This looks good to me, except that instead of leaving all the other variants of AddCommand, they should funnel through the one that takes the most arguments. It was poor form to leave two around and more so now that there's three. I'm beginning to think we need an

[Lldb-commits] [PATCH] D73206: Pass `CompileUnit *` along `DWARFDIE` for DWZ

jankratochvil added a comment. In D73206#1954668 , @labath wrote: > Having a iterator/callback based api would allow us to minimize the impact of > that, as it would only need to happen for the entries that are really used. > And /I think/ we could make

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 2 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2951 +type_sp = resolved_type->shared_from_this(); +break; } aprantl wrote: > I think

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255815. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255813. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/ https://reviews.llvm.org/D77326 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

[Lldb-commits] [PATCH] D77662: [WIP][lldb/test] Make TestLoadUnload compatible with windows

amccarth added a comment. I like where this is going. Comment at: lldb/packages/Python/lldbsuite/test/make/dylib.h:50 + FormatMessageA(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, + NULL, err, MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT), (char *), 0,

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil updated this revision to Diff 255801. jankratochvil marked 4 inline comments as done. jankratochvil added a comment. Implemented all the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77326/new/

[Lldb-commits] [lldb] 873b79b - Don't access reference to a vector after pop_back

Author: Benjamin Kramer Date: 2020-04-07T23:10:58+02:00 New Revision: 873b79b8675d0c8eca6055ae8a874fe52b033c28 URL: https://github.com/llvm/llvm-project/commit/873b79b8675d0c8eca6055ae8a874fe52b033c28 DIFF:

[Lldb-commits] [PATCH] D77326: 1/2: [nfc] [lldb] Unindent code

jankratochvil marked 10 inline comments as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2016 +for (size_t i = 0; i < num_matches; ++i) { + const DIERef _ref = method_die_offsets[i];

[Lldb-commits] [PATCH] D77661: [lldb/Python] Add lldbconfig Python module to make the lldb module configurable.

JDevlieghere updated this revision to Diff 255792. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Address code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77661/new/ https://reviews.llvm.org/D77661 Files: lldb/bindings/python.swig

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8de17bca658: Fix illegal early call to PyBuffer_Release in swig typemaps (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

JDevlieghere updated this revision to Diff 255785. JDevlieghere added a comment. Address code review feedback Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77588/new/ https://reviews.llvm.org/D77588 Files: lldb/bindings/headers.swig

[Lldb-commits] [lldb] c8de17b - Fix illegal early call to PyBuffer_Release in swig typemaps

Author: Lawrence D'Anna Date: 2020-04-07T13:31:29-07:00 New Revision: c8de17bca658e62bbf8c33eae839e457332e885e URL: https://github.com/llvm/llvm-project/commit/c8de17bca658e62bbf8c33eae839e457332e885e DIFF:

[Lldb-commits] [lldb] 30a292c - [ScriptInterpreterPython] Remove buggy code to save/restore stdin.

Author: Davide Italiano Date: 2020-04-07T12:43:25-07:00 New Revision: 30a292c25df327eb35b341b919c4e9b5e80323be URL: https://github.com/llvm/llvm-project/commit/30a292c25df327eb35b341b919c4e9b5e80323be DIFF:

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna updated this revision to Diff 255772. lawrence_danna added a comment. fix initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 Files: lldb/bindings/python/python-typemaps.swig

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77480/new/ https://reviews.llvm.org/D77480 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

labath added a reviewer: JDevlieghere. labath added a subscriber: JDevlieghere. labath added a comment. Adding @JDevlieghere as he is in the same time zone and knows about all this stuff. This is on the right track, but changing lldb-dotest is not enough -- you'll also need to change

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil marked 6 inline comments as done. jankratochvil added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:102 + // Helper iterator for the 'equal_range' method. + class CString_iterator { aprantl wrote: > /// I am sorry but

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255766. jankratochvil marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:861 +def is_reproducer(): +if ('LLDB_REPRODUCER_CAPTURE_PATH' in os.environ or 'LLDB_REPRODUCER_REPLAY_PATH' in os.environ): +return "reproducers unsupported"

[Lldb-commits] [PATCH] D77661: [lldb/Python] Add lldbconfig Python module to make the lldb module configurable.

labath added a comment. Thanks. This looks fine, just a question about the placement of the lldbconfig module. Comment at: lldb/CMakeLists.txt:130 + "${LLDB_SOURCE_DIR}/bindings/python/lldbconfig.py" + "${python_build_path}/lldbconfig/__init__.py") +

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

wallace abandoned this revision. wallace added a comment. Will revisit it whenever I need it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582 ___ lldb-commits

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil updated this revision to Diff 255761. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77327/new/ https://reviews.llvm.org/D77327 Files: lldb/include/lldb/Core/UniqueCStringMap.h

[Lldb-commits] [PATCH] D77662: [WIP][lldb/test] Make TestLoadUnload compatible with windows

jingham added inline comments. Comment at: lldb/test/API/functionalities/load_unload/TestLoadUnload.py:419 self.copy_shlibs_to_remote() +env_cmd_string = "settings set target.env-vars " + self.dylibPath + "=" + self.getBuildArtifact(".") +

[Lldb-commits] [PATCH] D77662: [WIP][lldb/test] Make TestLoadUnload compatible with windows

labath updated this revision to Diff 255727. labath added a comment. include some changes I forgot (they're the ones that need cleaning up the most) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77662/new/ https://reviews.llvm.org/D77662 Files:

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

JDevlieghere updated this revision to Diff 255726. JDevlieghere added a comment. Update `lldbtest.py` too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77588/new/ https://reviews.llvm.org/D77588 Files: lldb/bindings/headers.swig lldb/bindings/interface/SBReproducer.i

[Lldb-commits] [PATCH] D77662: [WIP][lldb/test] Make TestLoadUnload compatible with windows

labath created this revision. labath added reviewers: amccarth, jingham, JDevlieghere, compnerd. Herald added a project: LLDB. labath updated this revision to Diff 255727. labath added a comment. include some changes I forgot (they're the ones that need cleaning up the most) This is WIP because

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

JDevlieghere updated this revision to Diff 255718. JDevlieghere added a comment. Use `lldbconfig` to initialize reproducers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77588/new/ https://reviews.llvm.org/D77588 Files: lldb/bindings/headers.swig

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

jingham added a comment. In D77582#1967031 , @labath wrote: > In D77582#1966962 , @teemperor wrote: > > > I think the part of the patch that adds documentation to the existing > > method should go in (In general

[Lldb-commits] [PATCH] D77661: [lldb/Python] Add lldbconfig Python module to make the lldb module configurable.

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:957 +import lldbconfig import lldb This is a NO-OP for now, but just shows that we can load the lldbconfig

[Lldb-commits] [PATCH] D77661: [lldb/Python] Add lldbconfig Python module to make the lldb module configurable.

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: mgorny. JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:957 +import lldbconfig

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

jingham added a comment. ValueObjects know their execution context, and so they can get to their frame, if they have one. The language of the frame seems like the best thing to clue off here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

jankratochvil added a comment. In D77327#1967060 , @labath wrote: > I can't say I have tried this, but ummm.. why is there a need for a separate > iterator class for this equal_range stuff? Couldn't this be implemented via > an iterator_pair of the

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

labath added a comment. I can't say I have tried this, but ummm.. why is there a need for a separate iterator class for this equal_range stuff? Couldn't this be implemented via an iterator_pair of the iterators of the underlying container (found via lower/upper_bound) ? Repository: rG LLVM

[Lldb-commits] [PATCH] D77327: [nfc] [lldb] 2/2: Introduce DWARF callbacks

labath added inline comments. Comment at: lldb/include/lldb/Core/UniqueCStringMap.h:130-163 + bool GetValues(ConstString unique_cstr, + std::function callback) const { +for (const Entry : llvm::make_range(std::equal_range( + m_map.begin(),

[Lldb-commits] [PATCH] D75750: [lldb] integrate debuginfod

fche2 added a comment. >> So it might be good to have the SymbolVendors use one or more SymbolServer >> plug-ins. > > I don't believe we have anything that would require all modules in a given > target (or whatever) to use the same symbol vendor type. [...] Just for clarity, is someone

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

labath added a comment. In D77582#1966962 , @teemperor wrote: > I think the part of the patch that adds documentation to the existing method > should go in (In general all patches that just add documentation have my > blanket approval, so please just

[Lldb-commits] [PATCH] D77588: [lldb/Reproducers] Make it possible to capture reproducers for the Python test suite.

labath added inline comments. Comment at: lldb/bindings/python.swig:132-136 +if 'LLDB_REPRODUCER_CAPTURE_PATH' in os.environ: + SBReproducer.Capture(os.environ['LLDB_REPRODUCER_CAPTURE_PATH']) + SBReproducer.SetAutoGenerate(True) +elif 'LLDB_REPRODUCER_REPLAY_PATH' in

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

teemperor added a comment. I think the part of the patch that adds documentation to the existing method should go in (In general all patches that just add documentation have my blanket approval, so please just commit those). For the additional function: If you just change that CommandExists

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

shafik added a comment. I agree, if we don't have an immediate use then I don't think we should add it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77582/new/ https://reviews.llvm.org/D77582

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

labath added a comment. BTW, in gtest tests, the prevailing convention is to name test .cpp files according to the name of the .cpp file under test. So, in this case, that would be something like `unittests/API/SBCommandInterpreterTest.cpp`. I wouldn't want to take that convention to the

[Lldb-commits] [PATCH] D77582: [CommandInterpreter] Implement UserCommandExists

labath added a reviewer: jingham. labath added a comment. I don't have a hard objection to this, but if we're don't have a use for it, I don't see a need for adding it right now. Particularly as it sounds weird to me that "user commands" are not a subset of "commands". I know that is how the

[Lldb-commits] [lldb] 95054ae - [lldb][NFC] Fix typo in 'watchpoint delete' error message

Author: Raphael Isemann Date: 2020-04-07T16:11:32+02:00 New Revision: 95054aeb07061dbfd6575c10673b9563430de64a URL: https://github.com/llvm/llvm-project/commit/95054aeb07061dbfd6575c10673b9563430de64a DIFF:

[Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

labath added a comment. Thank you for trying out gtest. I'm very happy that this is working out for you. The test looks fine -- just please move it to `unittests/API` (new folder) -- that's where it logically belongs as it's testing the API code (and it also avoids dangerous ODR violations

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

jarin added a comment. Looking at the code for flushing L1 cache , it appears broken. I am guessing that is the reason for the failure of my patch on the bots. Here is the

[Lldb-commits] [PATCH] D74136: [LLDB] WIP: Follow DW_AT_decl_file when setting breakpoint

kwk updated this revision to Diff 255648. kwk added a comment. - Simplified test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74136/new/ https://reviews.llvm.org/D74136 Files: lldb/source/Breakpoint/BreakpointResolverName.cpp

[Lldb-commits] [lldb] 2a436a0 - Mark TestFixIts.py xfail for LLDB AArch64/Linux

Author: Muhammad Omair Javaid Date: 2020-04-07T17:11:22+05:00 New Revision: 2a436a07ae9749ed4d3f42c0d1e660eb4f7ca6e8 URL: https://github.com/llvm/llvm-project/commit/2a436a07ae9749ed4d3f42c0d1e660eb4f7ca6e8 DIFF:

[Lldb-commits] [lldb] e609fe6 - Revert "[lldb-server] jThreadsInfo returns stack memory"

Author: Muhammad Omair Javaid Date: 2020-04-07T17:11:22+05:00 New Revision: e609fe68b2c59b145c0a5c66bedbee2bff545200 URL: https://github.com/llvm/llvm-project/commit/e609fe68b2c59b145c0a5c66bedbee2bff545200 DIFF:

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This patch breaks on TestMemoryCache.py lldb AArch64/Linux. we ll have to revert it untill fixed FAIL: test_memory_cache_dwarf (TestMemoryCache.MemoryCacheTestCase) Test the

[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

omjavaid added a comment. In D77045#1963896 , @labath wrote: > In D77045#1956879 , @omjavaid wrote: > > > Adding a testcase would be tricky as these register overlap in memory and > > we store them with

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid added a comment. In D77047#1956774 , @omjavaid wrote: > In D77047#1954696 , @labath wrote: > > > > There is no physical hardware currently available to test SVE and we make > > > use of QEMU for the

[Lldb-commits] [PATCH] D77480: Fix illegal early call to PyBuffer_Release in swig typemaps

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I'm not exactly happy about the lack of a test case, but I guess we can let this slide on the account of it requiring implementing a non-standard PyBuffer in c++ and then loading that from a

[Lldb-commits] [PATCH] D77214: [lldb] Add option to retry Fix-Its multiple times to failed expressions

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This patch fails on lldb-aarch64-linux with following backtrace, apparently failing experession eval. I am marking it xfail for now. Traceback (most recent call last): File

[Lldb-commits] [PATCH] D77568: Return correct entry in RangeDataVector::FindEntryThatContains

labath added a comment. This is definitely a bug, but I fear that fixing this via a linear search will cause a big performance regression. Fortunately, since D74759 we now have a way to implement this more efficiently. Could you reimplement this function to