Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

They do on staging. http://lab.llvm.org:8014/#/builders/sanitizer-windows http://lab.llvm.org:8014/#/builders/clang-x64-windows-msvc Galina, when do you plan to push this to the primary server? If it's a few days, I'd rather keep bots on staging to have colors. On Tue, 13 Oct 2020 at 11:11,

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere updated this revision to Diff 298034. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89334/new/ https://reviews.llvm.org/D89334 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h lldb/include/lldb/Interpreter/ScriptInterpreter.h

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere updated this revision to Diff 298033. JDevlieghere added a comment. Remove bogus files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89334/new/ https://reviews.llvm.org/D89334 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere added a comment. In D89334#2328372 , @kastiglione wrote: > Would you mind adding a couple tests for imports via a path to a python file, > ex `command script import command.py`, maybe even a test that checks nested > directories, ex:

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:644 + // FIXME: Stop using this to control adding to the history and then replace + // this with m_command_source_dirs.size(). uint32_t m_command_source_depth;

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere updated this revision to Diff 298032. JDevlieghere added a comment. Fix edge cases and add more tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89334/new/ https://reviews.llvm.org/D89334 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

JosephTremoulet added a comment. In D89156#2328772 , @jingham wrote: > IIUC, the problem with ReplaceModule will get fixed in a dependent patch, > right? So the last bit of this patch will get cleaned up by that change. If > that's right, then this

[Lldb-commits] [PATCH] D89358: Add an API to get an SBBreakpoint's owning SBTarget

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. jingham requested review of this revision. Scripted breakpoint resolvers receive the breakpoint they are being set on, and the callback takes an

[Lldb-commits] [PATCH] D89351: Move initialization of Variable::m_loc_is_const_data into constructor (NFC)

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:823 scope, comp_unit.get(), ranges, , location, is_external, false, - false); - var_sp->SetLocationIsConstantValueData(false); + false, false);

[Lldb-commits] [PATCH] D89351: Move initialization of Variable::m_loc_is_const_data into constructor (NFC)

shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:823 scope, comp_unit.get(), ranges, , location, is_external, false, - false); - var_sp->SetLocationIsConstantValueData(false); + false, false);

[Lldb-commits] [lldb] 9b1c06c - Move initialization of Variable::m_loc_is_const_data into constructor (NFC)

Author: Adrian Prantl Date: 2020-10-13T17:01:28-07:00 New Revision: 9b1c06c0e84a9cc763e12b289becb5fc3c9d01ea URL: https://github.com/llvm/llvm-project/commit/9b1c06c0e84a9cc763e12b289becb5fc3c9d01ea DIFF: https://github.com/llvm/llvm-project/commit/9b1c06c0e84a9cc763e12b289becb5fc3c9d01ea.diff

[Lldb-commits] [PATCH] D89352: [lldb] Unconditionally strip the `.py(c)` extension as we always import Python modules

JDevlieghere created this revision. JDevlieghere added reviewers: kastiglione, labath. JDevlieghere requested review of this revision. Currently we only strip the Python extension when the file exists on disk because we assumed that if it didn't exist it was a module. However, with the change

[Lldb-commits] [PATCH] D89351: Move initialization of Variable::m_loc_is_const_data into constructor (NFC)

aprantl created this revision. aprantl added a reviewer: JDevlieghere. aprantl requested review of this revision. This makes it symmetric with all other flags and makes it easier to not forget to initialize it. https://reviews.llvm.org/D89351 Files: lldb/include/lldb/Symbol/Variable.h

[Lldb-commits] [lldb] 7d67c06 - Remove unused build configurations from debugserver xcode project

Author: Jason Molenda Date: 2020-10-13T16:39:30-07:00 New Revision: 7d67c06391bba00a043c23eb6bb478484831de98 URL: https://github.com/llvm/llvm-project/commit/7d67c06391bba00a043c23eb6bb478484831de98 DIFF: https://github.com/llvm/llvm-project/commit/7d67c06391bba00a043c23eb6bb478484831de98.diff

[Lldb-commits] [lldb] e763709 - Add a new launch flag option for watchos, WatchComplicationLaunch.

Author: Jason Molenda Date: 2020-10-13T16:28:16-07:00 New Revision: e763709d14e560915e04731c2fd6f1595d7ff8ba URL: https://github.com/llvm/llvm-project/commit/e763709d14e560915e04731c2fd6f1595d7ff8ba DIFF: https://github.com/llvm/llvm-project/commit/e763709d14e560915e04731c2fd6f1595d7ff8ba.diff

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

jingham added a comment. IIUC, the problem with ReplaceModule will get fixed in a dependent patch, right? So the last bit of this patch will get cleaned up by that change. If that's right, then this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

jasonmolenda added a comment. Just to confirm one quick detail (I couldn't remember for sure and had to check) - if we strtoul will stop parsing when it finds a character outside the range of the specified base. e.g. calling strtoul("0x100", nullptr, 10) will yield 0; strtoul("10f", nullptr,

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

jingham added a comment. The return from a SIGSEGV or SIGILL has less information than the equivalent exception, so reporting the exceptions should be the default, but having a switch for people who need the exception to propagate is okay. I wonder if the implementation would be less intrusive

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

JosephTremoulet added inline comments. Comment at: lldb/source/Core/ModuleList.cpp:779-781 if (module_sp->FileHasChanged()) { if (old_modules) old_modules->push_back(module_sp); JosephTremoulet wrote: > > If I run lldb on a

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

JosephTremoulet marked an inline comment as done. JosephTremoulet added a comment. Comment at: lldb/source/Core/ModuleList.cpp:779-781 if (module_sp->FileHasChanged()) { if (old_modules) old_modules->push_back(module_sp); > If

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

JosephTremoulet updated this revision to Diff 297939. JosephTremoulet added a comment. - Comment new parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89157/new/ https://reviews.llvm.org/D89157 Files: lldb/include/lldb/Core/ModuleList.h

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

mgorny updated this revision to Diff 297932. mgorny marked an inline comment as done. mgorny edited the summary of this revision. mgorny added a comment. Updated the comment above assertion, and indicated fixed tests in the description. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449 + +assert(info.xsave_mask & XFEATURE_ENABLED_X87); +assert(info.xsave_mask &

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

kastiglione added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:644 + // FIXME: Stop using this to control adding to the history and then replace + // this with m_command_source_dirs.size(). uint32_t m_command_source_depth;

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

kastiglione added a comment. Would you mind adding a couple tests for imports via a path to a python file, ex `command script import command.py`, maybe even a test that checks nested directories, ex: `command script import path/to/command.py`? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D89248: [lldb] [test/Register] Add read/write tests for multithreaded process

emaste added a comment. Looks reasonable to me and currently fails (as expected) on FreeBSD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89248/new/ https://reviews.llvm.org/D89248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Mon, Oct 12, 2020 at 10:01 PM Galina Kistanova via lldb-commits wrote: > If somebody else could move their AnnotatedCommand bots to the staging area, > that would be much appreciated. I moved the libc bots to staging to now. Thanks, Siva Chandra

[Lldb-commits] [PATCH] D89157: [lldb] Report old modules from ModuleList::ReplaceEquivalent

jingham added a comment. The change makes sense. If I run lldb on a binary, hit a breakpoint, run to it, then change a file, rebuild the executable outside lldb and rerun, I only see one instance of the executable. Why does that path not need your fix? Comment at:

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere updated this revision to Diff 297921. JDevlieghere added a comment. Extend test case to show that this works with files sourcing other files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89334/new/ https://reviews.llvm.org/D89334 Files:

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

FWIW, I don't see any issues with my two bots that use buildbot annotated commands: http://lab.llvm.org:8011/#/builders/sanitizer-windows http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc The individual steps don't highlight as green or red, but that's OK for now. On Mon, Oct 12, 2020 at

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

krytarowski added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449 + +assert(info.xsave_mask & XFEATURE_ENABLED_X87); +assert(info.xsave_mask & XFEATURE_ENABLED_SSE); + emaste wrote:

[Lldb-commits] [PATCH] D89335: [lldb] Generic support for caching register set reads/writes [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. mgorny requested review of this revision. // This is work-in-progress, submitted to get proposed API reviewed. No actual caching is done yet. // I am planning to use this

[Lldb-commits] [PATCH] D89295: [lldb] Add $HOME to Python's sys.path

JDevlieghere abandoned this revision. JDevlieghere added a comment. Abandoning in favor of https://reviews.llvm.org/D89334 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89295/new/ https://reviews.llvm.org/D89295 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

JDevlieghere created this revision. JDevlieghere added reviewers: labath, kastiglione, teemperor. JDevlieghere requested review of this revision. Make it possible to use a relative path in `command script import` to the location of the file being sourced. This allows the user to put Python

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

emaste added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449 + +assert(info.xsave_mask & XFEATURE_ENABLED_X87); +assert(info.xsave_mask & XFEATURE_ENABLED_SSE); + mgorny wrote: >

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449 + +assert(info.xsave_mask & XFEATURE_ENABLED_X87); +assert(info.xsave_mask & XFEATURE_ENABLED_SSE); + mgorny wrote: >

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449 + +assert(info.xsave_mask & XFEATURE_ENABLED_X87); +assert(info.xsave_mask & XFEATURE_ENABLED_SSE); + emaste wrote: > I

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

emaste added a comment. Looks OK Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449 + +assert(info.xsave_mask & XFEATURE_ENABLED_X87); +assert(info.xsave_mask & XFEATURE_ENABLED_SSE); + I wonder if

[Lldb-commits] [PATCH] D89248: [lldb] [test/Register] Add read/write tests for multithreaded process

mgorny updated this revision to Diff 297893. mgorny added a comment. Fixed .cpp file name and removed unused mutex. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89248/new/ https://reviews.llvm.org/D89248 Files: lldb/test/Shell/Register/Inputs/x86-multithread-read.cpp

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

JDevlieghere added a comment. In D89295#2327905 , @labath wrote: > In D89295#2327767 , @teemperor wrote: > >> In D89295#2327751 , @kastiglione >> wrote: >> >>> For lldbinit

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

labath added a comment. In D89295#2327767 , @teemperor wrote: > In D89295#2327751 , @kastiglione > wrote: > >> For lldbinit files, and any file that gets `command source`'d, I think it >> would be useful if they

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

JDevlieghere added a comment. In D89295#2327809 , @kastiglione wrote: >> I don't think it's that unreasonable to do the same for `$HOME` to be able >> to use imports relative to the `.lldbinit` file in both cases. > > In theory I agree, but in practice I

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

labath updated this revision to Diff 297876. labath added a comment. - GetCurrentThread - const Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89124/new/ https://reviews.llvm.org/D89124 Files:

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

labath marked 12 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1362 + + NativeThreadLinux = *GetThreadByID(GetID()); + assert(thread.GetState() == eStateStopped); jankratochvil

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. > I don't think it's that unreasonable to do the same for `$HOME` to be able to > use imports relative to the `.lldbinit` file in both cases. In theory I agree, but in practice I think it's unnecessary because `~` can be used (and possibly should be explicit), and

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

JDevlieghere added a comment. PS: when I created this patch I used `$HOME` in the title, I didn't expect that to get expanded?! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89295/new/ https://reviews.llvm.org/D89295 ___ lldb-commits

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

JDevlieghere added a comment. I misunderstood what was being asked for. In LLDB there are two places we look for an `.lldbinit` file, in the home directory and in the current working directory. We already add `.` to the system path so I don't think it's that unreasonable to do the same for

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. > (and whether we should make this implicit a relative path vs for example some > kind of placeholder 'variable' or something like that). I'm not sure either, but if we do it could probably be as a `./` as prefix? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

teemperor added a comment. In D89295#2327751 , @kastiglione wrote: > For lldbinit files, and any file that gets `command source`'d, I think it > would be useful if they could perform `command script import > some/path/to/command.py`, where `some` is

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. For lldbinit files, and any file that gets `command source`'d, I think it would be useful if they could perform `command script import some/path/to/command.py`, where `some` is resolved relative to the dirname of the lldb file. For example, given an lldbinit file

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. In D89295#2327367 , @labath wrote: > That actually seems to work (if you add .py to the end). Yes that was my (poorly explained) point, I use this form regularly. Is it not better to require an explicit `~` instead of

[Lldb-commits] [PATCH] D88950: [lldb][cmake] Remove custom logic for finding VCS file to fix LLDB's VCSVersion.inc generation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6733b2544794: [lldb][cmake] Remove custom logic for finding VCS file to fix LLDBs VCSVersion. (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] 6733b25 - [lldb][cmake] Remove custom logic for finding VCS file to fix LLDB's VCSVersion.inc generation

Author: Raphael Isemann Date: 2020-10-13T17:14:43+02:00 New Revision: 6733b2544794f2703f19f07aa7c6806408e36160 URL: https://github.com/llvm/llvm-project/commit/6733b2544794f2703f19f07aa7c6806408e36160 DIFF:

[Lldb-commits] [PATCH] D88889: [lldb] Allow limiting the number of error diagnostics when parsing an expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG02114e15daad: [lldb] Allow limiting the number of error diagnostics when parsing an expression (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] 02114e1 - [lldb] Allow limiting the number of error diagnostics when parsing an expression

Author: Raphael Isemann Date: 2020-10-13T17:12:43+02:00 New Revision: 02114e15daad7f02e65289412d37334618386ce5 URL: https://github.com/llvm/llvm-project/commit/02114e15daad7f02e65289412d37334618386ce5 DIFF:

[Lldb-commits] [lldb] 24e0757 - [lldb] Remove all the RegisterInfo name constification code

Author: Raphael Isemann Date: 2020-10-13T17:10:29+02:00 New Revision: 24e07570cc928b75e894b81639cabe96c660ccef URL: https://github.com/llvm/llvm-project/commit/24e07570cc928b75e894b81639cabe96c660ccef DIFF:

[Lldb-commits] [PATCH] D88490: [lldb] Remove all the RegisterInfo name constification code

This revision was automatically updated to reflect the committed changes. Closed by commit rG24e07570cc92: [lldb] Remove all the RegisterInfo name constification code (authored by teemperor). Herald added subscribers: lldb-commits, jrtc27. Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] 4cd873c - [lldb][NFC] Remove property predicate matcher

Author: Raphael Isemann Date: 2020-10-13T17:09:27+02:00 New Revision: 4cd873c4bd7ff66d4af2bf5e57c27e6924bfc92a URL: https://github.com/llvm/llvm-project/commit/4cd873c4bd7ff66d4af2bf5e57c27e6924bfc92a DIFF:

[Lldb-commits] [PATCH] D88910: [lldb][NFC] Remove property predicate matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cd873c4bd7f: [lldb][NFC] Remove property predicate matcher (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D89224: [lldb] Add targets for running test suite against Watch/TV/iPhone simulators

This revision was automatically updated to reflect the committed changes. Closed by commit rGef733d9df486: [lldb] Add targets for running test suite against Watch/TV/iPhone simulators (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to

[Lldb-commits] [lldb] ef733d9 - [lldb] Add targets for running test suite against Watch/TV/iPhone simulators

Author: Raphael Isemann Date: 2020-10-13T17:07:46+02:00 New Revision: ef733d9df486884aa33de9f5a9f6bade4e70f187 URL: https://github.com/llvm/llvm-project/commit/ef733d9df486884aa33de9f5a9f6bade4e70f187 DIFF:

[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

labath added a comment. I'm still digesting this, but here's my first set of comments. From a high-level perspective. it's not clear to me how to test the exceptional states that can occur when decoding a trace. The decoding function is pretty complex, but the current tests only seem to cover

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added a comment. Sounds like a plan. I've raised https://bugs.llvm.org/show_bug.cgi?id=47820 to track this,.Tell me if I miss-stated anything there, otherwise I'll start the first part. debugserver is an apple-only implementation of the remote stub. However, I think that may

[Lldb-commits] [PATCH] D89315: [debugserver] Add option to propagate SIGSEGV to target process

aarzilli created this revision. aarzilli added reviewers: clayborg, jasonmolenda. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. aarzilli requested review of this revision. Herald added a subscriber: JDevlieghere. Adds a command line option that makes debugserver propagate

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

labath added a comment. Interesting. I think that implementing a project-specific script repository would be indeed best done in xcode, since that's the thing which knows what a "project" is. I'm not sure if this needs any special kind of support from lldb (it sounds like xcode could just

[Lldb-commits] [PATCH] D89236: [lldb] Fix bitfield "frame var" for pointers (pr47743)

cameron314 added a comment. This fixes https://bugs.llvm.org/show_bug.cgi?id=47743 for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89236/new/ https://reviews.llvm.org/D89236 ___ lldb-commits

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

labath added a comment. In D89227#2327066 , @DavidSpickett wrote: >> Given how often the '0x' prefix on base16 numbers is dropped in the remote >> serial protocol > > Now you mention it, I thought I knew how strtoull worked but I don't. (I > assumed it

[Lldb-commits] [PATCH] D89052: [lldb] Don't add no-sandbox entitlement when running tests on simulator

This revision was automatically updated to reflect the committed changes. Closed by commit rGdfc72439529c: [lldb] Dont add no-sandbox entitlement when running tests on simulator (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [lldb] dfc7243 - [lldb] Don't add no-sandbox entitlement when running tests on simulator

Author: Raphael Isemann Date: 2020-10-13T15:08:46+02:00 New Revision: dfc72439529c49e8bfeab9d604b1aa1cac7d89e8 URL: https://github.com/llvm/llvm-project/commit/dfc72439529c49e8bfeab9d604b1aa1cac7d89e8 DIFF:

[Lldb-commits] [PATCH] D89053: [lldb] Don't let dotest silently fall back to default SDK if the specified one can't be found

This revision was automatically updated to reflect the committed changes. Closed by commit rG480c440f9a3c: [lldb] Dont let dotest silently fall back to default SDK if the specified one… (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository:

[Lldb-commits] [lldb] 480c440 - [lldb] Don't let dotest silently fall back to default SDK if the specified one can't be found

Author: Raphael Isemann Date: 2020-10-13T15:07:45+02:00 New Revision: 480c440f9a3cf3434355f24217cfa430dc1cabda URL: https://github.com/llvm/llvm-project/commit/480c440f9a3cf3434355f24217cfa430dc1cabda DIFF:

[Lldb-commits] [lldb] f4f4d54 - [lldb] Fill Watch/AppleTV simulator gaps in PlatformDarwin

Author: Raphael Isemann Date: 2020-10-13T15:06:41+02:00 New Revision: f4f4d54ae0d8971e67fd64e10d700804105b720c URL: https://github.com/llvm/llvm-project/commit/f4f4d54ae0d8971e67fd64e10d700804105b720c DIFF:

[Lldb-commits] [PATCH] D89106: [lldb] Fill Watch/AppleTV simulator gaps in PlatformDarwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4f4d54ae0d8: [lldb] Fill Watch/AppleTV simulator gaps in PlatformDarwin (authored by teemperor). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

teemperor added a comment. In D89295#2327367 , @labath wrote: > What exactly is the use case for this? Xcode running a project-specific lldbinit file but users can't specify a `command script import relative/path/script.py` as the CWD for the

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

labath added a comment. What exactly is the use case for this? Having a place where the user can place lldb python scripts and have them be automatically accessible seems like a nice feature, but I am not convinced that $HOME is the right place for it. I definitely wouldn't want lldb scripts

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added a comment. And I'm saying lldb-server and not that and debug-server because if I'm honest, I don't really know what the latter is. I assume this applies to both though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89227/new/

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

DavidSpickett added a comment. > Given how often the '0x' prefix on base16 numbers is dropped in the remote > serial protocol Now you mention it, I thought I knew how strtoull worked but I don't. (I assumed it was some best effort that would roll back if somehow the digits didn't fit the

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Mon, 12 Oct 2020 at 22:01, Galina Kistanova wrote: > Thanks, Vitaly! > > Let's have them there for at least 24 hours, shall we? > We can do that. > > Could you move sanitizer-buildbot1, sanitizer-buildbot3, > sanitizer-buildbot7 as well, please? > Done. > AnnotatedCommand on the staging

[Lldb-commits] [PATCH] D89227: [lldb] Note difference in vFile:pread/pwrite format for lldb

jasonmolenda added a comment. Thanks for adding the clarifying text, I wrote the doc based on the existing lldb-server implementation of these packets while I was writing a separate implementation of the platform packets, so I hadn't seen the gdb docs. Given how often the '0x' prefix on base16

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. Could this have undesirable side effects? I wouldn't expect `command script import` to be searching my home dir. Second question: is there value in requiring the explicit use of `~`, for ex: `command script import ~/path`. CHANGES SINCE LAST ACTION