[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

aprantl added a comment. Let me know if this goes into the right direction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103575/new/ https://reviews.llvm.org/D103575 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

aprantl updated this revision to Diff 351332. aprantl added a comment. Address review feedback from @JDevlieghere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103575/new/ https://reviews.llvm.org/D103575 Files: lldb/include/lldb/Utility/Timer.h lldb/source/Utility/Timer.cpp

[Lldb-commits] [PATCH] D104091: [NFC] Fix leak in test

vitalybuka created this revision. vitalybuka requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Test leaks if we run tools/lldb/unittests/Host/HostTests without --gtest_filter Also if we call HostInfoLinux::Initialize twice some

[Lldb-commits] [PATCH] D103588: [trace] Create a top-level instruction class

wallace updated this revision to Diff 351329. wallace added a comment. Herald added a subscriber: mgorny. Following @vsk 's feedback, I made the following changes: - Create a ThreadTrace class, that contains the trace for a specific thread and offers the TraverseInstructions method and other

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. In D102993#2811337 , @teemperor wrote: > Sure I can take a look, but I don't see the immediate problem when looking at > the backtrace. > > I assume it takes some time to reduce the bug in Chrome? If you could get me > the

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

jingham added a comment. This looks pretty good to me. It's a little awkward in InitNameIndexes that we look up the various NameToSymbolIndex maps by eFunctionNameType, use the function name type again to sort the names & index pairs into the bucket we looked up before. I wonder if that

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord added a comment. Herald added a subscriber: JDevlieghere. Note that this is working towards solving the same problem as D103210 but it does so in a different way. Instead of repurposing the old diff, I made a new one so it is a little easier to

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord created this revision. bulbazord added a reviewer: teemperor. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We can extend/modify `GetMethodNameVariants` to suit our purposes here.

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor added inline comments. Comment at: lldb/unittests/Core/MangledTest.cpp:72 + + EXPECT_STREQ("", TheDemangled.GetCString()); +} asm wrote: > teemperor wrote: > > Could you do me a favour and change your test functions to LLDB's code > > style, so

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added inline comments. Comment at: lldb/unittests/Core/MangledTest.cpp:72 + + EXPECT_STREQ("", TheDemangled.GetCString()); +} teemperor wrote: > Could you do me a favour and change your test functions to LLDB's code style, > so `mangled_name` as a variable

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev added inline comments. Comment at: lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py:38 +# Exit GUI. +self.child.send(escape_key) +self.expect_prompt() wallace wrote: > create a method self.exit_gui

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev updated this revision to Diff 351263. OmarEmaraDev added a comment. - Merge branch 'main' into lldb-gui-expand-threads-tree - Implement default selection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100243/new/

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

teemperor added a comment. This seems reasonable to me, but I'll leave this open for a while in case someone that knows more about Rust mangling shows up. Otherwise I'll accept this next week. Comment at: lldb/source/Core/Mangled.cpp:213 +else + LLDB_LOGF(log,

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm created this revision. asm added reviewers: clayborg, wallace. Herald added subscribers: pengfei, JDevlieghere. asm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Rust's v0 name mangling scheme [1] is easy to disambiguate from other

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

teemperor added a comment. Sure I can take a look, but I don't see the immediate problem when looking at the backtrace. I assume it takes some time to reduce the bug in Chrome? If you could get me the `dump()` output for the Decls `D`, `(Decl*)ToDC`, `FromRD`, `ToD`,

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

rupprecht added a comment. This commit seems to be causing an LLDB crash. I'm still working on gathering info and reducing it, but maybe the crash reason is obvious to you given this stack trace: $ lldb -b -o "b ChromeMain" -o "r" -o "v" -o "p chrome_main_delegate"

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

This revision was automatically updated to reflect the committed changes. Closed by commit rGca10add5dbe4: [lldb, win] Remove obsolete workaround for MSVC and python libs (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ca10add - [lldb, win] Remove obsolete workaround for MSVC and python libs

Author: Stella Stamenova Date: 2021-06-10T11:13:38-07:00 New Revision: ca10add5dbe4c3fb2ccaa032d9c7f3e13ca4b14b URL: https://github.com/llvm/llvm-project/commit/ca10add5dbe4c3fb2ccaa032d9c7f3e13ca4b14b DIFF:

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104047/new/ https://reviews.llvm.org/D104047

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

stella.stamenova created this revision. stella.stamenova added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This workaround was necessary before the major

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

teemperor added a comment. LGTM beside some minor formatting bugs that got exacerbated by the clang-tidy run. I got bored of writing 'format' everywhere so I translated every comment into a different language via Google translate. I'll already accept this as this is easy to fix.

[Lldb-commits] [PATCH] D104041: [lldb] Replace default bodies of special member functions with = default;

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:103-105 CommandInterpreterRunOptions() + = default; Interesting, I would've expected clang-format to get this. CHANGES SINCE LAST ACTION