labath added a comment.
looks good as far as i am concerned
https://reviews.llvm.org/D25569
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dvlahovski updated this revision to Diff 74824.
dvlahovski marked 11 inline comments as done.
dvlahovski added a comment.
Changed std::map with llvm::StringMap
Using containter.empty() instead of containter.size() == 0
Avoiding copy by using for(const auto& ...)
Added bitwise operations to the
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:222
+
+ if (header->size_of_header > sizeof(MinidumpMemoryInfoListHeader)) {
+data = data.drop_front(header->size_of_header -
zturner wrote:
> I don't think you
labath added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:15
+#include "lldb/Target/MemoryRegionInfo.h"
+#include "lldb/Utility/LLDBAssert.h"
+
I think this is not needed anymore.
Comment at:
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:242
+
+ for (const auto : modules) {
+name = GetMinidumpString(module.module_name_rva);
I don't know how big the minidumps you're working with are or if
labath added a comment.
First round of comments from me :).
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:248
+
+if (lowest_addr.find(module_name) == lowest_addr.end()) {
+ lowest_addr[module_name] =
If you use the `emplace` function,
