[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Pavel Labath via lldb-commits
labath added a comment. Our darwin buildbot is also running the local test suite with cmake: http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4, look under build step "test9 local test". We've been considering turning these tests off as we don't have bandwidth to monitor and fix them, bu

[Lldb-commits] [lldb] r284001 - [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-10-12 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Oct 12 05:21:09 2016 New Revision: 284001 URL: http://llvm.org/viewvc/llvm-project?rev=284001&view=rev Log: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI Reviewers: clayborg, labath Subscribers: jaydeep, bhushan, slthakur, lldb-commit

[Lldb-commits] [lldb] r284003 - [LLDB][MIPS] fix Floating point register read/write for big endian

2016-10-12 Thread Nitesh Jain via lldb-commits
Author: nitesh.jain Date: Wed Oct 12 05:53:57 2016 New Revision: 284003 URL: http://llvm.org/viewvc/llvm-project?rev=284003&view=rev Log: [LLDB][MIPS] fix Floating point register read/write for big endian Reviewers: clayborg, labath, jaydeep Subscribers: bhushan, slthakur, lldb-commits Differen

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-10-12 Thread Nitesh Jain via lldb-commits
nitesh.jain added a comment. In https://reviews.llvm.org/D24603#566575, @clayborg wrote: > Commit anytime. Thanks https://reviews.llvm.org/D24603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D24603: [LLDB][MIPS] fix Floating point register read/write for big endian

2016-10-12 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284003: [LLDB][MIPS] fix Floating point register read/write for big endian (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D24603?vs=73278&id=74357#toc Repository: rL LLV

[Lldb-commits] [PATCH] D25021: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI

2016-10-12 Thread Nitesh Jain via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284001: [LLDB][MIPS] Fix qProcessInfo to return correct pointer size based on ELF ABI (authored by nitesh.jain). Changed prior to commit: https://reviews.llvm.org/D25021?vs=73029&id=74356#toc Repositor

[Lldb-commits] [PATCH] D23802: gdb-remote: Make the sequence mutex non-recursive

2016-10-12 Thread Ted Woodward via lldb-commits
ted added a comment. I'm seeing the same issue as Nitesh, except in a different spot. The Hexagon Simulator doesn't support QSaveRegisterState, so lldb calls GDBRemoteRegisterContext::ReadAllRegisterValues. It gets a lock on the communication client, then calls ReadAllRegisters, which tries to

[Lldb-commits] [lldb] r284041 - Fix lookup path for lldb-mi

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:15:46 2016 New Revision: 284041 URL: http://llvm.org/viewvc/llvm-project?rev=284041&view=rev Log: Fix lookup path for lldb-mi Summary: The test suite calls realpath on the lldb executable then append "-mi" to it to find the path of the lldb-mi executable. Th

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284041: Fix lookup path for lldb-mi (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25486?vs=74292&id=74429#toc Repository: rL LLVM https://reviews.llvm.org/D25486 Files:

[Lldb-commits] [lldb] r284042 - Fix building tests without system headers on Darwin

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:19:19 2016 New Revision: 284042 URL: http://llvm.org/viewvc/llvm-project?rev=284042&view=rev Log: Fix building tests without system headers on Darwin Summary: Default installations of OS X do not have system headers installed at /usr/include. This patch allo

[Lldb-commits] [PATCH] D25487: Fix building tests without system headers on Darwin

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284042: Fix building tests without system headers on Darwin (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25487?vs=74293&id=74430#toc Repository: rL LLVM https://review

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284043: Fix test suite lookup path for LLDB.h (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25488?vs=74294&id=74431#toc Repository: rL LLVM https://reviews.llvm.org/D25

[Lldb-commits] [lldb] r284043 - Fix test suite lookup path for LLDB.h

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:22:02 2016 New Revision: 284043 URL: http://llvm.org/viewvc/llvm-project?rev=284043&view=rev Log: Fix test suite lookup path for LLDB.h Summary: When running on Darwin, the test suite assumes a specific directory structure for the build directory. This works

[Lldb-commits] [PATCH] D25488: Fix test suite lookup path for LLDB.h

2016-10-12 Thread Chris Bieneman via lldb-commits
beanz added a comment. @labath I think having them running is useful. At the moment that is probably the only Darwin bot building LLDB using CMake. https://reviews.llvm.org/D25488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lis

[Lldb-commits] [lldb] r284045 - Use LLDB_SRC for relative paths

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:24:42 2016 New Revision: 284045 URL: http://llvm.org/viewvc/llvm-project?rev=284045&view=rev Log: Use LLDB_SRC for relative paths Summary: Going from LLDB_SRC instead of the file path is safer when looking for compiler-rt. Also need to add support for lookin

[Lldb-commits] [PATCH] D25489: Use LLDB_SRC for relative paths

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284045: Use LLDB_SRC for relative paths (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25489?vs=74295&id=74433#toc Repository: rL LLVM https://reviews.llvm.org/D25489 F

[Lldb-commits] [lldb] r284046 - [CMake] Cleanup check-lldb targets

2016-10-12 Thread Chris Bieneman via lldb-commits
Author: cbieneman Date: Wed Oct 12 15:26:13 2016 New Revision: 284046 URL: http://llvm.org/viewvc/llvm-project?rev=284046&view=rev Log: [CMake] Cleanup check-lldb targets Summary: This patch adds the following fixes to the check-lldb targets: * Adds missing dependencies on lldb tools so they get

[Lldb-commits] [PATCH] D25490: [CMake] Cleanup check-lldb targets

2016-10-12 Thread Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284046: [CMake] Cleanup check-lldb targets (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D25490?vs=74296&id=74434#toc Repository: rL LLVM https://reviews.llvm.org/D25490

[Lldb-commits] [PATCH] D25486: Fix lookup path for lldb-mi

2016-10-12 Thread Chris Bieneman via lldb-commits
beanz added inline comments. Comment at: packages/Python/lldbsuite/test/dotest.py:676-677 # If not found, disable the lldb-mi tests -lldbMiExec = None -if lldbtest_config.lldbExec and is_exe(lldbtest_config.lldbExec + "-mi"): -lldbMiExec = lldbtest_config.lld

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-12 Thread Tamas Berghammer via lldb-commits
Hi Jason, Thank you for adding unit test for this code. I think the current implementation doesn't fail terribly on 16 vs 32 byte stack alignment because we use the "opc" from the instruction to calculate the write back address (to adjust the SP) so having the wrong size of the register won't effe

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-12 Thread Jason Molenda via lldb-commits
Hi Tamas, sorry for that last email being a mess, I was doing something else while writing it and only saw how unclear it was after I sent it. You understood everything I was trying to say. I looked at the AAPCS64 again. It says v8-v15 are callee saved, but says, "Additionally, only the botto

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-12 Thread Tamas Berghammer via lldb-commits
I am a bit surprised that we don't define the smaller floating point registers on AArch64 the same way we do it on x86/x86_64/Arm (have no idea about MIPS) and I would consider this as a bug what we should fix (will gave it a try when I have a few free cycles) because currently it is very difficult

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-12 Thread Jason Molenda via lldb-commits
Yeah, it's incorrectly grabbing the stack pointer reg number (31) from the Rn bits and using that as the register # being saved, instead of the Rt and Rt2 register numbers, and saying that v31 is being pushed twice. It's an easy bug in EmulateInstructionARM64::EmulateLDPSTP but fixing that just

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

2016-10-12 Thread Jason Molenda via lldb-commits
But if I attach to an arm64 core file, where lldb is using it's own register definitions, then lldb has no idea what s0 is. My concern about defining these subset registers in RegisterInfos_arm64.h is that the offsets are in a target-endian register context buffer. My example below was littl

[Lldb-commits] [lldb] r284100 - Fix Python binding generation build step on Windows

2016-10-12 Thread Vadim Macagon via lldb-commits
Author: enlight Date: Wed Oct 12 23:07:22 2016 New Revision: 284100 URL: http://llvm.org/viewvc/llvm-project?rev=284100&view=rev Log: Fix Python binding generation build step on Windows Summary: If Python is installed to a location that contains spaces (e.g. "C:\Program Files\Python3") then the b