[Lldb-commits] [lldb] r373719 - [lldb] Fix typo in r373675

Author: sammccall Date: Fri Oct 4 02:33:04 2019 New Revision: 373719 URL: http://llvm.org/viewvc/llvm-project?rev=373719=rev Log: [lldb] Fix typo in r373675 Modified: lldb/trunk/scripts/Python/python-wrapper.swig Modified: lldb/trunk/scripts/Python/python-wrapper.swig URL:

[Lldb-commits] [lldb] r373725 - [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent

Author: teemperor Date: Fri Oct 4 02:54:58 2019 New Revision: 373725 URL: http://llvm.org/viewvc/llvm-project?rev=373725=rev Log: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent Summary: We should get the TargetAPI lock here to prevent the process of being destroyed

[Lldb-commits] [PATCH] D68376: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c

This revision was automatically updated to reflect the committed changes. Closed by commit rL373723: [lldb] Fix that ninja clean breaks the build by deleting debugserver_vers.c (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [lldb] r373721 - [lldb] Fix -Wreorder-ctor in r373673

Author: sammccall Date: Fri Oct 4 02:41:43 2019 New Revision: 373721 URL: http://llvm.org/viewvc/llvm-project?rev=373721=rev Log: [lldb] Fix -Wreorder-ctor in r373673 Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp Modified:

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

labath added a comment. Yeah, that's definitely python-related, but it's hard to say how exactly without knowing more details. Also note that there have been some changes in how the python stuff is used/built in the last couple of weeks so it's possible this was not caused by a change on your

[Lldb-commits] [PATCH] D68299: [JSON] Use LLVM's library for encoding JSON in GDBRemoteCommunicationServerLLGS

labath added a comment. TBE, this happens when lldb is not able to find the python package files (which should normally be in `$BUILD/libXY/pythonA.B/site-packages`). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68299/new/ https://reviews.llvm.org/D68299

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223143. lawrence_danna added a comment. deserializer hijinks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files:

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to

[Lldb-commits] [lldb] r373723 - [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c

Author: teemperor Date: Fri Oct 4 02:52:26 2019 New Revision: 373723 URL: http://llvm.org/viewvc/llvm-project?rev=373723=rev Log: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c Summary: We mark debugserver_vers.c as a generated file in CMake. This means that when

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

labath added inline comments. Comment at: lldb/include/lldb/Utility/ReproducerInstrumentation.h:19 +#include "lldb/API/SBFile.h" + This is definitely not right. `Utility` should never include other lldb libraries. I think this stuff should be defined in the

[Lldb-commits] [PATCH] D68454: Fix the unwinding plan augmentation from x86 assembly

jarin created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Unwind plan augmentation should compute the plan row at offset x from the instruction before offset x, but currently we compute it from the instruction at offset x. Note that this behavior is a

[Lldb-commits] [PATCH] D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

This revision was automatically updated to reflect the committed changes. Closed by commit rL373711: [lldb][modern-type-lookup] No longer import temporary declarations into the… (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223146. lawrence_danna added a comment. :-/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files: lldb/include/lldb/API/SBCommandReturnObject.h

[Lldb-commits] [lldb] r373711 - [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

Author: teemperor Date: Fri Oct 4 01:26:17 2019 New Revision: 373711 URL: http://llvm.org/viewvc/llvm-project?rev=373711=rev Log: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST Summary: As we figured out in D67803, importing declarations from a

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added subscribers: amccarth, zturner. labath added a comment. Thanks. I was just about to hit approve, but then I noticed one other thing... :/ It seems that somebody (I guess it was @zturner) spent a lot of time in creating the whole PythonObject hierarchy, and it's (worthwhile) goal

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

labath added inline comments. Comment at: lldb/source/Core/IOHandler.cpp:332 + if (m_output_sp) { +m_output_sp->GetFile().Printf("%s", prompt); +m_output_sp->Flush(); It looks like this could actually use the `Stream` interface

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks for doing this. Personally, I'd just remove the `Log` argument from the function argument list, and let the function re-fetch it if needed. I know we sometimes pass

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

labath added a comment. Makes sense. Would it make sense to use `@expectedFailure` instead of `@skipIf`? That way you'll get an notification once a test actually starts passing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/

[Lldb-commits] [PATCH] D68533: Explicitly set entry point arch when it's thumb [Second Try]

aadsm created this revision. aadsm added reviewers: clayborg, labath, wallace, espindola. aadsm added a project: LLDB. This is a redo of D68069 because I reverted it due to some concerns that were now addressed along with the new comments that @labath added. I

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

vsk added a comment. In D68422#1694147 , @labath wrote: > Looks good to me. Thanks for doing this. Personally, I'd just remove the > `Log` argument from the function argument list, and let the function re-fetch > it if needed. I know we sometimes pass

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

wallace updated this revision to Diff 223358. wallace added a comment. added a basic python test It was a nice learning experience and fortunately there was no need to add any intrusive code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68312: [gdb-remote] process properly effective uid

wallace updated this revision to Diff 223359. wallace added a comment. added a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68312/new/ https://reviews.llvm.org/D68312 Files:

[Lldb-commits] [PATCH] D68442: [lldb] Unifying lldb python path

hhb updated this revision to Diff 223346. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68442/new/ https://reviews.llvm.org/D68442 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223352. lawrence_danna added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. I changed my mind about splitting this into another patch.When I first said that I had in mind a much more extensive rewrite of the PythonDataObjects. I think it's fine now as one patch -- though we should still go back later add Expected<> everywhere in

[Lldb-commits] [PATCH] D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC

vsk updated this revision to Diff 223357. vsk added a comment. - Remove the `log` parameter from `ParseTypeFromDWARF`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68422/new/ https://reviews.llvm.org/D68422 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223355. lawrence_danna added a comment. python2 const fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace updated this revision to Diff 223356. wallace added a comment. added a basic python test It was a nice learning experience and fortunately there was no need to add any intrusive code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

wallace added a comment. damn, i overwrote this patch lol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1695069 , @labath wrote: > I agree about the separate patch stuff, but it seems to be that this should > be done before this one. After all, all (most?) of the existing code has > already been DataObject-ized

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223351. lawrence_danna added a comment. spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [lldb] r373804 - [test] Run TestLaunchWithShellExpand with /bin/sh on POSIX.

Author: jdevlieghere Date: Fri Oct 4 15:21:35 2019 New Revision: 373804 URL: http://llvm.org/viewvc/llvm-project?rev=373804=rev Log: [test] Run TestLaunchWithShellExpand with /bin/sh on POSIX. Now that we do shell expansion on POSIX with the user's shel, this test can potentially fail. This

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223350. lawrence_danna added a comment. better integration with PythonObject Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223361. lawrence_danna added a comment. fix typemaps to deal with None correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

labath added a comment. Yea, I see what you mean. I wouldn't spend too much time on fixing that though. The ability for SymbolFiles to add symtab entries is a fairly new thing. Not all issues with it have been ironed out, and I don't think it's up to you to fix them. The same kind of conflict

[Lldb-commits] [PATCH] D67831: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresen

This revision was automatically updated to reflect the committed changes. Closed by commit rL373725: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D68069: Explicitly set entry point arch when it's thumb

aadsm added a comment. Ok. Initially I thought that with the entry point we were making big assumptions there but after reading the parse unwind symbols I guess it's really no big difference. I guess my main concern is that the user can no longer create symbols within the span of the entry

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

JDevlieghere added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to labath wrote: > lawrence_danna

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1694276 , @labath wrote: > Most of your interactions seem to be about calling methods. Would it be > possible to add a PythonDataObject wrapper for this (and any other frequently > used python API)? I'm hoping

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

mgorny created this revision. mgorny added reviewers: labath, compnerd, phosek, beanz. Link against clang-cpp dylib rather than split libs when CLANG_LINK_CLANG_DYLIB is enabled. https://reviews.llvm.org/D68456 Files: lldb/cmake/modules/AddLLDB.cmake lldb/source/Core/CMakeLists.txt

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

labath added a comment. Seems reasonable. Just one quick question about the implementation. Comment at: lldb/cmake/modules/AddLLDB.cmake:94-99 + +if(CLANG_LINK_CLANG_DYLIB) + target_link_libraries(${name} PRIVATE clang-cpp) +else() +

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/cmake/modules/AddLLDB.cmake:94-99 + +if(CLANG_LINK_CLANG_DYLIB) + target_link_libraries(${name} PRIVATE clang-cpp) +else() +

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

This revision was automatically updated to reflect the committed changes. Closed by commit rL373734: [lldb] [cmake] Support linking against clang-cpp dylib (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath updated this revision to Diff 223193. labath added a comment. Upload a new version of the patch. This isn't fully ready for submission, but I am putting it up anyway, to get some feedback on the direction I am taking this, and ask some questions. First I tried to do a complete rewrite of

[Lldb-commits] [PATCH] D68464: [lldb][modern-type-lookup] Ask the ExternalASTMerger to lookup namespaces instead of using the old mechanism

teemperor created this revision. teemperor added a reviewer: shafik. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. With this patch LLDB starts querying the ExternalASTMerger when we look up a namespace in the translation unit context. Because Clang's

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:94-99 + +if(CLANG_LINK_CLANG_DYLIB) + target_link_libraries(${name} PRIVATE clang-cpp) +else() + target_link_libraries(${name} PRIVATE

[Lldb-commits] [PATCH] D68456: [lldb] [cmake] Support linking against clang-cpp dylib

mgorny added a comment. FTR, I'm getting missing LD_LIBRARY_PATH problems when running `check-llvm` with dylibs. However, it also happens with plain `LLVM_LINK_LLVM_DYLIB`, so I don't think it needs to be addressed with this patch. CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] r373734 - [lldb] [cmake] Support linking against clang-cpp dylib

Author: mgorny Date: Fri Oct 4 05:03:03 2019 New Revision: 373734 URL: http://llvm.org/viewvc/llvm-project?rev=373734=rev Log: [lldb] [cmake] Support linking against clang-cpp dylib Link against clang-cpp dylib rather than split libs when CLANG_LINK_CLANG_DYLIB is enabled. Differential

[Lldb-commits] [PATCH] D68270: DWARFDebugLoc: Add a function to get the address range of an entry

labath marked 8 inline comments as done. labath added inline comments. Comment at: include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h:91 + class EntryIterator { + public: I went for an iterator-like approach (instead of a callback or direct materialization)

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the stream changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444

[Lldb-commits] [PATCH] D68433: SBFile: add a bunch of tests that should eventually work.

lawrence_danna updated this revision to Diff 223238. lawrence_danna added a comment. use expectedFailure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68433/new/ https://reviews.llvm.org/D68433 Files:

[Lldb-commits] [PATCH] D68314: [process info] Remove assert in DoGetGroupName

wallace closed this revision. wallace added a comment. This has been committed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68314/new/ https://reviews.llvm.org/D68314 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

labath added a comment. I agree about the separate patch stuff, but it seems to be that this should be done before this one. After all, all (most?) of the existing code has already been DataObject-ized and this patch is the thing that's deviating from that practice. I don't think you should

[Lldb-commits] [lldb] r373758 - [lldb-server/android] Show more processes and package name when necessary

Author: wallace Date: Fri Oct 4 09:35:59 2019 New Revision: 373758 URL: http://llvm.org/viewvc/llvm-project?rev=373758=rev Log: [lldb-server/android] Show more processes and package name when necessary Summary: By default `platform process list` only shows the processes of the current user

[Lldb-commits] [lldb] r373760 - [process info] Remove assert in DoGetGroupName

Author: wallace Date: Fri Oct 4 09:56:23 2019 New Revision: 373760 URL: http://llvm.org/viewvc/llvm-project?rev=373760=rev Log: [process info] Remove assert in DoGetGroupName Summary: Disabling this assert prevents lldb-server from crashing, which prevents it from finding the user and group

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna marked 4 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 223235. wallace added a comment. last nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 223234. lawrence_danna marked 4 inline comments as done. lawrence_danna added a comment. minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1369 +const char *utf8 = PyUnicode_AsUTF8AndSize(pystring.get(), ); +if (!utf8 || PyErr_Occurred()) + return Status(llvm::make_error("Read"));

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL373758: [lldb-server/android] Show more processes and package name when necessary (authored by wallace, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

labath added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to lawrence_danna wrote: > JDevlieghere

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

wallace updated this revision to Diff 223236. wallace added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68289/new/ https://reviews.llvm.org/D68289 Files: lldb/source/Host/linux/Host.cpp Index:

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223248. lawrence_danna added a comment. a different deserializer fix for SBFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files:

[Lldb-commits] [PATCH] D68370: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

This revision was automatically updated to reflect the committed changes. Closed by commit rL373768: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS (authored by aadsm, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna updated this revision to Diff 223254. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 Files:

[Lldb-commits] [PATCH] D68444: remove a smattering of isolated, unnecessary uses of FILE*

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68444/new/ https://reviews.llvm.org/D68444 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r373768 - Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS

Author: aadsm Date: Fri Oct 4 11:10:42 2019 New Revision: 373768 URL: http://llvm.org/viewvc/llvm-project?rev=373768=rev Log: Componentize lldb/scripts to use with LLVM_DISTRIBUTION_COMPONENTS Summary: I'd like to install lldb using the install-distribution target with

[Lldb-commits] [lldb] r366848 - Revert "Revert "Add ReadCStringFromMemory for faster string reads""

Author: aadsm Date: Tue Jul 23 13:40:37 2019 New Revision: 366848 URL: http://llvm.org/viewvc/llvm-project?rev=366848=rev Log: Revert "Revert "Add ReadCStringFromMemory for faster string reads"" This reverts commit 9c10b620c0619611dfe062216459431955ac4801. Modified:

[Lldb-commits] [lldb] r366847 - Revert "Revert "Implement xfer:libraries-svr4:read packet""

Author: aadsm Date: Tue Jul 23 13:40:30 2019 New Revision: 366847 URL: http://llvm.org/viewvc/llvm-project?rev=366847=rev Log: Revert "Revert "Implement xfer:libraries-svr4:read packet"" This reverts commit 08c38f77c5fb4d3735ec215032fed8ee6730b3db. Added:

Re: [Lldb-commits] [lldb] r373776 - [Host] Don't discard return value from RunShellCommand

On 04/10/2019 21:37, Jonas Devlieghere via lldb-commits wrote: + error.SetErrorString(e.AsCString()); + return error; +} return e; ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r373783 - [Host] Return status directly from RunShellCommand

Author: jdevlieghere Date: Fri Oct 4 12:54:45 2019 New Revision: 373783 URL: http://llvm.org/viewvc/llvm-project?rev=373783=rev Log: [Host] Return status directly from RunShellCommand Thanks for catching this, Pavel! Modified: lldb/trunk/source/Host/macosx/objcxx/Host.mm

Re: [Lldb-commits] [lldb] r373776 - [Host] Don't discard return value from RunShellCommand

Thanks! Fixed in 373783. On Fri, Oct 4, 2019 at 12:38 PM Pavel Labath wrote: > > On 04/10/2019 21:37, Jonas Devlieghere via lldb-commits wrote: > > + error.SetErrorString(e.AsCString()); > > + return error; > > +} > > return e; ___

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218930. kwk added a comment. Herald added subscribers: wuzish, rnkovacs. - Fixup - Test for minidebuginfo image dump symtab - Fixed test for corrupted xz blob - Fix test - Added test that runs when no LZMA is configured Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218932. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220830. mbrkusanin added a comment. - `MipsMCAsmInfo()` now always reads ABI from `MipsABIInfo` instead of `Triple`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files:

[Lldb-commits] [lldb] r367386 - Change '|' to '&' in conditional.

Author: rtrieu Date: Tue Jul 30 21:41:05 2019 New Revision: 367386 URL: http://llvm.org/viewvc/llvm-project?rev=367386=rev Log: Change '|' to '&' in conditional. Bitwise-or with a non-zero constant will always evaluate to true. Switch to bitwise-and which will only evalute to true if the

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 220675. mbrkusanin added a comment. Herald added subscribers: lldb-commits, cfe-commits, seiya, lenary, rupprecht, jrtc27, hiraditya. Herald added projects: clang, LLDB. - MCTargetOptions is now always passed to MCAsmInfo (or rather createMCAsmInfo). In

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218929. kwk added a comment. Herald added subscribers: openmp-commits, libcxx-commits, Sanitizers, cfe-commits, seiya, erik.pilkington, asbirlea, ormris, Petar.Avramovic, jsji, mstorsjo, jfb, kadircet, arphaman, jkorous, george.burgess.iv, christof,

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. In D66795#1650305 , @atanasyan wrote: > But take a look at `LLVMCreateDisasmCPUFeatures` function from > `Disassembler.cpp`. If we cannot retrieve `MCTargetOptions` right in this > function, we will have to change "LLVM-C"

Re: [Lldb-commits] [lldb] r371882 - Fix error in ProcessLauncherWindows.cpp

Thanks! > On Sep 13, 2019, at 8:50 PM, Adrian McCarthy via lldb-commits > wrote: > > Author: amccarth > Date: Fri Sep 13 11:50:39 2019 > New Revision: 371882 > > URL: http://llvm.org/viewvc/llvm-project?rev=371882=rev > Log: > Fix error in ProcessLauncherWindows.cpp > > Restored missing

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218931. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

cishida abandoned this revision. cishida added a comment. Ran into issue with pushing update to this middle of stack revision. Will create new clean revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66149/new/

[Lldb-commits] [lldb] r356672 - Workaround Python's map difference between Python2/3

Author: serge_sans_paille Date: Thu Mar 21 07:44:58 2019 New Revision: 356672 URL: http://llvm.org/viewvc/llvm-project?rev=356672=rev Log: Workaround Python's map difference between Python2/3 When the output of map is not used, using a list comprehension or an explicit call to list looks

[Lldb-commits] [lldb] r371195 - Remove call to obsolete gethostbyname, using getaddrinfo

Author: serge_sans_paille Date: Fri Sep 6 04:06:23 2019 New Revision: 371195 URL: http://llvm.org/viewvc/llvm-project?rev=371195=rev Log: Remove call to obsolete gethostbyname, using getaddrinfo Differential Revision: https://reviews.llvm.org/D67230 Modified:

[Lldb-commits] [PATCH] D66149: [BinaryFormat] Teach identify_magic about Tapi files.

cishida updated this revision to Diff 215174. cishida added a comment. Herald added subscribers: openmp-commits, libcxx-commits, lldb-commits, Sanitizers, cfe-commits, jdoerfert, asbirlea, Petar.Avramovic, thopre, jsji, jfb, kadircet, rupprecht, arphaman, atanasyan, jkorous, MaskRay, jrtc27,

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 219038. kwk added a comment. - Fix spelling error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt lldb/cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D62732: [WIP][RISCV] Initial port of LLDB for RISC-V

simoncook updated this revision to Diff 205287. simoncook added a comment. - Refactored register tables to match style used in i386/x86_64 - Add enum for RISC-V DWARF numbers - Add F registers (assuming 32-bit, at runtime this seems to be overwritten to 64-bit if D extension is provided) - Add

[Lldb-commits] [PATCH] D62732: [WIP][RISCV] Initial port of LLDB for RISC-V

jasonmolenda added inline comments. Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp:624-635 +case llvm::Triple::riscv32: +case llvm::Triple::riscv64: + for (auto : m_regs) { +if (strcmp(reg.name, "x1") == 0) +

[Lldb-commits] [lldb] r364614 - Fixing a couple of wrong logical operator bugs.

Author: tamur Date: Thu Jun 27 17:11:26 2019 New Revision: 364614 URL: http://llvm.org/viewvc/llvm-project?rev=364614=rev Log: Fixing a couple of wrong logical operator bugs. Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h

[Lldb-commits] [lldb] r366478 - [lldb][swig] Fix autodocs flag parsing

Author: rupprecht Date: Thu Jul 18 11:18:51 2019 New Revision: 366478 URL: http://llvm.org/viewvc/llvm-project?rev=366478=rev Log: [lldb][swig] Fix autodocs flag parsing r366471 added "-features autodoc" without a trailing comment, leading to `Unrecognized option -features autodoc-threads` due

[Lldb-commits] [lldb] r367865 - [lldb][clang] Reflect LangStandard.h move to clang/Basic

Author: ro Date: Mon Aug 5 07:00:43 2019 New Revision: 367865 URL: http://llvm.org/viewvc/llvm-project?rev=367865=rev Log: [lldb][clang] Reflect LangStandard.h move to clang/Basic D65562 moves LangStandard.h from clang/Frontend to clang/Basic. This patch

[Lldb-commits] [lldb] r362192 - Fix off-by-one error.

Author: rtrieu Date: Thu May 30 22:06:54 2019 New Revision: 362192 URL: http://llvm.org/viewvc/llvm-project?rev=362192=rev Log: Fix off-by-one error. The created string is one char too large, so it pulls the terminating NULL as the last character of the string. This later causes SocketTest.cpp

[Lldb-commits] [PATCH] D62732: [WIP][RISCV] Initial port of LLDB for RISC-V

xiaobai added subscribers: compnerd, xiaobai. xiaobai added a reviewer: compnerd. xiaobai added a comment. @compnerd You might be interested in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732

[Lldb-commits] [PATCH] D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.

ymandel marked 2 inline comments as done. ymandel added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp:46 + + StringRef Message = "no explanation"; + if (Case.Explanation) { ilya-biryukov wrote: > ymandel wrote: >

[Lldb-commits] [lldb] r356647 - Use list comprehension instead of map/filter to prepare Python2/3 compat

Author: serge_sans_paille Date: Thu Mar 21 00:19:09 2019 New Revision: 356647 URL: http://llvm.org/viewvc/llvm-project?rev=356647=rev Log: Use list comprehension instead of map/filter to prepare Python2/3 compat Differential Revision: https://reviews.llvm.org/D59579 Modified:

[Lldb-commits] [lldb] r356673 - Workaround items/iteritems difference between Python2 and Python3

Author: serge_sans_paille Date: Thu Mar 21 07:47:40 2019 New Revision: 356673 URL: http://llvm.org/viewvc/llvm-project?rev=356673=rev Log: Workaround items/iteritems difference between Python2 and Python3 Differential Revision: https://reviews.llvm.org/D59588 Modified:

[Lldb-commits] [lldb] r356670 - Portable exception value access across Python 2 / Python 3

Author: serge_sans_paille Date: Thu Mar 21 07:39:55 2019 New Revision: 356670 URL: http://llvm.org/viewvc/llvm-project?rev=356670=rev Log: Portable exception value access across Python 2 / Python 3 Differential Revision: https://reviews.llvm.org/D59583 Modified:

[Lldb-commits] [lldb] r356671 - Portable int/long conversion across Python 2 / Python 3

Author: serge_sans_paille Date: Thu Mar 21 07:41:34 2019 New Revision: 356671 URL: http://llvm.org/viewvc/llvm-project?rev=356671=rev Log: Portable int/long conversion across Python 2 / Python 3 Differential Revision: https://reviews.llvm.org/D59585 Modified:

[Lldb-commits] [lldb] r337070 - Update ClangASTContext for the new DependentVector type.

Author: saugustine Date: Fri Jul 13 15:54:41 2018 New Revision: 337070 URL: http://llvm.org/viewvc/llvm-project?rev=337070=rev Log: Update ClangASTContext for the new DependentVector type. https://reviews.llvm.org/D49326 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

[Lldb-commits] [lldb] r356904 - Python 2/3 compat: unichr vs chr

Author: serge_sans_paille Date: Mon Mar 25 08:12:48 2019 New Revision: 356904 URL: http://llvm.org/viewvc/llvm-project?rev=356904=rev Log: Python 2/3 compat: unichr vs chr Modified: lldb/trunk/examples/summaries/cocoa/CFString.py Modified: lldb/trunk/examples/summaries/cocoa/CFString.py

  1   2   3   4   >