https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/140562
>From 580e8625cb0431a86dd77e5c5ba72cd6f33f38ed Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Thu, 8 May 2025 21:19:26 +0100
Subject: [PATCH 1/2] [OpenMP][Flang] Emit default declare mappers implicitly
for
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/140562
>From 580e8625cb0431a86dd77e5c5ba72cd6f33f38ed Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Thu, 8 May 2025 21:19:26 +0100
Subject: [PATCH] [OpenMP][Flang] Emit default declare mappers implicitly for
der
https://github.com/TIFitis created
https://github.com/llvm/llvm-project/pull/140562
This patch adds support to emit default declare mappers for implicit mapping of
derived types when not supplied by user. This especially helps tackle mapping
of allocatables of derived types.
>From 5d735f1cd6d
https://github.com/TIFitis approved this pull request.
LG Thanks :)
https://github.com/llvm/llvm-project/pull/137199
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-com
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121005
>From 77e95624798ddc1f07ab7af30962e7a128248bae Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:50:03 +
Subject: [PATCH 1/2] Add OpenMP to LLVM dialect conversion support for
DeclareM
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 784c7fb6fb6c8dbbda2838fd2e5dee7b86129b5a Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/8] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121001
>From 2121c61420db36438293ae2df8b297f70ab4b61c Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:13:42 +
Subject: [PATCH 1/5] Add flang lowering changes for mapper field in map
clause.
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/120994
>From e70f3c9aed18b33c07e60f3314722825031d5ed1 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 20:53:47 +
Subject: [PATCH 1/2] Add mapper field to mapInfoOp.
---
flang/lib/Lower/OpenMP
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 7b5c918249a9c29ae586d9f1ccae6b7359fcd793 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/8] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
@@ -4673,7 +4804,8 @@ convertHostOrTargetOperation(Operation *op,
llvm::IRBuilderBase &builder,
.Case([&](omp::TaskwaitOp op) {
return convertOmpTaskwaitOp(op, builder, moduleTranslation);
})
- .Casehttps://github.com/llvm/llvm-project/pull/124746
@@ -3529,6 +3549,84 @@ static void genMapInfos(llvm::IRBuilderBase &builder,
}
}
+static llvm::Expected
+emitUserDefinedMapper(Operation *declMapperOp, llvm::IRBuilderBase &builder,
+ LLVM::ModuleTranslation &moduleTranslation);
+
+static llvm::Expected
@@ -3529,6 +3549,84 @@ static void genMapInfos(llvm::IRBuilderBase &builder,
}
}
+static llvm::Expected
+emitUserDefinedMapper(Operation *declMapperOp, llvm::IRBuilderBase &builder,
+ LLVM::ModuleTranslation &moduleTranslation);
+
+static llvm::Expected
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 7b5c918249a9c29ae586d9f1ccae6b7359fcd793 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/7] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
@@ -9099,9 +9099,10 @@ void CGOpenMPRuntime::emitUserDefinedMapper(const
OMPDeclareMapperDecl *D,
CGM.getCXXABI().getMangleContext().mangleCanonicalTypeName(Ty, Out);
std::string Name = getName({"omp_mapper", TyStr, D->getName()});
- auto *NewFn = OMPBuilder.emitUserDefi
@@ -0,0 +1,47 @@
+! Offloading test checking lowering of arrays with dynamic extents.
+! REQUIRES: flang, amdgpu
+
+! RUN: %libomptarget-compile-fortran-run-and-check-generic
+
+program test_openmp_mapper
+ implicit none
+ integer, parameter :: n = 1024
+ type :: mytype
+
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 7b5c918249a9c29ae586d9f1ccae6b7359fcd793 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/6] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121005
>From 0cba204faac851d186470b74aab3601a987e0f2d Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:50:03 +
Subject: [PATCH 1/2] Add OpenMP to LLVM dialect conversion support for
DeclareM
@@ -3529,6 +3549,84 @@ static void genMapInfos(llvm::IRBuilderBase &builder,
}
}
+static llvm::Expected
+emitUserDefinedMapper(Operation *declMapperOp, llvm::IRBuilderBase &builder,
+ LLVM::ModuleTranslation &moduleTranslation);
+
+static llvm::Expected
@@ -0,0 +1,85 @@
+! This test checks lowering of OpenMP declare mapper Directive.
+
+! RUN: split-file %s %t
+! RUN: %flang_fc1 -emit-hlfir -fopenmp -fopenmp-version=50
%t/omp-declare-mapper-1.f90 -o - | FileCheck %t/omp-declare-mapper-1.f90
+! RUN: %flang_fc1 -emit-hlfir -fopenm
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121001
>From 107f59d06dcb0523e373682b5879bb79c824bb2f Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:13:42 +
Subject: [PATCH 1/5] Add flang lowering changes for mapper field in map
clause.
@@ -1003,6 +1006,20 @@ void ClauseProcessor::processMapObjects(
}
}
+if (!mapperIdName.empty()) {
TIFitis wrote:
The if is contained in a loop and I want the if to execute only the first
iteration. So this replacement won't be helpful here.
ht
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/120994
>From 57858d2e19897a72057464bd33311d2cd4d4f156 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 20:53:47 +
Subject: [PATCH 1/2] Add mapper field to mapInfoOp.
---
flang/lib/Lower/OpenMP
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121005
>From 14e666593f9966b24f11602104788c3501364574 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:50:03 +
Subject: [PATCH 1/2] Add OpenMP to LLVM dialect conversion support for
DeclareM
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121001
>From d7bb2309591d828756b7e1274ebcf592b992eb16 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:13:42 +
Subject: [PATCH 1/4] Add flang lowering changes for mapper field in map
clause.
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/120994
>From 95e8e2b18d9e5b35ec2ad13bd7ee58a1bd1b996d Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 20:53:47 +
Subject: [PATCH 1/2] Add mapper field to mapInfoOp.
---
flang/lib/Lower/OpenMP
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121005
>From 879d8a1765b9176fce18c02bdcc29bb079b6ba7e Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:50:03 +
Subject: [PATCH 1/2] Add OpenMP to LLVM dialect conversion support for
DeclareM
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121001
>From c93eefb9cc4db635a694f16aee6b42525cd05e79 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:13:42 +
Subject: [PATCH 1/4] Add flang lowering changes for mapper field in map
clause.
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/120994
>From f8642ec5b59e8617d2f1b8a87938ce2d6ba25205 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 20:53:47 +
Subject: [PATCH 1/2] Add mapper field to mapInfoOp.
---
flang/lib/Lower/OpenMP
@@ -2612,7 +2612,52 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From d80da54e1edee017f97aebf5f2e17895ddbf6413 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/4] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121005
>From c993ac570b1788867be44690f87cf8ccafb97534 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:50:03 +
Subject: [PATCH 1/2] Add OpenMP to LLVM dialect conversion support for
DeclareM
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121001
>From 64e17c3992cc89aa02148b2b0e9319552a9ca63f Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:13:42 +
Subject: [PATCH 1/3] Add flang lowering changes for mapper field in map
clause.
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/120994
>From f7c3a6505a3affa159b178852c67cff5739f2c26 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 20:53:47 +
Subject: [PATCH 1/2] Add mapper field to mapInfoOp.
---
flang/lib/Lower/OpenMP
@@ -936,8 +936,10 @@ void ClauseProcessor::processMapObjects(
llvm::omp::OpenMPOffloadMappingFlags mapTypeBits,
std::map &parentMemberIndices,
llvm::SmallVectorImpl &mapVars,
-llvm::SmallVectorImpl &mapSyms) const {
+llvm::SmallVectorImpl &mapSyms,
+std:
TIFitis wrote:
> One small comment, though. Please trigger a not-yet-implemented error when
> translating all operations taking `map` clauses if the new field is set. That
> would be in `checkImplementationStatus`, in OpenMPToLLVMIRTranslation.cpp.
Is that necessary given I have the entire imp
@@ -2612,7 +2612,52 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -2612,7 +2612,52 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -2612,7 +2612,54 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
TIFitis wrote:
Polite request for review 🙂
https://github.com/llvm/llvm-project/pull/117046
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -3421,6 +3441,85 @@ static void genMapInfos(llvm::IRBuilderBase &builder,
}
}
+static llvm::Expected
+emitUserDefinedMapper(Operation *declMapperOp, llvm::IRBuilderBase &builder,
+ LLVM::ModuleTranslation &moduleTranslation);
+
+static llvm::Expected
@@ -3421,6 +3441,85 @@ static void genMapInfos(llvm::IRBuilderBase &builder,
}
}
+static llvm::Expected
+emitUserDefinedMapper(Operation *declMapperOp, llvm::IRBuilderBase &builder,
+ LLVM::ModuleTranslation &moduleTranslation);
+
+static llvm::Expected
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From a8671fc83f026a692802d4eee25c91657228928b Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/3] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121005
>From 5fe7a97dd2f1844ad4d538c0ee5bf47f44aefa95 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:50:03 +
Subject: [PATCH] Add OpenMP to LLVM dialect conversion support for
DeclareMappe
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121001
>From 44eafafd74ecbce7ed7c4a408fff6c82b4cc07e1 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:13:42 +
Subject: [PATCH 1/2] Add flang lowering changes for mapper field in map
clause.
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 431c404dc125aa6b27f32b6019baebf603111f51 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 15:45:55 +
Subject: [PATCH 1/5] Add description for mapper_id. Add verifier check for
vali
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 5ca5a1f7c1e33949f8e0d32a4c94645842432559 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 15:45:55 +
Subject: [PATCH 1/8] Add description for mapper_id. Add verifier check for
vali
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 5ca5a1f7c1e33949f8e0d32a4c94645842432559 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 15:45:55 +
Subject: [PATCH 1/8] Add description for mapper_id. Add verifier check for
vali
@@ -2709,13 +2709,23 @@ getRefPtrIfDeclareTarget(mlir::Value value,
}
namespace {
+// Append customMappers information to existing MapInfosTy
+struct MapInfosTy : llvm::OpenMPIRBuilder::MapInfosTy {
+ SmallVector Mappers;
TIFitis wrote:
Yes, we can do that,
@@ -3421,6 +3441,85 @@ static void genMapInfos(llvm::IRBuilderBase &builder,
}
}
+static llvm::Expected
+emitUserDefinedMapper(Operation *declMapperOp, llvm::IRBuilderBase &builder,
+ LLVM::ModuleTranslation &moduleTranslation);
+
+static llvm::Expected
@@ -3421,6 +3441,85 @@ static void genMapInfos(llvm::IRBuilderBase &builder,
}
}
+static llvm::Expected
+emitUserDefinedMapper(Operation *declMapperOp, llvm::IRBuilderBase &builder,
+ LLVM::ModuleTranslation &moduleTranslation);
+
+static llvm::Expected
@@ -2709,13 +2709,23 @@ getRefPtrIfDeclareTarget(mlir::Value value,
}
namespace {
+// Append customMappers information to existing MapInfosTy
+struct MapInfosTy : llvm::OpenMPIRBuilder::MapInfosTy {
+ SmallVector Mappers;
TIFitis wrote:
Technically it might
@@ -186,6 +186,32 @@ struct MapInfoOpConversion : public
ConvertOpToLLVMPattern {
}
};
+struct DeclMapperOpConversion
TIFitis wrote:
I tried to use the `MultiRegionOpConversion` but it doesn't support Ops with a
single region, and `RegionOpConversion` doe
TIFitis wrote:
@kiranchandramohan @skatrak @agozillon Hi everyone! I was on vacation these
last couple of weeks, apologies for the delay.
I have added PR #124746 with which we have all the implementation in place for
declare mappers.
It would be great to resume the review process for this PR
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/124746
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1000,6 +1000,7 @@ def MapInfoOp : OpenMP_Op<"map.info",
[AttrSizedOperandSegments]> {
OptionalAttr:$members_index,
Variadic:$bounds, /* rank-0 to
rank-{n-1} */
OptionalAttr:$map_type,
+
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/120994
>From 002d7153f4029c02722b6a4f45bbde8fad83ba95 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 20:53:47 +
Subject: [PATCH 1/2] Add mapper field to mapInfoOp.
---
flang/lib/Lower/OpenMP
@@ -0,0 +1,23 @@
+! RUN: %flang_fc1 -emit-hlfir -fopenmp -fopenmp-version=50 %s -o - | FileCheck
%s
+program p
+ integer, parameter :: n = 256
+ type t1
+ integer :: x(256)
+ end type t1
+
+ !$omp declare mapper(xx : t1 :: nn) map(to: nn, nn%x)
+ !$omp declare mapp
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/121001
>From 30611f81421028ccc8fceed006e06f8afc6848b9 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 19:05:30 +
Subject: [PATCH 1/3] Add mapper field to mapInfoOp.
---
flang/test/Lower/OpenM
@@ -1057,13 +1075,17 @@ bool ClauseProcessor::processMap(
"Support for iterator modifiers is not implemented yet");
}
if (mappers) {
- TODO(currentLocation,
- "Support for mapper modifiers is not implemented yet");
+ assert(mappers->size()
@@ -970,6 +972,20 @@ void ClauseProcessor::processMapObjects(
}
}
+if (!mapperIdName.empty()) {
+ if (mapperIdName == "default") {
+auto &typeSpec = object.sym()->owner().IsDerivedType()
+ ? *object.sym()->owner().derivedT
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/121001
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -186,6 +186,32 @@ struct MapInfoOpConversion : public
ConvertOpToLLVMPattern {
}
};
+struct DeclMapperOpConversion
TIFitis wrote:
Hi, sorry for the late reply, I've just returned from my vacation.
Can we use a specialised `forwardOpAttrs` to convert th
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/124746
>From 6bba19e7df6da05f77e5e1ac5fb06c4fb2a1bda0 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Tue, 28 Jan 2025 13:38:13 +
Subject: [PATCH 1/2] [MLIR][OpenMP] Add LLVM translation support for OpenMP
Use
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/121005
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/121001
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/TIFitis created
https://github.com/llvm/llvm-project/pull/121005
Add conversion support from FIR to LLVM Dialect for OMP DeclareMapper.
>From 8a90d208ace9b8fe34f427f6268968e8b4b08976 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 21:50:03 +
Subject:
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/120994
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/TIFitis created
https://github.com/llvm/llvm-project/pull/121001
Add Lowering support for OpenMP mapper field in mapInfoOp.
Depends on #120994.
>From 30611f81421028ccc8fceed006e06f8afc6848b9 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 19:05:30 +
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/120994
>From 002d7153f4029c02722b6a4f45bbde8fad83ba95 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 20:53:47 +
Subject: [PATCH] Add mapper field to mapInfoOp.
---
flang/lib/Lower/OpenMP/Uti
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/120994
>From 0b54cafc829119b931d04d1d9ec3e790e50f7b08 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 19:05:30 +
Subject: [PATCH] Add mapper field to mapInfoOp.
---
flang/lib/Lower/OpenMP/Uti
https://github.com/TIFitis created
https://github.com/llvm/llvm-project/pull/120994
This patch adds the mapper field to the omp.map.info op.
>From 21178b07176869e000f7e027bc5c9593b715b5ad Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Mon, 23 Dec 2024 19:05:30 +
Subject: [PATCH] Add m
TIFitis wrote:
@kiranchandramohan @kparzysz I guess I must be using the name mangler in an
incorrect way then. I've added the code snippets I am using when lowering and
later performing a lookup. Please let me know what would be the correct way of
doing this.
When lowering DeclMapperOp:
```
s
TIFitis wrote:
@kiranchandramohan I discussed the current approach with @skatrak today. When
trying to implement the mapper lowering for the map clause, it became apparent
that we need to add the `declMapperOp` name to the `SymbolTable`. As such, we
would also need to hoist the `declareMapperO
@@ -2701,7 +2701,42 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -2701,7 +2701,42 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
TIFitis wrote:
As @agozillon requested, here's a sample of how Clang lowers declare mapper.
**C Code:**
```
typedef struct {
int *ptr;
int buf_size;
} T;
#pragma omp declare mapper(deep_copy : T abc) map(abc, abc.ptr[ : abc.buf_size])
int main() {
T xyz;
#pragma omp target data map(mapper(
@@ -2701,7 +2701,42 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -2701,7 +2701,42 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -2701,7 +2701,42 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -2701,7 +2701,42 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -2701,7 +2701,42 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -2701,7 +2701,42 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/117046
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2701,7 +2702,39 @@ static void
genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
semantics::SemanticsContext &semaCtx, lower::pft::Evaluation &eval,
const parser::OpenMPDeclareMapperConstruct &declareMapperConstruct) {
- TODO(converter.getC
@@ -21,7 +21,7 @@ subroutine declare_mapper_1
type (my_type2):: t
real :: x, y(nvals)
!$omp declare mapper (my_type :: var) map (var, var%values (1:var%num_vals))
-!CHECK: not yet implemented: OpenMPDeclareMapperConstruct
+!CHECK: not yet impleme
https://github.com/TIFitis approved this pull request.
LGTM :)
https://github.com/llvm/llvm-project/pull/92
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -13,19 +13,22 @@
#include "Utils.h"
#include "Clauses.h"
+#include
+
+#include
#include
+#include
TIFitis wrote:
Are all of the header file changes necessary? Just making sure we only have the
minimal set here.
https://github.com/llvm/llvm-project/p
@@ -2663,6 +2657,8 @@ static llvm::omp::OpenMPOffloadMappingFlags
mapParentWithMembers(
auto mapOp = dyn_cast(mapData.MapClause[mapDataIndex]);
int firstMemberIdx = getMapDataMemberIdx(
mapData, getFirstOrLastMappedMemberPtr(mapOp, true));
+// NOTE/TODO: Sh
https://github.com/TIFitis approved this pull request.
Added couple of nit comments. Otherwise happy with the patch. Thank you for the
amazing work :)
https://github.com/llvm/llvm-project/pull/91
___
llvm-branch-commits mailing list
llvm-branch-co
https://github.com/TIFitis edited
https://github.com/llvm/llvm-project/pull/91
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2468,51 +2468,45 @@ static int getMapDataMemberIdx(MapInfoData &mapData,
omp::MapInfoOp memberOp) {
return std::distance(mapData.MapClause.begin(), res);
}
-static omp::MapInfoOp getFirstOrLastMappedMemberPtr(omp::MapInfoOp mapInfo,
-
https://github.com/TIFitis approved this pull request.
Im happy with the changes. Thanks :)
https://github.com/llvm/llvm-project/pull/109810
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/101707
>From 10f575c3457719e2b21f9633c890c34ae671548e Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Fri, 2 Aug 2024 17:11:21 +0100
Subject: [PATCH] [OpenMP]Update use_device_clause lowering
This patch updates th
@@ -2193,80 +2197,137 @@ llvm::Value *getSizeInBytes(DataLayout &dl, const
mlir::Type &type,
return builder.getInt64(dl.getTypeSizeInBits(type) / 8);
}
-void collectMapDataFromMapVars(MapInfoData &mapData,
- llvm::SmallVectorImpl &mapVars,
-
TIFitis wrote:
Ping for review.
https://github.com/llvm/llvm-project/pull/101707
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2439,7 +2504,7 @@ static llvm::omp::OpenMPOffloadMappingFlags
mapParentWithMembers(
// data by the descriptor (which itself, is a structure containing
// runtime information on the dynamically allocated data).
auto parentClause =
- llvm::cast(mapData.MapClause[m
TIFitis wrote:
@skatrak Thanks for the review, I've addressed the comments in the latest
revision.
https://github.com/llvm/llvm-project/pull/101707
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/TIFitis updated
https://github.com/llvm/llvm-project/pull/101707
>From 547b339b175fa996eef8d45c5df8a73967ee94c2 Mon Sep 17 00:00:00 2001
From: Akash Banerjee
Date: Fri, 2 Aug 2024 17:11:21 +0100
Subject: [PATCH 1/3] [OpenMP]Update use_device_clause lowering
This patch update
@@ -6357,7 +6357,7 @@ OpenMPIRBuilder::InsertPointTy
OpenMPIRBuilder::createTargetData(
// Disable TargetData CodeGen on Device pass.
if (Config.IsTargetDevice.value_or(false)) {
if (BodyGenCB)
- Builder.restoreIP(BodyGenCB(Builder.saveIP(), BodyGenTy::NoPriv));
+
@@ -2193,80 +2197,141 @@ llvm::Value *getSizeInBytes(DataLayout &dl, const
mlir::Type &type,
return builder.getInt64(dl.getTypeSizeInBits(type) / 8);
}
-void collectMapDataFromMapVars(MapInfoData &mapData,
- llvm::SmallVectorImpl &mapVars,
-
1 - 100 of 112 matches
Mail list logo
