On 25 November 2014 at 18:24, Maxim Uvarov maxim.uva...@linaro.org wrote:
Define special name for loop back interface. That interface
can be used mostly for testing. Each implementation can interpret
that loop0 to any other device.
[Alex] A few words about what is expected from this interface
On Tue, 25 Nov 2014 15:04:53 -0600 Bill Fischofer bill.fischo...@linaro.org
wrote:
These functions are scheduled for rework as part of the packet API
revisions. Will be sure to address this point as part of that rework.
Thanks.
If there's a concensus the 'len ODPH_ETH_LEN_MIN' is too
On 26 November 2014 at 09:39, Alexandru Badicioiu
alexandru.badici...@linaro.org wrote:
This patch has no description. The title is not self explanatory either.
Also the existence of eth0 should be verified before mapping the loop0 to
eth0 - some platforms may use other interface names (e.g.
On Wed, Nov 26, 2014 at 11:16 AM, Ola Liljedahl
ola.liljed...@linaro.org wrote:
I think this check is too strict and should be removed.
I remember we had a discussion about this many months ago and already
then I was of the opinion that this check is unnecessary and not very
beneficial.
The
This patch removes Classification APIs which have been deferred from ODP v1.0
The following is the list of the deferred APIs
* odp_cos_set_queue_group
* odp_cos_set_pool
* odp_cos_set_headroom
* odp_cos_flow_set
* odp_cos_flow_is_set
* odp_cos_class_flow_signature
* odp_cos_port_flow_signature
On Mon, Nov 24, 2014 at 9:19 PM, Mike Holmes mike.hol...@linaro.org wrote:
ODP_UNUSED should be used internally to an ODP implementation and not by
an application. The declaration should never have specified ODP_UNUSED for
find_ipsec_cache_entry_out()
Signed-off-by: Mike Holmes
On Wed, Nov 26, 2014 at 12:11 AM, Mike Holmes mike.hol...@linaro.org wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
Just a couple of nits, otherwise you can have my Reviewed-by
---
Add t to ar.bz2
DEPENDENCIES | 18 ++
1 file changed, 14 insertions(+), 4
On Wed, Nov 26, 2014 at 12:29 PM, Ciprian Barbu
ciprian.ba...@linaro.org wrote:
On Wed, Nov 26, 2014 at 12:11 AM, Mike Holmes mike.hol...@linaro.org wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
Just a couple of nits, otherwise you can have my Reviewed-by
---
Add t to ar.bz2
On 11/25/2014 06:54 PM, Mike Holmes wrote:
Taras is submitting a patch that allows you to replace the output stream
for ODP_ERR etc with the applications prefered stream - see
https://mail.google.com/mail/u/1/#inbox/149e780e4e57d70c
Taking into account that ODP_ERR() is not a part of public
On 11/26/2014 12:08 AM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
DEPENDENCIES | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/DEPENDENCIES b/DEPENDENCIES
index f70a1d4..11452ff 100644
--- a/DEPENDENCIES
+++ b/DEPENDENCIES
On 11/26/2014 12:25 PM, Ola Liljedahl wrote:
On 26 November 2014 at 09:39, Alexandru Badicioiu
alexandru.badici...@linaro.org wrote:
This patch has no description. The title is not self explanatory either.
Also the existence of eth0 should be verified before mapping the loop0 to
eth0 - some
Merged, thanks,
Maxim.
On 11/24/2014 10:19 PM, Mike Holmes wrote:
ODP_UNUSED should be used internally to an ODP implementation and not by
an application. The declaration should never have specified ODP_UNUSED for
find_ipsec_cache_entry_out()
Signed-off-by: Mike Holmes mike.hol...@linaro.org
On 11/25/2014 09:06 PM, Mike Holmes wrote:
+++ b/test/validation/.gitignore
@@ -0,0 +1,6 @@
+*.log
+*.trs
+odp_init
+odp_queue
+odp_crypto
+CUnit-Memory-Dump.xml
xml has to be global. It's like core which stores to PWD, not to
directory where binary is located.
Maxim.
On 11/26/2014 01:59 PM, Taras Kondratiuk wrote:
On 11/26/2014 12:08 AM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
DEPENDENCIES | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/DEPENDENCIES b/DEPENDENCIES
index
Reviewed-by: Maxim Uvarov maxim.uva...@linaro.org
On 11/21/2014 03:27 PM, Balasubramanian Manoharan wrote:
This patch contains classification implementation for ODP v1.0.
The salient features of this classification version are as follows:
* Attaches PMR, PMR_SET to a Pktio entry
* Attaches
Merged.
Maxim.
On 11/25/2014 11:44 PM, Mike Holmes wrote:
On 25 November 2014 at 15:38, Ola Liljedahl ola.liljed...@linaro.org
mailto:ola.liljed...@linaro.org wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
mailto:ola.liljed...@linaro.org
Reviewed-and-tested-by:
But independent from this, OVS should overwrite the log function, right?
So ODP internal log messages won't be lost.
Regards,
Zoli
On 26/11/14 10:47, Taras Kondratiuk wrote:
On 11/25/2014 06:54 PM, Mike Holmes wrote:
Taras is submitting a patch that allows you to replace the output stream
On 11/26/2014 02:54 PM, Zoltan Kiss wrote:
But independent from this, OVS should overwrite the log function, right?
So ODP internal log messages won't be lost.
Right.
I assume it should direct log messages into its own logging subsystem.
___
lng-odp
On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote:
On 11/26/2014 12:25 PM, Ola Liljedahl wrote:
On 26 November 2014 at 09:39, Alexandru Badicioiu
alexandru.badici...@linaro.org wrote:
This patch has no description. The title is not self explanatory either.
Also the existence of
On 26 November 2014 at 15:23, Jerin Jacob jerin.ja...@caviumnetworks.com
wrote:
On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote:
On 11/26/2014 12:25 PM, Ola Liljedahl wrote:
On 26 November 2014 at 09:39, Alexandru Badicioiu
alexandru.badici...@linaro.org wrote:
This patch
On 11/26/2014 03:23 PM, Jerin Jacob wrote:
On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote:
On 11/26/2014 12:25 PM, Ola Liljedahl wrote:
On 26 November 2014 at 09:39, Alexandru Badicioiu
alexandru.badici...@linaro.org wrote:
This patch has no description. The title is not self
On 11/26/2014 04:33 PM, Taras Kondratiuk wrote:
On 11/26/2014 03:23 PM, Jerin Jacob wrote:
On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote:
On 11/26/2014 12:25 PM, Ola Liljedahl wrote:
On 26 November 2014 at 09:39, Alexandru Badicioiu
alexandru.badici...@linaro.org wrote:
This
On Wed, Nov 26, 2014 at 05:05:14PM +0300, Maxim Uvarov wrote:
On 11/26/2014 04:33 PM, Taras Kondratiuk wrote:
On 11/26/2014 03:23 PM, Jerin Jacob wrote:
On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote:
On 11/26/2014 12:25 PM, Ola Liljedahl wrote:
On 26 November 2014 at 09:39,
On 11/26/2014 04:05 PM, Maxim Uvarov wrote:
On 11/26/2014 04:33 PM, Taras Kondratiuk wrote:
On 11/26/2014 03:23 PM, Jerin Jacob wrote:
On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote:
On 11/26/2014 12:25 PM, Ola Liljedahl wrote:
On 26 November 2014 at 09:39, Alexandru Badicioiu
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/.gitignore | 1 +
test/validation/Makefile.am | 4 +-
test/validation/odp_system.c | 114 +++
3 files changed, 118 insertions(+), 1 deletion(-)
create mode 100644
On 24 November 2014 at 05:38, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/21/2014 10:23 PM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
testing.dox | 7 +++
1 file changed, 7 insertions(+)
diff --git a/testing.dox b/testing.dox
index
Running under Linux these tests are redundant since the OS takes care of
it. On SoCs the I/O HW will normally flag runt packets anyway so again
this is unnecessary. It will be deleted along with the parser changes
needed for the new packet APIs. An intermediate patch is fine but would be
short
On Wed, Nov 26, 2014 at 04:32:43PM +0200, Taras Kondratiuk wrote:
On 11/26/2014 04:05 PM, Maxim Uvarov wrote:
On 11/26/2014 04:33 PM, Taras Kondratiuk wrote:
On 11/26/2014 03:23 PM, Jerin Jacob wrote:
On Wed, Nov 26, 2014 at 02:53:50PM +0300, Maxim Uvarov wrote:
On 11/26/2014 12:25 PM, Ola
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/odp_queue.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/platform/linux-generic/odp_queue.c
b/platform/linux-generic/odp_queue.c
index 1318bcd..f44aba0 100644
---
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/api/odp_queue.h |9 +
1 file changed, 9 insertions(+)
diff --git a/platform/linux-generic/include/api/odp_queue.h
b/platform/linux-generic/include/api/odp_queue.h
index b8ac4bb..3321950
On 26 November 2014 at 12:03, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
platform/linux-generic/include/api/odp_queue.h |9 +
1 file changed, 9 insertions(+)
diff --git
Define API for mac address change and implement linux-generic version.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 23
platform/linux-generic/odp_packet_io.c | 67 ++
2 files changed, 90
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 164
2 files changed, 167 insertions(+), 1 deletion(-)
create mode 100644
Mac address unit test.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/odp_pktio.c | 46 +
1 file changed, 46 insertions(+)
diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c
index 56fece9..c3eb65b 100644
Define API and implement promisc functions for linux-generic.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 24 +++
platform/linux-generic/odp_packet_io.c | 74 ++
2 files changed, 98 insertions(+)
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
I started from scratch this time trying to follow the list Taras proposed. This
patch covers the first 4 bullets on his lists.
One thing I need to mention is that the schedule_mq_mt_prio_atomic would not
work (at least on linux-generic)
On 26 November 2014 at 09:31, Maxim Uvarov maxim.uva...@linaro.org wrote:
Define API for mac address change and implement linux-generic version.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 23
The API require guide lines to help it conform to a consistent look and feel.
These additional clarifications help promote those guidelines.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
api_guide_lines.dox | 30 +-
1 file changed, 25 insertions(+), 5
Improve the documentation regarding possible return values.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/include/api/odp_system_info.h | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git
Hi,
It seems packet parsing in Linux implementation fails to analyze VLAN
frames (on most recent Linux systems).
The implementation of 'odp_packet_parse' relies on frame's ethtype field
to be either 0x8100 or 0x88A8 (i.e 802.1q and 802.1ad) for
identification of vlan frames.
Problem is, Linux
I disprove of this patch.
On 26 November 2014 at 20:20, Mike Holmes mike.hol...@linaro.org wrote:
Improve the documentation regarding possible return values.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/include/api/odp_system_info.h | 19 ++-
On 26 November 2014 at 15:23, Ola Liljedahl ola.liljed...@linaro.org
wrote:
I disprove of this patch.
On 26 November 2014 at 20:20, Mike Holmes mike.hol...@linaro.org wrote:
Improve the documentation regarding possible return values.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
On 11/26/2014 09:00 PM, Victor Kamensky wrote:
On 26 November 2014 at 09:31, Maxim Uvarov maxim.uva...@linaro.org wrote:
Define API for mac address change and implement linux-generic version.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
On 26 November 2014 at 13:19, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/26/2014 09:00 PM, Victor Kamensky wrote:
On 26 November 2014 at 09:31, Maxim Uvarov maxim.uva...@linaro.org
wrote:
Define API for mac address change and implement linux-generic version.
Signed-off-by: Maxim
On 11/27/2014 12:43 AM, Victor Kamensky wrote:
On 26 November 2014 at 13:19, Maxim Uvarov maxim.uva...@linaro.org wrote:
On 11/26/2014 09:00 PM, Victor Kamensky wrote:
On 26 November 2014 at 09:31, Maxim Uvarov maxim.uva...@linaro.org
wrote:
Define API for mac address change and implement
On 11/26/2014 11:23 PM, Shmulik Ladkani wrote:
Hi,
It seems packet parsing in Linux implementation fails to analyze VLAN
frames (on most recent Linux systems).
The implementation of 'odp_packet_parse' relies on frame's ethtype field
to be either 0x8100 or 0x88A8 (i.e 802.1q and 802.1ad) for
Why is all of this junk always printed by ODP applications?
odp_buffer_pool.c:137:odp_buffer_pool_init_global():
Buffer pool init global
odp_buffer_pool.c:138:odp_buffer_pool_init_global(): pool_entry_s size 192
odp_buffer_pool.c:139:odp_buffer_pool_init_global(): pool_entry_t size 192
Already fixed. Do git pull.
Maxim.
On 11/27/2014 01:45 AM, Ola Liljedahl wrote:
Why is all of this junk always printed by ODP applications?
odp_buffer_pool.c:137:odp_buffer_pool_init_global():
Buffer pool init global
odp_buffer_pool.c:138:odp_buffer_pool_init_global(): pool_entry_s size
Ping
On 26 November 2014 at 11:07, Bala Manoharan bala.manoha...@linaro.org
wrote:
Hi,
Pls let me know if there are any additional comments for this patch.
If otherwise please provide reviewed-by
Regards,
Bala
On 25 November 2014 03:24, Anders Roxell anders.rox...@linaro.org wrote:
On
This patch adds TCP header description struct odph_tcphdr_t
This structure is used for accessing TCP header information from the packet
Signed-off-by: Balasubramanian Manoharan bala.manoha...@linaro.org
---
V2: Removes Bit Fields from Header struct
helper/include/odph_tcp.h | 90
50 matches
Mail list logo
