On 11/29/2014 10:43 AM, Yan Sonming wrote:
diff --git a/test/validation/common/odp_cunit_common.h
b/test/validation/common/odp_cunit_common.h
new file mode 100644
index 000..5eec376
--- /dev/null
+++ b/test/validation/common/odp_cunit_common.h
@@ -0,0 +1,35 @@
+/* Copyright (c) 2014, Linaro
Wasn't there some discussion a while ago that the ODP test program
expects buffer enqueue operations to be instantaneous (the buffer can
immediately be popped or scheduled) while HW queue implementations
likely will have some latency before the buffer becomes visible again.
-- Ola
On 30
I would like to understand the ODP _application_ expectation with ODP
pull(odp_schedule()) and push(polled queues) execution model.
Is it expected that a confirming ODP platform implementation need to support
both models ?
or at least one model shall be supported by confirming ODP platform
It's OK, Thanks for update this patch.
yan.songm...@linaro.org
From: Taras Kondratiuk
Date: 2014-12-01 18:23
To: Yan Songming; lng-odp
Subject: Re: [lng-odp] [PATCH v1] validation: queue: use CU_register_suites()
for tests registration
I've addressed this in RFC:
Hi,
Both have their use cases in application architecture (dynamic load balancing
vs. fixed pipelining) and support is needed on both platforms. It depends on
the application which model suites the best. In addition a schedule() driven
application can use poll queues as internal storage, etc.
On 12/01/2014 01:58 PM, Maxim Uvarov wrote:
Taras, I think you need to send your patch without RFC.
Yan, please provide your reviewed-by to Taras patch series.
It is RFC, because depends in Yan's shm test patch in-flight.
I'll repost it after Yan's patch is merged.
Yan, please provide your reviewed-by to Taras patch series.
So , Maybe i should provide my reviewed-by when Taras repost.
yan.songm...@linaro.org
From: Taras Kondratiuk
Date: 2014-12-01 20:07
To: Maxim Uvarov; yan.songm...@linaro.org; lng-odp
Subject: Re: [lng-odp] [PATCH v1] validation:
The real answer would seem to be that there should be a wait option on
odp_queue_deq() that doesn't return until a buffer is available for
dequeue. That's a fairly natural means of using queues as a
synchronization mechanism. Busy waiting on a queue seems wasteful whether
or not we call it a
On 1 December 2014 at 13:30, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
Hi,
This change degrades ticketlock performance. The cur_ticket variable does not
need atomic add functionality, since it's written only from within the lock.
Only correct barrier enforcement is
Hi,
This is why lock (and lock free algorithm) implementation abstraction has low
value. It's hard to find a single abstraction that is optimal for all HW
architectures - a few C lines arranged differently may cause major performance
impact. E.g. the kernel ticketlock for x86 packs both those
Isn't that a question of implementation rather than API definition? The
APIs are useful. It's the responsibility for each implementation to
realize those APIs optimally for its platform. The alternative is to push
that responsibility onto the application, which defeats the portability
goals of
Implementation abstraction == usage of odp_atomic_internal.h in the
implementation.
-Petri
From: ext Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Monday, December 01, 2014 3:18 PM
To: Savolainen, Petri (NSN - FI/Espoo)
Cc: ext Ola Liljedahl; lng-odp@lists.linaro.org
Subject: Re:
On 1 December 2014 at 14:14, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
Hi,
This is why lock (and lock free algorithm) implementation abstraction has low
value.
I can't agree with that. Using higher level abstraction and
programming model makes it much easier to write
I agree with that approach. Getting things correct first is the most
important. Getting the wrong answer quickly isn't terribly useful. :)
On Mon, Dec 1, 2014 at 8:43 AM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
On 1 December 2014 at 14:25, Bill Fischofer bill.fischo...@linaro.org
-Original Message-
From: ext Ciprian Barbu [mailto:ciprian.ba...@linaro.org]
Sent: Friday, November 28, 2014 5:18 PM
To: Savolainen, Petri (NSN - FI/Espoo)
Cc: lng-odp
Subject: [lng-odp] scheduler: question about testing ATOMIC queues
Hi,
I was looking at how to validate
In case of stdin is not attached socket() can return 0 for valid
socket fd. Not initialized socket has to be -1.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 164
2 files changed, 167 insertions(+), 1 deletion(-)
create mode 100644
Socket can be 0 and it's accounted in previews patch. Correct that function too.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/platform/linux-generic/odp_packet_io.c
Use special device for cunit tests. Named as loop odp pktio dev.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/odp_pktio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c
index
Define special name for loop back interface. That interface
can be used mostly for testing. Each implementation can interpret
that loop to any other device.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 4
1 file changed, 4
On 12/01/2014 03:56 PM, Mike Holmes wrote:
ping
That was merged:
b12c332 .gitignore: distribute the ignore file to sub dirs
Maxim.
On 26 November 2014 at 08:41, Taras Kondratiuk
taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote:
On 11/26/2014 03:35 PM, Mike Holmes
On 1 December 2014 at 14:27, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
Lock free algorithms do re-tries and in addition there seems to be atomic
Taking locks (e.g. spin locks) also involve retries (on x86, looping
on the return value of a locked xchg instruction). It is
I want my gcc to catch such things also.
Are you using gcc?
mine is:
gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-2ubuntu1~12.04)
Maxim.
On 12/01/2014 06:14 PM, Anders Roxell wrote:
On 2014-12-01 17:08, Maxim Uvarov wrote:
v3: - socket() 0 is valid descr, so init it to -1.
- use
On 27 November 2014 at 05:01, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
On 11/26/2014 10:13 PM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
api_guide_lines.dox | 6 ++
1 file changed, 6 insertions(+)
diff --git a/api_guide_lines.dox
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
api_guide_lines.dox | 5 +
1 file changed, 5 insertions(+)
diff --git a/api_guide_lines.dox b/api_guide_lines.dox
index be23e9a..4cfe088 100644
--- a/api_guide_lines.dox
+++ b/api_guide_lines.dox
@@ -144,6 +144,11 @@ The values !0 =
On 2014-12-01 17:08, Maxim Uvarov wrote:
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 164
2 files changed, 167
Define API and implement promisc functions for linux-generic.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 24 +++
platform/linux-generic/odp_packet_io.c | 74 ++
2 files changed, 98 insertions(+)
Define API for mac address change and implement linux-generic version.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 25
platform/linux-generic/include/api/odp_std_types.h | 2 +
platform/linux-generic/odp_packet_io.c
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 164
2 files changed, 167 insertions(+), 1 deletion(-)
create mode 100644
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/odp_pktio.c | 50 ++---
1 file changed, 24 insertions(+), 26 deletions(-)
diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c
index 67dd8d0..cfdf3f8 100644
---
v4: - fixed array size;
- use CU_register_suites(suites);
- more consistent checks in test file;
v3: - socket() 0 is valid descr, so init it to -1.
- use ssize_t type to return readable return codes.
- use standard errno codes for failures;
v2:
In
Update return codes to readable values.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 16 +++-
platform/linux-generic/odp_packet_io.c | 20 ++--
2 files changed, 17 insertions(+), 19
Socket can be 0 and it's accounted in previews patch. Correct that function too.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/platform/linux-generic/odp_packet_io.c
In case of stdin is not attached socket() can return 0 for valid
socket fd. Not initialized socket has to be -1.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 3 +++
1 file changed, 3 insertions(+)
diff --git
Mac address unit test.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/odp_pktio.c | 53 +
1 file changed, 53 insertions(+)
diff --git a/test/validation/odp_pktio.c b/test/validation/odp_pktio.c
index edbf0c9..9f3cb40 100644
Implement pktio device loop device suitable for testing.
Note: lo0 can not be used. Instead of it first upped device
is used.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/odp_packet_io.c | 60 ++
1 file changed, 60 insertions(+)
On 11/27/2014 11:39 AM, Stuart Haslam wrote:
queue_to_qentry doesn't do any validation of the queue handle so will
never return NULL and ends up returning an invalid pointer if passed
ODP_QUEUE_INVALID.
Reviewed-by: Taras Kondratiuk taras.kondrat...@linaro.org
This patch has been superseded and is withdrawn.
On Sat, Nov 22, 2014 at 5:04 PM, Bill Fischofer bill.fischo...@linaro.org
wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
Merge parts 1, 2, and 3 of this patch after review.
.../linux-generic/include/api/odp_buffer_pool.h
This patch has been superseded and is withdrawn.
On Sat, Nov 22, 2014 at 5:04 PM, Bill Fischofer bill.fischo...@linaro.org
wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
Merge parts 1, 2, and 3 of this patch after review.
On 11/27/2014 11:38 AM, Stuart Haslam wrote:
In ODP_PACKET_SOCKET_MMSG or ODP_PACKET_SOCKET_BASIC modes, when the
same interface is opened multiple times an attempt is made to use a
single socket descriptor for all instances. There are a few issues with
the implementation though;
- a
Most of test application will have the same main function.
Move main() from odp_shm to a common place where it can be reused by
other test applications.
Unifying main() will also simplify transition to a combined single test
application in future.
Signed-off-by: Taras Kondratiuk
Avoid duplicating the same code by using a common main() function
in most of test applications.
Taras Kondratiuk (5):
validation: shm: move main() to a common place
validation: common: add tests_global_init() function
validation: queue: reuse common main() function
validation: crypto:
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/Makefile.am |2 +-
test/validation/odp_queue.c | 53 ---
2 files changed, 10 insertions(+), 45 deletions(-)
diff --git a/test/validation/Makefile.am
Signed-off-by: Taras Kondratiuk taras.kondrat...@linaro.org
---
test/validation/Makefile.am |2 +-
test/validation/odp_crypto.c | 43 ++
2 files changed, 7 insertions(+), 38 deletions(-)
diff --git a/test/validation/Makefile.am
On 01/12/14 16:15, Maxim Uvarov wrote:
Define API and implement promisc functions for linux-generic.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
platform/linux-generic/include/api/odp_packet_io.h | 24 +++
platform/linux-generic/odp_packet_io.c | 74
On 2014-11-26 13:05, Mike Holmes wrote:
The API require guide lines to help it conform to a consistent look and feel.
These additional clarifications help promote those guidelines.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
Applied!
On 1 December 2014 at 12:05, Taras Kondratiuk taras.kondrat...@linaro.org
wrote:
Most of test application will have the same main function.
Move main() from odp_shm to a common place where it can be reused by
other test applications.
Unifying main() will also simplify transition to a combined
On 2014-12-01 19:15, Maxim Uvarov wrote:
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 164
2 files changed, 167
On 27 November 2014 at 18:54, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
odp_atomic_internal.h is updated with operations (e.g.
On 29 November 2014 at 17:42, Anders Roxell anders.rox...@linaro.org
wrote:
Signed-off-by: Anders Roxell anders.rox...@linaro.org
Reviewed-and-tested-by: Mike Holmes mike.hol...@linaro.org
---
configure.ac | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure.ac
Drop for v1.0 APIs
You introduced some warnings that we didn't have:
odp_config.h:55: warning: Member ODP_CONFIG_BUF_MAX_SIZE (macro definition) of
group odp_compiler_optim is not documented.
odp_config.h:55: warning: Member ODP_CONFIG_BUF_MAX_SIZE (macro definition) of
group odp_compiler_optim
On 24 November 2014 at 11:01, Anders Roxell anders.rox...@linaro.org
wrote:
Signed-off-by: Anders Roxell anders.rox...@linaro.org
Reviewed-and-tested-by: Mike Holmes mike.hol...@linaro.org
---
configure.ac | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
On 24 November 2014 at 11:01, Anders Roxell anders.rox...@linaro.org
wrote:
Signed-off-by: Anders Roxell anders.rox...@linaro.org
Reviewed-and-tested-by: Mike Holmes mike.hol...@linaro.org
---
configure.ac| 29 -
test/validation/Makefile.am |
On 24 November 2014 at 11:01, Anders Roxell anders.rox...@linaro.org
wrote:
Signed-off-by: Anders Roxell anders.rox...@linaro.org
Reviewed-and-tested-by: Mike Holmes mike.hol...@linaro.org
---
configure.ac | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure.ac
Just as an FYI, when I add a thread-local buffer cache to the new patch the
numbers for odp_example are reduced to this:
Thread 1 starts on core 1
Thread 2 starts on core 0
[1] alloc_sng alloc+free 67 cycles, 19 ns
[2] alloc_sng alloc+free 72 cycles, 21 ns
[1] alloc_multi alloc+free 87
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/.gitignore | 1 +
test/validation/Makefile.am | 4 +-
test/validation/odp_system.c | 114 +++
3 files changed, 118 insertions(+), 1 deletion(-)
create mode 100644
Should have been v2
On 1 December 2014 at 16:28, Mike Holmes mike.hol...@linaro.org wrote:
On 24 November 2014 at 11:01, Anders Roxell anders.rox...@linaro.org
wrote:
Signed-off-by: Anders Roxell anders.rox...@linaro.org
Reviewed-and-tested-by: Mike Holmes mike.hol...@linaro.org
---
On 12/01/2014 10:20 PM, Anders Roxell wrote:
On 2014-12-01 19:15, Maxim Uvarov wrote:
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
test/validation/odp_pktio.c | 164
On 12/01/2014 10:48 PM, Anders Roxell wrote:
On 2014-12-01 19:15, Maxim Uvarov wrote:
v4: - fixed array size;
- use CU_register_suites(suites);
- more consistent checks in test file;
v3: - socket() 0 is valid descr, so init it to -1.
- use ssize_t type to return
On 2014-11-26 19:51, Ciprian Barbu wrote:
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
I started from scratch this time trying to follow the list Taras proposed.
This
patch covers the first 4 bullets on his lists.
One thing I need to mention is that the
On 1 December 2014 at 01:16, Yan Sonming yan.songm...@linaro.org wrote:
Add odp_version.c to test api of odp_version.h.
Signed-off-by: Yan Songming yan.songm...@linaro.org
---
test/validation/.gitignore| 1 +
test/validation/Makefile.am | 4 ++-
test/validation/odp_version.c | 70
On 2014-12-02 01:07, Maxim Uvarov wrote:
On 12/01/2014 10:20 PM, Anders Roxell wrote:
On 2014-12-01 19:15, Maxim Uvarov wrote:
Add basic check for mtu and promisc modes.
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/Makefile.am | 4 +-
On 2014-12-01 19:15, Maxim Uvarov wrote:
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/odp_pktio.c | 50
++---
1 file changed, 24 insertions(+), 26 deletions(-)
diff --git a/test/validation/odp_pktio.c
When I run the version of checkpatch that's part of odp.git I get this:
bill@Ubuntu13:~/linaro/v10bufpool$ ./scripts/checkpatch.pl *.patch
total: 0 errors, 0 warnings, 0 checks, 2392 lines checked
NOTE: Ignored message types: DEPRECATED_VARIABLE NEW_TYPEDEFS
On 2 December 2014 at 01:15, Bill Fischofer bill.fischo...@linaro.org wrote:
When I run the version of checkpatch that's part of odp.git I get this:
bill@Ubuntu13:~/linaro/v10bufpool$ ./scripts/checkpatch.pl *.patch
total: 0 errors, 0 warnings, 0 checks, 2392 lines checked
NOTE: Ignored
65 matches
Mail list logo
