On 2014-12-09 17:56, Mike Holmes wrote:
Has checkpatch issues
Using patch:
/home/mike/incoming/lng-odp_PATCH_3-3_test_odp_timer.h_cunit_test.mbox
git am
/home/mike/incoming/lng-odp_PATCH_3-3_test_odp_timer.h_cunit_test.mbox
Patch applied, building...
WARNING: line over 80 characters
On 10 December 2014 at 09:13, Anders Roxell anders.rox...@linaro.org wrote:
On 2014-12-09 17:56, Mike Holmes wrote:
Has checkpatch issues
Using patch:
/home/mike/incoming/lng-odp_PATCH_3-3_test_odp_timer.h_cunit_test.mbox
git am
On 9 December 2014 at 17:48, Robbie King (robking) robk...@cisco.com wrote:
After cloning tip just now, I found that I couldn’t build the fresh
workspace due to having GCC 4.6.3 (the C11 changes to the atomics
bumps minimum GCC up to 4.8 as best I can tell). I’m not very familiar
GCC 4.7
On 9 December 2014 at 18:17, Bill Fischofer bill.fischo...@linaro.org wrote:
I suggest we turn on that by default. It's the one way to ensure that the
issues will get fixed. Is this a stop-on-first-error situation or can we
have it carry on so we get a complete list of what the c99 issues
On Wed, Dec 10, 2014 at 11:59 AM, Ciprian Barbu
ciprian.ba...@linaro.org wrote:
On Tue, Dec 9, 2014 at 4:16 PM, Ciprian Barbu ciprian.ba...@linaro.org
wrote:
On Tue, Dec 9, 2014 at 3:46 PM, Savolainen, Petri (NSN - FI/Espoo)
petri.savolai...@nsn.com wrote:
After the minor documentation
On 12/10/2014 08:32 AM, Bill Fischofer wrote:
Just as an FYI, I took a stab at classifying the issues with std=c99.
The root issue is that c99 is more than just a C language issue--it
also implies that you're restricted to using the standard C library
,and most of the examples (and
On Tue, Dec 9, 2014 at 7:53 PM, Bill Fischofer
bill.fischo...@linaro.org wrote:
If you've already received the packet there's not much point in classifying
it since the output of classification is the queue that the packet should be
sent to (and the buffer pool it should be stored in for
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
Implemented the missing odp_ticketlock_trylock().
platform/linux-generic/odp_ticketlock.c | 30 ++
1 file
On 10 December 2014 at 11:18, Ciprian Barbu ciprian.ba...@linaro.org wrote:
On Wed, Dec 10, 2014 at 11:59 AM, Ciprian Barbu
ciprian.ba...@linaro.org wrote:
On Tue, Dec 9, 2014 at 4:16 PM, Ciprian Barbu ciprian.ba...@linaro.org
wrote:
On Tue, Dec 9, 2014 at 3:46 PM, Savolainen, Petri (NSN -
I have some classification API questions:
1.A packet that was classified on a pmr or pmr_set would finally reach a
target cos which will be translated in a queue or
a queue group that will be scheduled by the scheduler (frame ordering being
insured if the queue is synched ATOMIC or
On Wed, Dec 10, 2014 at 12:54:38PM +0200, Ciprian Barbu wrote:
On Tue, Dec 9, 2014 at 7:53 PM, Bill Fischofer
bill.fischo...@linaro.org wrote:
If you've already received the packet there's not much point in classifying
it since the output of classification is the queue that the packet should
Hi Ola, I don't think ODP necessarily needs to support
older versions of GCC, but if the GCC configure finds
is not compatible it would be nice to fail then as opposed
to cryptic build failures.
-Original Message-
From: Ola Liljedahl [mailto:ola.liljed...@linaro.org]
Sent: Wednesday,
The buffer being returned shouldn't be enqueued as this will cause it to
be returned again on the next dequeue, by which point it may have been
freed via the returned reference.
Signed-off-by: Stuart Haslam stuart.has...@arm.com
---
(This code contribution is provided under the terms of agreement
On 10 December 2014 at 13:46, Robbie King (robking) robk...@cisco.com wrote:
Hi Ola, I don't think ODP necessarily needs to support
older versions of GCC, but if the GCC configure finds
is not compatible it would be nice to fail then as opposed
to cryptic build failures.
OK. Because I could
Patch set is merged,
Thanks!
Maxim.
On 12/08/2014 03:02 PM, Balasubramanian Manoharan wrote:
Adds TCP header description struct odph_tcphdr_t in helper directory.
This structure is used for accessing TCP header information from the packet
Signed-off-by: Balasubramanian Manoharan
On Tue, Dec 9, 2014 at 8:09 PM, Victor Kamensky
victor.kamen...@linaro.org wrote:
On 9 December 2014 at 09:44, Maxim Uvarov maxim.uva...@linaro.org wrote:
Define API to get MAC address for specific packet i/o and
implement linux-generic version.
Signed-off-by: Maxim Uvarov
On Tue, Dec 09, 2014 at 08:05:27PM +, Mike Holmes wrote:
Works around https://bugs.linaro.org/show_bug.cgi?id=975
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/Makefile.am | 4
1 file changed, 4 insertions(+)
diff --git a/test/validation/Makefile.am
On Wed, Dec 10, 2014 at 4:55 AM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
Signed-off-by: Ola Liljedahl ola.liljed...@linaro.org
Reviewed-by: Bill Fischofer bill.fischo...@linaro.org
---
(This document/code contribution attached is provided under the terms of
agreement LES-LTM-21309)
On 8 December 2014 at 09:58, Maxim Uvarov maxim.uva...@linaro.org wrote:
Add cunit tests for new pktio api:
- MAC address get;
- Promisc mode set / test;
- MTU value set / get;
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
test/validation/.gitignore | 3 +-
Merged!
Thanks Simon. Hope to see next products on ODP ;)
Maxim.
On 12/09/2014 11:15 AM, Simon Kågström wrote:
When building with --std=c++0x or --std=c++11, you will otherwise get
this warning:
C++11 requires a space between literal and identifier [-Wliteral-suffix]
Signed-off-by: Robbie King robk...@cisco.com
---
.../linux-generic/include/odp_crypto_internal.h| 2 +
platform/linux-generic/odp_crypto.c| 98 ++
2 files changed, 83 insertions(+), 17 deletions(-)
diff --git
Merged,
thanks,
Maxim.
On 12/09/2014 12:02 AM, Mike Holmes wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/api_test/odp_ring_test.c | 3 ++-
test/api_test/odp_shm_test.c | 3 ++-
test/api_test/odp_timer_ping.c | 3 ++-
3 files changed, 6 insertions(+), 3 deletions(-)
On Tue, Dec 09, 2014 at 10:27:51PM +, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v3 of this patch incorporates the following changes based on
review comments by Petri and Stuart
- Remove use of typeof for C99 compliance
- Use intmax_t instead of
Agreed, this is one of the exceptions.
On 10 December 2014 at 04:22, Ola Liljedahl ola.liljed...@linaro.org
wrote:
On 10 December 2014 at 09:13, Anders Roxell anders.rox...@linaro.org
wrote:
On 2014-12-09 17:56, Mike Holmes wrote:
Has checkpatch issues
Using patch:
On Tue, Dec 9, 2014 at 11:24 PM, Mike Holmes mike.hol...@linaro.org wrote:
Need to add .gitignore odp_schedule
comments inline below
On 9 December 2014 at 07:49, Ciprian Barbu ciprian.ba...@linaro.org wrote:
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
v2:
- rebased
The merge conflict with the classification code was well know before. Now
that it's been merged I'll resolve this as part of the v4 patch I'll post
today. Getting these various conflicts resolved will happen as part of the
merge process.
The agreed-to sequence is:
- classifier
- buffers/packets
Rather than having a list of privileged code that gets special
exceptions, why not just increase the checkpatch line length limit beyond
the arbitrary 80-char limit? We're not coding on punch cards any more. :)
Raising the limit to say 100 chars would eliminate the vast majority of
these
This fixes https://bugs.linaro.org/show_bug.cgi?id=714
Signed-off-by: Alexandru Badicioiu alexandru.badici...@linaro.org
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
This extends a prvious patch from Alex to cover all the cases. With this patch
Coverity no longer produces warnings.
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
v3:
- changes after Mike's review
- removed duplicate check of end of test in schedule_common_
v2:
- rebased against ODP tip
- fixed some bugs
- added some defines to clearly see the testcase parameters
test/validation/Makefile.am
On 10 December 2014 at 17:33, Mike Holmes mike.hol...@linaro.org wrote:
Agreed, this is one of the exceptions.
It should be possible to fix checkpatch so that it does not warn for
too long lines when that line is a string constant.
I could remove some of the indentation but I assume checkpatch
On 10 December 2014 at 11:58, Bill Fischofer bill.fischo...@linaro.org
wrote:
Rather than having a list of privileged code that gets special
exceptions,
I don't think it is privileged, but as checkpatch docs say, if you have a
good case for ignoring a guideline in a given case - ok
why not
snip
.
+
+ for (i = 0; i prios; i++) {
+ odp_queue_param_t p;
+ p.sched.prio = i;
+ p.sched.group = ODP_SCHED_GROUP_DEFAULT;
+
+ for (j = 0; j QUEUES_PER_PRIO; j++) {
+ /* Per sched sync
Earlier the debates were pure philosophy. We now have a substantial body
of code and that sleek and stylish 80-char straightjacket is a lot less
comfortable for daily wear than it may have looked on the rack before we
bought it.
Even a bump to 85 would be a welcome relief. 100 or 132 would be
On Tue, Dec 09, 2014 at 10:28:09PM +, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v2 reflects review comments by Stuart
- Correct miscelaneous errors in packet parser
example/generator/odp_generator.c | 82 +-
Currently a test can fail tests_gloabl_init without indicating to the user.
This patch ensures that an indication is always given via stdout.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
test/validation/common/odp_cunit_common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
On Tue, Dec 09, 2014 at 10:28:09PM +, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v2 reflects review comments by Stuart
- Correct miscelaneous errors in packet parser
example/generator/odp_generator.c | 82 +-
I believe you are correct. But another notch on your debugging gun. :)
On Wed, Dec 10, 2014 at 12:42 PM, Stuart Haslam stuart.has...@arm.com
wrote:
On Tue, Dec 09, 2014 at 10:28:09PM +, Bill Fischofer wrote:
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v2 reflects
There are a few other places where this issue arises in similar packet
calls. I'll address them all in v3. Thanks.
On Wed, Dec 10, 2014 at 12:51 PM, Bill Fischofer bill.fischo...@linaro.org
wrote:
I believe you are correct. But another notch on your debugging gun. :)
On Wed, Dec 10, 2014
Move remaining API macros that were tagged @internal to the internal
header file.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/include/api/odp_align.h | 44 --
.../linux-generic/include/odp_align_internal.h | 21 +++
2 files
ping
On 1 December 2014 at 10:35, Mike Holmes mike.hol...@linaro.org wrote:
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
api_guide_lines.dox | 5 +
1 file changed, 5 insertions(+)
diff --git a/api_guide_lines.dox b/api_guide_lines.dox
index be23e9a..4cfe088 100644
---
On 10 December 2014 at 19:40, Bill Fischofer bill.fischo...@linaro.org wrote:
Good point on the parser since it's validating as well as parsing the
packet. I'll add those checks in v3. For the other case, these are ODP
owned and maintained data structures and are assumed to be valid. In
I think odp_syne would be better as odp_sync throughout the patch
Does Barrys patch cover atomics in an overlapping way, or do we have both
as separate suites ? I think this one is much more sunny day as we had
originally planned.
Mario were you able to make the final changes to create a patch
Patch does not describe why the loop needed fixing, the message also does
not indicate if it was an example, test or implementation change.
On 8 December 2014 at 09:58, Maxim Uvarov maxim.uva...@linaro.org wrote:
Signed-off-by: Maxim Uvarov maxim.uva...@linaro.org
---
Since these are internal APIs I'd rather do the checking in the called
routine once rather than having every caller clutter the code with
asserts. But point taken.
On Wed, Dec 10, 2014 at 1:34 PM, Ola Liljedahl ola.liljed...@linaro.org
wrote:
On 10 December 2014 at 19:40, Bill Fischofer
Skip that patch.
Maxim.
Исходное сообщение
От: Mike Holmes mike.hol...@linaro.org
Дата:10.12.2014 23:13 (GMT+03:00)
Кому: Maxim Uvarov maxim.uva...@linaro.org
Копия: lng-odp lng-odp@lists.linaro.org
Тема: Re: [lng-odp] [PATCH] fix loop
Patch does not describe why the
This assert is used in the public API but is not intended for use in
applications and so it is marked with an underscore.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
The checkpatch warning for camel case cannot be avoided, the offending
function is defined externally to ODP.
#145:
On Wed, Dec 10, 2014 at 09:49:46PM +, Mike Holmes wrote:
This assert is used in the public API but is not intended for use in
applications and so it is marked with an underscore.
Any reason not to also move it to odp_debug_internal.h so that it can't
be used externally?
--
Stuart.
Specify more clearly the behaviour of the function.
Signed-off-by: Mike Holmes mike.hol...@linaro.org
---
platform/linux-generic/include/api/odp_system_info.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/platform/linux-generic/include/api/odp_system_info.h
On 10 December 2014 at 16:58, Stuart Haslam stuart.has...@arm.com wrote:
On Wed, Dec 10, 2014 at 09:49:46PM +, Mike Holmes wrote:
This assert is used in the public API but is not intended for use in
applications and so it is marked with an underscore.
Any reason not to also move it
On Wed, Dec 10, 2014 at 09:58:23PM +, Stuart Haslam wrote:
On Wed, Dec 10, 2014 at 09:49:46PM +, Mike Holmes wrote:
This assert is used in the public API but is not intended for use in
applications and so it is marked with an underscore.
Any reason not to also move it to
On 12/10/2014 10:42 PM, Mike Holmes wrote:
+#include CUnit/TestDB.h
CUnit/TestDB.h
___
lng-odp mailing list
lng-odp@lists.linaro.org
http://lists.linaro.org/mailman/listinfo/lng-odp
On 12/10/2014 05:12 PM, Robbie King wrote:
Signed-off-by: Robbie King robk...@cisco.com
---
platform/linux-generic/include/api/odp_crypto.h | 77
-
1 file changed, 63 insertions(+), 14 deletions(-)
diff --git a/platform/linux-generic/include/api/odp_crypto.h
On 12/10/2014 05:12 PM, Robbie King wrote:
@@ -761,9 +766,9 @@ pkt_disposition_e do_ipsec_in_classify(odp_packet_t pkt,
*/
static
pkt_disposition_e do_ipsec_in_finish(odp_packet_t pkt,
- pkt_ctx_t *ctx)
+ pkt_ctx_t *ctx,
On 12/10/2014 05:12 PM, Robbie King wrote:
v1 - Illustrates abstracting completion event out to be a unique data
type. What is here still uses packet to serve as completion event
however application is no longer aware of the fact and simply converts
the received buffer to a
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v4 Removes RFC, incorporates doxygen change recommended by Anders and PEtri
and incorporates bug fixes that enable it to pass Taras' buffer tests.
example/generator/odp_generator.c | 19 +-
example/ipsec/odp_ipsec.c
Signed-off-by: Bill Fischofer bill.fischo...@linaro.org
---
v3 removes RFC, incorporates bug fixes from Stuart, and doxygen
usage recommendations fram Anders and Petri
example/generator/odp_generator.c | 82 +-
example/ipsec/odp_ipsec.c | 32 +-
On Wed, Dec 10, 2014 at 07:12:43PM +0200, Ciprian Barbu wrote:
Signed-off-by: Ciprian Barbu ciprian.ba...@linaro.org
---
v3:
- changes after Mike's review
- removed duplicate check of end of test in schedule_common_
v2:
- rebased against ODP tip
- fixed some bugs
- added some defines
57 matches
Mail list logo
