[lng-odp] [PATCHv2] validation: scheduler: release context according to scheduler sync type

For different scheduler sync type, need to call different release function. Signed-off-by: Kevin Wang --- test/common_plat/validation/api/scheduler/scheduler.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git

Re: [lng-odp] [API-NEXT][RFC][rebased] linux-gen: ipsec: draft IPsec implementation

Next version should be marked API-NEXT, whether or not it is still an RFC since IPsec APIs cannot move to master until we have a complete implementation / validation test suite. I realize this is an RFC, but it doesn't apply to the current api-next: Applying: linux-gen: ipsec: draft IPsec

[lng-odp] [Bug 2941] test bug for debug

https://bugs.linaro.org/show_bug.cgi?id=2941 Maxim Uvarov changed: What|Removed |Added Assignee|bill.fischo...@linaro.org

Re: [lng-odp] [PATCH] linux-gen: set errno = 0 before mmap

Just following the recommendations: "Set errno to zero before calling a library function known to set errno, and check errno only after the function returns a value indicating failure" I think in general it is not a good idea to set errno after a library call. In this case it could be done, but

[lng-odp] [Bug 2941] test bug for debug

https://bugs.linaro.org/show_bug.cgi?id=2941 --- Comment #3 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/420f9d5427a3f9f0424930061ea0e3480e818d82 2017-04-13T19:29:08+03:00 Maxim Uvarov maxim.uva...@linaro.org some test commit short message that commit

[lng-odp] [Bug 2941] test bug for debug

https://bugs.linaro.org/show_bug.cgi?id=2941 --- Comment #2 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/420f9d5427a3f9f0424930061ea0e3480e818d82 2017-04-13T19:29:08+03:00 Maxim Uvarov maxim.uva...@linaro.org some test commit short message that commit

[lng-odp] [Bug 2941] test bug for debug

https://bugs.linaro.org/show_bug.cgi?id=2941 --- Comment #1 from Maxim Uvarov --- https://github.com/muvarov/odp/commit/420f9d5427a3f9f0424930061ea0e3480e818d82 2017-04-13T19:29:08+03:00 Maxim Uvarov maxim.uva...@linaro.org some test commit short message that commit

Re: [lng-odp] [PATCH] linux-gen: set errno = 0 before mmap

Why not just set errno to 0 in the success case? On 04/13/17 17:05, Oriol Arcas wrote: > Fixes bug #2921. > > During odp_shm_reserve() mmap is tried with huge pages, and if it fails, > without huge pages. The first call leaves errno set, which can confuse > the client app. > > In general, errno

[lng-odp] [Bug 2941] New: test bug for debug

https://bugs.linaro.org/show_bug.cgi?id=2941 Bug ID: 2941 Summary: test bug for debug Product: OpenDataPlane - linux- generic reference Version: v1.14.0.0 Hardware: Other OS: Linux Status: UNCONFIRMED

Re: [lng-odp] [API-NEXT PATCH v4 1/2] api: queue: added queue size param

For the series: Reviewed-by: Balasubramanian Manoharan > On 13-Apr-2017, at 9:13 PM, Honnappa Nagarahalli > wrote: > > For this series: Reviewed-by: Honnappa Nagarahalli > > >> On 13 April 2017 at

Re: [lng-odp] [API-NEXT PATCH v4 1/2] api: queue: added queue size param

Hi Maxim, Appreciate if this can be merged quickly, it will unblock some more patches that are dependent on queue size. Thank you, Honnappa On 13 April 2017 at 10:43, Honnappa Nagarahalli wrote: > For this series: Reviewed-by: Honnappa Nagarahalli >

Re: [lng-odp] [PATCHv2] validation: scheduler: modify the queue size for atomic queue

We need the ring size patch to go in first and then you can review this patch. Thank you, Honnappa On 11 April 2017 at 02:43, Kevin Wang wrote: > Thanks for remind. Awared that if we change it using this way, this patch > should be in the scalable scheduler patch serial

Re: [lng-odp] [API-NEXT PATCH v4 1/2] api: queue: added queue size param

For this series: Reviewed-by: Honnappa Nagarahalli On 13 April 2017 at 10:14, Bill Fischofer wrote: > For this series: Reviewed-by: Bill Fischofer > > This should still have Honnappa's review as well. > > On

Re: [lng-odp] [PATCH] validation: scheduler: Release context before the end of the scheduler test

We will re-spin this patch with the following changes: 1) Remove the extra context release introduced in 'scheduler_test_groups' 2) Remove the 'CU_ASSERT_FATAL(ret == 0)' change (or restore it back) New API will not be handled as part of this patch. Any concerns? Thanks, Honnappa On 10 April

Re: [lng-odp] [API-NEXT PATCH v4 1/2] api: queue: added queue size param

For this series: Reviewed-by: Bill Fischofer This should still have Honnappa's review as well. On Thu, Apr 13, 2017 at 9:40 AM, Petri Savolainen wrote: > Added capability information about maximum number of queues > and queue sizes. Both

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On Thu, Apr 13, 2017 at 9:07 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Thursday, April 13, 2017 1:57 PM >> To: Savolainen, Petri

[lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

Add an example application implementing lock-free IPv4 fragmentation and reassembly functionality using ODP's packet "concat" and "split". Signed-off-by: Joe Savage Reviewed-and-tested-by: Bill Fischofer --- (This code contribution is provided under the terms of agreement

[lng-odp] [API-NEXT PATCH v4 1/2] api: queue: added queue size param

Added capability information about maximum number of queues and queue sizes. Both are defined per queue type, since plain and scheduled queues may have different implementations (e.g. one uses HW while the other is SW). Added queue size parameter, which specifies how large storage size

[lng-odp] [API-NEXT PATCH v4 2/2] validation: queue: test queue max_num per type

Updated implementation and test with type specific number of queues. Signed-off-by: Petri Savolainen --- platform/linux-generic/odp_queue.c| 2 ++ test/common_plat/validation/api/queue/queue.c | 49 +-- 2 files changed, 34

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

> -Original Message- > From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] > Sent: Thursday, April 13, 2017 1:57 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com>; lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH

[lng-odp] [PATCH] linux-gen: set errno = 0 before mmap

Fixes bug #2921. During odp_shm_reserve() mmap is tried with huge pages, and if it fails, without huge pages. The first call leaves errno set, which can confuse the client app. In general, errno must be cleared before calling any library call known to set it (see SEI CERT rule ERR30-C).

Re: [lng-odp] [PATCH] doc: userguide: add portability and usage info for odp time apis

Ping. This patch seems to have stalled. Does it need revision or just a review? On Fri, Feb 17, 2017 at 4:00 AM, Maxim Uvarov wrote: > > > On 17 February 2017 at 00:56, Bill Fischofer > wrote: >> >> On Thu, Feb 16, 2017 at 3:20 PM, Brian

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

13.04.2017 15:31, Dmitry Eremin-Solenikov wrote: On 13.04.2017 15:26, Bill Fischofer wrote: On Thu, Apr 13, 2017 at 6:46 AM, Maxim Uvarov wrote: I vote for default build will not build with deprecating support. Yes all general propose distributives will need to

Re: [lng-odp] [API-NEXT PATCH 0/4] add maximum packet counts to pool info

On Thu, Apr 13, 2017 at 2:17 AM, Elo, Matias (Nokia - FI/Espoo) wrote: > >> On 12 Apr 2017, at 22:52, Bill Fischofer wrote: >> >> On Wed, Apr 12, 2017 at 7:58 AM, Matias Elo wrote: >>> On some packet pool

[lng-odp] [Bug 2921] odp_init_global() and odp_pool_create() set errno = 12

https://bugs.linaro.org/show_bug.cgi?id=2921 --- Comment #7 from Maxim Uvarov --- Then you need to submit patch to master. Then submit patch for Monarch as back port of master branch patch. -- You are receiving this mail because: You are on the CC list for the bug.

[lng-odp] [Bug 2940] odp_packet_seg_t fails ABI compatibility between odp-linux and odp-dpdk

https://bugs.linaro.org/show_bug.cgi?id=2940 --- Comment #3 from Bill Fischofer --- Patch v2 submitted http://patches.opendataplane.org/patch/8527/ to address Krishna comments. -- You are receiving this mail because: You are on the CC list for the bug.

Re: [lng-odp] [Bug 2921] odp_init_global() and odp_pool_create() set errno = 12

Maxim, the fix in Monarch is quite different than in master. In Monarch, it affects odp_shm_reserve() in odp_shared_memory.c. In master, it has been moved to _odp_ishmphy_map() in _ishmphy.c. Which patch should I submit? Or both? -- Oriol Arcas Software Engineer Starflow Networks On Wed, Apr

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 13.04.2017 15:26, Bill Fischofer wrote: > On Thu, Apr 13, 2017 at 6:46 AM, Maxim Uvarov wrote: >> I vote for default build will not build with deprecating support. Yes all >> general propose distributives will need to enable --enable-deprecated-api >> to support some

Re: [lng-odp] [PATCHv2] abi: packet: restore abi compatibility for odp_packet_seg_t type

Thanks. On Thu, Apr 13, 2017 at 7:05 AM, Krishna Garapati wrote: > Reviewed-by: Balakrishna Garapati > > /Krishna > > On 13 April 2017 at 13:48, Bill Fischofer wrote: >> >> When running in

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On Thu, Apr 13, 2017 at 6:46 AM, Maxim Uvarov wrote: > I vote for default build will not build with deprecating support. Yes all > general propose distributives will need to enable --enable-deprecated-api > to support some old software. But developers who work with git

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

> > > A change of architecture shouldn't introduce any additional race > > > conditions or deadlocks, no. If this were the case, then I agree that > > > this example would be far too fragile to include. Any standards compliant > > > implementation of "__atomic_compare_exchange_n" will work fine -

Re: [lng-odp] [PATCHv2] abi: packet: restore abi compatibility for odp_packet_seg_t type

Reviewed-by: Balakrishna Garapati /Krishna On 13 April 2017 at 13:48, Bill Fischofer wrote: > When running in --enable-abi-compat=yes mode, all ODP types need to be > of pointer width in the default ABI definition. The optimization

[lng-odp] [PATCHv2] abi: packet: restore abi compatibility for odp_packet_seg_t type

When running in --enable-abi-compat=yes mode, all ODP types need to be of pointer width in the default ABI definition. The optimization of the odp_packet_seg_t type to uint8_t can only be supported when running in --enable-abi-compate=no mode. Change the ODP packet routines to use type converter

Re: [lng-odp] [PATCH] abi: packet: restore abi compatibility for odp_packet_seg_t type

Thanks. v2 sent. On Thu, Apr 13, 2017 at 3:32 AM, Krishna Garapati wrote: > > > On 13 April 2017 at 00:06, Bill Fischofer wrote: >> >> When running in --enable-abi-compat=yes mode, all ODP types need to be >> of pointer width in the

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

I vote for default build will not build with deprecating support. Yes all general propose distributives will need to enable --enable-deprecated-api to support some old software. But developers who work with git should not work with deprecated api. Maxim. On 13 April 2017 at 13:57, Dmitry

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 13 April 2017 at 13:49, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > ODP is about HW abstraction and CPU instructions are HW features. Of > > course, > > > applications are free to use other libs/APIs/GCC features, but should > > our > > > examples

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

On 13.04.2017 10:33, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Wednesday, April 12, 2017 3:11 PM >> To: Savolainen, Petri (Nokia - FI/Espoo) >

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

> > ODP is about HW abstraction and CPU instructions are HW features. Of > course, > > applications are free to use other libs/APIs/GCC features, but should > our > > examples do that? > > I'm not sure I agree that ODP primarily exists to abstract non-accelerator > HW, as far as I'm concerned

[lng-odp] [Bug 2940] odp_packet_seg_t fails ABI compatibility between odp-linux and odp-dpdk

https://bugs.linaro.org/show_bug.cgi?id=2940 --- Comment #2 from Maxim Uvarov --- test: new comment from python script 1492079015.45 -- You are receiving this mail because: You are on the CC list for the bug.

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

On 13.04.2017 12:55, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Joe Savage [mailto:joe.sav...@arm.com] >> Sent: Thursday, April 13, 2017 11:57 AM >> To: Savolainen, Petri (Nokia - FI/Espoo) > labs.com>; Dmitry

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

> > > > >> You can have arm, arm64, mips64, etc. directories inside > > > > >> examples/ipfrag. > > > > > > > > > > This does not scale in practice. If another example comes along, does > > > > > that also need to split whatever is determined to be "arch" code into > > > > > "arch" directories

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

> -Original Message- > From: Joe Savage [mailto:joe.sav...@arm.com] > Sent: Thursday, April 13, 2017 11:57 AM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com>; Dmitry Eremin-Solenikov ; > Brian Brooks

Re: [lng-odp] [PATCH v5 1/3] validation: packet: increase test pool size

Ping. > On 6 Apr 2017, at 14:41, Krishna Garapati > wrote: > > for this patch series, > > Reviewed-by: Balakrishna Garapati > > /Krishna > > On 31 March 2017 at 14:18, Matias Elo wrote: > Previously

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

> > >> You can have arm, arm64, mips64, etc. directories inside > > >> examples/ipfrag. > > > > > > This does not scale in practice. If another example comes along, does > > > that also need to split whatever is determined to be "arch" code into > > > "arch" directories within its own folder? > >

Re: [lng-odp] [PATCH] abi: packet: restore abi compatibility for odp_packet_seg_t type

On 13 April 2017 at 00:06, Bill Fischofer wrote: > When running in --enable-abi-compat=yes mode, all ODP types need to be > of pointer width in the default ABI definition. The optimization of the > odp_packet_seg_t type to uint8_t can only be supported when running in

Re: [lng-odp] [PATCH v2] build: fix native Clang build on ARMv8

> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Dmitry Eremin-Solenikov > Sent: Thursday, April 13, 2017 1:13 AM > To: Brian Brooks ; lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [PATCH v2] build: fix native Clang

Re: [lng-odp] [PATCH v2 1/3] linux-gen: add internal helper for reading system thread id

Ping. > On 28 Mar 2017, at 10:41, Elo, Matias (Nokia - FI/Espoo) > wrote: > > Ping. > >> On 17 Mar 2017, at 14:16, Matias Elo wrote: >> >> Signed-off-by: Matias Elo >> --- >> platform/linux-generic/Makefile.am

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

> >> > >> You can have arm, arm64, mips64, etc. directories inside > >> examples/ipfrag. > > > > This does not scale in practice. If another example comes along, does > > that also need to split whatever is determined to be "arch" code into > > "arch" directories within its own folder? > > > > I

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

> -Original Message- > From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] > Sent: Wednesday, April 12, 2017 3:11 PM > To: Savolainen, Petri (Nokia - FI/Espoo) labs.com>; lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT

Re: [lng-odp] [API-NEXT PATCH 0/4] add maximum packet counts to pool info

> On 12 Apr 2017, at 22:52, Bill Fischofer wrote: > > On Wed, Apr 12, 2017 at 7:58 AM, Matias Elo wrote: >> On some packet pool implementations the number of available packets may vary >> depending on the packet length (examples below). E.g. a

Re: [lng-odp] [PATCHv2] linux-gen: pktio: miss an unlock operation before exit if error happens

Is this patch able to be merged if no more comments? Kevin 2017-04-10 13:43 GMT+08:00 Kevin Wang : > Just set the return value, and remove the return() function at the > failure branch. > https://bugs.linaro.org/show_bug.cgi?id=2933 > > Signed-off-by: Kevin Wang