Re: [lng-odp] Need to standardize tools version

On Thu, Jun 22, 2017 at 3:03 AM, Honnappa Nagarahalli wrote: > Why is it Hard? It is a matter of documenting/advertising which > versions we are using in CI and making that as a minimum standard. If > someone has a different compiler they can always submit the

Re: [lng-odp] [CLOUD-DEV] ddf: examples: add ddf module skeleton and ddf application

Hi, Bogdan This looks good to me as an evaluation example of the DDF, two comments: 1, Copyright (c) 2014, Linaro Limited needs to be updated. 2, make distcheck failures: Making all in ddf_ifs make[3]: Entering directory

[lng-odp] [PATCH] build: fix conditional compilation of sources

Explicitly add all arch//* files to respective _SOURCES variables instead of using @ARCH_DIR@ substitution. This patch fixes the broken build for ARM, PPC, and MIPS introduced by [1] and the similar issue reported while testing [2]. >From the Autoconf manual [3]: You can't put a configure

Re: [lng-odp] Need to standardize tools version

Why is it Hard? It is a matter of documenting/advertising which versions we are using in CI and making that as a minimum standard. If someone has a different compiler they can always submit the patches for their compilers. On 21 June 2017 at 14:49, Maxim Uvarov wrote: >

Re: [lng-odp] [API-NEXT PATCH v9 0/6] A scalable software scheduler

I explained that my review was premature. I had forgotten to check make distcheck. This needs to be fixed prior to merge. On Wed, Jun 21, 2017 at 4:22 PM Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > Just wondering here. Why is this being enforced now? Why was this not >

Re: [lng-odp] [API-NEXT PATCH v9 0/6] A scalable software scheduler

Just wondering here. Why is this being enforced now? Why was this not enforced when the patch was approved? On 21 June 2017 at 15:26, Bill Fischofer wrote: > On Wed, Jun 21, 2017 at 3:17 PM, Brian Brooks wrote: >> On 06/20 19:38:59, Bill

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

On 06/21/17 23:30, Brian Brooks wrote: > #if -> #ifdef > ifdef works. > On Wed, Jun 21, 2017 at 3:27 PM, Maxim Uvarov wrote: >> odp check with ARCH=arm fails after this patch: >> >> CC arch/arm/odp_cpu_arch.lo >> arch/arm/odp_cpu_arch.c: In function

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

#if -> #ifdef On Wed, Jun 21, 2017 at 3:27 PM, Maxim Uvarov wrote: > odp check with ARCH=arm fails after this patch: > > CC arch/arm/odp_cpu_arch.lo > arch/arm/odp_cpu_arch.c: In function 'cpu_global_time': > arch/arm/odp_cpu_arch.c:71:5: error: "__aarch64__" is

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

odp check with ARCH=arm fails after this patch: CC arch/arm/odp_cpu_arch.lo arch/arm/odp_cpu_arch.c: In function 'cpu_global_time': arch/arm/odp_cpu_arch.c:71:5: error: "__aarch64__" is not defined [-Werror=undef] #if __aarch64__ ^ arch/arm/odp_cpu_arch.c: In function

Re: [lng-odp] [API-NEXT PATCH v9 0/6] A scalable software scheduler

On Wed, Jun 21, 2017 at 3:17 PM, Brian Brooks wrote: > On 06/20 19:38:59, Bill Fischofer wrote: >> Now that master has been merged back into api-next I can confirm that >> make distcheck fails for 64-bit systems as well, so I need to withdraw >> my earlier

Re: [lng-odp] [API-NEXT PATCH v9 0/6] A scalable software scheduler

On 06/20 19:38:59, Bill Fischofer wrote: > Now that master has been merged back into api-next I can confirm that > make distcheck fails for 64-bit systems as well, so I need to withdraw > my earlier reviewed-and-tested-by until that is fixed. This appears to be a problem in pristine upstream as

Re: [lng-odp] [API-NEXT PATCH v9 3/6] linux-gen: sched scalable: add a bitset

On 21/06/2017, 22:00, "Dmitry Eremin-Solenikov" wrote: >On 21.06.2017 21:14, Ola Liljedahl wrote: >> >> On 20/06/2017, 15:04, "Savolainen, Petri (Nokia - FI/Espoo)" >> wrote: >> >>> >>> +++

Re: [lng-odp] [API-NEXT PATCH v9 3/6] linux-gen: sched scalable: add a bitset

On 06/21/17 23:00, Dmitry Eremin-Solenikov wrote: > On 21.06.2017 21:14, Ola Liljedahl wrote: >> >> On 20/06/2017, 15:04, "Savolainen, Petri (Nokia - FI/Espoo)" >> wrote: >> >>> >>> +++ b/platform/linux-generic/include/odp_bitset.h @@ -0,0 +1,210 @@ +/*

Re: [lng-odp] [API-NEXT PATCH v9 3/6] linux-gen: sched scalable: add a bitset

On 21.06.2017 21:14, Ola Liljedahl wrote: > > On 20/06/2017, 15:04, "Savolainen, Petri (Nokia - FI/Espoo)" > wrote: > >> >> >>> +++ b/platform/linux-generic/include/odp_bitset.h >>> @@ -0,0 +1,210 @@ >>> +/* Copyright (c) 2017, ARM Limited >>> + * All rights

Re: [lng-odp] [PATCH API-NEXT v1 1/1] linux-generic: queue: modular queue interface

On 06/19/17 08:00, Github ODP bot wrote: > log| 1269 > log has not be a part of patch. Maxim.

Re: [lng-odp] Need to standardize tools version

it's very hard to standardize tools and compiler version. For now to validate patches we use Linaro CI (odp-check scripts) and Travis CI which is based on some stable ubuntu version. Also we really want that all people can download odp, compile it and run. It's very rare case if different tools

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

On 06/21/17 21:57, Honnappa Nagarahalli wrote: > I cannot make a decision on this topic. This is what I have been told > and I am also told that Linaro is in sync on this. I will initiate > some discussions on this internally. Bill, do you want to check in > Linaro on this? > we will check this

Re: [lng-odp] Need to standardize tools version

On Wed, Jun 21, 2017 at 1:30 PM, Honnappa Nagarahalli wrote: > On 21 June 2017 at 12:23, Bill Fischofer wrote: >> ODP is fairly open-ended in this regard because in theory we're only >> dependent on >> >> - A C99-conforming compiler >>

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

I cannot make a decision on this topic. This is what I have been told and I am also told that Linaro is in sync on this. I will initiate some discussions on this internally. Bill, do you want to check in Linaro on this? I suggest we go ahead with the patch and agree to change it when we have a

Re: [lng-odp] [API-NEXT PATCH v4] timer: allow timer processing to run on worker cores

We have not run any performance application. In our Linaro connect meeting, we presented numbers on how it improves the timer resolution. At this point, there is enough configuration options to control the effect of calling timer in the scheduler. For applications that do not want to use the

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

Reviewed-by: Brian Brooks ACLE [1] was added to GCC 4.9. GCC 4.8 does define __aarch64__ so this change should be safe. [1] http://infocenter.arm.com/help/topic/com.arm.doc.ihi0053c/IHI0053C_acle_2_0.pdf On 06/21 14:48:36, Petri Savolainen wrote: > Use __aarch64__

Re: [lng-odp] [API-NEXT PATCH v9 3/6] linux-gen: sched scalable: add a bitset

On 20/06/2017, 15:04, "Savolainen, Petri (Nokia - FI/Espoo)" wrote: > > >> +++ b/platform/linux-generic/include/odp_bitset.h >> @@ -0,0 +1,210 @@ >> +/* Copyright (c) 2017, ARM Limited >> + * All rights reserved. >> + * >> + * SPDX-License-Identifier:

Re: [lng-odp] [API-NEXT PATCH v9 5/6] linux-gen: sched scalable: add scalable scheduler

On 20/06/2017, 15:58, "Savolainen, Petri (Nokia - FI/Espoo)" wrote: >> --- a/platform/linux-generic/include/odp_config_internal.h >> +++ b/platform/linux-generic/include/odp_config_internal.h >> @@ -7,9 +7,7 @@ >> #ifndef ODP_CONFIG_INTERNAL_H_ >> #define

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

It's perfectly fine to have an ARM copyright as the original contributor, but it also needs a Linaro copyright to be incorporated into ODP. See traffic_mngr.c for an example of this. On Wed, Jun 21, 2017 at 9:27 AM, Honnappa Nagarahalli wrote: > Hi Maxim, >

Re: [lng-odp] Need to standardize tools version

ODP is fairly open-ended in this regard because in theory we're only dependent on - A C99-conforming compiler - A platform that supports a reasonably recent Linux kernel Today we do test on 32 and 64 bit systems, and try to support both GCC and clang, however as newer versions of these tools get

Re: [lng-odp] Need to standardize tools version

Along with this, we need to standardize 32b/64b compilations and the platforms on which we run the test cases. Thanks, Honnappa On 21 June 2017 at 11:38, Honnappa Nagarahalli wrote: > Hi, >I think there is a need to identify tools and specific versions of >

[lng-odp] Need to standardize tools version

Hi, I think there is a need to identify tools and specific versions of the tools from patch acceptance perspective. Any failures outside of these versions should be the responsibility of the person facing the issues, they should submit a patch for those versions and tools. Travis CI is a step

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

On 20/06/2017, 15:12, "Savolainen, Petri (Nokia - FI/Espoo)" wrote: >> +++ b/platform/linux-generic/include/odp_llqueue.h >> @@ -0,0 +1,309 @@ >> +/* Copyright (c) 2017, ARM Limited. >> + * All rights reserved. >> + * >> + * SPDX-License-Identifier:

Re: [lng-odp] [API-NEXT PATCH v9 2/6] linux-gen: sched scalable: add arch files

On 20/06/2017, 15:00, "Savolainen, Petri (Nokia - FI/Espoo)" wrote: > >> +#endif /* PLATFORM_LINUXGENERIC_ARCH_ARM_CPU_IDLING_H */ >> diff --git a/platform/linux-generic/arch/arm/odp_llsc.h >>b/platform/linux- >> generic/arch/arm/odp_llsc.h >> new file mode 100644

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

I think we have talked about this earlier. We have been directed from our executives that we should use ARM copyright if a member has done this work and Linaro/LNG/FF/Bill are in sync on this. Thanks, Honnappa On 21 June 2017 at 10:10, Maxim Uvarov wrote: > On 06/21/17

[lng-odp] [Linaro/odp] 4bcd15: linux-gen: queue: clean up after modular interface

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: 4bcd15e2bfb839ac0ef6419aa9e7b720958638f7 https://github.com/Linaro/odp/commit/4bcd15e2bfb839ac0ef6419aa9e7b720958638f7 Author: Petri Savolainen Date: 2017-06-21 (Wed, 21 Jun

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

On 06/21/17 17:27, Honnappa Nagarahalli wrote: Hi Maxim, This is a new file added by us. Hence the ARM copyright. Thanks, Honnappa Was this work done as Linaro member/assignee? If yes - it has to have Linaro copyright as I know. Maxim. On 21 June 2017 at 09:06, Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

On 06/19/17 22:12, Brian Brooks wrote: Signed-off-by: Ola Liljedahl Reviewed-by: Brian Brooks --- platform/linux-generic/Makefile.am | 1 + platform/linux-generic/include/odp_llqueue.h | 309 +++ 2 files

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

Hi Maxim, This is a new file added by us. Hence the ARM copyright. Thanks, Honnappa On 21 June 2017 at 09:06, Maxim Uvarov wrote: > On 06/19/17 22:12, Brian Brooks wrote: >> >> --- /dev/null >> +++ b/platform/linux-generic/include/odp_llqueue.h >> @@ -0,0 +1,309 @@

Re: [lng-odp] [API-NEXT PATCH v3 0/3] IPSEC packet event

On 16 June 2017 at 13:49, Petri Savolainen wrote: > Applies on top of: "[API-NEXT PATCH v2 0/2] IPsec API update" > > Input and output of IPSEC operations are packets. Parameter and > result structures are cleaner when packet arrays are direct > parameters to

Re: [lng-odp] [API-NEXT PATCH v9 4/6] linux-gen: sched scalable: add a concurrent queue

On 06/19/17 22:12, Brian Brooks wrote: --- /dev/null +++ b/platform/linux-generic/include/odp_llqueue.h @@ -0,0 +1,309 @@ +/* Copyright (c) 2017, ARM Limited. + * All rights reserved. + * + * SPDX-License-Identifier:BSD-3-Clause + */ + Has to be Linaro copyright. Maxim.

Re: [lng-odp] [API-NEXT PATCH v3 0/3] IPSEC packet event

For the series: Reviewed-by: Nikhil Agarwal -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Bala Manoharan Sent: Wednesday, June 21, 2017 6:58 PM To: Petri Savolainen Cc: lng-odp-forward

Re: [lng-odp] [API-NEXT PATCH v3 0/3] IPSEC packet event

For the series: Reviewed-by: Balasubramanian Manoharan On 16 June 2017 at 16:19, Petri Savolainen wrote: > Applies on top of: "[API-NEXT PATCH v2 0/2] IPsec API update" > > Input and output of IPSEC operations are packets. Parameter and >

Re: [lng-odp] [PATCH v4] example: add IPv4 fragmentation/reassembly example

On 06/13/17 17:44, Joe Savage wrote: Any progress on this, Maxim? Merged! Maxim.

Re: [lng-odp] [PATCH v3 3/3] travis: enable tests when make distcheck

On 06/21/17 11:00, Github ODP bot wrote: From: Yi He Make distcheck with all test configurations to confirm test programs installation in odp distribution package. Signed-off-by: Yi He --- /** Email created from pull request 35 (heyi-linaro:install-check)

[lng-odp] [Linaro/odp] ebbd83: api: ipsec: refine packet order specification

Branch: refs/heads/api-next Home: https://github.com/Linaro/odp Commit: ebbd8301f396e3f2f106ed94ce5c3970ec8bacce https://github.com/Linaro/odp/commit/ebbd8301f396e3f2f106ed94ce5c3970ec8bacce Author: Petri Savolainen Date: 2017-06-20 (Tue, 20 Jun

[lng-odp] [Linaro/odp] f43379: example: add IPv4 fragmentation/reassembly example

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: f4337956ee3be1e783e2389eb5a5ceecb4b0b0ca https://github.com/Linaro/odp/commit/f4337956ee3be1e783e2389eb5a5ceecb4b0b0ca Author: Joe Savage Date: 2017-06-21 (Wed, 21 Jun 2017) Changed

[lng-odp] [Linaro/odp] cd1f18: linux-gen: improve conversion between buf_hdr_t an...

Branch: refs/heads/master Home: https://github.com/Linaro/odp Commit: cd1f187d33d65cb54781b5a3c0864229b19c11c3 https://github.com/Linaro/odp/commit/cd1f187d33d65cb54781b5a3c0864229b19c11c3 Author: Joyce Kong Date: 2017-06-20 (Tue, 20 Jun 2017) Changed

Re: [lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

I've confirmed this is benign on x86. Brian: Please review for ARM. On Wed, Jun 21, 2017 at 6:48 AM, Petri Savolainen wrote: > Use __aarch64__ instead of __ARM_ARCH, since it's backwards > compatible between GCC versions. > > Fixes bug

Re: [lng-odp] [RFC API-NEXT] api: crypto: change crypto result to packet

On 21.06.2017 14:48, Dmitry Eremin-Solenikov wrote: > Input and output of crypto operations are packets. API is more flexible > for application and API pipelining when output is packet with additional > metadata. Application or API pipeline stages which do not care about > crypto results may work

Re: [lng-odp] [RFC API-NEXT] api: crypto: change crypto result to packet

On Wed, Jun 21, 2017 at 6:48 AM, Dmitry Eremin-Solenikov wrote: > Input and output of crypto operations are packets. API is more flexible > for application and API pipelining when output is packet with additional > metadata. Application or API pipeline stages

Re: [lng-odp] Suspected SPAM - Re: [API-NEXT PATCH v2 0/2] IPsec API update

+1 Now that api-next has been re-sync'd with master we need to clear out the reviewed patches that were pending the release of v1.15. On Wed, Jun 21, 2017 at 7:00 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > Ping. This was reviewed two weeks ago. The "IPSEC

Re: [lng-odp] Suspected SPAM - Re: [API-NEXT PATCH v2 0/2] IPsec API update

Ping. This was reviewed two weeks ago. The "IPSEC packet event" patch set goes on top of this. > -Original Message- > From: Savolainen, Petri (Nokia - FI/Espoo) > Sent: Thursday, June 15, 2017 10:52 AM > To: Maxim Uvarov > Cc: lng-odp-forward

[lng-odp] [PATCH] linux-gen: time: fix ARM compile for GCC 4.8

Use __aarch64__ instead of __ARM_ARCH, since it's backwards compatible between GCC versions. Fixes bug https://bugs.linaro.org/show_bug.cgi?id=3066 Signed-off-by: Petri Savolainen --- platform/linux-generic/arch/arm/odp_cpu_arch.c | 4 ++-- 1 file changed, 2

[lng-odp] [RFC API-NEXT] api: crypto: change crypto result to packet

Input and output of crypto operations are packets. API is more flexible for application and API pipelining when output is packet with additional metadata. Application or API pipeline stages which do not care about crypto results may work on basic packet metadata. Crypto result event type changes

[lng-odp] [Bug 3066] New: Cross compile broken for ARMv8

https://bugs.linaro.org/show_bug.cgi?id=3066 Bug ID: 3066 Summary: Cross compile broken for ARMv8 Product: OpenDataPlane - linux- generic reference Version: master Hardware: Other OS: Linux Status: UNCONFIRMED

[lng-odp] [Linaro/odp]

Branch: refs/heads/revert-47-fix-devio-race Home: https://github.com/Linaro/odp

[lng-odp] [Linaro/odp] f0e099: Revert "drv: driver: fix devio registration race"

Branch: refs/heads/revert-47-fix-devio-race Home: https://github.com/Linaro/odp Commit: f0e09934c1519dc7c5f34ddbd174eed03de418c8 https://github.com/Linaro/odp/commit/f0e09934c1519dc7c5f34ddbd174eed03de418c8 Author: He Yi Date: 2017-06-21

[lng-odp] [CLOUD-DEV] ddf: examples: add ddf module skeleton and ddf application

Signed-off-by: Bogdan Pricope --- example/Makefile.am | 4 +- example/ddf_app/Makefile.am | 10 example/ddf_app/odp_ddf_app.c | 49 +++ example/ddf_ifs/Makefile.am | 26 ++

[lng-odp] [CLOUD-DEV] ddf: examples: ddf module skeleton

This patch contains a ddf module skeleton (example) and a ddf model application. Was designed to highlight (print) DDF operations/steps. Module is loaded at init_global time through odp configuration file (modules section). Usage: export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/odp/lib/.libs

[lng-odp] [PATCH v3 3/3] travis: enable tests when make distcheck

From: Yi He Make distcheck with all test configurations to confirm test programs installation in odp distribution package. Signed-off-by: Yi He --- /** Email created from pull request 35 (heyi-linaro:install-check) ** https://github.com/Linaro/odp/pull/35

[lng-odp] [PATCH v3 1/3] test: traffic_mngr: fix distcheck failure

From: Yi He When configured odp with --enable-test-vald, make distcheck will fail by not being able to find the traffic_mngr test binary and script in the distribution. This patch installs traffic_mngr test_PROGRAMS and test_SCRIPTS in distribution build. Signed-off-by: Yi He

[lng-odp] [PATCH v3 0/3] test: fix distcheck failures when configured ODP with tests enabled

make install-check failed by not able to find traffic_mngr test binary and script in the installation. this patch changes Makefile.am to install test_PROGRAMS and test_SCRIPTS. Signed-off-by: Yi He yi...@linaro.org github /** Email created from pull request

[lng-odp] [PATCH v3 2/3] test: time: fix distcheck failure

From: Yi He When configured odp with --enable-test-vald, make distcheck will fail by not being able to find the test script time.sh in the distribution. This patch installs time test_SCRIPTS in distribution build. Signed-off-by: Yi He --- /** Email created