[lng-odp] [API-NEXT PATCHv3 6/6] helper: add additional doxygen documentation

2017-04-21 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- helper/include/odp/helper/icmp.h | 11 ++ helper/include/odp/

[lng-odp] [API-NEXT PATCHv3 5/6] linux-generic: types: add additional doxygen documentation

2017-04-21 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp/api/debug.h

[lng-odp] [API-NEXT PATCHv3 4/6] api: tm: add additional doxygen documentation

2017-04-21 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/traffic_mngr.h | 5 +++-- 1 file changed, 3 insertions

[lng-odp] [API-NEXT PATCHv3 2/6] api: ipsec: add additional doxygen documentation

2017-04-21 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/ipsec.h | 5 + 1 file changed, 5 insertions(+) diff

[lng-odp] [API-NEXT PATCHv3 3/6] api: pool: add additional doxygen documentation

2017-04-21 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/pool.h | 6 ++ 1 file changed, 6 insertions(+) diff

[lng-odp] [API-NEXT PATCHv3 1/6] api: classification: add additional doxygen documentation

2017-04-21 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/classification.h | 4 1 file changed, 4 insertions(+)

Re: [lng-odp] [API-NEXT PATCHv2 6/6] helper: add additional doxygen documentation

2017-04-21 Thread Bill Fischofer
On Fri, Apr 21, 2017 at 8:52 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Friday, April 21, 2017 4:26 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <pet

Re: [lng-odp] [API-NEXT PATCHv2 6/6] helper: add additional doxygen documentation

2017-04-21 Thread Bill Fischofer
and then it can be pulled forward to master. > > -Petri > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Bill > > Fischofer > > Sent: Thursday, April 20, 2017 1:35 AM > > To: lng-odp@lists.linaro.o

Re: [lng-odp] shmem pool APIs

2017-04-20 Thread Bill Fischofer
On Thu, Apr 20, 2017 at 12:26 PM, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > Hi, >I looked at the shmem pool APIs for allocating smaller chunks of > shared memory. Following are the APIs I am looking at: > > odpdrv_shm_pool_create > odpdrv_shm_pool_destroy >

Re: [lng-odp] [PATCH v2] linux-generic: crypto: properly handle errors in packet copy

2017-04-20 Thread Bill Fischofer
On Mon, Mar 13, 2017 at 6:44 AM, Dmitry Eremin-Solenikov < dmitry.ereminsoleni...@linaro.org> wrote: > Add proper handling for errors returned by odp_packet_copy_from_pkt(). > > Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > Reviewed-by: Bil

Re: [lng-odp] [PATCH] test: tm: use script instead of binary when calling traffic manager test

2017-04-20 Thread Bill Fischofer
I. However linux-generic > testsuite was not updated to call script instead of binary, resulting in > test failures. > > Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > /** Email

Re: [lng-odp] [PATCH 2/2] add queue size config to cuckoo table

2017-04-20 Thread Bill Fischofer
nnappa Nagarahalli <honnappa.nagaraha...@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > helper/cuckootable.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/helper/cuckootable.c b/helper/cuckootable.c > index 80ff498..0d46300 100644 > -

Re: [lng-odp] [API-NEXT v5] api: ipsec: factor out definitions for feature support levels

2017-04-19 Thread Bill Fischofer
On Wed, Apr 19, 2017 at 8:52 AM, Maxim Uvarov wrote: > Dmitry, please name patches as API-NEXT PATH v5, not as API-NEXT. > API-NEXT PATCH v5 > > Maxim. > > > On 19.04.2017 16:41, Dmitry Eremin-Solenikov wrote: > > Instead of having magic 0-1-2 numbers, let's have the

[lng-odp] [API-NEXT PATCHv2 1/6] api: classification: add additional doxygen documentation

2017-04-19 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/classification.h | 4 1 file changed, 4 insertions(+)

[lng-odp] [API-NEXT PATCHv2 4/6] api: tm: add additional doxygen documentation

2017-04-19 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/traffic_mngr.h | 5 +++-- 1 file changed, 3 insertions

[lng-odp] [API-NEXT PATCHv2 2/6] api: ipsec: add additional doxygen documentation

2017-04-19 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/ipsec.h | 5 + 1 file changed, 5 insertions(+) diff

[lng-odp] [PATCH 4/5] linux-generic: types: add additional doxygen documentation

2017-04-19 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- platform/linux-generic/include/odp/api/debug.h

[lng-odp] [PATCH 1/5] api: classification: add additional doxygen documentation

2017-04-19 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/classification.h | 4 1 file changed, 4 insertions(+)

[lng-odp] [PATCH 5/5] helper: add additional doxygen documentation

2017-04-19 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- helper/include/odp/helper/icmp.h | 11 ++ helper/include/odp/

[lng-odp] [PATCH 2/5] api: pool: add additional doxygen documentation

2017-04-19 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/pool.h | 6 ++ 1 file changed, 6 insertions(+) diff

[lng-odp] [PATCH 3/5] api: tm: add additional doxygen documentation

2017-04-19 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2952 by adding additional field documentation to avoid problems with doxygen 1.8.13 and higher. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/api/spec/traffic_mngr.h | 5 +++-- 1 file changed, 3 insertions

Re: [lng-odp] Patches to merge from V2 of scalable scheduler

2017-04-18 Thread Bill Fischofer
On Tue, Apr 18, 2017 at 4:00 PM, Honnappa Nagarahalli < honnappa.nagaraha...@linaro.org> wrote: > Hi Bill and Maxim, > It is my understanding that discussions on the following patches > from V2 series have been concluded and they can be merged to API-NEXT. > >

Re: [lng-odp] [PATCH] test: tm: skip tm result under travis run

2017-04-18 Thread Bill Fischofer
esult. Threat only segfault as actual error. Linaro CI > will still do full test. > https://bugs.linaro.org/show_bug.cgi?id=2881 > > Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > .../

Re: [lng-odp] [API-NEXT PATCH 1/4] api: pool: add maximum packet counts to pool info

2017-04-18 Thread Bill Fischofer
See comments below based on today's discussions. On Wed, Apr 12, 2017 at 7:58 AM, Matias Elo wrote: > Add fields to odp_pool_info_t for maximum number of packets of any length, > maximum number of minimum length packets, and maximum number of maximum > length packets. > >

Re: [lng-odp] [PATCH] test: tm: skip tm result under travis run

2017-04-18 Thread Bill Fischofer
Do I understand this patch correctly that it attempts to run the test and if it fails for any reason other than a segfault and we are running in Travis that it is then just ignored? That seems reasonable. On Tue, Apr 18, 2017 at 11:27 AM, Maxim Uvarov wrote: > ping. If

Re: [lng-odp] [API-NEXT PATCH 0/4] add maximum packet counts to pool info

2017-04-18 Thread Bill Fischofer
On Tue, Apr 18, 2017 at 4:05 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia-bell-labs.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Bill > > Fischofer > >

[lng-odp] [PATCH] bug: linux-generic: add syntax to allow newer clang to compile odp

2017-04-17 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2942 by adding casts needed to avoid compilation failures when using clang 4.0.0 included in Ubuntu 17.04, which is stricter than clang 3.8.1 which is in Ubuntu 16.10. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> ---

Re: [lng-odp] [API-NEXT v2] api: feature: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
On Fri, Apr 14, 2017 at 11:28 AM, Dmitry Eremin-Solenikov wrote: > Instead of having magic 0-1-2 numbers, let's have the special enum for > feature support levels (unsupported/supported/preferred). > > Signed-off-by: Dmitry Eremin-Solenikov

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
On Fri, Apr 14, 2017 at 9:39 AM, Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> wrote: > On 14.04.2017 17:35, Bill Fischofer wrote: >> Perhaps something like: >> >> typedef enum odp_feature_t { >> ODP_FEATURE_UNSUPPORTED = 0, >

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
4.2017 16:25, Bill Fischofer wrote: >> On Fri, Apr 14, 2017 at 6:53 AM, Bala Manoharan >> <bala.manoha...@linaro.org> wrote: >>> Regards, >>> Bala >>> >>> >>> On 14 April 2017 at 16:52, Bill Fischofer <bill.fischo...@linar

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
On Fri, Apr 14, 2017 at 6:53 AM, Bala Manoharan <bala.manoha...@linaro.org> wrote: > Regards, > Bala > > > On 14 April 2017 at 16:52, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> On Fri, Apr 14, 2017 at 5:58 AM, Dmitry Eremin-Solenikov >> &l

Re: [lng-odp] [API-NEXT] api: ipsec: factor out definitions for feature support levels

2017-04-14 Thread Bill Fischofer
On Fri, Apr 14, 2017 at 5:58 AM, Dmitry Eremin-Solenikov wrote: > Instead of having magic 0-1-2 numbers, let's have the special enum for > feature support levels (unsupported/supported/preferred). > > Signed-off-by: Dmitry Eremin-Solenikov

Re: [lng-odp] [API-NEXT][RFC][rebased] linux-gen: ipsec: draft IPsec implementation

2017-04-13 Thread Bill Fischofer
Next version should be marked API-NEXT, whether or not it is still an RFC since IPsec APIs cannot move to master until we have a complete implementation / validation test suite. I realize this is an RFC, but it doesn't apply to the current api-next: Applying: linux-gen: ipsec: draft IPsec

Re: [lng-odp] [API-NEXT PATCH v4 1/2] api: queue: added queue size param

2017-04-13 Thread Bill Fischofer
For this series: Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> This should still have Honnappa's review as well. On Thu, Apr 13, 2017 at 9:40 AM, Petri Savolainen <petri.savolai...@linaro.org> wrote: > Added capability information about maximum number of queues > and

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-13 Thread Bill Fischofer
On Thu, Apr 13, 2017 at 9:07 AM, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Thursday, April 13, 2017 1:57 PM >> To: Savolainen, Petri

Re: [lng-odp] [PATCH] doc: userguide: add portability and usage info for odp time apis

2017-04-13 Thread Bill Fischofer
Ping. This patch seems to have stalled. Does it need revision or just a review? On Fri, Feb 17, 2017 at 4:00 AM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > > > On 17 February 2017 at 00:56, Bill Fischofer <bill.fischo...@linaro.org> > wrote: >> >> On

Re: [lng-odp] [API-NEXT PATCH 0/4] add maximum packet counts to pool info

2017-04-13 Thread Bill Fischofer
On Thu, Apr 13, 2017 at 2:17 AM, Elo, Matias (Nokia - FI/Espoo) <matias@nokia-bell-labs.com> wrote: > >> On 12 Apr 2017, at 22:52, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> >> On Wed, Apr 12, 2017 at 7:58 AM, Matias Elo <matias@nokia

Re: [lng-odp] [PATCHv2] abi: packet: restore abi compatibility for odp_packet_seg_t type

2017-04-13 Thread Bill Fischofer
Thanks. On Thu, Apr 13, 2017 at 7:05 AM, Krishna Garapati <balakrishna.garap...@linaro.org> wrote: > Reviewed-by: Balakrishna Garapati <balakrishna.garap...@linaro.org> > > /Krishna > > On 13 April 2017 at 13:48, Bill Fischofer <bill.fischo...@linaro.org> wrote: &

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-13 Thread Bill Fischofer
On Thu, Apr 13, 2017 at 6:46 AM, Maxim Uvarov wrote: > I vote for default build will not build with deprecating support. Yes all > general propose distributives will need to enable --enable-deprecated-api > to support some old software. But developers who work with git

[lng-odp] [PATCHv2] abi: packet: restore abi compatibility for odp_packet_seg_t type

2017-04-13 Thread Bill Fischofer
Reported-by: Krishna Garapati <balakrishna.garap...@linaro.org> Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- v2: - Incorporate changes suggested by Krishna - Added Reported-by attribution include/odp/arch/default/api/abi/packet.h | 7 +-- .../include/

Re: [lng-odp] [PATCH] abi: packet: restore abi compatibility for odp_packet_seg_t type

2017-04-13 Thread Bill Fischofer
Thanks. v2 sent. On Thu, Apr 13, 2017 at 3:32 AM, Krishna Garapati <balakrishna.garap...@linaro.org> wrote: > > > On 13 April 2017 at 00:06, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> >> When running in --enable-abi-compat=yes mode, all ODP typ

[lng-odp] [PATCH] abi: packet: restore abi compatibility for odp_packet_seg_t type

2017-04-12 Thread Bill Fischofer
Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- include/odp/arch/default/api/abi/packet.h | 7 +-- .../include/odp/api/plat/packet_inlines.h | 21 ++--- .../include/odp/api/plat/packet_types.h | 10 ++ platform/linux-g

Re: [lng-odp] [API-NEXT PATCH 0/4] add maximum packet counts to pool info

2017-04-12 Thread Bill Fischofer
On Wed, Apr 12, 2017 at 7:58 AM, Matias Elo wrote: > On some packet pool implementations the number of available packets may vary > depending on the packet length (examples below). E.g. a packet pool may > include > smaller sub-pools for different packet length ranges. I'm

Re: [lng-odp] [PATCH] example: l3fwd: check rc from odph_eth_addr_parse()

2017-04-12 Thread Bill Fischofer
On Wed, Apr 12, 2017 at 2:10 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > On 04/06/17 00:16, Bill Fischofer wrote: >> Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2779 by checking >> the return code from odph_eth_addr_parse() and failing the call if >

[lng-odp] [PATCHv2] example: l3fwd: check rc from odph_eth_addr_parse()

2017-04-12 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2779 by checking the return code from odph_eth_addr_parse() and failing the call if dst_mac is unparseable. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- Changes in v2: - Don't forget to free(local) (Maxim comment) e

Re: [lng-odp] [PATCHv4] linux-generic: debug: enable helper use from c++ programs

2017-04-12 Thread Bill Fischofer
rg> > wrote: >> rechecked this patch and it fails: >> https://travis-ci.org/muvarov/odp/jobs/217195437 >> >> Maxim. >> >> On 02/08/17 04:04, Bill Fischofer wrote: >>> I've done a fair amount of experimentation with using variants of >&g

Re: [lng-odp] [PATCH 1/2] add queue size param and related capability

2017-04-12 Thread Bill Fischofer
On Wed, Apr 12, 2017 at 12:28 PM, Honnappa Nagarahalli wrote: > On 12 April 2017 at 00:45, Bala Manoharan wrote: >> Regards, >> Bala >> >> >> On 12 April 2017 at 10:05, Honnappa Nagarahalli >> wrote:

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-12 Thread Bill Fischofer
On Wed, Apr 12, 2017 at 10:05 AM, Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> wrote: > On 12.04.2017 17:24, Bill Fischofer wrote: >> On Wed, Apr 12, 2017 at 8:22 AM, Dmitry Eremin-Solenikov >> <dmitry.ereminsoleni...@linaro.org> wrote: >>> On 12

Re: [lng-odp] [PATCH v3 1/2] api: queue: added queue size param

2017-04-12 Thread Bill Fischofer
Based on today's ARCH call, this seems to be a good approach, with some slight wording clarification (noted below) On Mon, Apr 3, 2017 at 5:11 AM, Petri Savolainen wrote: > Added capability information about maximum number of queues > and queue sizes. Both are

Re: [lng-odp] [API-NEXT PATCH 2/4] linux-gen: socket: handle recv/send calls with large burst size

2017-04-12 Thread Bill Fischofer
This patch seems orthogonal to the rest of this series. Shouldn't this be a separate patch? On Wed, Apr 12, 2017 at 7:58 AM, Matias Elo wrote: > There is no need to fail if the requested burst length is larger than the > maximum supported. Simply use the maximum supported

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-12 Thread Bill Fischofer
On Wed, Apr 12, 2017 at 8:22 AM, Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> wrote: > On 12.04.2017 15:21, Bill Fischofer wrote: >> On Wed, Apr 12, 2017 at 7:11 AM, Dmitry Eremin-Solenikov >> <dmitry.ereminsoleni...@linaro.org> wrote: >>> On

Re: [lng-odp] [PATCH 1/2] add queue size param and related capability

2017-04-12 Thread Bill Fischofer
On Tue, Apr 11, 2017 at 11:14 PM, Honnappa Nagarahalli <honnappa.nagaraha...@linaro.org> wrote: > On 10 April 2017 at 11:49, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> On Mon, Apr 10, 2017 at 11:17 AM, Honnappa Nagarahalli >> <honnappa.nagaraha...@

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-04-12 Thread Bill Fischofer
On Wed, Apr 12, 2017 at 7:11 AM, Dmitry Eremin-Solenikov wrote: > On 12.04.2017 14:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: >> >> >>> -Original Message- >>> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >>> Sent:

Re: [lng-odp] [PATCH v3] example: add IPv4 fragmentation/reassembly example

2017-04-12 Thread Bill Fischofer
I've added this to today's ARCH call agenda. On Wed, Apr 12, 2017 at 5:32 AM, Maxim Uvarov wrote: > On 12.04.2017 13:15, Joe Savage wrote: > The problem is that when we discussed this patch on ODP call people very > worry about having 128bit instructions in ODP

Re: [lng-odp] [PATCH v3 1/2] api: queue: added queue size param

2017-04-11 Thread Bill Fischofer
On Tue, Apr 11, 2017 at 4:47 AM, Maxim Uvarov wrote: > Petri, whom review is needed for that? We currently have conflicting approaches to this from Petri and Honnappa. They need to come to some consensus on this to move forward. > > Maxim. > > On 11 April 2017 at

Re: [lng-odp] [PATCH 1/2] add queue size param and related capability

2017-04-10 Thread Bill Fischofer
On Mon, Apr 10, 2017 at 11:17 AM, Honnappa Nagarahalli wrote: > Hi Bala, > Continuing the discussion from the call, as I mentioned in the > call today, the queues need to hold all kinds of events and not just > packets. The events need not be defined by ODP

Re: [lng-odp] [PATCH 1/2] add queue size param and related capability

2017-04-10 Thread Bill Fischofer
On Thu, Apr 6, 2017 at 11:07 PM, Honnappa Nagarahalli wrote: > Added size parameter indicating the maximum number of events in the > queue and the corresponding queue capability changes. > > Signed-off-by: Honnappa Nagarahalli >

Re: [lng-odp] [PATCH] validation: scheduler: Release context before the end of the scheduler test

2017-04-08 Thread Bill Fischofer
On Sat, Apr 8, 2017 at 4:31 PM, Ola Liljedahl wrote: > On 7 April 2017 at 14:06, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> >> >> From: Kevin Wang [mailto:kevin.w...@linaro.org] >> Sent: Friday, April 07, 2017 11:45 AM >> To:

Re: [lng-odp] linux-gen: timer: ODP general timer timeout machenism on massive timers usage

2017-04-07 Thread Bill Fischofer
Thanks for your note Mario. As an aside, please subscribe to the ODP mailing list otherwise I have to approve each post you make manually, which will only add delay. Please see https://lists.linaro.org/mailman/listinfo/lng-odp for that. We also have a weekly public call on Tuesdays at 15:00 UTC

Re: [lng-odp] [API-NEXT PATCH] abi: event: add ODP_EVENT_IPSEC_STATUS

2017-04-07 Thread Bill Fischofer
t; >> -Original Message- >> From: Bill Fischofer [mailto:bill.fischo...@linaro.org] >> Sent: Friday, April 07, 2017 3:53 PM >> To: Peltonen, Janne (Nokia - FI/Espoo) <janne.pelto...@nokia.com> >> Cc: lng-odp-forward <lng-odp@lists.linaro.org> >

Re: [lng-odp] [API-NEXT PATCH] abi: event: add ODP_EVENT_IPSEC_STATUS

2017-04-07 Thread Bill Fischofer
On Fri, Apr 7, 2017 at 4:54 AM, Janne Peltonen <janne.pelto...@nokia.com> wrote: > > Update ABI spec with the new IPsec event type. > > Signed-off-by: Janne Peltonen <janne.pelto...@nokia.com> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- &g

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: spi_overlap and lookup modes

2017-04-07 Thread Bill Fischofer
lainen <petri.savolai...@linaro.org> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > include/odp/api/spec/ipsec.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h > index b

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

2017-04-06 Thread Bill Fischofer
;>>>> >>>>> ev = odp_queue_deq(queue); >>>>> >>>>> buf = odp_buffer_from_event(ev); >>>>> >>>>> if (!odp_buffer_is_valid(buf)) { >>>>>

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-06 Thread Bill Fischofer
On Thu, Apr 6, 2017 at 1:32 PM, Ola Liljedahl wrote: > On 6 April 2017 at 13:48, Jerin Jacob wrote: >> -Original Message- >>> Date: Thu, 6 Apr 2017 12:54:10 +0200 >>> From: Ola Liljedahl >>> To: Brian

Re: [lng-odp] Sequence requirments for odp_schedule_order_lock()

2017-04-06 Thread Bill Fischofer
equence, so the thread holding the current sequence always gets the lock when it asks for it and all others wait. So lock inversions are impossible with ordered locks because inversions can only happen when it's unpredictable who gets which lock. In the case of ordered locks that sequence is

Re: [lng-odp] [RFC][PATCH] added asymmetric crypto algorithm support.

2017-04-06 Thread Bill Fischofer
We should also take into account Barry's earlier RFC for adding public key support. See http://patches.opendataplane.org/patch/4985/ as this is closely related to this RFC. On Thu, Apr 6, 2017 at 7:31 AM, Kartha, Umesh wrote: > Thanks for comments, please go through my

Re: [lng-odp] [PATCHv2] linux-generic: decouple odp_errno define from odp-linux

2017-04-06 Thread Bill Fischofer
<balakrishna.garap...@linaro.org> Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > since v1: Fixed the extra blank line > platform/linux-generic/Makefile.am| 1 + > platform/linux-generic/include/odp_errno_define.h | 26 >

Re: [lng-odp] [RFC/API-NEXT 1/1] api: classification: packet hashing per class of service

2017-04-06 Thread Bill Fischofer
Bala, any idea when this can advance from the RFC stage to a real patch? On Thu, Apr 6, 2017 at 6:15 AM, Bala Manoharan wrote: > Regards, > Bala > > > On 6 April 2017 at 00:53, Brian Brooks wrote: >> On Fri, Dec 9, 2016 at 5:54 AM,

[lng-odp] [PATCH] example: l3fwd: check rc from odph_eth_addr_parse()

2017-04-05 Thread Bill Fischofer
Resolve Bug https://bugs.linaro.org/show_bug.cgi?id=2779 by checking the return code from odph_eth_addr_parse() and failing the call if dst_mac is unparseable. Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org> --- example/l3fwd/odp_l3fwd_db.c | 3 ++- 1 file changed, 2 insertions

Re: [lng-odp] CRC/Adler requirement in comp interface

2017-04-05 Thread Bill Fischofer
Adding Barry to the to list since I'm not sure if he follows the ODP mailing list and this was something he raised. On Wed, Apr 5, 2017 at 7:31 AM, Verma, Shally wrote: > from yesterday meeting minutes , I see a note on this feedback on compression: > Consider adding

Re: [lng-odp] [PATCH] linux-generic: decouple odp_errno define from odp-linux

2017-04-05 Thread Bill Fischofer
Garapati <balakrishna.garap...@linaro.org> wrote: > makes it easy to define odp_errno to dpdk rteerrno and fixes > linking issues. > > Signed-off-by: Balakrishna Garapati <balakrishna.garap...@linaro.org> Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.or

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-05 Thread Bill Fischofer
Environment is Ubuntu 16.10. On Wed, Apr 5, 2017 at 7:03 AM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > This is running on my desktop x86: > > ./bootstrap > ./configure --enable-schedule-scalable --enable-cunit-support > make > cd test/common_plat/

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-05 Thread Bill Fischofer
017 at 16:12, Bill Fischofer <bill.fischo...@linaro.org> wrote: >> When I compile configure this without --enable-schedule-scalable the >> scheduler validation test runs normally, however if I enable the new >> scheduler I get this output: >> >> >> ... >&

Re: [lng-odp] [API-NEXT PATCH v2 10/16] Add _odp_packet_to_buf_hdr_ptr()

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 1:48 PM, Brian Brooks wrote: > Signed-off-by: Kevin Wang > Reviewed-by: Brian Brooks > --- > platform/linux-generic/include/odp_packet_internal.h | 3 +++ > platform/linux-generic/odp_packet.c

Re: [lng-odp] [API-NEXT PATCH v2 09/16] Avoid shm namespace collisions and allow shm block per queue

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 1:48 PM, Brian Brooks wrote: > Signed-off-by: Kevin Wang > Reviewed-by: Ola Liljedahl > Reviewed-by: Brian Brooks > Reviewed-by: Honnappa Nagarahalli >

Re: [lng-odp] [API-NEXT PATCH v2 08/16] test: scheduler: Fixup calling release operations

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 3:48 PM, Brian Brooks wrote: > On 04/04 23:07:32, Maxim Uvarov wrote: >> On 04/04/17 22:51, Brian Brooks wrote: >> > On 04/04 22:01:23, Maxim Uvarov wrote: >> >> On 04/04/17 21:48, Brian Brooks wrote: >> >>> Remove erroneous assertion that is handled

Re: [lng-odp] [API-NEXT PATCH v2 07/16] test: odp_scheduling: Handle dequeueing from a concurrent queue

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 3:37 PM, Brian Brooks wrote: > On 04/04 21:59:15, Maxim Uvarov wrote: >> On 04/04/17 21:47, Brian Brooks wrote: >> > Signed-off-by: Ola Liljedahl >> > Reviewed-by: Brian Brooks >> > Reviewed-by: Honnappa

Re: [lng-odp] [API-NEXT PATCH v2 06/16] Fix a locking bug

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 5:20 PM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > This is clearly orthogonal to this patch series. Ideally you should > (a) Create a Bug to represent this, (b) Post the fix patch noting the > Bug URL in the commit log, and (c) update the Bug ent

Re: [lng-odp] [API-NEXT PATCH v2 06/16] Fix a locking bug

2017-04-04 Thread Bill Fischofer
This is clearly orthogonal to this patch series. Ideally you should (a) Create a Bug to represent this, (b) Post the fix patch noting the Bug URL in the commit log, and (c) update the Bug entry with the URL of the patch that fixes this bug. On Tue, Apr 4, 2017 at 1:47 PM, Brian Brooks

Re: [lng-odp] [API-NEXT PATCH v2 05/16] Add ODP_CONFIG_QUEUE_SIZE

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 3:40 PM, Brian Brooks wrote: > On 04/04 23:02:15, Maxim Uvarov wrote: >> On 04/04/17 22:48, Brian Brooks wrote: >> > On 04/04 21:57:29, Maxim Uvarov wrote: >> >> On 04/04/17 21:47, Brian Brooks wrote: >> >>> Signed-off-by: Ola Liljedahl

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 4:31 PM, Brian Brooks <brian.bro...@arm.com> wrote: > On 04/04 14:53:23, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks <brian.bro...@arm.com> wrote: >> > On 04/04 21:55:06, Maxim Uvarov wrote: >> >> thi

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 4:23 PM, Brian Brooks <brian.bro...@arm.com> wrote: > On 04/04 15:20:06, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 3:11 PM, Brian Brooks <brian.bro...@arm.com> wrote: >> > On 04/04 14:22:25, Bill Fischofer wrote: >> >> On

Re: [lng-odp] [API-NEXT PATCH v2 00/16] A scalable software scheduler

2017-04-04 Thread Bill Fischofer
When I compile configure this without --enable-schedule-scalable the scheduler validation test runs normally, however if I enable the new scheduler I get this output: ... CUnit - A unit testing framework for C - Version 2.1-3 http://cunit.sourceforge.net/

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 3:35 PM, Bill Fischofer <bill.fischo...@linaro.org> wrote: > On Tue, Apr 4, 2017 at 3:08 PM, Brian Brooks <brian.bro...@arm.com> wrote: >> On 04/04 22:17:48, Maxim Uvarov wrote: >>> On 04/04/17 21:48, Brian Brooks wrote: >>> >

Re: [lng-odp] [API-NEXT PATCH v2 13/16] Add a bitset

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 3:08 PM, Brian Brooks wrote: > On 04/04 22:17:48, Maxim Uvarov wrote: >> On 04/04/17 21:48, Brian Brooks wrote: >> > Signed-off-by: Ola Liljedahl >> > Reviewed-by: Brian Brooks >> > Reviewed-by: Honnappa

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 3:11 PM, Brian Brooks <brian.bro...@arm.com> wrote: > On 04/04 14:22:25, Bill Fischofer wrote: >> On Tue, Apr 4, 2017 at 1:53 PM, Maxim Uvarov <maxim.uva...@linaro.org> wrote: >> > On 04/04/17 21:47, Brian Brooks wrote: >> >> Signed-

Re: [lng-odp] [API-NEXT PATCH v2 02/16] linux-generic: ring.c: use required memory orderings

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 2:53 PM, Brian Brooks <brian.bro...@arm.com> wrote: > On 04/04 14:11:45, Bill Fischofer wrote: >> This part has already been merged into the repo and should be removed >> from this series as it cannot be applied since it's already part of >> api-

Re: [lng-odp] [API-NEXT PATCH v2 01/16] Fix native Clang build on ARMv8

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 2:45 PM, Brian Brooks wrote: > On 04/04 21:55:06, Maxim Uvarov wrote: >> this patch should be not part of this serries and can go to master as >> standalone patch. > > Can you help to cherry pick such patches to master? They need to remain > in this

Re: [lng-odp] [API-NEXT PATCH v2 03/16] api: queue: Add ring_size

2017-04-04 Thread Bill Fischofer
On Tue, Apr 4, 2017 at 1:53 PM, Maxim Uvarov wrote: > On 04/04/17 21:47, Brian Brooks wrote: >> Signed-off-by: Brian Brooks >> Signed-off-by: Honnappa Nagarahalli >> --- >> include/odp/api/spec/queue.h | 5 + >> 1

Re: [lng-odp] [API-NEXT PATCH v2 02/16] linux-generic: ring.c: use required memory orderings

2017-04-04 Thread Bill Fischofer
This part has already been merged into the repo and should be removed from this series as it cannot be applied since it's already part of api-next. On Tue, Apr 4, 2017 at 1:47 PM, Brian Brooks wrote: > From: Ola Liljedahl > > Signed-off-by: Ola

Re: [lng-odp] odp_ipsec_result behaviour

2017-04-03 Thread Bill Fischofer
On Mon, Apr 3, 2017 at 3:23 PM, Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> wrote: > On 03.04.2017 23:13, Bill Fischofer wrote: >> On Mon, Apr 3, 2017 at 2:48 PM, Dmitry Eremin-Solenikov >> <dmitry.ereminsoleni...@linaro.org> wrote: >>> Hell

Re: [lng-odp] odp_ipsec_result behaviour

2017-04-03 Thread Bill Fischofer
On Mon, Apr 3, 2017 at 2:48 PM, Dmitry Eremin-Solenikov wrote: > Hello, > > I was hunting last issues in my IPsec patchset. And suddently I was hit > by the fact that I do not fully understand semantics around > odp_ipsec_result() function. So here comes several

Re: [lng-odp] [API-NEXT PATCH v4 1/3] api: ipsec: extend lookaside API

2017-04-02 Thread Bill Fischofer
For the v4 series: Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> On Thu, Mar 30, 2017 at 5:29 AM, Petri Savolainen <petri.savolai...@linaro.org> wrote: > Added configuration option for inbound SPI range (for > lookups). Removed unique SPI requirement and add

Re: [lng-odp] [PATCH v2] helper: iplookuptable: fix prefix_entry_t member order

2017-04-01 Thread Bill Fischofer
> > Fixes https://bugs.linaro.org/show_bug.cgi?id=2910 > > Signed-off-by: Matias Elo <matias@nokia.com> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > V2: > - Improved commit log (Maxim) > > helper/iplookuptable.c | 8 > 1 file changed

Re: [lng-odp] [API-NEXT PATCH v2 1/2] api: queue: added queue size param

2017-03-31 Thread Bill Fischofer
On Fri, Mar 31, 2017 at 6:46 AM, Petri Savolainen wrote: > Added capability information about maximum number of queues > and queue sizes. Both are defined per queue type, since > plain and scheduled queues may have different implementations > (e.g. one uses HW while

Re: [lng-odp] [API-NEXT PATCH v2 2/2] validation: queue: test queue max_num per type

2017-03-31 Thread Bill Fischofer
This patch is incomplete. Since you're adding a max_size, we need to add a test for that. If an implementation says the max size of a queue is n (n > 0) then we have to attempt to allocate a queue of that size and verify that trying to add an n+1st element to it will fail. Otherwise, we shouldn't

Re: [lng-odp] My last day at linaro/LNG

2017-03-31 Thread Bill Fischofer
Au revoir! It was great working with you and I hope our paths will cross again. Best wishes for your future success. On Fri, Mar 31, 2017 at 6:20 AM, Mike Holmes wrote: > Sad to see you go Christophe, it really was energizing to work with you. > > Mike > > On Mar 31, 2017

Re: [lng-odp] [PATCHv2] test: perf: fix bash syntax in odp_pktio_ordered_run.sh

2017-03-30 Thread Bill Fischofer
gt; Signed-off-by: Maxim Uvarov <maxim.uva...@linaro.org> Reviewed-by: Bill Fischofer <bill.fischo...@linaro.org> > --- > v2: after repairing test logic make distcheck failed due to > missing targets. Added what was needed. > > test/common_plat/performan

Re: [lng-odp] [API-NEXT 2/4] linux-generic: ring.c: use required memory orderings

2017-03-30 Thread Bill Fischofer
bro...@arm.com> wrote: > From: Ola Liljedahl <ola.liljed...@arm.com> > > Signed-off-by: Ola Liljedahl <ola.liljed...@arm.com> > Reviewed-by: Brian Brooks <brian.bro...@arm.com> Reviewed-and-tested-by: Bill Fischofer <bill.fischo...@linaro.org> > --

Re: [lng-odp] [API-NEXT 4/4] A scalable software scheduler

2017-03-30 Thread Bill Fischofer
On Thu, Mar 30, 2017 at 8:56 AM, Brian Brooks <brian.bro...@arm.com> wrote: > On 03/28 18:50:32, Bill Fischofer wrote: >> >> >> >> <!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: >> #80 2px solid; } --> >> >

<    1   2   3   4   5   6   7   8   9   10   >