Re: [lng-odp] PKTIO hash capability

2018-10-26 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Savolainen, Petri (Nokia - FI/Espoo) > Sent: Tuesday, October 23, 2018 10:59 AM > To: 'Liron Himi' ; lng-odp-forward o...@lists.linaro.org> > Subject: RE: PKTIO hash capability > > > I have a platform that doesn't support ha

Re: [lng-odp] PKTIO hash capability

2018-10-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
> I have a platform that doesn't support hashing on input queues, only > classification. > I think it be good to add the below to the PKTIO capabilities. > As currently in the capabilities I declare to have several input queues but > application has not idea it cannot activate hash on those

Re: [lng-odp] Are those Asynchronous ordered locks available for use in 1.19?

2018-09-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, These calls have been implemented by the API spec. So, you can use those in your application. Lock_start() hints implementation that a lock_wait() will follow, but implementation is free to ignore the hint (if there's nothing it can do as preparation for lock_wait()). Lock_wait() is the

Re: [lng-odp] odp_hash_crc32() vs python zlib crc32

2018-08-21 Thread Savolainen, Petri (Nokia - FI/Espoo)
ut_data, 9, 0x); if (result_u64 == 0xcbf43926) { // Correct CRC32 ... } -Petri From: Daniel Feferman [mailto:dlfefer...@gmail.com] Sent: Tuesday, August 21, 2018 4:32 AM To: Savolainen, Petri (Nokia - FI/Espoo) Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] odp_hash_crc32() vs p

Re: [lng-odp] odp_hash_crc32() vs python zlib crc32

2018-08-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, Did you give 0x as the init value for zlib call? CRC32 algorithm is defined with that as the init value. Also, you can check correct operation by trying to hash "123456789" (the common check string), which should result 0xcbf43926 as output for CRC32. See e.g.

Re: [lng-odp] armv8 gcc lock free instructions

2018-06-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Maxim > Uvarov > Sent: Wednesday, June 6, 2018 4:26 PM > To: Maxim Kuvyrkov > Cc: LNG ODP Mailman List > Subject: [lng-odp] armv8 gcc lock free instructions > > Hello Maxim, > > we have

Re: [lng-odp] odp_hash_crc32 support

2018-06-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Daniel > Feferman > Sent: Tuesday, June 5, 2018 7:52 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] odp_hash_crc32 support > > Hi All, > > I saw on this link: > >

Re: [lng-odp] odp_packet_data() considered harmful

2018-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] > Sent: Thursday, February 15, 2018 4:00 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; > Bill Fischofer <bill.fischo...@linaro.org> >

Re: [lng-odp] odp_packet_data() considered harmful

2018-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Thursday, February 15, 2018 2:49 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> Cc: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>; lng-odp-forward <lng-odp@lists.linaro.org>

Re: [lng-odp] odp_packet_data() considered harmful

2018-02-15 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Dmitry Eremin-Solenikov > Sent: Tuesday, February 13, 2018 4:46 PM > To: lng-odp-forward > Subject: [lng-odp] odp_packet_data() considered harmful > > Hello, > >

Re: [lng-odp] RSS in ODP

2018-01-04 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Oriol > Arcas > Sent: Wednesday, January 03, 2018 7:12 PM > To: LNG ODP Mailman List > Subject: [lng-odp] RSS in ODP > > Hello and happy new year, > > In our company

Re: [lng-odp] odp_shm_reserve() with same block name

2017-12-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
he same name would be better than creating X queues with no name. Lookup is useless in the first case anyway so why bother? Is it useful to have both scenarios allowed? -- Best Regards, Stanisław Kardach On Mon, Dec 11, 2017 at 9:43 AM, Savolainen, Petri (Nokia - FI/Espoo) <petri.savol

Re: [lng-odp] odp_shm_reserve() with same block name

2017-12-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Stanislaw Kardach > Sent: Friday, December 08, 2017 6:03 PM > To: LNG ODP Mailman List > Subject: [lng-odp] odp_shm_reserve() with same block name > > Hi all, > >

Re: [lng-odp] odp dpdk

2017-12-04 Thread Savolainen, Petri (Nokia - FI/Espoo)
Maxim, try https://github.com/Linaro/odp/pull/313 It has been tested to fix checksum insert for 10/40GE Intel NICs. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Bogdan Pricope > Sent: Monday, December 04, 2017 12:21 PM > To: Maxim

Re: [lng-odp] L4 offset

2017-11-30 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Liron > Himi > Sent: Wednesday, November 29, 2017 3:13 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] L4 offset > > Hi, > > I'm trying to understand when pktio implementation should set

Re: [lng-odp] Github shows commits in wrong order

2017-11-20 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Savolainen, Petri (Nokia - FI/Espoo) > Sent: Friday, November 17, 2017 10:24 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] Github shows commits in wrong order &g

Re: [lng-odp] ODP vs Protocol headers

2017-11-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Dmitry Eremin-Solenikov > Sent: Friday, November 10, 2017 1:36 PM > To: lng-odp-forward > Subject: [lng-odp] ODP vs Protocol headers > > Hello, > > Historically ODP

Re: [lng-odp] [EXT] Re: classifier with pktio in ODP_PKTIN_MODE_QUEUE

2017-11-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
To mix things, api-next introduces queue hashing *within* a CoS. But also there you use odp_cls_cos_queues() to get the implementation created queue handles, not odp_pktin_event_queue(). -Petri > -Original Message- > From: Savolainen, Petri (Nokia - FI/Espoo) > Sent: Friday,

Re: [lng-odp] [EXT] Re: classifier with pktio in ODP_PKTIN_MODE_QUEUE

2017-11-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
a...@linaro.org>; Savolainen, Petri (Nokia - > FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp@lists.linaro.org; Liron Himi <lir...@marvell.com> > Subject: RE: [EXT] Re: [lng-odp] classifier with pktio in > ODP_PKTIN_MODE_QUEUE > > Hi, > > I understand what y

Re: [lng-odp] [EXT] Re: classifier with pktio in ODP_PKTIN_MODE_QUEUE

2017-11-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
odp_pktin_event_queue() is used when ODP creates the event queues == when hashing is enabled. When classifier is enabled, application itself creates event queues and links those to CoS. So, application knows which event queues to poll. Classifier can be used with both types of event queues,

Re: [lng-odp] [PATCH API-NEXT v3 0/3] api: ones complement metadata

2017-11-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
Weekly ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Savolainen, Petri (Nokia - FI/Espoo) > Sent: Wednesday, November 01, 2017 9:51 AM > To: lng-odp@lists.linaro.org > Subject: Suspected SPAM - Re: [lng-odp] [PATCH AP

Re: [lng-odp] [PATCH API-NEXT v3 0/3] api: ones complement metadata

2017-11-01 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Thursday, October 26, 2017 3:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v3 0/3] api: ones complement metadata > > Added packet

Re: [lng-odp] [PATCH API-NEXT v4 0/8] api: pool subparameters

2017-11-01 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Friday, October 27, 2017 11:00 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v4 0/8] api: pool subparameters > > Added packet pool

Re: [lng-odp] [PATCH API-NEXT v4 1/3] api: ipsec: rework ODP_IPSEC_SA_DISABLE into packet error

2017-10-27 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] > Sent: Thursday, October 26, 2017 3:45 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; > Github ODP bot <odp...@yandex.ru>; lng-odp@lis

Re: [lng-odp] [PATCH API-NEXT v4 1/3] api: ipsec: rework ODP_IPSEC_SA_DISABLE into packet error

2017-10-26 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Wednesday, October 25, 2017 12:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v4 1/3] api: ipsec: rework > ODP_IPSEC_SA_DISABLE into packet

Re: [lng-odp] [PATCH API-NEXT v2 0/3] api: ones complement metadata

2017-10-26 Thread Savolainen, Petri (Nokia - FI/Espoo)
; > > -----Original Message----- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Savolainen, Petri > > (Nokia - FI/Espoo) > > Sent: Thursday, October 26, 2017 10:00 AM > > To: Github ODP bot <odp...@yandex.ru>; lng-odp@lists.linaro.org

Re: [lng-odp] API-next branch

2017-10-26 Thread Savolainen, Petri (Nokia - FI/Espoo)
er 26, 2017 10:30 AM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> Cc: Bill Fischofer <bill.fischo...@linaro.org>; Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>; lng-odp-forward <lng-odp@lists.linaro.org> Subject: Re: [lng-odp] API-next b

Re: [lng-odp] [PATCH API-NEXT v3 0/8] api: pool subparameters

2017-10-26 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Monday, October 23, 2017 3:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v3 0/8] api: pool subparameters > > Added packet pool parameters

Re: [lng-odp] API-next branch

2017-10-26 Thread Savolainen, Petri (Nokia - FI/Espoo)
We need one branch that holds all new API changes before those are released (> 4 months currently): either it's master or api-next. If we change API development to master, then applications would need follow the latest release branch instead of master. At least previous there was resistance to

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: packet: print data (#258)

2017-10-25 Thread Savolainen, Petri (Nokia - FI/Espoo)
that has to be odp helper, not need for that in odp api — Helper is not API, in general all applications cannot rely that. Out validation/example/etc apps can rely on helpers, but not all. This solves a very common debug need for data plane application - print a received packet on the screen.

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: packet: print data (#258)

2017-10-25 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi Petri there's no check on snprintf regarding the returned len. Is there any possibility in this code that the final buffer will be bigger than max_len? — I calculate max string len from number of bytes to print: int num_rows = (byte_len + bytes_per_row - 1) / bytes_per_row; int max_len =

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: pktio: clarify odp_pktio_config() restrictions (#247)

2017-10-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bogdan Pricope [mailto:bogdan.pric...@linaro.org] > Sent: Tuesday, October 24, 2017 11:26 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [Linaro/odp]

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: pktio: clarify odp_pktio_config() restrictions (#247)

2017-10-24 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Bill Fischofer [mailto:notificati...@github.com] Sent: Monday, October 23, 2017 5:55 PM To: Linaro/odp <o...@noreply.github.com> Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; Mention <ment...@noreply.github.com> Subject: Re: [Linaro/odp] [PATC

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api: pktio: clarify odp_pktio_config() restrictions

2017-10-23 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Friday, October 20, 2017 5:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v1 1/1] api: pktio: clarify > odp_pktio_config() restrictions > >

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: pool subparameters (#234)

2017-10-17 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Tuesday, October 17, 2017 2:59 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [Linaro/odp]

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: pool subparameters (#234)

2017-10-17 Thread Savolainen, Petri (Nokia - FI/Espoo)
> typedef struct odp_pool_param_t { > /** Pool type */ > @@ -192,17 +193,34 @@ typedef struct odp_pool_param_t { > > /** Parameters for packet pools */ > struct { > - /** The number of packets that the pool must provide > -

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: pool subparameters (#234)

2017-10-17 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: muvarov [mailto:notificati...@github.com] Sent: Tuesday, October 17, 2017 3:01 AM To: Linaro/odp <o...@noreply.github.com> Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; Author <aut...@noreply.github.com> Subject: Re: [Linaro/odp] [PATCH API-

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: pool subparameters (#234)

2017-10-17 Thread Savolainen, Petri (Nokia - FI/Espoo)
Received mail through Github ... and in HTML format of course. From: muvarov [mailto:notificati...@github.com] Sent: Tuesday, October 17, 2017 3:01 AM To: Linaro/odp <o...@noreply.github.com> Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>;

Re: [lng-odp] [Linaro/odp] [PATCH API-NEXT v1] api: pool subparameters (#234)

2017-10-17 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Bill Fischofer [mailto:notificati...@github.com] Sent: Tuesday, October 17, 2017 2:20 AM To: Linaro/odp <o...@noreply.github.com> Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; Author <aut...@noreply.github.com> Subject: Re: [Linaro/odp] [PATC

Re: [lng-odp] [PATCH API-NEXT v1 1/1] api: ipsec: return maximum antireplay window size via capability

2017-10-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
Git log entry is missing. Update with some rationale why this change is needed. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Sunday, October 15, 2017 9:00 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp]

Re: [lng-odp] Code review and discussion on mailing list only

2017-10-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Savolainen, Petri (Nokia - FI/Espoo) > Sent: Monday, October 02, 2017 5:53 PM > To: lng-odp-forward <lng-odp@lists.linaro.org> > Subject: Suspected SPAM - [lng-odp] Co

Re: [lng-odp] classifier_enable flag

2017-10-09 Thread Savolainen, Petri (Nokia - FI/Espoo)
odp_pktin_queue_config() creates all queues for the interface, except when classifier is used. That's why the classifier config is there. odp_pktin_queue_config() is an interface level call (there are no queue level config calls). Parser is not classifier. Parser config tells which metadata

Re: [lng-odp] generic core + HW specific drivers

2017-10-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > No, I'm pointing that the more there's common core SW, the more there > > are trade-offs and the less direct HW access == less performance. For > > optimal performance, the amount of common core SW is zero. > > Yes this is sort of the ideal but I doubt this type of installation > will be

[lng-odp] Let's remove odp_packet_unshared_len

2017-10-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, I propose that we'd remove the odp_packet_unshared_len() call. The rationale is: * Application rarely needs this to be maintained by ODP (never ?) * Application may maintain offsets/lengths e.g. in packet user area * Application may utilize knowledge about the context: e.g. in this

Re: [lng-odp] generic core + HW specific drivers

2017-10-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
No HTML mails, please. From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Wednesday, October 04, 2017 3:55 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> Cc: Andriy Berestovskyy <andriy.berestovs...@caviumnetworks.com>; Ola Liljedahl

Re: [lng-odp] generic core + HW specific drivers

2017-10-04 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Andriy Berestovskyy [mailto:andriy.berestovs...@caviumnetworks.com] > Sent: Tuesday, October 03, 2017 8:22 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; Ola > Liljedahl <ola.liljed...@linaro.org>

Re: [lng-odp] Code review and discussion on mailing list only

2017-10-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Tuesday, October 03, 2017 12:50 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> Cc: lng-odp-forward <lng-odp@lists.linaro.org> Subject: Re: [lng-odp] Code review and discussion on mailing list

Re: [lng-odp] [PATCH v1 1/1] linux-gen: User /proc/cpuinfo, if sysfs is not available. Fixes https://bugs.linaro.org/show_bug.cgi?id=3249

2017-10-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Tuesday, October 03, 2017 11:00 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH v1 1/1] linux-gen: User /proc/cpuinfo, if sysfs > is not available. Fixes

Re: [lng-odp] generic core + HW specific drivers

2017-10-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Ola > Liljedahl > Sent: Friday, September 29, 2017 8:47 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] generic core + HW specific drivers > > olli@vubuntu:~$ dpkg --get-selections | grep

[lng-odp] Code review and discussion on mailing list only

2017-10-02 Thread Savolainen, Petri (Nokia - FI/Espoo)
Hi, Let's stop using Github for code review and design discussions. Mailing list is far more flexible and robust for human-to-human interaction than a web-based tool. We can continue to use Github for sending/bookkeeping pull requests (and run Travis on those), but all discussions should

Re: [lng-odp] Compiler Barrier API

2017-09-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Andriy Berestovskyy > Sent: Tuesday, September 05, 2017 2:08 PM > To: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] Compiler Barrier API > > Hey Maxim, > There is a use case in the ODP code

Re: [lng-odp] [PATCH API-NEXT v2 1/1] api: event: add documentation for ODP_EVENT_PACKET_CRYPTO

2017-08-30 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Tuesday, August 29, 2017 5:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v2 1/1]

Re: [lng-odp] Regarding crypto event subtypes

2017-08-29 Thread Savolainen, Petri (Nokia - FI/Espoo)
Looks like it's missing from the event.h documentation. It's defined by implementation (and crypto.h spec file), so code compiles OK, but doxygen may not show it https://github.com/Linaro/odp/blob/api-next/platform/linux-generic/include/odp/api/plat/event_types.h > -Original Message-

Re: [lng-odp] [PATCH API-NEXT v8 1/1] comp: compression spec

2017-08-29 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: shally verma [mailto:shallyvermacav...@gmail.com] > Sent: Tuesday, August 29, 2017 10:26 AM > To: Narayana Prasad Athreya <pathr...@caviumnetworks.com> > Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; > Gi

Re: [lng-odp] Suspected SPAM - Re: [PATCH API-NEXT v5 1/1] API:IPSEC: IPSEC events may be reported synchronously.

2017-08-16 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Peltonen, Janne (Nokia - FI/Espoo) > Sent: Wednesday, August 16, 2017 9:16 AM > To: Bill Fischofer > Cc: lng-odp@lists.linaro.org > Subject: Suspected SPAM - Re:

Re: [lng-odp] [PATCH API-NEXT v8 1/1] comp: compression spec

2017-08-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Friday, August 04, 2017 4:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v8 1/1] comp: compression spec > > From: Shally Verma

Re: [lng-odp] [Linaro/odp] 09ce94: api: schedule: add thread removal correction

2017-08-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
This is an API change, that I did oppose on June 16th. Why it's now merged? What is the requirement ("All threads that have joined the group must leave before destroying the group") ? A thread may be in a group due to automatic group (no create/join called), being part of thread mask in a

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: add warning status event

2017-07-14 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Bill Fischofer [mailto:bill.fischo...@linaro.org] Sent: Friday, July 14, 2017 4:40 PM To: Dmitry Eremin-Solenikov Cc: Petri Savolainen ; lng-odp-forward Subject: Re: [lng-odp] [API-NEXT PATCH]

Re: [lng-odp] [RFC/API-NEXTv3 1/3] api: classification: add support for packet hashing in classification

2017-07-14 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Balasubramanian Manoharan > Sent: Friday, July 14, 2017 12:12 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [RFC/API-NEXTv3 1/3] api: classification: add support > for packet hashing in

Re: [lng-odp] [API-NEXT PATCH v1 1/1] pktio APIs to set the MAC address and MTU size.

2017-07-14 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Vamsi > Attunuru > Sent: Friday, July 14, 2017 1:05 PM > To: lng-odp@lists.linaro.org > Cc: mcha...@cavium.com; pathr...@cavium.com; vattun...@cavium.com; > sve...@cavium.com > Subject: [lng-odp]

Re: [lng-odp] [PATCH API-NEXT v3 0/4] Crypto API updates

2017-07-14 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen Maxim, could you merge this ASAP since patch 1/4 fixes broken api-next build (when using gcc 4.8.4) > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Friday,

Re: [lng-odp] [API-NEXT PATCHv6 2/4] linux-generic: timer: implement odp_timer_capability()

2017-07-14 Thread Savolainen, Petri (Nokia - FI/Espoo)
OK. Yes I think 10x should be conservative enough. Make it a #define so that it's easy to update if needed. -Petri From: Kevin Wang [mailto:kevin.w...@linaro.org] Sent: Thursday, July 13, 2017 6:31 PM To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> Cc: Kevi

Re: [lng-odp] [PATCH 0/3] Change buffer handle to pointer

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Bill Fischofer [mailto:bill.fischo...@linaro.org] > Sent: Thursday, July 13, 2017 3:18 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: Maxim Uvarov <maxim.uva...@linaro.org>; lng-odp@lists.linaro.

Re: [lng-odp] [PATCH v1 1/1] pktio APIs to modify the MAC address or the MTU size of the given packet IO handler.

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Vamsi > Attunuru > Sent: Thursday, July 13, 2017 11:54 AM > To: lng-odp@lists.linaro.org > Cc: macha...@cavium.com; pathr...@cavium.com; vattun...@cavium.com; > sve...@cavium.com > Subject:

Re: [lng-odp] [PATCH API-NEXT v2 0/4] Crypto API updates

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
Dmitry, Maxim, I think it's OK to merge v1 of this ASAP since it fixes e.g. api-next build break. I did send my review yesterday. V2 just adds 4/4 patch on top. -Petri

Re: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation of crypto completion API

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Wednesday, July 12, 2017 5:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v2 4/4] api: crypto: revert deprecation > of crypto completion API >

Re: [lng-odp] [API-NEXT PATCHv6 2/4] linux-generic: timer: implement odp_timer_capability()

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Kevin > Wang > Sent: Thursday, July 13, 2017 8:47 AM > To: lng-odp@lists.linaro.org > Cc: Kevin Wang > Subject: [lng-odp] [API-NEXT PATCHv6 2/4] linux-generic: timer:

Re: [lng-odp] [API-NEXT PATCHv6 1/4] api: timer: add odp_timer_capability() api

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Kevin > Wang > Sent: Thursday, July 13, 2017 8:47 AM > To: lng-odp@lists.linaro.org > Cc: Kevin Wang > Subject: [lng-odp] [API-NEXT PATCHv6 1/4] api: timer: add >

Re: [lng-odp] [PATCH API-NEXT v4 1/1] api: ipsec: add retain header capability

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Thursday, July 13, 2017 12:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v4 1/1]

Re: [lng-odp] Regarding odp_pktin_rcv() packets

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: shally verma [mailto:shallyvermacav...@gmail.com] > Sent: Thursday, July 13, 2017 11:43 AM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org>; Shally Verma >

Re: [lng-odp] [API-NEXT PATCH] test: l2fwd: list not used features

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. I think it's better to modify only this application now, and update other apps once the new API is released into master. Otherwise, we would increase diff between api-next vs master. Most apps do odp_init_global(, NULL, NULL) today, so there's no performance difference. This change

Re: [lng-odp] [PATCH 0/3] Change buffer handle to pointer

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
t: Friday, July 07, 2017 7:18 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: Maxim Uvarov <maxim.uva...@linaro.org> > Subject: Re: [lng-odp] [PATCH 0/3] Change buffer handle to pointer > > For this series: > > Reviewed-

Re: [lng-odp] Regarding odp_pktin_rcv() packets

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > shally verma > Sent: Wednesday, July 12, 2017 3:36 PM > To: lng-odp-forward ; Shally Verma > > Subject: [lng-odp] Regarding odp_pktin_rcv() packets

Re: [lng-odp] [PATCH API-NEXT v1 1/1] Adding additonal capability options to IPSEC APIs.

2017-07-13 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Thursday, July 13, 2017 10:00 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v1 1/1] Adding additonal capability > options to IPSEC APIs. Typo:

Re: [lng-odp] [PATCH API-NEXT v1 0/3] Crypto API updates

2017-07-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Wednesday, July 12, 2017 3:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v1 0/3]

Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt parameter

2017-07-12 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] > Sent: Wednesday, July 12, 2017 11:53 AM > To: Petri Savolainen ; lng- > o...@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCH 1/9] api: ipsec: add salt

Re: [lng-odp] [PATCH API-NEXT v3 1/3] api: ipsec: pass OUT_INLINE outer headers as const

2017-07-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
This change is included in my latest IPsec API patch set. -Petri

Re: [lng-odp] [PATCH API-NEXT v8 6/10] api: crypto: add crypto packet operation interface

2017-07-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h > index 454855ea..27b12c89 100644 > --- a/include/odp/api/spec/crypto.h > +++ b/include/odp/api/spec/crypto.h > @@ -16,6 +16,7 @@ > #include > > #include > +#include > > #ifdef __cplusplus > extern "C" { > @@

Re: [lng-odp] [PATCH API-NEXT v8 3/10] api: crypto: drop async mode support

2017-07-11 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Github ODP bot > Sent: Wednesday, July 05, 2017 5:00 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v8 3/10] api: crypto: drop async mode > support > > From: Dmitry

Re: [lng-odp] [API-NEXT PATCH 1/4] linux-gen: sched: remove schedule interface depedency to qentry

2017-07-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Friday, July 07, 2017 9:28 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Su

Re: [lng-odp] [PATCH v4 3/9] linux-gen: stop poisoning CPPFLAGS/LDFLAGS with DPDK flags

2017-07-10 Thread Savolainen, Petri (Nokia - FI/Espoo)
From: Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Thursday, July 06, 2017 8:28 PM To: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; Github ODP bot <odp...@yandex.ru>; lng-odp@lists.

Re: [lng-odp] [API-NEXT PATCH 0/4] Clean up scheduler interface

2017-07-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
This is the first step to clean up queue / scheduler dependencies. Could we merge this now and continue towards the next steps. Master and api-next should be synced soon otherwise the code base delta just increases for no real reason (API is the same). -Petri > -Original Message- >

Re: [lng-odp] [API-NEXT PATCH 1/4] linux-gen: sched: remove schedule interface depedency to qentry

2017-07-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> >> typedef struct schedule_fn_t { > >> + int status_sync; > > > > this structure should contain functions that are provided by scheduler > > to other components of ODP. 'status_sync' seems to be an internal > > mechanism between the default scheduler and default

Re: [lng-odp] [API-NEXT PATCH 1/4] linux-gen: sched: remove schedule interface depedency to qentry

2017-07-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Thursday, July 06, 2017 11:07 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Su

Re: [lng-odp] [API-NEXT PATCH 2/4] linux-gen: sched: use config max ordered locks

2017-07-07 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Thursday, July 06, 2017 11:00 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org> > Su

Re: [lng-odp] Suspected SPAM - [API-NEXT PATCH v2 1/3] api: system_info: add function for fetching all supported huge page sizes

2017-07-06 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Matias Elo > Sent: Wednesday, July 05, 2017 5:23 PM > To: lng-odp@lists.linaro.org > Subject: Suspected SPAM - [lng-odp] [API-NEXT

Re: [lng-odp] [PATCHv2] linux-gen: scheduler: modular scheduler interface

2017-07-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Wednesday, July 05, 2017 6:31 AM > To: Brian Brooks <brian.bro...@arm.com> > Cc: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; > Joyce

Re: [lng-odp] [API-NEXT PATCH 4/4] linux-gen: sched: remove unused sched interface functions

2017-07-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > platform/linux-generic/include/odp_schedule_if.h | 7 +-- > > platform/linux-generic/odp_queue.c | 21 + > > > platform/linux-generic/odp_schedule_iquery.c | 4 +--- > > 3 files changed, 3 insertions(+), 29 deletions(-) > > > > diff --git

Re: [lng-odp] [API-NEXT PATCH 2/4] linux-gen: sched: use config max ordered locks

2017-07-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
> > diff --git a/platform/linux-generic/include/odp_config_internal.h > b/platform/linux-generic/include/odp_config_internal.h > > index 3cff0045..469396df 100644 > > --- a/platform/linux-generic/include/odp_config_internal.h > > +++ b/platform/linux-generic/include/odp_config_internal.h > > @@

Re: [lng-odp] [API-NEXT PATCH 1/4] linux-gen: sched: remove schedule interface depedency to qentry

2017-07-05 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] > Sent: Wednesday, July 05, 2017 7:04 AM > To: Petri Savolainen > Cc: lng-odp-forward > Subject: Re: [lng-odp] [API-NEXT PATCH 1/4]

Re: [lng-odp] [PATCH v4 3/9] linux-gen: stop poisoning CPPFLAGS/LDFLAGS with DPDK flags

2017-07-04 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] > Sent: Tuesday, July 04, 2017 3:16 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com>; > Github ODP bot <odp...@yandex.ru>; lng-odp@lis

Re: [lng-odp] [PATCH API-NEXT v5 6/10] api: crypto: add crypto packet operation interface

2017-07-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h > index 454855ea..9dd60749 100644 > --- a/include/odp/api/spec/crypto.h > +++ b/include/odp/api/spec/crypto.h > @@ -16,6 +16,7 @@ > #include > > #include > +#include > > #ifdef __cplusplus > extern "C" { > @@

Re: [lng-odp] [PATCH v4 3/9] linux-gen: stop poisoning CPPFLAGS/LDFLAGS with DPDK flags

2017-07-03 Thread Savolainen, Petri (Nokia - FI/Espoo)
> diff --git a/test/Makefile.inc b/test/Makefile.inc > index 1ef2a92c..bf31b374 100644 > --- a/test/Makefile.inc > +++ b/test/Makefile.inc > @@ -4,7 +4,7 @@ LIB = $(top_builddir)/lib > #in the following line, the libs using the symbols should come before > #the libs containing them! The

Re: [lng-odp] [API-NEXTv2] api: ipsec: reorganize odp_ipsec_sa_param_t structure based on SA direction

2017-06-29 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Bogdan Pricope > Sent: Thursday, June 22, 2017 9:56 AM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [API-NEXTv2] api: ipsec: reorganize > odp_ipsec_sa_param_t structure based on SA

Re: [lng-odp] [PATCHv2] linux-gen: scheduler: modular scheduler interface

2017-06-29 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: Brian Brooks [mailto:brian.bro...@arm.com] > Sent: Wednesday, June 28, 2017 5:17 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: Joyce Kong <joyce.k...@arm.com>; lng-odp@lists.linaro.org > S

Re: [lng-odp] [PATCH API-NEXT v3 0/2] event subtype implementation

2017-06-29 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > Dmitry Eremin-Solenikov > Sent: Friday, June 16, 2017 2:48 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH API-NEXT v3

Re: [lng-odp] [PATCH] linux-gen: time: use true hz

2017-06-28 Thread Savolainen, Petri (Nokia - FI/Espoo)
Reviewed-by: Petri Savolainen > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Brian > Brooks > Sent: Monday, June 26, 2017 9:21 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH] linux-gen: time: use

Re: [lng-odp] regarding ODP_PKTIO_MACADDR_MAXSIZE in pktio spec

2017-06-28 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of > shally verma > Sent: Wednesday, June 28, 2017 1:23 PM > To: lng-odp-forward > Subject: [lng-odp] regarding ODP_PKTIO_MACADDR_MAXSIZE in pktio spec > > I have question

Re: [lng-odp] [PATCHv2] linux-gen: scheduler: modular scheduler interface

2017-06-28 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of Joyce > Kong > Sent: Wednesday, June 28, 2017 5:14 AM > To: lng-odp@lists.linaro.org > Cc: Joyce Kong > Subject: [lng-odp] [PATCHv2] linux-gen: scheduler: modular scheduler >

Re: [lng-odp] [API-NEXT, PATCH v4 1/1] comp: compression API

2017-06-27 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: shally verma [mailto:shallyvermacav...@gmail.com] > Sent: Tuesday, June 27, 2017 12:31 PM > To: Savolainen, Petri (Nokia - FI/Espoo) <petri.savolai...@nokia.com> > Cc: lng-odp-forward <lng-odp@lists.linaro.org>; Mahipal Challa &g

  1   2   3   4   5   6   7   8   9   10   >