[lng-odp] [PATCH] linux-dpdk: Enable promiscous mode

2014-08-21 Thread Santosh Shukla
Noticed that enabling promiscous mode helps l2fwd application work with pktgen or dpdk-pktgen Suggested-by: Venkatesh Vivekanandan venkatesh.vivekanan...@linaro.org Signed-off-by: Santosh Shukla santosh.shu...@linaro.org --- platform/linux-dpdk/odp_packet_dpdk.c |3 +++ 1 file changed, 3

Re: [lng-odp] [PATCH] linux-dpdk: Enable promiscous mode

2014-08-21 Thread Santosh Shukla
On 21 August 2014 14:24, Ola Liljedahl ola.liljed...@linaro.org wrote: You are not always setting promiscuous mode on network interfaces in ODP/linux-dpdk? Promiscuous mode should only be enabled when the application requires it. The l2fwd (is this the DPDK port? passthrough would be a better

Re: [lng-odp] [PATCH] linux-dpdk: Enable promiscous mode

2014-08-21 Thread Santosh Shukla
On 21 August 2014 14:57, Venkatesh Vivekanandan venkatesh.vivekanan...@linaro.org wrote: On 21 August 2014 14:27, Santosh Shukla santosh.shu...@linaro.org wrote: On 21 August 2014 14:24, Ola Liljedahl ola.liljed...@linaro.org wrote: You are not always setting promiscuous mode on network

Re: [lng-odp] [PATCH v3] Change invalid buffer pool handle to zero

2014-08-21 Thread Anders Roxell
On 2014-08-21 09:39, Savolainen, Petri (NSN - FI/Espoo) wrote: -Original Message- From: ext Anders Roxell [mailto:anders.rox...@linaro.org] Sent: Thursday, August 21, 2014 11:44 AM To: Petri Savolainen Cc: lng-odp@lists.linaro.org Subject: Re: [lng-odp] [PATCH v3] Change

Re: [lng-odp] [PATCH] linux-dpdk: Enable promiscous mode

2014-08-21 Thread Santosh Shukla
On 21 August 2014 15:47, Venkatesh Vivekanandan venkatesh.vivekanan...@linaro.org wrote: On 21 August 2014 15:16, Ola Liljedahl ola.liljed...@linaro.org wrote: This command line option would be interpreted by the application. But the application needs a function for setting an interface

Re: [lng-odp] [PATCH] linux-dpdk: Enable promiscous mode

2014-08-21 Thread Maxim Uvarov
On 08/21/2014 01:33 PM, Santosh Shukla wrote: On 21 August 2014 14:57, Venkatesh Vivekanandan venkatesh.vivekanan...@linaro.org wrote: On 21 August 2014 14:27, Santosh Shukla santosh.shu...@linaro.org wrote: On 21 August 2014 14:24, Ola Liljedahl ola.liljed...@linaro.org wrote: You are not

Re: [lng-odp] [PATCHv2 0/2] Add infrastructure required by IPSec example

2014-08-21 Thread Robbie King (robking)
Please ignore this one, I will put these out as part of the IPsec example application patch. -Original Message- From: Robbie King (robking) Sent: Tuesday, August 19, 2014 10:31 AM To: lng-odp@lists.linaro.org Cc: Robbie King (robking) Subject: [PATCHv2 0/2] Add infrastructure required by

[lng-odp] [PATCH] Timer bug corrections

2014-08-21 Thread Petri Savolainen
- Start POSIX timer in odp_timer_create - return correct value int odp_timeout_tick Signed-off-by: Petri Savolainen petri.savolai...@linaro.org --- platform/linux-generic/odp_timer.c | 127 - 1 file changed, 83 insertions(+), 44 deletions(-) diff --git

Re: [lng-odp] [PATCH] linux-dpdk: Enable promiscous mode

2014-08-21 Thread Ola Liljedahl
If one ODP implementation automatically enables promiscuous mode on network interfaces, I think we might get different semantics on those targets (can't rely on external switches to do all filtering for you). If this is a work-around because we cannot get pktgen to use the intended destination

Re: [lng-odp] Crypto completion event proposal...

2014-08-21 Thread Taras Kondratiuk
On 08/20/2014 02:59 PM, Robbie King (robking) wrote: Hey Taras, a while back we tabled the completion event discussion until we linux-generic crypto implementation got into the repository. If I remember correctly, you had a proposal for dealing with the completion event issue that you

[lng-odp] [PATCH] bootstrap: add include m4 directory in bootstrap

2014-08-21 Thread Gilad Ben-Yossef
From: Gilad Ben-Yossef gi...@benyossef.com First time configure was failing due to missing Doxygen includes from m4/ directory. Include m4/ directory during bootstrap generation to get autoconf to create a correct configure script. Signed-off-by: Gilad Ben-Yossef gil...@ezchip.com CC: Barry

[lng-odp] [PATCH 00/13] IPsec example application

2014-08-21 Thread Robbie King
Hello all, Here is the refactored IPsec example application. Changes from the existing github version are: - Split into multiple source/header files - Support for querying MAC address via pktio handle - Removed unused test code for scheduling - Adding ability to set packet flags (for steam

[lng-odp] [PATCH 04/13] Add IPsec example app to build environment

2014-08-21 Thread Robbie King
Signed-off-by: Robbie King robk...@cisco.com --- .gitignore|2 ++ configure.ac |1 + example/Makefile.am |2 +- example/ipsec/Makefile.am | 12 4 files changed, 16 insertions(+), 1 deletions(-) create mode 100644

[lng-odp] [PATCH 10/13] IPsec example SP DB

2014-08-21 Thread Robbie King
Signed-off-by: Robbie King robk...@cisco.com --- example/ipsec/odp_ipsec_sp_db.c | 124 +++ example/ipsec/odp_ipsec_sp_db.h | 71 ++ 2 files changed, 195 insertions(+), 0 deletions(-) create mode 100644 example/ipsec/odp_ipsec_sp_db.c

[lng-odp] [PATCH 01/13] Add user context to packet

2014-08-21 Thread Robbie King
Signed-off-by: Robbie King robk...@cisco.com --- include/odp_packet.h | 18 ++ .../linux-generic/include/odp_packet_internal.h|2 ++ platform/linux-generic/odp_packet.c| 10 ++ 3 files changed, 30 insertions(+), 0

[lng-odp] [PATCH 06/13] IPsec example app support routines

2014-08-21 Thread Robbie King
Signed-off-by: Robbie King robk...@cisco.com --- example/ipsec/odp_ipsec_misc.h | 321 1 files changed, 321 insertions(+), 0 deletions(-) create mode 100644 example/ipsec/odp_ipsec_misc.h diff --git a/example/ipsec/odp_ipsec_misc.h

[lng-odp] How to set dstmac in Pktgen-dpdk

2014-08-21 Thread Venkatesh Vivekanandan
Hi Keith, Can you please let us know how do we set dest mac in Pktgen-dpdk?. For eg, if there are 2 interfaces eth0(a0:36:9f:13:89:08) and eth1(a0:36:9f:13:89:0a), pktgen comes up with eth0-eth1 as a0:36:9f:13:89:08 to a0:36:9f:13:89:0a and eth1-eth0 as a0:36:9f:13:89:0a to a0:36:9f:13:89:08

Re: [lng-odp] [PATCH] CONTRIBUTING: Add doxygen commenting rules

2014-08-21 Thread Taras Kondratiuk
On 08/21/2014 12:43 AM, Mike Holmes wrote: On 20 August 2014 17:31, Taras Kondratiuk taras.kondrat...@linaro.org mailto:taras.kondrat...@linaro.org wrote: On 08/18/2014 04:03 PM, Mike Holmes wrote: Signed-off-by: Mike Holmes mike.hol...@linaro.org mailto:mike.hol...@linaro.org

Re: [lng-odp] [PATCH] odp_debug.h: backward compatible _Static_assert

2014-08-21 Thread Gilad Ben Yossef
...and I botched this one with a missing #endif. Sorry. Fixed version coming up in a sec. Gilad Ben-Yossef Software Architect EZchip Technologies Ltd. 37 Israel Pollak Ave, Kiryat Gat 82025 ,Israel Tel: +972-4-959- ext. 576, Fax: +972-8-681-1483 Mobile: +972-52-826-0388, US Mobile:

[lng-odp] [[PATCH v2]] odp_debug.h: backward compatible _Static_assert

2014-08-21 Thread Gilad Ben-Yossef
Static_assert() support was only added to GCC 4.6. Provide a weak replcement for GCC users prior to that version, such as the default RHEL 6.x GCC, as it is better than breaking the build. The replacement macro is based on example from the following email:

[lng-odp] [Bug 300] __Static_assert in linux generic is a C11 feature

2014-08-21 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=300 --- Comment #1 from Mike Holmes mike.hol...@linaro.org --- Patch proposed by Gilad Ben-Yossef http://lists.linaro.org/pipermail/lng-odp/2014-August/002598.html -- You are receiving this mail because: You are on the CC list for the

[lng-odp] [Bug 290] Linux-genric cannot compile with clang

2014-08-21 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=290 --- Comment #1 from Mike Holmes mike.hol...@linaro.org --- Clang is becoming more mainstream and does produce superior code in many cases, with that in mind I think the linux-generic implementation and the tests should all compile for clang cleanly. --

Re: [lng-odp] [PATCH 00/13] IPsec example application

2014-08-21 Thread Robbie King (robking)
Thanks Taras. I can add the polling vs scheduling logic back, I didn't realize you needed it. I created the large number of patches to facilitate the review process, however I can merge them easily (I think, I know just enough about git rebase to be dangerous). If no one else objects, I will

Re: [lng-odp] [PATCH 0/3] Move include back to linux-generic

2014-08-21 Thread Mike Holmes
Please add my reviewed by to this series. Reviewed-and-Tested-by: Mike Holmes mike.hol...@linaro.org On 20 August 2014 20:03, Anders Roxell anders.rox...@linaro.org wrote: Hi all, In this patch set we have, one patch that moves the include files back to linux-generic, and some cleanup

Re: [lng-odp] [PATCH] bootstrap: add include m4 directory in bootstrap

2014-08-21 Thread Anders Roxell
On 2014-08-21 15:20, Gilad Ben-Yossef wrote: From: Gilad Ben-Yossef gi...@benyossef.com First time configure was failing due to missing Doxygen includes from m4/ directory. Include m4/ directory during bootstrap generation to get autoconf to create a correct configure script. Hi, I

[lng-odp] [PATCHv2 0/4] IPsec example application

2014-08-21 Thread Robbie King
Hello all, Here is the refactored IPsec example application. V1: Changes from the existing github version are: - Split into multiple source/header files - Support for querying MAC address via pktio handle - Removed unused test code for scheduling - Adding ability to set packet flags (for

[lng-odp] [PATCHv2 1/4] Add user context to packet

2014-08-21 Thread Robbie King
Signed-off-by: Robbie King robk...@cisco.com --- include/odp_packet.h | 18 ++ .../linux-generic/include/odp_packet_internal.h|2 ++ platform/linux-generic/odp_packet.c| 10 ++ 3 files changed, 30 insertions(+), 0

[lng-odp] [PATCHv2 2/4] Add helper include file with IPSec headers

2014-08-21 Thread Robbie King
Signed-off-by: Robbie King robk...@cisco.com --- include/helper/odp_ipsec.h | 73 1 files changed, 73 insertions(+), 0 deletions(-) create mode 100644 include/helper/odp_ipsec.h diff --git a/include/helper/odp_ipsec.h b/include/helper/odp_ipsec.h

[lng-odp] [PATCHv2 4/4] Add IPsec example app to build environment

2014-08-21 Thread Robbie King
Signed-off-by: Robbie King robk...@cisco.com --- .gitignore|2 + configure.ac |1 + example/Makefile.am |2 +- example/ipsec/Makefile.am | 12 + example/ipsec/README | 164

[lng-odp] [PATCHv2 3/4] Add ability to set packet flags

2014-08-21 Thread Robbie King
Signed-off-by: Robbie King robk...@cisco.com --- include/odp_packet_flags.h| 136 + platform/linux-generic/odp_packet_flags.c | 87 ++ 2 files changed, 223 insertions(+), 0 deletions(-) diff --git a/include/odp_packet_flags.h

[lng-odp] odp ipc api

2014-08-21 Thread Maxim Uvarov
Taras, I want to check with you that you will be fine with following api for ipc app: 1. Process one: Create standard ingress queue: pktio = odp_pktio_open(thr_args-pktio_dev, pkt_pool, params); inq_def = odp_queue_create(inq_name, ODP_QUEUE_TYPE_PKTIN, qparam); ret =

Re: [lng-odp] [[PATCH v2]] odp_debug.h: backward compatible _Static_assert

2014-08-21 Thread Anders Roxell
On 2014-08-21 16:02, Gilad Ben-Yossef wrote: Static_assert() support was only added to GCC 4.6. Provide a weak replcement for GCC users prior to that version, such as the default RHEL 6.x GCC, as it is better than breaking the build. The replacement macro is based on example from the

Re: [lng-odp] [ARCH PATCHv5] Publish Classification API Design to git

2014-08-21 Thread Anders Roxell
On 2014-08-21 16:21, Bill Fischofer wrote: Please publish as it is complete and useful in its own right and accurately reflects what was submitted for LNG-SC approval. Then open a bug for the rework. The rework you suggest is non-trivial and is non-gating here. Thanks. Does anyone else have

Re: [lng-odp] [ARCH PATCHv5] Publish Classification API Design to git

2014-08-21 Thread Mike Holmes
On 21 August 2014 17:34, Anders Roxell anders.rox...@linaro.org wrote: On 2014-08-21 16:21, Bill Fischofer wrote: Please publish as it is complete and useful in its own right and accurately reflects what was submitted for LNG-SC approval. Then open a bug for the rework. The rework you