Ping.
-- Forwarded message --
From:
Date: 22 May 2015 at 14:44
Subject: [lng-odp][PATCH 1/2 v2] examples: ipsec: tunnel mode support
To: lng-odp@lists.linaro.org
Cc: Alexandru Badicioiu
From: Alexandru Badicioiu
v1 - added comment for tunnel DB entry use
v2 - fixed tun pointe
Hi Robbie, in case you missed this I'm resending.
Also could you explain why magic number verification should be removed - it
is used to verify (part of) the payload after applying IPSec.
Thanks,
Alex
-- Forwarded message --
From: Alexandru Badicioiu
Date: 2 April 2015 at 12:17
I posted patch http://patches.opendataplane.org/patch/1822/ as an
alternative to this one. The change of the underlying buffer type seems
wrong. If an implementation wished to define a new buffer type it should
be managed as a separate pool type, but in this case I don't believe that's
warranted,
odp_crypto_operation() should not change underlying buffer types for
completions as these are purely internal and not needed, and doing
so is confusing and error-prome.
Signed-off-by: Bill Fischofer
---
platform/linux-generic/include/odp_buffer_internal.h | 9 -
platform/linux-generic/od
Thanks for spotting that. I hadn't realized that odp_crypto was making
those changes, even though it notes that it isn't needed for the API. That
looks to be a somewhat ugly solution and I'd like to take a look to see if
there isn't a cleaner way to deal with this other than this sort of hack.
O
Well, in this case the change was to add a function (scanf) to do the
conversion, and as part of that a (proper) RC check is included. It looks
to be part of the same change to me.
Reviewed-by: Bill Fischofer
On Tue, Jun 9, 2015 at 7:24 PM, Mike Holmes wrote:
> I see what you are saying, any
I see what you are saying, any time a patch says "also" or "and" I start
looking for why it was not two patches :)
On 9 June 2015 at 17:09, Nicolas Morey Chaisemartin
wrote:
> The sscanf format is also changed.
> Because of this checkpatch was bothering me with the uncheck returned
> value so I
The sscanf format is also changed.
Because of this checkpatch was bothering me with the uncheck returned value so
I squashed it in the same path.
If you'd rather have two patches, I'll happily split it :)
--
Nicolas Morey Chaisemartin
Phone : +33 6 42 46 68 87
nmo...@kalray.eu
KALRAY SA
Signed-off-by: Mike Holmes
---
apply-and-build.sh | 2 ++
build.sh | 2 ++
helper/generic | 4
3 files changed, 8 insertions(+)
diff --git a/apply-and-build.sh b/apply-and-build.sh
index 5c30e8c..a02e446 100755
--- a/apply-and-build.sh
+++ b/apply-and-build.sh
@@ -56,6 +56,8 @
These look like two unrelated patches squashed in one patch to me.
One adds a return check and the other adds printf formatting.
On 9 June 2015 at 10:26, Nicolas Morey-Chaisemartin
wrote:
> Also adds a check of sscanf return value to make checkpatch happy
>
> Signed-off-by: Nicolas Morey-Chaisem
There seems to be an issue with the handling of completion event buffers:
These are drawn from the same pool as the packet event buffers,
but are re-typed as completion events.
(see platform/linux-generic/odp_crypto.c:428)
However, when these are freed and returned to the pool,
the buffer type was
On 2015-06-09 11:19, Petri Savolainen wrote:
> The linux specific helper was replaced by default cpumask
> calls (odp_cpumask_def_worker()) in the cpumask API.
>
> Signed-off-by: Petri Savolainen
Reviewed-by: Christophe Milard
> ---
> example/classifier/odp_classifier.c | 7 ++-
>
On 2015-06-09 11:19, Petri Savolainen wrote:
> Added default cpumask functions for worker and control threads.
> These will replace odph_linux_cpumask_default() helper. CPU masks
> and IDs are system specific, API is generic.
>
> Signed-off-by: Petri Savolainen
Reviewed-by: Christophe Milard
>
On 2015-06-09 11:19, Petri Savolainen wrote:
> The call sets all possible CPUs in the mask. It's system specific which
> CPUs are actually available to the application.
>
> Signed-off-by: Petri Savolainen
Reviewed-by: Christophe Milard
> ---
> include/odp/api/cpumask.h| 15 +++
Also adds a check of sscanf return value to make checkpatch happy
Signed-off-by: Nicolas Morey-Chaisemartin
---
example/classifier/odp_classifier.c | 6 --
example/timer/odp_timer_test.c | 3 ++-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/example/classifier/odp_class
We updated checkpatch so older code may not be compliant now, we always
need a patch to pass the current checkpatch.
The new checkpatch now generates these warning s in the old code
https://ci.linaro.org/job/odp-api-style-check/label=build/466/console
On 9 June 2015 at 08:38, Nicolas Morey-Chaise
Although implementation (linux-generic) is using the API calls, it can do short
cuts e.g. ensure that queue_enq will never fail (abort instead of fail) and
then exploit that knowledge. The implementation gets more complex if any "API
call" it uses can fail as specified by the API spec.
> ---
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Zoltan Kiss
> Sent: Friday, June 05, 2015 8:51 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCH v3 4/9] api: event: define
> odp_event_free()
>
> We need a convenient f
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Zoltan Kiss
> Sent: Friday, June 05, 2015 8:51 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCH v3 3/9] packet_io: release unsent
> packets after odp_pktio_send()
>
> S
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Zoltan Kiss
> Sent: Friday, June 05, 2015 8:51 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCH v3 1/9] api: packet_io: clarify what
> happens when not all packets are s
One question about this:
I added spaces between the string and the PRIx32 macro because checkpatch
generated a warning when I didn't.
However most source files I've seen do not add spaces.
What is your preferred way? Does check patch needs to be updated to remove this
specific warning, or shoul
On our arch, int32_t is defined as long, not int (same for x86 if I remember
correctly):
/work1/nmorey/workspace/alternates/mOS/odp/test/performance/odp_pktio_perf.c:
In function ‘run_test’:
/work1/nmorey/workspace/alternates/mOS/odp/test/performance/odp_pktio_perf.c:654:2:
error: format ‘%d’ ex
A rebase would have eliminated this from the series.
From: ext Bill Fischofer [mailto:bill.fischo...@linaro.org]
Sent: Tuesday, June 09, 2015 2:47 PM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: lng-odp@lists.linaro.org
Subject: Re: [lng-odp] [API-NEXT PATCHv2 1/3] api: packet: remove stale v0.5
Reviewed-by: Petri Savolainen
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Bill Fischofer
> Sent: Tuesday, June 02, 2015 5:45 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCHv2] api: pool: remove shm paramter from
On 06/09/15 11:06, Nicolas Morey-Chaisemartin wrote:
- printf("\tTransmit batch length:\t%d\n", gbl_args->args.tx_batch_len);
- printf("\tReceive batch length: \t%d\n", gbl_args->args.rx_batch_len);
+ printf("\tTransmit batch length:\t%" PRIu32 "\n",
+ gbl_args->arg
I agree. Some additional APIs for this area would be useful.
On Tue, Jun 9, 2015 at 6:42 AM, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
>
>
> > -Original Message-
> > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> > Bill Fischofe
On 9 June 2015 at 04:06, Nicolas Morey-Chaisemartin
wrote:
> Signed-off-by: Nicolas Morey-Chaisemartin
>
Reviewed-by: Mike Holmes
> ---
> test/validation/odp_packet.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/test/validation/odp_packet.c b/test/validation/odp_packet.c
> inde
On 9 June 2015 at 04:08, Nicolas Morey-Chaisemartin
wrote:
> On some systems, char is mapped to unsigned char which causes gcc to issue
> this warning:
> test/validation/ver_abt_log_dbg/odp_system.c:23:7: error: array subscript
> has type ‘char’ [-Werror=char-subscripts]
> Manually casting from c
I included it for completeness since Part 2 needs this part to get the line
numbers for the diff correct.
On Tue, Jun 9, 2015 at 6:28 AM, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolai...@nokia.com> wrote:
> This is not "v2" - it has been already merged.
>
> -Petri
>
> > -Original Messa
On 9 June 2015 at 04:06, Nicolas Morey-Chaisemartin
wrote:
> Signed-off-by: Nicolas Morey-Chaisemartin
>
Reviewed-by: Mike Holmes
> ---
> test/performance/odp_pktio_perf.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/test/performance/odp_pktio_perf.c
> b/te
Module pktio now gets its own directory and create its own lib
(currentely only containing its executable)
Startup scripting stuff is just moved to the pktio directory but remains
untouched at this stage (test is still ran from validation side)
Signed-off-by: Christophe Milard
---
configure.ac
The platform specific scripts for pktio are now moved
from the validation to the platform side.
Pktio tests are now initiated from the platform side.
Signed-off-by: Christophe Milard
---
configure.ac | 1 +
platform/linux-generic/test/.gitignore
When tests will be ran from the platform side, they will use
platform agnostic tests from the validation side: i.e.
-the validation side must be build before the platform test side.
And the platform agnostic tests uses ODP.
The building order must therefore be as follows:
1) (i.e. ODP)
2) validat
These are no longer referenced and should not be used as they introduce
platform dependency which should no longer occur in this platform
agnostic part.
Signed-off-by: Christophe Milard
---
test/validation/Makefile.am | 2 --
1 file changed, 2 deletions(-)
diff --git a/test/validation/Makefile.
In odp_cunit_common.c, a macro, called MODULE_HAS_OWN_MAIN is used to tell
whether to define a main or not.
If MODULE_HAS_OWN_MAIN is defined, odp_cunit_common.c does not
define any main, but offers odp_cunit_run(CU_SuiteInfo testsuites[])
to run the tests.
Two libs are then built, one with MODULE_
Renaming of things which may be, one day, exported in a lib.
This renaming is important, as it creates consistency between test
symbols, which is needed if things get eventually exported in the lib.
Also, tests are often created from other tests: Fixing the first exemples
will help geting future te
Signed-off-by: Christophe Milard
---
test/validation/Makefile.am | 2 ++
test/validation/odp_pktio.c | 15 +--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
index e1474aa..d4bbdb5 100644
--- a/test/validation
since V3: '.' added in pktio_run search PATH for pktio_main.
All patches already reviewed by Stuart and Mike, except patch 7
All Patched unchanged except patch7 (validation: moving pktio
plt specific to platform).
--
This series of patches comes following the req
Preparing for the next patch where this file is moved and
check-odp would yell if these things were still there.
Signed-off-by: Christophe Milard
Reviewed-by: Stuart Haslam
---
test/validation/odp_pktio.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/test/val
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Bill Fischofer
> Sent: Thursday, June 04, 2015 7:23 AM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCHv2 3/3] api: packet: clarify valid len
> range on alloc
>
> Signed-o
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Bill Fischofer
> Sent: Thursday, June 04, 2015 7:23 AM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCHv2 2/3] api: buffer: clarify pool handle
> on alloc
>
> Signed-off-b
This is not "v2" - it has been already merged.
-Petri
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Bill Fischofer
> Sent: Thursday, June 04, 2015 7:23 AM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [API-NEXT PATCHv2 1/3] api: pa
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Maxim Uvarov
> Sent: Tuesday, June 09, 2015 1:14 PM
> To: lng-odp@lists.linaro.org
> Subject: Re: [lng-odp] [API-NEXT PATCH v2 4/4] api: init: added thread
> type to local init
>
> On 05/08/
On 05/08/15 10:07, Petri Savolainen wrote:
--- a/helper/linux.c
+++ b/helper/linux.c
@@ -60,7 +60,7 @@ static void *odp_run_start_routine(void *arg)
odp_start_args_t *start_args = arg;
/* ODP thread local init */
- if (odp_init_local()) {
+ if (odp_init_local(ODP_THREAD
Ping. Is there still something unclear? Other patches are already using
definitions of "worker" vs. "control" threads.
-Petri
> -Original Message-
> From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext
> Savolainen, Petri (Nokia - FI/Espoo)
> Sent: Tuesday, June 02, 2
Thanks, fixed both issues in v3.
- Petri
From: ext Christophe Milard [mailto:christophe.mil...@linaro.org]
Sent: Tuesday, June 09, 2015 9:30 AM
To: Savolainen, Petri (Nokia - FI/Espoo)
Cc: LNG ODP Mailman List
Subject: Re: [lng-odp] [API-NEXT PATCH v2 1/3] api: cpumask: added
cpumask_setall
The linux specific helper was replaced by default cpumask
calls (odp_cpumask_def_worker()) in the cpumask API.
Signed-off-by: Petri Savolainen
---
example/classifier/odp_classifier.c | 7 ++-
example/generator/odp_generator.c | 7 ++-
example/ipsec/odp_ipsec.c
Added default cpumask functions for worker and control threads.
These will replace odph_linux_cpumask_default() helper. CPU masks
and IDs are system specific, API is generic.
Signed-off-by: Petri Savolainen
---
include/odp/api/cpumask.h| 24 +++
platform/linux-gen
The call sets all possible CPUs in the mask. It's system specific which
CPUs are actually available to the application.
Signed-off-by: Petri Savolainen
---
include/odp/api/cpumask.h| 15 +--
platform/linux-generic/odp_cpumask.c | 8
2 files changed, 21 insertion
Please ignore this one (just posted v2). I broke the indentation while trying
to understand the warning message :)
On 06/09/2015 10:06 AM, Nicolas Morey-Chaisemartin wrote:
> On some systems, char is mapped to unsigned char which causes gcc to issue
> this warning:
> test/validation/ver_abt_log_
On some systems, char is mapped to unsigned char which causes gcc to issue this
warning:
test/validation/ver_abt_log_dbg/odp_system.c:23:7: error: array subscript has
type ‘char’ [-Werror=char-subscripts]
Manually casting from char to int should fix issue on both (signed or unsigned)
types of sy
On some systems, char is mapped to unsigned char which causes gcc to issue this
warning:
test/validation/ver_abt_log_dbg/odp_system.c:23:7: error: array subscript has
type ‘char’ [-Werror=char-subscripts]
Manually casting from char to int should fix issue on both (signed or unsigned)
types of sy
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/validation/odp_packet.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/test/validation/odp_packet.c b/test/validation/odp_packet.c
index a363438..5915aba 100644
--- a/test/validation/odp_packet.c
+++ b/test/validation/odp_packet.c
@@ -62,9
Signed-off-by: Nicolas Morey-Chaisemartin
---
test/performance/odp_pktio_perf.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test/performance/odp_pktio_perf.c
b/test/performance/odp_pktio_perf.c
index 17975bf..6d9b66c 100644
--- a/test/performance/odp_pktio_perf.c
++
Small patch series to remove compiler warnings on our system
Nicolas Morey-Chaisemartin (3):
performance: pktio_perf: use PRIu32 to printf uint32_t
validation: packet: remove debug messages
validation: system: manually cast char to int
test/performance/odp_pktio_perf.c| 6 -
55 matches
Mail list logo
