[lng-odp] [PATCHv2 2/3] checkpatch: remove line length limit for examples and tests log functions

Signed-off-by: Nicolas Morey-Chaisemartin --- scripts/checkpatch.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4bd7230..cee734a 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -365,6 +365,8 @@ our $logFunctions = qr{

[lng-odp] [PATCHv2 3/3] example: use SCNx32/PRIx32 macro

Signed-off-by: Nicolas Morey-Chaisemartin --- example/classifier/odp_classifier.c | 2 +- example/timer/odp_timer_test.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/example/classifier/odp_classifier.c b/example/classifier/odp_classifier.c index 63678b7..643e16c 10

[lng-odp] [PATCHv2 1/3] example: classifier: check sscanf return code

Signed-off-by: Nicolas Morey-Chaisemartin --- example/classifier/odp_classifier.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/example/classifier/odp_classifier.c b/example/classifier/odp_classifier.c index 48fc1ab..63678b7 100644 --- a/example/classifier/odp_classif

[lng-odp] [PATCHv2] linux-generic: crypto: eliminate buffer type hack for completions

Signed-off-by: Bill Fischofer --- .../linux-generic/include/odp_buffer_inlines.h | 9 ++ .../linux-generic/include/odp_buffer_internal.h| 1 + .../linux-generic/include/odp_packet_internal.h| 4 +++ platform/linux-generic/odp_crypto.c| 32 ++

Re: [lng-odp] [PATCH 2/2] example: use SCNx32/PRIx32 macro

On 10 June 2015 at 08:49, Maxim Uvarov wrote: > On 06/10/15 15:34, Nicolas Morey-Chaisemartin wrote: > >> >> On 06/10/2015 02:32 PM, Maxim Uvarov wrote: >> >>> On 06/10/15 15:26, Nicolas Morey-Chaisemartin wrote: >>> On 06/10/2015 02:20 PM, Maxim Uvarov wrote: > On 06/10/15 15:06, N

[lng-odp] [PATCHv5 5/8] validation: creating own dir and lib for pktio

Module pktio now gets its own directory and create its own lib (currentely only containing its executable) Startup scripting stuff is just moved to the pktio directory but remains untouched at this stage (test is still ran from validation side) Signed-off-by: Christophe Milard Reviewed-by: Mike H

[lng-odp] [PATCHv5 7/8] validation: moving pktio plt specific to platform

The platform specific scripts for pktio are now moved from the validation to the platform side. Pktio tests are now initiated from the platform side. Signed-off-by: Christophe Milard --- configure.ac | 1 + platform/linux-generic/test/.gitignore

[lng-odp] [PATCHv5 8/8] validation: removing obsolete environment variable

These are no longer referenced and should not be used as they introduce platform dependency which should no longer occur in this platform agnostic part. Signed-off-by: Christophe Milard Reviewed-by: Mike Holmes Reviewed-by: Stuart Haslam --- test/validation/Makefile.am | 2 -- 1 file changed,

[lng-odp] [PATCHv5 6/8] validation: changing build order

When tests will be ran from the platform side, they will use platform agnostic tests from the validation side: i.e. -the validation side must be build before the platform test side. And the platform agnostic tests uses ODP. The building order must therefore be as follows: 1) (i.e. ODP) 2) validat

[lng-odp] [PATCHv5 4/8] validation: cosmetic fixes in odp_pktio.c

Preparing for the next patch where this file is moved and check-odp would yell if these things were still there. Signed-off-by: Christophe Milard Reviewed-by: Mike Holmes Reviewed-by: Stuart Haslam --- test/validation/odp_pktio.c | 13 - 1 file changed, 4 insertions(+), 9 deletions

[lng-odp] [PATCHv5 3/8] validation: renaming in odp_pktio.c

Renaming of things which may be, one day, exported in a lib. This renaming is important, as it creates consistency between test symbols, which is needed if things get eventually exported in the lib. Also, tests are often created from other tests: Fixing the first exemples will help geting future te

[lng-odp] [PATCHv5 1/8] validation: preparing for main in tests

In odp_cunit_common.c, a macro, called MODULE_HAS_OWN_MAIN is used to tell whether to define a main or not. If MODULE_HAS_OWN_MAIN is defined, odp_cunit_common.c does not define any main, but offers odp_cunit_run(CU_SuiteInfo testsuites[]) to run the tests. Two libs are then built, one with MODULE_

[lng-odp] [PATCHv5 2/8] validation: own main in odp_pktio.c

Signed-off-by: Christophe Milard Reviewed-by: Mike Holmes Reviewed-by: Stuart Haslam --- test/validation/Makefile.am | 2 ++ test/validation/odp_pktio.c | 15 +-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/test/validation/Makefile.am b/test/validation/Makefile.

[lng-odp] [PATCHv5 0/8] pktio test move to platform side

since V4: *Added condition in platform/linux-generic/Makefile.am to avoid building these tests when not required. *pktio_run prefixes $PATH (rather than suffix) to avoid possible wrong pktio_main selection All Patched unchanged except patch7 (validation: moving pktio plt specific to platform).

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

The proposal I described during today's ARCH meeting is to add an explicit event type to buffers so that when buffers (of whatever flavor) are being used as events this field can be interrogated without needing to overwrite the buffer type field. As I mentioned, I'll post a patch for this later to

Re: [lng-odp] [PATCH] configure: remove extra result message

Merged, thanks, Maxim. On 06/05/15 15:22, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 89b0846..ed74b4a 100644 --- a/configure.ac +++ b/config

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Init API and thread type

Merged! Thanks, Maxim. On 05/08/15 10:07, Petri Savolainen wrote: Introduce thread types: worker and control. Implementations may be HW limited how many worker threads can be supported. Number of control threads may be only SW limited. Note: This series depends on "example: classifier: remove

Re: [lng-odp] [PATCH] validation: pktio: don't use reserved UDP port 0

We need the fix for IP address also in the same function as the src and dst ip address are also kept as zero. Regards, Bala On 10 June 2015 at 20:55, Maxim Uvarov wrote: > I always fix that for debugging :) > > Maxim. > > On 06/10/15 18:00, Stuart Haslam wrote: > >> The test generates UDP packe

Re: [lng-odp] Apply multiple filters using ODP Classifier API

Hi Genís, Sorry that I had not explained about the second part of your question in the previous mail, The composite pmr (odp_pmr_match_t ) succeeds only if it matches ALL the values in the odp_pmr_set_t it is an AND operation and not an OR operation. The entire set either matches or does not matc

Re: [lng-odp] [PATCH] validation: pktio: don't use reserved UDP port 0

I always fix that for debugging :) Maxim. On 06/10/15 18:00, Stuart Haslam wrote: The test generates UDP packets with the src and dest port numbers set to 0, which is a reserved port so may lead some to the packets being dropped and the test failing. Change to use some other arbitrary port numb

[lng-odp] [PATCH] validation: pktio: don't use reserved UDP port 0

The test generates UDP packets with the src and dest port numbers set to 0, which is a reserved port so may lead some to the packets being dropped and the test failing. Change to use some other arbitrary port numbers. Signed-off-by: Stuart Haslam --- This is a fix for; https://bugs.linaro.org/sho

[lng-odp] [PATCH 2/2] validation: timer: introduce CONFIG_MIN_TICK option in timer test case

This option is to specify minimum number ticks (delta between future tick and current tick) required to successfully reset/set the timer. some hardware timer implementations needs at least two ticks gap between "current tick" and "future tick" to cancel/set timer and let timer test case aware of t

[lng-odp] [PATCH 1/2] validation: timer: added an assert to catch any timer dispatch race to different worker and/or queue

timer validation program creates each worker thread and associate a private queue for event delivery. With out this assert its difficult debug if there is any race issue in timer event dispatch. Signed-off-by: Jerin Jacob --- test/validation/odp_timer.c | 6 +- 1 file changed, 5 insertions(+

Re: [lng-odp] Apply multiple filters using ODP Classifier API

Hi Bala, First of all, thanks a lot for your response. I think I've explained myself wrong in the previous mail, so I'll try to express myself in a better way. The scanerio I propose has two filter, eahc one composed by a set of PMR. The problem is that I want the packet classified in "Queue1" if

[lng-odp] [Bug 1632] New: validation: pktio test generates UDP packets with reserved port 0

https://bugs.linaro.org/show_bug.cgi?id=1632 Bug ID: 1632 Summary: validation: pktio test generates UDP packets with reserved port 0 Product: OpenDataPlane Version: 1.1 Hardware: Other OS: Linux

Re: [lng-odp] Bug 620 (https://bugs.linaro.org/show_bug.cgi?id=620) clarifications

Hi Robbie, it definitely helps. Thanks, Alex On 10 June 2015 at 16:24, Robbie King (robking) wrote: > Hey Alex, hope you’re doing well! Sorry there weren’t more details in > the bug. > > > > By “add counters”, the intention was simply to add some periodic > statistics for > > “normal” (i.e. l

Re: [lng-odp] Apply multiple filters using ODP Classifier API

Hi, There is a possibility in classification configuration to attach multiple PMR rules at the pktio level. I believe the above example you have described could be solved using the following rules pmr1 = odp_pmr_create(rule1); pmr2 = odp_pmr_create(rule2); odp_pktio_pmr_match_set_cos(pmr1, src_p

Re: [lng-odp] Bug 620 (https://bugs.linaro.org/show_bug.cgi?id=620) clarifications

Hey Alex, hope you’re doing well! Sorry there weren’t more details in the bug. By “add counters”, the intention was simply to add some periodic statistics for “normal” (i.e. live traffic) mode and summary statistics for the “stream” (i.e. standalone test) mode to make it easier to determine what

Re: [lng-odp] [PATCH 1/2] example: classifier: check sscanf return code

Reviewed-by: Balasubramanian Manoharan On 10 June 2015 at 17:36, Nicolas Morey-Chaisemartin wrote: > Signed-off-by: Nicolas Morey-Chaisemartin > --- > example/classifier/odp_classifier.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/example/classifier/odp_clas

[lng-odp] [API-NEXT PATCH] pool: clarify use of odp_pool_destroy()

The intended use of odp_pool_destroy() is during a controlled termination of an application, rather than to support pools being dynamically created and destroyed. Signed-off-by: Stuart Haslam --- include/odp/api/pool.h | 4 1 file changed, 4 insertions(+) diff --git a/include/odp/api/pool.

Re: [lng-odp] [PATCH 2/2] example: use SCNx32/PRIx32 macro

On 06/10/15 15:34, Nicolas Morey-Chaisemartin wrote: On 06/10/2015 02:32 PM, Maxim Uvarov wrote: On 06/10/15 15:26, Nicolas Morey-Chaisemartin wrote: On 06/10/2015 02:20 PM, Maxim Uvarov wrote: On 06/10/15 15:06, Nicolas Morey-Chaisemartin wrote: /* Not the expected expiratio

Re: [lng-odp] [PATCH 2/2] example: use SCNx32/PRIx32 macro

On 10 June 2015 at 14:26, Nicolas Morey-Chaisemartin wrote: > > > On 06/10/2015 02:20 PM, Maxim Uvarov wrote: > > On 06/10/15 15:06, Nicolas Morey-Chaisemartin wrote: > >> > >> /* Not the expected expiration tick, timer has > >>* been reset or cancelled or freed */ >

Re: [lng-odp] [PATCH 2/2] example: use SCNx32/PRIx32 macro

On 06/10/2015 02:32 PM, Maxim Uvarov wrote: > On 06/10/15 15:26, Nicolas Morey-Chaisemartin wrote: >> >> On 06/10/2015 02:20 PM, Maxim Uvarov wrote: >>> On 06/10/15 15:06, Nicolas Morey-Chaisemartin wrote: /* Not the expected expiration tick, timer has * b

Re: [lng-odp] [PATCH 2/2] example: use SCNx32/PRIx32 macro

On 06/10/15 15:26, Nicolas Morey-Chaisemartin wrote: On 06/10/2015 02:20 PM, Maxim Uvarov wrote: On 06/10/15 15:06, Nicolas Morey-Chaisemartin wrote: /* Not the expected expiration tick, timer has * been reset or cancelled or freed */ -EXAMPLE_ABORT("

Re: [lng-odp] [PATCH 2/2] example: use SCNx32/PRIx32 macro

On 06/10/2015 02:20 PM, Maxim Uvarov wrote: > On 06/10/15 15:06, Nicolas Morey-Chaisemartin wrote: >> >> /* Not the expected expiration tick, timer has >>* been reset or cancelled or freed */ >> -EXAMPLE_ABORT("Unexpected timeout received (timer %x, tick

Re: [lng-odp] [PATCH 2/2] example: use SCNx32/PRIx32 macro

On 06/10/15 15:06, Nicolas Morey-Chaisemartin wrote: Signed-off-by: Nicolas Morey-Chaisemartin --- example/classifier/odp_classifier.c | 2 +- example/timer/odp_timer_test.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/example/classifier/odp_classifier.c b/e

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

On 10 June 2015 at 13:57, Ola Liljedahl wrote: > As Petri writes, the type of a crypto completion event must be visible to > the user (who is receiving the event and responsible for figuring out what > to do with those events). Different types of events may be received from > the same queue and r

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

Hi, in my opinion crypto completion event is required as the packet output only is not enough for the application to get the operation status in the async operation case. Also for out-of-place mode the input packet may be returned to the application - the fact is that output from crypto is always a

Re: [lng-odp] [PATCH] example: use PRIx32 macro

Fixed and split into two patches so Mike is happier too ;) On 06/10/2015 12:18 PM, Maxim Uvarov wrote: > On 06/09/15 17:26, Nicolas Morey-Chaisemartin wrote: >> Also adds a check of sscanf return value to make checkpatch happy >> >> Signed-off-by: Nicolas Morey-Chaisemartin >> --- >> example/cl

[lng-odp] [PATCH 2/2] example: use SCNx32/PRIx32 macro

Signed-off-by: Nicolas Morey-Chaisemartin --- example/classifier/odp_classifier.c | 2 +- example/timer/odp_timer_test.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/example/classifier/odp_classifier.c b/example/classifier/odp_classifier.c index 63678b7..643e16c

[lng-odp] [PATCH 1/2] example: classifier: check sscanf return code

Signed-off-by: Nicolas Morey-Chaisemartin --- example/classifier/odp_classifier.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/example/classifier/odp_classifier.c b/example/classifier/odp_classifier.c index 48fc1ab..63678b7 100644 --- a/example/classifier/odp_classif

Re: [lng-odp] [PATCHv4 7/8] validation: moving pktio plt specific to platform

On 10 June 2015 at 11:17, Maxim Uvarov wrote: > On 06/10/15 11:37, Christophe Milard wrote: > >> Hi, >> I would agree with you, but saddly pktio_env (which is defined under >> platform/linux-generic/test/pktio) is also used in the performance tests. >> pktio_env was before packed in the debian pa

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

As Petri writes, the type of a crypto completion event must be visible to the user (who is receiving the event and responsible for figuring out what to do with those events). Different types of events may be received from the same queue and require different action. I think it is useful for an imp

[lng-odp] Apply multiple filters using ODP Classifier API

Hi, I've used the linux-generic implementation of ODP since few month ago, and I would like to implement a classification system based on multiple filters. My scenario is as follows (arbitrary example, not real values): Imagine that you want classify packets matching the following set of filters:

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

OK, let me take another look at this. I notice odp_crypto.c has this routine: /* * @todo This is a serious hack to allow us to use packet buffer to convey * crypto operation results by placing them at the very end of the * packet buffer. The issue should be resolved shortly once t

Re: [lng-odp] [API-NEXT PATCH v3 1/3] api: cpumask: added cpumask_setall

Merged, Thanks, Maxim. On 06/09/15 11:19, Petri Savolainen wrote: The call sets all possible CPUs in the mask. It's system specific which CPUs are actually available to the application. Signed-off-by: Petri Savolainen --- include/odp/api/cpumask.h| 15 +-- platform/l

Re: [lng-odp] [API-NEXT PATCHv2] api: pool: remove shm paramter from odp_pool_create()

Merged, Thanks, Maxim. On 06/09/15 15:03, Savolainen, Petri (Nokia - FI/Espoo) wrote: Reviewed-by: Petri Savolainen -Original Message- From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Bill Fischofer Sent: Tuesday, June 02, 2015 5:45 PM To: lng-odp@lists.linar

Re: [lng-odp] [PATCH] doc: use only WITH_PLATFORM and not always linux-generic

Merged, thanks. On 06/08/15 19:01, Mike Holmes wrote: On 5 June 2015 at 08:22, Nicolas Morey-Chaisemartin > wrote: Signed-off-by: Nicolas Morey-Chaisemartin mailto:nmo...@kalray.eu>> Reviewed-by: Mike Holmes http://inaro.org>> :) I think we should not impo

Re: [lng-odp] [PATCH] example: use PRIx32 macro

On 06/09/15 17:26, Nicolas Morey-Chaisemartin wrote: Also adds a check of sscanf return value to make checkpatch happy Signed-off-by: Nicolas Morey-Chaisemartin --- example/classifier/odp_classifier.c | 6 -- example/timer/odp_timer_test.c | 3 ++- 2 files changed, 6 insertions(+),

Re: [lng-odp] [PATCH v1] validation: timer: save expected expiration tick only on success

Merged, Thanks, Maxim. On 06/10/15 11:09, Jerin Jacob wrote: On Tue, Jun 09, 2015 at 08:26:28AM +0530, Jerin Jacob wrote: ping. otherwise "tt[i].tick" in "handle_tmo" will be a wrong value in case timer set failed due to ODP_TIMER_NOEVENT(failed to cancel the outstanding timer). some hardwar

Re: [lng-odp] [PATCH 0/3] Warning fixes

Merged, thanks, Maxim. On 06/09/15 11:04, Nicolas Morey-Chaisemartin wrote: Small patch series to remove compiler warnings on our system Nicolas Morey-Chaisemartin (3): performance: pktio_perf: use PRIu32 to printf uint32_t validation: packet: remove debug messages validation: system:

[lng-odp] [PATCH 1/2 v3] examples: ipsec: tunnel mode support

From: Alexandru Badicioiu Tunnel mode is enabled from the command line using -t argument with the following format: SrcIP:DstIP:TunnelSrcIP:TunnelDstIP. SrcIP - cleartext packet source IP DstIP - cleartext packet destination IP TunnelSrcIP - tunnel source IP TunnelDstIP - tunnel destination IP T

Re: [lng-odp] [PATCH 1/2 v2] examples: ipsec: tunnel mode support

Merged! On 06/10/15 12:04, Anders Roxell wrote: On 2015-05-22 14:44, alexandru.badici...@linaro.org wrote: From: Alexandru Badicioiu v1 - added comment for tunnel DB entry use v2 - fixed tun pointer initialization, new checkpatch compliance This should not be in the changelog. Anders Thank

Re: [lng-odp] [PATCHv4 7/8] validation: moving pktio plt specific to platform

On 06/10/15 11:37, Christophe Milard wrote: Hi, I would agree with you, but saddly pktio_env (which is defined under platform/linux-generic/test/pktio) is also used in the performance tests. pktio_env was before packed in the debian package, despite the fact that the tests were not. So, If we

Re: [lng-odp] [PATCH 1/2 v2] examples: ipsec: tunnel mode support

On 2015-05-22 14:44, alexandru.badici...@linaro.org wrote: > From: Alexandru Badicioiu > > v1 - added comment for tunnel DB entry use > v2 - fixed tun pointer initialization, new checkpatch compliance This should not be in the changelog. Anders > > Tunnel mode is enabled from the command line

Re: [lng-odp] [PATCHv4 7/8] validation: moving pktio plt specific to platform

Christophe, if we do not package other tests to deb then there is no need to package pktio tests also. In that patch you can extend if test_vald on next 2 lines: --- a/platform/linux-generic/test/Makefile.am +++ b/platform/linux-generic/test/Makefile.am @@ -2,7 +2,9 @@ TESTS_ENVIRONMENT = TEST_

Re: [lng-odp] [PATCHv4 7/8] validation: moving pktio plt specific to platform

On 06/09/15 14:44, Christophe Milard wrote: The platform specific scripts for pktio are now moved from the validation to the platform side. Pktio tests are now initiated from the platform side. Signed-off-by: Christophe Milard --- configure.ac | 1 + pl

Re: [lng-odp] [PATCHv4 7/8] validation: moving pktio plt specific to platform

Hi, I would agree with you, but saddly pktio_env (which is defined under platform/linux-generic/test/pktio) is also used in the performance tests. pktio_env was before packed in the debian package, despite the fact that the tests were not. So, If we really want to do something now, it would then b

Re: [lng-odp] [PATCHv4 7/8] validation: moving pktio plt specific to platform

Christophe, if we do not package other tests to deb then there is no need to package pktio tests also. In that patch you can extend if test_vald on next 2 lines: --- a/platform/linux-generic/test/Makefile.am +++ b/platform/linux-generic/test/Makefile.am @@ -2,7 +2,9 @@ TESTS_ENVIRONMENT = TEST_

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of ext Christophe Milard Sent: Wednesday, June 10, 2015 10:18 AM To: Bill Fischofer Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions On 10 June 2015 at 0

Re: [lng-odp] [PATCH v1] validation: timer: save expected expiration tick only on success

On Tue, Jun 09, 2015 at 08:26:28AM +0530, Jerin Jacob wrote: ping. > otherwise "tt[i].tick" in "handle_tmo" will be a wrong value > in case timer set failed due to > ODP_TIMER_NOEVENT(failed to cancel the outstanding timer). > > some hardware timer implementations needs at least two ticks gap be

Re: [lng-odp] [PATCH] linux-generic: crypto: eliminate buffer type hack for completions

On 10 June 2015 at 04:50, Bill Fischofer wrote: > odp_crypto_operation() should not change underlying buffer types for > completions as these are purely internal and not needed, and doing > so is confusing and error-prome. > > Yes, Bill, I would prefer your approach: my patch felt like a hack to