Re: [lng-odp] [API-NEXT PATCH] validation: common: fix VPATH builds

2015-07-23 Thread Maxim Uvarov
So no objections about patch itself? Maxim. On 07/23/15 20:23, Mike Holmes wrote: On 23 July 2015 at 13:03, Stuart Haslam stuart.has...@linaro.org mailto:stuart.has...@linaro.org wrote: On Thu, Jul 23, 2015 at 12:43:01PM -0400, Mike Holmes wrote: sing patch:

Re: [lng-odp] [PATCH] m4: pthread: fix warning with Wextra

2015-07-23 Thread Anders Roxell
On 2015-07-15 16:03, Nicolas Morey-Chaisemartin wrote: When adding both Wextra and Werror to CPPFLAGS, configure fails due to a warning during the pthread configuration phase: | #include pthread.h | static void routine(void *a) { a = 0; } |

Re: [lng-odp] [PATCH] linux-generic: Makefile.am: fix basename conflicts

2015-07-23 Thread Mike Holmes
On 23 July 2015 at 05:34, Maxim Uvarov maxim.uva...@linaro.org wrote: I think that patch is not correct. Main problem that odp source for linux-generic has to be arch independent. We decided to allow ARCH optimization where it did not compromise linux-generics goal of being a clear

Re: [lng-odp] api-next gerrit

2015-07-23 Thread Mike Holmes
Yes, we need to do a local trail of all of this before making a switch. Docker is important for those who want to confirm their patch will not be immediately rejected by gerrit using the exact same environment and the check-odp scripts, but most people are managing their own environment currently

Re: [lng-odp] [API-NEXT PATCH] validation: common: fix VPATH builds

2015-07-23 Thread Mike Holmes
On 23 July 2015 at 17:08, Maxim Uvarov maxim.uva...@linaro.org wrote: So no objections about patch itself? Not form me, just need to update checkpatch to not warn on gerrit IDs when used with ODP Maxim. On 07/23/15 20:23, Mike Holmes wrote: On 23 July 2015 at 13:03, Stuart Haslam

[lng-odp] [PATCH] example: ipsec: fix copy/paste error in README

2015-07-23 Thread Stuart Haslam
Instructions should include adding static ARP entry as per the instructions for the other end of the tunnel on line #138. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- example/ipsec/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/example/ipsec/README

[lng-odp] [PATCH] Remove unwanted gitignore file

2015-07-23 Thread Stuart Haslam
Looks like this was added by mistake (note the missing .) there is a .gitignore file in the same directory. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- test/miscellaneous/gitignore | 1 - 1 file changed, 1 deletion(-) delete mode 100644 test/miscellaneous/gitignore diff --git

Re: [lng-odp] [PATCH] Remove unwanted gitignore file

2015-07-23 Thread Maxim Uvarov
On 07/23/15 17:21, Stuart Haslam wrote: Looks like this was added by mistake (note the missing .) there is a .gitignore file in the same directory. Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- test/miscellaneous/gitignore | 1 - 1 file changed, 1 deletion(-) delete mode 100644

[lng-odp] [Bug 1701] validation/packet assumes the number of available segments

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1701 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added CC||mike.hol...@linaro.org

[lng-odp] [RFC-PATCH 2/3] test: removing current dir from -I

2015-07-23 Thread Christophe Milard
The goal of this patch is to remove the src directory and current directory from the standard include search path (gcc -Ipath), so that #include ... and #include ... actually search different locations. This enables standard filenames (such as errno.h) to be used locally. Signed-off-by:

[lng-odp] [Bug 1688] CID 98427: /example/packet/odp_pktio.c

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1688 --- Comment #4 from Mike Holmes mike.hol...@linaro.org --- (In reply to Mike Holmes from comment #3) https://bugs.linaro.org/show_bug.cgi?id=1698 Bad paste commit d2b3247f56570cdeee0da660075bbe2fb8647d90 -- You are receiving this mail because: You

[lng-odp] [Bug 1001] linux-generic: schedule: priority scheduling broken for one thread

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1001 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[lng-odp] [API-NEXT PATCH] validation: common: fix VPATH builds

2015-07-23 Thread Stuart Haslam
libs are in $(top_builddir) rather than $(top_srcdir). Change-Id: Icc73306eabc211cbb77d4fa57d493f7ebbea7447 Signed-off-by: Stuart Haslam stuart.has...@linaro.org --- test/validation/Makefile.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/validation/Makefile.inc

[lng-odp] [Bug 1546] Untested API verify_pmr_udp_dport

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1546 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Ever confirmed|0 |1

[lng-odp] [Bug 1542] Untested API verify_pmr_ip_proto

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1542 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever

[lng-odp] [Bug 1544] Untested API verify_pmr_tcp_sport

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1544 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever

[lng-odp] [Bug 1615] odp_timer fails in CI with Segmentation fault

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1615 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|CONFIRMED |IN_PROGRESS --- Comment

[lng-odp] [Bug 1469] ./odp_timer_test -r0 does not check -r for invalid case of 0

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1469 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Resolution|--- |WONTFIX

[lng-odp] [Bug 1545] Untested API verify_pmr_tcp_dport

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1545 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever

[lng-odp] [Bug 1706] odp_term_local() not being called from main thread

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1706 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added CC||mike.hol...@linaro.org

[lng-odp] [Bug 1541] Untested API verify_pmr_packet_len

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1541 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Status|UNCONFIRMED |IN_PROGRESS Ever

[lng-odp] [Bug 1543] Untested API verify_pmr_ipv4_daddr

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1543 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Ever confirmed|0 |1

[lng-odp] [RFC-PATCH 3/3] validation: errno: populate lib

2015-07-23 Thread Christophe Milard
Signed-off-by: Christophe Milard christophe.mil...@linaro.org --- test/validation/errno/errno.c | 2 +- test/validation/errno/errno.h | 12 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/test/validation/errno/errno.c b/test/validation/errno/errno.c index

[lng-odp] [RFC-PATCH 0/3] validation: errno: populating lib

2015-07-23 Thread Christophe Milard
This is a try to fix the problem met with module errno (and conflicting filename errno.h) The RFC regards patch2 of the series, which is removing '-I.' from the gcc default options (as seen from automake) The goal is that #include ... and #include ... should search different paths. I could not see

[lng-odp] [RFC-PATCH 1/3] validation: errno: adding missing include

2015-07-23 Thread Christophe Milard
Signed-off-by: Christophe Milard christophe.mil...@linaro.org --- test/validation/errno/errno.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/validation/errno/errno.c b/test/validation/errno/errno.c index ac1d93c..65da40f 100644 --- a/test/validation/errno/errno.c +++

Re: [lng-odp] [PATCH 3/3] linux-generic: pktio: handle transmit errors correctly

2015-07-23 Thread Mike Holmes
Any progress with https://bugs.linaro.org/show_bug.cgi?id=1365 On 2 April 2015 at 11:21, Stuart Haslam stuart.has...@linaro.org wrote: On Thu, Apr 02, 2015 at 02:17:02PM +0300, Maxim Uvarov wrote: On 04/02/15 14:07, Stuart Haslam wrote: { -odp_packet_t pkt; uint8_t *frame;

Re: [lng-odp] api-next gerrit

2015-07-23 Thread Bill Fischofer
I assume this would be just for testing things out? If we're going to adopt this then I'd like to see this rolled into the docker environment (when that eventually arrives) so that the config and setup is automatic for anyone using it for development work. On Thu, Jul 23, 2015 at 6:01 AM, Mike

[lng-odp] [Bug 1365] Lock-up following sendmmsg failure

2015-07-23 Thread bugzilla-daemon
https://bugs.linaro.org/show_bug.cgi?id=1365 Mike Holmes mike.hol...@linaro.org changed: What|Removed |Added Assignee|stuart.has...@linaro.org|maxim.uva...@linaro.org

Re: [lng-odp] [API-NEXT PATCH] validation: common: fix VPATH builds

2015-07-23 Thread Stuart Haslam
On Thu, Jul 23, 2015 at 12:43:01PM -0400, Mike Holmes wrote: sing patch: lng-odp_API-NEXT_PATCH_validation_common_fix_VPATH_builds.mbox Trying to apply patch Patch applied ERROR: Remove Gerrit Change-Id's before submitting upstream. #8: Change-Id:

Re: [lng-odp] [API-NEXT PATCH] validation: common: fix VPATH builds

2015-07-23 Thread Mike Holmes
On 23 July 2015 at 13:03, Stuart Haslam stuart.has...@linaro.org wrote: On Thu, Jul 23, 2015 at 12:43:01PM -0400, Mike Holmes wrote: sing patch: lng-odp_API-NEXT_PATCH_validation_common_fix_VPATH_builds.mbox Trying to apply patch Patch applied ERROR: Remove Gerrit Change-Id's before

Re: [lng-odp] [Patch v2 2/2] example: timer: use ability to indicate that event was lost

2015-07-23 Thread Mike Holmes
Patch has warnings Using patch: lng-odp_Patch_2-2_example_timer_use_ability_to_indicate_that_event_was_lost.mbox Trying to apply patch Patch applied WARNING: line over 80 characters #40: FILE: example/timer/odp_timer_test.c:147: +if (++wait WAIT_NUM

Re: [lng-odp] [RFC-PATCH 2/3] test: removing current dir from -I

2015-07-23 Thread Stuart Haslam
On Thu, Jul 23, 2015 at 05:44:34PM +0200, Christophe Milard wrote: The goal of this patch is to remove the src directory and current directory from the standard include search path (gcc -Ipath), so that #include ... and #include ... actually search different locations. This enables standard

Re: [lng-odp] [Patch v2 1/2] example: timer: delete races while termination

2015-07-23 Thread Mike Holmes
the EXAMPLE_ABORT one might be fine, we usually accept prints that are 80 if there is no nice way to split them. Using patch: lng-odp_Patch_v2_1-2_example_timer_delete_races_while_termination.mbox Trying to apply patch Patch applied WARNING: Possible unwrapped commit description (prefer a

[lng-odp] [PATCH] doc: publish contributing and dependencies

2015-07-23 Thread Mike Holmes
Signed-off-by: Mike Holmes mike.hol...@linaro.org --- doc/doxygen.cfg | 2 +- doc/odp.dox | 9 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/doxygen.cfg b/doc/doxygen.cfg index 213a903..f28ec24 100644 --- a/doc/doxygen.cfg +++ b/doc/doxygen.cfg @@ -28,7 +28,7 @@

Re: [lng-odp] [Patch v2 1/2] example: timer: delete races while termination

2015-07-23 Thread Ivan Khoronzhuk
I will resend. Just created this patch before had added hook in git. Thanks. On 23.07.15 20:39, Mike Holmes wrote: the EXAMPLE_ABORT one might be fine, we usually accept prints that are 80 if there is no nice way to split them. Using patch:

Re: [lng-odp] [API-NEXT PATCH] validation: common: fix VPATH builds

2015-07-23 Thread Mike Holmes
sing patch: lng-odp_API-NEXT_PATCH_validation_common_fix_VPATH_builds.mbox Trying to apply patch Patch applied ERROR: Remove Gerrit Change-Id's before submitting upstream. #8: Change-Id: Icc73306eabc211cbb77d4fa57d493f7ebbea7447 We need to make changes to checkpatch possibly, looks like there

Re: [lng-odp] [API-NEXT RFC] api: packet: add define for max segmentation

2015-07-23 Thread Nicolas Morey-Chaisemartin
On 07/23/2015 07:43 AM, Bala Manoharan wrote: On 21 July 2015 at 13:05, Nicolas Morey-Chaisemartin nmo...@kalray.eu mailto:nmo...@kalray.eu wrote: On 07/20/2015 07:24 PM, Bala Manoharan wrote: Hi, Few comments inline On 20 July 2015 at 22:38, Nicolas

[lng-odp] api-next gerrit

2015-07-23 Thread Maxim Uvarov
We can try to use gerrit for api-next changes. Steps: 1. register at and upload public key: https://review.linaro.org 2. add remote: git add remote apinext-review ssh://yourloginh...@review.linaro.org:29418/lng/odp 3. push changes for review: git push apinext-review HEAD:refs/for/api-next

Re: [lng-odp] [PATCH] linux-generic: Makefile.am: fix basename conflicts

2015-07-23 Thread Maxim Uvarov
I think that patch is not correct. Main problem that odp source for linux-generic has to be arch independent. But generated after ./scripts/builddeb opendataplane-1.x.tar.gz does not contain any other arches for timer. It has only linux-generic/arch/x86/. So in that case you can only compile

Re: [lng-odp] [API-NEXT PATCHv4 06/10] validation: split out cpumask tests into separate file

2015-07-23 Thread Christophe Milard
On 2015-07-22 16:46, Stuart Haslam wrote: Split the majority of the test cases out into a separate file in preparation for them being reused to perform thrmask tests. Signed-off-by: Stuart Haslam stuart.has...@linaro.org Reviewed-by: Christophe Milard christophe.mil...@linaro.org ---

Re: [lng-odp] [API-NEXT PATCHv4 08/10] validation: thrmask: introduce thrmask tests

2015-07-23 Thread Christophe Milard
On 2015-07-22 16:46, Stuart Haslam wrote: Signed-off-by: Stuart Haslam stuart.has...@linaro.org Reviewed-by: Christophe Milard christophe.mil...@linaro.org --- test/validation/Makefile.inc | 1 + test/validation/common/.gitignore| 1 + test/validation/common/Makefile.am |

Re: [lng-odp] api-next gerrit

2015-07-23 Thread Mike Holmes
Maxim I think we still need to do some configuration, I did not see it CC the list with the patches you pushed to gerrit as a trial. Mike On 23 July 2015 at 06:06, Maxim Uvarov maxim.uva...@linaro.org wrote: We can try to use gerrit for api-next changes. Steps: 1. register at and upload