[lng-odp] Per-packet IV specification

2017-05-15 Thread Dmitry Eremin-Solenikov
Hello, I'd like to clarify the crypto API vs the case of per-packet IV specification. Is it expected to have meaningful iv.length be specified at session creation time (with NULL == iv.data)? Current linux-generic crypto code expects that if (NULL == iv.data) then also (0 == iv.length). Two

[lng-odp] [RFC API-NEXT] api: crypto: change crypto result to packet

2017-06-21 Thread Dmitry Eremin-Solenikov
from ODP_EVENT_CRYPTO_COMPL to ODP_EVENT_PACKET. Event subtype (ODP_EVENT_PACKET_CRYPTO) can be used to identify packets with crypto metadata. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- This depends on all previous patches related to IPsec and event

Re: [lng-odp] [RFC API-NEXT] api: crypto: change crypto result to packet

2017-06-21 Thread Dmitry Eremin-Solenikov
On 21.06.2017 14:48, Dmitry Eremin-Solenikov wrote: > Input and output of crypto operations are packets. API is more flexible > for application and API pipelining when output is packet with additional > metadata. Application or API pipeline stages which do not care about > crypto resu

Re: [lng-odp] [PATCH v2 2/2] travis: enable samples and tests when make distcheck

2017-06-20 Thread Dmitry Eremin-Solenikov
On 20.06.2017 22:53, Maxim Uvarov wrote: > Yi, how about something like: > > diff --git a/.travis.yml b/.travis.yml > index 50b3b9c2..3d641209 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -139,6 +139,13 @@ jobs: >- ./configure >- sudo

Re: [lng-odp] [API-NEXT PATCH v9 3/6] linux-gen: sched scalable: add a bitset

2017-06-21 Thread Dmitry Eremin-Solenikov
On 21.06.2017 21:14, Ola Liljedahl wrote: > > On 20/06/2017, 15:04, "Savolainen, Petri (Nokia - FI/Espoo)" > wrote: > >> >> >>> +++ b/platform/linux-generic/include/odp_bitset.h >>> @@ -0,0 +1,210 @@ >>> +/* Copyright (c) 2017, ARM Limited >>> + * All rights

Re: [lng-odp] [PATCH API-NEXT v1 1/1] linux-generic: crypto: adapt HMAC code to OpenSSL 1.1.x

2017-06-22 Thread Dmitry Eremin-Solenikov
On 15.06.2017 11:00, Github ODP bot wrote: > From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > > OpenSSL 1.1.x has changed HMAC API in an incompatible way. Let's adapt > to it by providing version-dependent wrapper around HMAC calculation. > > Sign

Re: [lng-odp] [API-NEXT PATCH v3 0/3] IPSEC packet event

2017-06-21 Thread Dmitry Eremin-Solenikov
rays are direct > parameters to functions. Also API is more flexible for > application or API pipelining when output is packets with > additional metadata. Application or API pipeline stages which > do not care about IPSEC results may work on basic packet metadata. For the whole serie

Re: [lng-odp] [PATCH v2] build: fix conditional compilation of sources

2017-06-22 Thread Dmitry Eremin-Solenikov
d-off-by: Brian Brooks <brian.bro...@arm.com> > Reviewed-by: Kevin Wang <kevin.w...@arm.com> > Reviewed-by: Yi He <yi...@arm.com> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> Reviewed-by: Dmitry Eremin-Solenikov -- With best wishes Dmitry

Re: [lng-odp] [PATCH API-NEXT 0/2] event subtype implementation

2017-06-24 Thread Dmitry Eremin-Solenikov
On 14.06.2017 20:35, Dmitry Eremin-Solenikov wrote: > Applies on top of [API-NEXT PATCH v2 0/3] IPSEC packet event > > These patches provide event subtype implementation and tests. Ideally they > should be merged together with event subtypes API definitions. > > Dmitry E

Re: [lng-odp] [RFC, API-NEXT v3 1/1] comp: compression interface

2017-05-23 Thread Dmitry Eremin-Solenikov
On 22.05.2017 09:54, Shally Verma wrote: > Signed-off-by: Shally Verma > Signed-off-by: Mahipal Challa > +/** > + * Comp API operation return codes > + * > + */ > +typedef enum { > + /** Operation completed successfully*/ > + ODP_COMP_ERR_NONE, > +

Re: [lng-odp] [API-NEXT PATCH] api: crypto: change iv_len field to feature min-max len

2017-05-16 Thread Dmitry Eremin-Solenikov
On 16.05.2017 10:43, Krishna Garapati wrote: > > > On 15 May 2017 at 19:38, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org > <mailto:dmitry.ereminsoleni...@linaro.org>> wrote: > > On 15.05.2017 15:42, Balakrishna Garapati wrote: > >

Re: [lng-odp] [PATCH API-NEXT v5 1/1] api: crypto: add odp_crypto_session_create2 returning odp_crypto_session_t

2017-05-30 Thread Dmitry Eremin-Solenikov
On 30 May 2017 at 18:06, Bala Manoharan <bala.manoha...@linaro.org> wrote: > On 30 May 2017 at 20:30, Github ODP bot <odp...@yandex.ru> wrote: >> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> >> >> Currently odp_crypto_session_cr

Re: [lng-odp] [PATCH API-NEXT v2 2/20] test: crypto: explicitly pass AAD to crypto subsystem

2017-05-31 Thread Dmitry Eremin-Solenikov
org >> Subject: [lng-odp] [PATCH API-NEXT v2 2/20] test: crypto: explicitly pass >> AAD to crypto subsystem >> >> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> >> >> Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.or

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-02 Thread Dmitry Eremin-Solenikov
On 01.06.2017 22:05, Brian Brooks wrote: > Signed-off-by: Brian Brooks > Reviewed-by: Ola Liljedahl > Reviewed-by: Honnappa Nagarahalli > --- > configure.ac | 5 + >

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-02 Thread Dmitry Eremin-Solenikov
On 02.06.2017 06:30, Bill Fischofer wrote: > On Thu, Jun 1, 2017 at 9:48 PM, Brian Brooks wrote: >> On 06/01 15:00:28, Bill Fischofer wrote: >>> If this is a bug fix it should reference a Bug that describes in more >>> detail what is being fixed. >> >> Can you elaborate? >>

Re: [lng-odp] [PATCH] Fixes for GCC 7

2017-06-02 Thread Dmitry Eremin-Solenikov
On 02.06.2017 18:34, Brian Brooks wrote: > On 06/02 10:39:18, Dmitry Eremin-Solenikov wrote: >> On 01.06.2017 22:05, Brian Brooks wrote: >>> Signed-off-by: Brian Brooks <brian.bro...@arm.com> >>> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com>

Re: [lng-odp] [API-NEXT PATCH v6 3/6] Add arch/ files

2017-06-03 Thread Dmitry Eremin-Solenikov
On 03.06.2017 07:23, Honnappa Nagarahalli wrote: > On 1 June 2017 at 02:43, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> >> >>> -Original Message- >>> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org] >>> Sent: Wednesday, May 31, 2017 9:03

Re: [lng-odp] [NEXT PATCH] changelog: updates for odp v1.15.0.0

2017-06-05 Thread Dmitry Eremin-Solenikov
On 04.06.2017 22:18, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > CHANGELOG | 266 > ++ > 1 file changed, 266 insertions(+) > > diff --git a/CHANGELOG b/CHANGELOG > index a550a723..bdb5ca49

Re: [lng-odp] [PATCH v1 0/9] Rework the way ODP links with other libraries

2017-06-05 Thread Dmitry Eremin-Solenikov
On 05.06.2017 15:27, Elo, Matias (Nokia - FI/Espoo) wrote: > Hi, > > It seems that after this patch set the dpdk pmd drivers are not properly > linked anymore. The build succeeds without errors but at runtime no dpdk > devices are found. Which example/test fails? I tried my best to test

Re: [lng-odp] [PATCH v1 0/9] Rework the way ODP links with other libraries

2017-06-05 Thread Dmitry Eremin-Solenikov
On 05.06.2017 16:06, Elo, Matias (Nokia - FI/Espoo) wrote: > >> On 5 Jun 2017, at 16:04, Dmitry Eremin-Solenikov >> <dmitry.ereminsoleni...@linaro.org> wrote: >> >> On 05.06.2017 15:27, Elo, Matias (Nokia - FI/Espoo) wrote: >>> Hi, >>> >>

Re: [lng-odp] [NEXT PATCH] changelog: updates for odp v1.15.0.0

2017-06-05 Thread Dmitry Eremin-Solenikov
On 05.06.2017 02:45, Bill Fischofer wrote: > On Sun, Jun 4, 2017 at 6:17 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 04.06.2017 22:18, Bill Fischofer wrote: >>> Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org

[lng-odp] [PATCH API-NEXT v4 00/23] Major cryptography rework

2017-06-01 Thread Dmitry Eremin-Solenikov
serie is visible as PR #34. Dmitry Eremin-Solenikov (23): validation: crypto: explicitly pass auth_digest_len to crypto subsystem validation: crypto: explicitly pass AAD to crypto subsystem test: odp_crypto: update performance test to set auth_digest_length example: ipsec: set

[lng-odp] [PATCH API-NEXT v4 05/23] linux-generic: crypto: use auth_digest_len when calculating HMACs

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index a99354

[lng-odp] [PATCH 05/23] linux: crypto: use auth_digest_len when calculating HMACs

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index a99354

[lng-odp] [PATCH API-NEXT v4 03/23] test: odp_crypto: update performance test to set auth_digest_length

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/performance/odp_crypto.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/test/common_plat/performance/odp_crypto.c b/test/common_plat/performance/odp_crypto.c

[lng-odp] [PATCH 09/23] test: crypto: add tests for NULL cipher

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/crypto/crypto.h| 2 + .../validation/api/crypto/odp_crypto_test_inp.c| 71 ++ .../validation/api/crypto/test_vectors.h | 12 .../vali

[lng-odp] [PATCH API-NEXT v4 08/23] linux-generic: crypto: remote extra memcpy in AES-GCM

2017-06-01 Thread Dmitry Eremin-Solenikov
There is no need to memcpy IV if it gets passed to EVP functions. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/platform/linux-g

[lng-odp] [PATCH 08/23] crypto: linux-generic: add capabilities for CIPHER_NULL and AUTH_NULL

2017-06-01 Thread Dmitry Eremin-Solenikov
There is no point in having separate cases for NULL algorithms. Add capabilities returning 0 key/digest/iv length. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c| 14 ++ .../validation/api/

[lng-odp] [PATCH 02/23] test: crypto: explicitly pass AAD to crypto subsystem

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 55 +- .../validation/api/crypto/test_vectors.h | 65 -- 2 files changed, 64 insertions(+), 56 deletions(-) diff

[lng-odp] [PATCH API-NEXT v4 10/23] linux-generic: crypto: explicitly disable padding for AES-GCM

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 3deec7de3f7c..ff3f1ac76780

[lng-odp] [PATCH API-NEXT v4 09/23] linux-generic: crypto: make AES-GCM thread safe

2017-06-01 Thread Dmitry Eremin-Solenikov
Using single context for all operations is not thread safe: multiple threads can access the same context in parallel, affecting its internal state. Make AES-GCM functions use local context for en/decryption operations. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.

[lng-odp] [PATCH 10/23] linux-generic: crypto: remote extra memcpy in AES-GCM

2017-06-01 Thread Dmitry Eremin-Solenikov
There is no need to memcpy IV if it gets passed to EVP functions. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/platform/linux-g

[lng-odp] [PATCH 01/23] test: crypto: explicitly pass auth_digest_len to crypto subsystem

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 57 +- .../validation/api/crypto/test_vectors.h | 10 .../validation/api/crypto/test_vectors_len.h | 3 -- 3 files c

[lng-odp] [PATCH API-NEXT v4 01/23] validation: crypto: explicitly pass auth_digest_len to crypto subsystem

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 57 +- .../validation/api/crypto/test_vectors.h | 10 .../validation/api/crypto/test_vectors_len.h | 3 -- 3 files c

[lng-odp] [PATCH API-NEXT v4 06/23] linux-generic: crypto: add SHA* capabilities for full length digests

2017-06-01 Thread Dmitry Eremin-Solenikov
In addition to truncated digests (used by IPsec) add full-length capabilities to SHA* algos. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/platform

[lng-odp] [PATCH 07/23] linux: crypto: update AES-GCM support to reflect aad and auth_digest_len

2017-06-01 Thread Dmitry Eremin-Solenikov
Make AES-GCM use recently introduced aad and auth_digest_len fields. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 58 ++--- 1 file changed, 15 insertions(+), 43 deletions(-) diff

[lng-odp] [PATCH 06/23] linux: crypto: add SHA* capabilities for full length digests

2017-06-01 Thread Dmitry Eremin-Solenikov
In addition to truncated digests (used by IPsec) add full-length capabilities to SHA* algos. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/platform

Re: [lng-odp] [PATCH API-NEXT v4 00/23] Major cryptography rework

2017-06-01 Thread Dmitry Eremin-Solenikov
On 01.06.2017 11:22, Dmitry Eremin-Solenikov wrote: > This is a cummulative patchset incorporating: > - AAD/ auth_digest_len implementation > - crypto engine working across packet segments > - SHA-1/SHA-512 implementation > - small fixes > > GitHub bot did not send this

Re: [lng-odp] [API-NEXT PATCH v6 3/6] Add arch/ files

2017-06-01 Thread Dmitry Eremin-Solenikov
On 31.05.2017 21:03, Honnappa Nagarahalli wrote: > On 31 May 2017 at 03:02, Savolainen, Petri (Nokia - FI/Espoo) > wrote: >> >> >> Arch specific code is not commonly added into odp-linux, but when you do add >> it you need to try hard not to break the code for others.

[lng-odp] [PATCH API-NEXT v4 02/23] validation: crypto: explicitly pass AAD to crypto subsystem

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 55 +- .../validation/api/crypto/test_vectors.h | 65 -- 2 files changed, 64 insertions(+), 56 deletions(-) diff

[lng-odp] [PATCH API-NEXT v4 04/23] example: ipsec: set auth_digest_len

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- example/ipsec/odp_ipsec_cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/example/ipsec/odp_ipsec_cache.c b/example/ipsec/odp_ipsec_cache.c index b2a91c242fe0..dba0ea0ab0c6 100644 --- a/example

[lng-odp] [PATCH API-NEXT v4 07/23] linux-generic: crypto: update AES-GCM support to reflect aad and auth_digest_len

2017-06-01 Thread Dmitry Eremin-Solenikov
Make AES-GCM use recently introduced aad and auth_digest_len fields. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 58 ++--- 1 file changed, 15 insertions(+), 43 deletions(-) diff

Re: [lng-odp] [PATCH API-NEXT v2 16/20] linux-generic: packet: add functions to optimize memset and memcmp paths

2017-05-31 Thread Dmitry Eremin-Solenikov
On 31.05.2017 17:14, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message----- >> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] >> Sent: Wednesday, May 31, 2017 4:18 PM >> To: Savolainen, Petri (Nokia - FI/Espo

[lng-odp] [PATCH API-NEXT v5 17/23] test: odp_crypto: bail out if odp_crypto_session_create failed

2017-06-01 Thread Dmitry Eremin-Solenikov
If odp_crypto_session_create() failed, there is no point in checking/freeing session, as it might not have been updated. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/performance/odp_crypto.c | 44 +++ 1 file c

[lng-odp] [PATCH API-NEXT v5 18/23] crypto: linux-generic: add capabilities for CIPHER_NULL and AUTH_NULL

2017-06-01 Thread Dmitry Eremin-Solenikov
There is no point in having separate cases for NULL algorithms. Add capabilities returning 0 key/digest/iv length. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c| 14 ++ .../validation/api/

[lng-odp] [PATCH API-NEXT v5 15/23] linux-generic: crypto: make en/decryption work across packet segments

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 184 +++- 1 file changed, 138 insertions(+), 46 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-g

[lng-odp] [PATCH API-NEXT v5 16/23] linux-generic: crypto: NULL session->next pointer on session allocation

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index ea7c702650f6..32fece

[lng-odp] [PATCH API-NEXT v5 23/23] linux-generic: crypto: add HMAC-SHA-512 authentication support

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 3117f6

[lng-odp] [PATCH API-NEXT v5 02/23] validation: crypto: explicitly pass AAD to crypto subsystem

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 55 +- .../validation/api/crypto/test_vectors.h | 65 -- 2 files changed, 64 insertions(+), 56 deletions(-) diff

[lng-odp] [PATCH API-NEXT v5 10/23] linux-generic: crypto: explicitly disable padding for AES-GCM

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 3deec7de3f7c..ff3f1ac76780

[lng-odp] [PATCH API-NEXT v5 09/23] linux-generic: crypto: make AES-GCM thread safe

2017-06-01 Thread Dmitry Eremin-Solenikov
Using single context for all operations is not thread safe: multiple threads can access the same context in parallel, affecting its internal state. Make AES-GCM functions use local context for en/decryption operations. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.

[lng-odp] [PATCH API-NEXT v5 19/23] validation: crypto: add tests for NULL cipher

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/crypto/crypto.h| 2 + .../validation/api/crypto/odp_crypto_test_inp.c| 71 ++ .../validation/api/crypto/test_vectors.h | 12 .../vali

[lng-odp] [PATCH API-NEXT v5 06/23] linux-generic: crypto: add SHA* capabilities for full length digests

2017-06-01 Thread Dmitry Eremin-Solenikov
In addition to truncated digests (used by IPsec) add full-length capabilities to SHA* algos. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/platform

[lng-odp] [PATCH API-NEXT v5 14/23] linux-generic: crypto: make HMAC work across segmented packets

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 78 + 1 file changed, 45 insertions(+), 33 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_cr

[lng-odp] [PATCH API-NEXT v5 21/23] validation: crypto: add HMAC-SHA-512 test cases

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/crypto/crypto.h| 3 +- .../validation/api/crypto/odp_crypto_test_inp.c| 110 - .../validation/api/crypto/test_vectors.h

[lng-odp] [PATCH API-NEXT v5 22/23] linux-generic: crypto: add SHA-1 authentication support

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 9e5a11

[lng-odp] [PATCH API-NEXT v5 00/23] Major cryptography code rework

2017-06-01 Thread Dmitry Eremin-Solenikov
serie is visible as PR #34. Dmitry Eremin-Solenikov (23): validation: crypto: explicitly pass auth_digest_len to crypto subsystem validation: crypto: explicitly pass AAD to crypto subsystem test: odp_crypto: update performance test to set auth_digest_length example: ipsec: set

[lng-odp] [PATCH API-NEXT v5 01/23] validation: crypto: explicitly pass auth_digest_len to crypto subsystem

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../validation/api/crypto/odp_crypto_test_inp.c| 57 +- .../validation/api/crypto/test_vectors.h | 10 .../validation/api/crypto/test_vectors_len.h | 3 -- 3 files c

[lng-odp] [PATCH API-NEXT v5 03/23] test: odp_crypto: update performance test to set auth_digest_length

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/performance/odp_crypto.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/test/common_plat/performance/odp_crypto.c b/test/common_plat/performance/odp_crypto.c

[lng-odp] [PATCH API-NEXT v5 08/23] linux-generic: crypto: remote extra memcpy in AES-GCM

2017-06-01 Thread Dmitry Eremin-Solenikov
There is no need to memcpy IV if it gets passed to EVP functions. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/platform/linux-g

[lng-odp] [PATCH API-NEXT v5 07/23] linux-generic: crypto: update AES-GCM support to reflect aad and auth_digest_len

2017-06-01 Thread Dmitry Eremin-Solenikov
Make AES-GCM use recently introduced aad and auth_digest_len fields. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 58 ++--- 1 file changed, 15 insertions(+), 43 deletions(-) diff

[lng-odp] [PATCH API-NEXT v5 13/23] linux-generic: crypto: merge AES-CBC and 3DES-CBC support

2017-06-01 Thread Dmitry Eremin-Solenikov
There is now nearly no difference between AES-CBC and 3DES-CBC code. Merge it into generic 'cipher' support, easing adding support for other ciphers in future. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/include/odp_crypto_internal.h

[lng-odp] [PATCH API-NEXT v5 12/23] linux-generic: crypto: rewrite 3DES-CBC support using EVP functions

2017-06-01 Thread Dmitry Eremin-Solenikov
Rewrite 3DES-CBC to use generic EVP interface following AES-GCM implementation. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/include/odp_crypto_internal.h| 5 +- platform/linux-generic/odp_crypto.c

[lng-odp] [PATCH API-NEXT v5 04/23] example: ipsec: set auth_digest_len

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- example/ipsec/odp_ipsec_cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/example/ipsec/odp_ipsec_cache.c b/example/ipsec/odp_ipsec_cache.c index b2a91c242fe0..dba0ea0ab0c6 100644 --- a/example

[lng-odp] [PATCH API-NEXT v5 05/23] linux-generic: crypto: use auth_digest_len when calculating HMACs

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/odp_crypto.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index a99354

[lng-odp] [PATCH API-NEXT v5 11/23] linux-generic: crypto: rewrite AES-CBC support using EVP functions

2017-06-01 Thread Dmitry Eremin-Solenikov
Rewrite AES-CBC to use generic EVP interface following AES-GCM implementation. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- .../linux-generic/include/odp_crypto_internal.h| 3 +- platform/linux-generic/odp_crypto.c

[lng-odp] [PATCH API-NEXT v5 20/23] validation: crypto: add HMAC-SHA-1 test cases

2017-06-01 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/crypto/crypto.h| 3 +- .../validation/api/crypto/odp_crypto_test_inp.c| 126 +++-- .../validation/api/crypto/test_vectors.h

Re: [lng-odp] [PATCH v4 1/2] build: GCC 7 fixes

2017-06-08 Thread Dmitry Eremin-Solenikov
On 08.06.2017 06:40, Brian Brooks wrote: > The GCC 7 series introduces changes that expose ODP compilation > issues. These include case statement fall through warnings, and > stricter checks on potential string overflows and other semantic > analysis. > > Fixes:

Re: [lng-odp] [NEXT PATCH] changelog: updates for odp v1.15.0.0

2017-06-04 Thread Dmitry Eremin-Solenikov
On 04.06.2017 22:18, Bill Fischofer wrote: > Signed-off-by: Bill Fischofer > --- > CHANGELOG | 266 > ++ > 1 file changed, 266 insertions(+) > > diff --git a/CHANGELOG b/CHANGELOG > index a550a723..bdb5ca49

Re: [lng-odp] [PATCH 1/2] linux-gen: socket: remove limits for maximum RX/TX burst size

2017-06-13 Thread Dmitry Eremin-Solenikov
On 13.06.2017 16:16, Elo, Matias (Nokia - FI/Espoo) wrote: > >> On 13 Jun 2017, at 16:00, Bill Fischofer wrote: >> >> Is the bug reported here detected by the validation or one of the >> performance tests? Does this now show the issue fixed? > > The pktio validation

Re: [lng-odp] [PATCH API-NEXT v1 4/4] travis: add scalable scheduler in CI

2017-06-15 Thread Dmitry Eremin-Solenikov
On 15.06.2017 05:53, Honnappa Nagarahalli wrote: > This should be the only patch to review. Don't know why GitHub sent > other patches in this series. Because scripts will resend whole patch series when PR is updated. -- With best wishes Dmitry

Re: [lng-odp] [PATCH v4 0/2] GCC 7 fixes

2017-06-15 Thread Dmitry Eremin-Solenikov
On 15.06.2017 11:47, shally verma wrote: > Does it mean that going further there would be certain limitation on > gcc version to be used? I just tried to compile next branch and > ./configure throws an error > > ./configure: line 22786: syntax error near unexpected token >

Re: [lng-odp] [API-NEXT PATCH 0/2] IPSEC packet event

2017-06-09 Thread Dmitry Eremin-Solenikov
Petri, On 09.06.2017 13:51, Petri Savolainen wrote: > Requires "[API-NEXT PATCH v2 0/2] IPsec API update". > > Input and output of IPSEC operations are packets. Parameter and > result structures are cleaner when packet arrays are direct > parameters to functions. Also API is more flexible for >

Re: [lng-odp] [API-NEXT PATCH 1/2] api: ipsec: change IPSEC result to packet

2017-06-09 Thread Dmitry Eremin-Solenikov
On 09.06.2017 13:51, Petri Savolainen wrote: > Input and output of IPSEC operations are packets. Parameter and > result structures are cleaner when packet arrays are direct > parameters to functions. Also API is more flexible for > application or API pipelining when output is packets with >

Re: [lng-odp] [API-NEXT PATCH 1/2] api: ipsec: change IPSEC result to packet

2017-06-14 Thread Dmitry Eremin-Solenikov
On 14.06.2017 12:53, Dmitry Eremin-Solenikov wrote: > On 09.06.2017 15:32, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>>> @@ -934,41 +926,70 @@ typedef struct odp_ipsec_op_status_t { >>>> } odp_ipsec_op_status_t; >>>> >>>> /** >>>&g

Re: [lng-odp] [API-NEXT PATCH] linux-gen: queue: clean up after modular interface

2017-06-14 Thread Dmitry Eremin-Solenikov
On 12.06.2017 14:11, Petri Savolainen wrote: > Clean up function and parameter naming after modular interface > patch. Queue_t type is referred as "queue internal": queue_int or > q_int. Term "handle" is reserved for API level handles (e.g. > odp_queue_t, odp_pktio_t, etc) through out linux-gen

Re: [lng-odp] [API-NEXT PATCH v2 2/3] api: ipsec: change IPSEC result to packet

2017-06-14 Thread Dmitry Eremin-Solenikov
On 14.06.2017 17:08, Petri Savolainen wrote: > Input and output of IPSEC operations are packets. Parameter and > result structures are cleaner when packet arrays are direct > parameters to functions. Also API is more flexible for > application and API pipelining when output is packets with >

[lng-odp] [PATCH API-NEXT 1/2] linux-generic: events subtype implementation

2017-06-14 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/include/odp_buffer_inlines.h | 2 ++ platform/linux-generic/include/odp_buffer_internal.h | 3 +++ platform/linux-generic/odp_event.c | 5 + platform/linux-g

[lng-odp] [PATCH API-NEXT 2/2] validation: test correctness of events subtype implementation

2017-06-14 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/buffer/buffer.c | 37 +++-- test/common_plat/validation/api/packet/packet.c | 5 test/common_plat/validation/api/timer/timer.c | 14 -- 3

[lng-odp] [PATCH API-NEXT 0/2] event subtype implementation

2017-06-14 Thread Dmitry Eremin-Solenikov
Applies on top of [API-NEXT PATCH v2 0/3] IPSEC packet event These patches provide event subtype implementation and tests. Ideally they should be merged together with event subtypes API definitions. Dmitry Eremin-Solenikov (2): linux-generic: events subtype implementation validation: test

Re: [lng-odp] [PATCH v4 0/2] GCC 7 fixes

2017-06-15 Thread Dmitry Eremin-Solenikov
On 15 June 2017 at 16:20, Maxim Uvarov <maxim.uva...@linaro.org> wrote: > On 06/15/17 11:50, Dmitry Eremin-Solenikov wrote: >> On 15.06.2017 11:47, shally verma wrote: >>> Does it mean that going further there would be certain limitation on >>> gcc version to be u

[lng-odp] [PATCH API-NEXT v2 1/2] linux-generic: events subtype implementation

2017-06-16 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/include/odp_buffer_inlines.h | 2 ++ platform/linux-generic/include/odp_buffer_internal.h | 3 +++ platform/linux-generic/odp_crypto.c | 14 -- platform

[lng-odp] [PATCH API-NEXT v2 2/2] validation: test correctness of events subtype implementation

2017-06-16 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/buffer/buffer.c | 37 +++-- test/common_plat/validation/api/packet/packet.c | 5 test/common_plat/validation/api/timer/timer.c | 14 -- 3

Re: [lng-odp] [PATCH API-NEXT 1/2] linux-generic: events subtype implementation

2017-06-16 Thread Dmitry Eremin-Solenikov
On 15.06.2017 14:21, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> index d71f4464af48..3cd4a73cbefb 100644 >> --- a/platform/linux-generic/odp_event.c >> +++ b/platform/linux-generic/odp_event.c >> @@ -19,6 +19,11 @@ odp_event_type_t odp_event_type(odp_event_t event) >> return

[lng-odp] [PATCH API-NEXT v2 0/2] event subtype implementation

2017-06-16 Thread Dmitry Eremin-Solenikov
in odp_crypto.c Dmitry Eremin-Solenikov (2): linux-generic: events subtype implementation validation: test correctness of events subtype implementation .../linux-generic/include/odp_buffer_inlines.h | 2 ++ .../linux-generic/include/odp_buffer_internal.h| 3 ++ platform/linux-generic/odp_crypto.c

Re: [lng-odp] [PATCH API-NEXT 1/2] linux-generic: events subtype implementation

2017-06-16 Thread Dmitry Eremin-Solenikov
On 16.06.2017 12:37, Savolainen, Petri (Nokia - FI/Espoo) wrote: switch (odp_event_type(event)) { diff --git a/platform/linux-generic/odp_packet.c b/platform/linux- generic/odp_packet.c index eb66af2d3b9c..3789feca45f9 100644 --- a/platform/linux-generic/odp_packet.c

[lng-odp] [PATCH API-NEXT v3 0/2] event subtype implementation

2017-06-16 Thread Dmitry Eremin-Solenikov
type and subtype Changes since v1: - Implement odp_event_types() - Update event subtype properly in odp_crypto.c Dmitry Eremin-Solenikov (2): linux-generic: events subtype implementation validation: test correctness of events subtype implementation .../linux-generic/include

[lng-odp] [PATCH API-NEXT v3 2/2] validation: test correctness of events subtype implementation

2017-06-16 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- test/common_plat/validation/api/buffer/buffer.c| 50 -- .../validation/api/crypto/odp_crypto_test_inp.c| 14 ++ test/common_plat/validation/api/packet/packet.c| 21 -

[lng-odp] [PATCH API-NEXT v3 1/2] linux-generic: events subtype implementation

2017-06-16 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- platform/linux-generic/include/odp_buffer_inlines.h | 2 ++ platform/linux-generic/include/odp_buffer_internal.h | 3 +++ platform/linux-generic/odp_crypto.c | 15 +-- platform

Re: [lng-odp] [API-NEXT PATCH 1/2] api: ipsec: change IPSEC result to packet

2017-06-14 Thread Dmitry Eremin-Solenikov
On 09.06.2017 15:32, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> @@ -934,41 +926,70 @@ typedef struct odp_ipsec_op_status_t { >>> } odp_ipsec_op_status_t; >>> >>> /** >>> - * IPSEC operation input parameters >>> + * IPSEC outbound operation options >>> + * >>> + * These may be used to

Re: [lng-odp] github web hook updated

2017-05-02 Thread Dmitry Eremin-Solenikov
On 02.05.2017 11:27, Maxim Uvarov wrote: > Updated github web hook: > > Changes: > > Now on merge request topic (title) of merge request automatic changed to: > [PATCH vX] title > or > [PATCH API-NEXT vX] title PR https://github.com/Linaro/odp/pull/10 was correctly renamed by your hook, but

Re: [lng-odp] [API-NEXT PATCH v2 0/4] Deprecated macros

2017-05-02 Thread Dmitry Eremin-Solenikov
On 03.05.2017 07:43, Honnappa Nagarahalli wrote: > Let us say: > > API spec v1.20 could define: > > typedef struct odp_foo_bar_t { > /** This is foo*/ > uint8_t foo; > } odp_foo_bar_t; > > > API spec v1.30 could define: > > typedef struct odp_foo_bar_t { > /**

Re: [lng-odp] [API-NEXT PATCH 1/2] api: crypto: add digest length session parameter

2017-05-04 Thread Dmitry Eremin-Solenikov
Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> > --- > include/odp/api/spec/crypto.h | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h > index 181c0cc4.

[lng-odp] [PATCH API-NEXT v2] api: packet: introduce odp_packet_data_range_t

2017-05-04 Thread Dmitry Eremin-Solenikov
Rename odp_crypto_data_range_t to odp_packet_data_range_t, as it is relevant not only to the crypto interface. Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> --- include/odp/api/spec/crypto.h | 17 +++-- include/odp/ap

Re: [lng-odp] [PATCH 3/4] linux-generic: crypto: add SHA-1 authentication support

2017-05-04 Thread Dmitry Eremin-Solenikov
On 04.05.2017 09:34, Peltonen, Janne (Nokia - FI/Espoo) wrote: > > Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] wrote: >> >> On 03.05.2017 17:17, Peltonen, Janne (Nokia - FI/Espoo) wrote: >>> Hi, >>> >>> I think there is a probl

Re: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version parameter

2017-05-05 Thread Dmitry Eremin-Solenikov
rg >> Subject: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version >> parameter >> >> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> >> >> Both tunnel and lookup parameters refer IP protocol version. Factor that >> ou

Re: [lng-odp] [PATCH API-NEXT v1 1/2] api: ipsec: add soft limit expiration event

2017-05-05 Thread Dmitry Eremin-Solenikov
org >> Subject: [lng-odp] [PATCH API-NEXT v1 1/2] api: ipsec: add soft limit >> expiration event >> >> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> >> >> If outbound packet was processed in inline mode, soft limit expira

Re: [lng-odp] [PATCH API-NEXT v1 2/2] api: ipsec: move soft limits expiration to flags, rather than errors

2017-05-05 Thread Dmitry Eremin-Solenikov
On 06.05.2017 00:29, Bill Fischofer wrote: > On Fri, May 5, 2017 at 4:24 PM, Dmitry Eremin-Solenikov > <dmitry.ereminsoleni...@linaro.org> wrote: >> On 05.05.2017 11:17, Savolainen, Petri (Nokia - FI/Espoo) wrote: >>> >>> >>>> -Original Mess

Re: [lng-odp] [API-NEXT PATCH 2/3] api: ipsec: add capability for max packets per result event

2017-05-05 Thread Dmitry Eremin-Solenikov
On 05.05.2017 15:34, Petri Savolainen wrote: > Added maximum number of packets per result event to make it easy > for application to prepare enough storage for packets. I'm still not sure that this is a good idea. Patches 1 and 3 are: Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ere

Re: [lng-odp] [PATCH API-NEXT v1 2/2] api: ipsec: move soft limits expiration to flags, rather than errors

2017-05-05 Thread Dmitry Eremin-Solenikov
org >> Subject: [lng-odp] [PATCH API-NEXT v1 2/2] api: ipsec: move soft limits >> expiration to flags, rather than errors >> >> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org> >> >> Soft limit expiration isn't an error per se. It does not mean

<    1   2   3   4   5   >