Hello,
I'd like to clarify the crypto API vs the case of per-packet IV
specification. Is it expected to have meaningful iv.length be specified
at session creation time (with NULL == iv.data)?
Current linux-generic crypto code expects that if (NULL == iv.data) then
also (0 == iv.length).
Two
from ODP_EVENT_CRYPTO_COMPL to
ODP_EVENT_PACKET. Event subtype (ODP_EVENT_PACKET_CRYPTO) can be
used to identify packets with crypto metadata.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
This depends on all previous patches related to IPsec and event
On 21.06.2017 14:48, Dmitry Eremin-Solenikov wrote:
> Input and output of crypto operations are packets. API is more flexible
> for application and API pipelining when output is packet with additional
> metadata. Application or API pipeline stages which do not care about
> crypto resu
On 20.06.2017 22:53, Maxim Uvarov wrote:
> Yi, how about something like:
>
> diff --git a/.travis.yml b/.travis.yml
> index 50b3b9c2..3d641209 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -139,6 +139,13 @@ jobs:
>- ./configure
>- sudo
On 21.06.2017 21:14, Ola Liljedahl wrote:
>
> On 20/06/2017, 15:04, "Savolainen, Petri (Nokia - FI/Espoo)"
> wrote:
>
>>
>>
>>> +++ b/platform/linux-generic/include/odp_bitset.h
>>> @@ -0,0 +1,210 @@
>>> +/* Copyright (c) 2017, ARM Limited
>>> + * All rights
On 15.06.2017 11:00, Github ODP bot wrote:
> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
>
> OpenSSL 1.1.x has changed HMAC API in an incompatible way. Let's adapt
> to it by providing version-dependent wrapper around HMAC calculation.
>
> Sign
rays are direct
> parameters to functions. Also API is more flexible for
> application or API pipelining when output is packets with
> additional metadata. Application or API pipeline stages which
> do not care about IPSEC results may work on basic packet metadata.
For the whole serie
d-off-by: Brian Brooks <brian.bro...@arm.com>
> Reviewed-by: Kevin Wang <kevin.w...@arm.com>
> Reviewed-by: Yi He <yi...@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com>
Reviewed-by: Dmitry Eremin-Solenikov
--
With best wishes
Dmitry
On 14.06.2017 20:35, Dmitry Eremin-Solenikov wrote:
> Applies on top of [API-NEXT PATCH v2 0/3] IPSEC packet event
>
> These patches provide event subtype implementation and tests. Ideally they
> should be merged together with event subtypes API definitions.
>
> Dmitry E
On 22.05.2017 09:54, Shally Verma wrote:
> Signed-off-by: Shally Verma
> Signed-off-by: Mahipal Challa
> +/**
> + * Comp API operation return codes
> + *
> + */
> +typedef enum {
> + /** Operation completed successfully*/
> + ODP_COMP_ERR_NONE,
> +
On 16.05.2017 10:43, Krishna Garapati wrote:
>
>
> On 15 May 2017 at 19:38, Dmitry Eremin-Solenikov
> <dmitry.ereminsoleni...@linaro.org
> <mailto:dmitry.ereminsoleni...@linaro.org>> wrote:
>
> On 15.05.2017 15:42, Balakrishna Garapati wrote:
> >
On 30 May 2017 at 18:06, Bala Manoharan <bala.manoha...@linaro.org> wrote:
> On 30 May 2017 at 20:30, Github ODP bot <odp...@yandex.ru> wrote:
>> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
>>
>> Currently odp_crypto_session_cr
org
>> Subject: [lng-odp] [PATCH API-NEXT v2 2/20] test: crypto: explicitly pass
>> AAD to crypto subsystem
>>
>> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
>>
>> Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.or
On 01.06.2017 22:05, Brian Brooks wrote:
> Signed-off-by: Brian Brooks
> Reviewed-by: Ola Liljedahl
> Reviewed-by: Honnappa Nagarahalli
> ---
> configure.ac | 5 +
>
On 02.06.2017 06:30, Bill Fischofer wrote:
> On Thu, Jun 1, 2017 at 9:48 PM, Brian Brooks wrote:
>> On 06/01 15:00:28, Bill Fischofer wrote:
>>> If this is a bug fix it should reference a Bug that describes in more
>>> detail what is being fixed.
>>
>> Can you elaborate?
>>
On 02.06.2017 18:34, Brian Brooks wrote:
> On 06/02 10:39:18, Dmitry Eremin-Solenikov wrote:
>> On 01.06.2017 22:05, Brian Brooks wrote:
>>> Signed-off-by: Brian Brooks <brian.bro...@arm.com>
>>> Reviewed-by: Ola Liljedahl <ola.liljed...@arm.com>
On 03.06.2017 07:23, Honnappa Nagarahalli wrote:
> On 1 June 2017 at 02:43, Savolainen, Petri (Nokia - FI/Espoo)
> wrote:
>>
>>
>>> -Original Message-
>>> From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@linaro.org]
>>> Sent: Wednesday, May 31, 2017 9:03
On 04.06.2017 22:18, Bill Fischofer wrote:
> Signed-off-by: Bill Fischofer
> ---
> CHANGELOG | 266
> ++
> 1 file changed, 266 insertions(+)
>
> diff --git a/CHANGELOG b/CHANGELOG
> index a550a723..bdb5ca49
On 05.06.2017 15:27, Elo, Matias (Nokia - FI/Espoo) wrote:
> Hi,
>
> It seems that after this patch set the dpdk pmd drivers are not properly
> linked anymore. The build succeeds without errors but at runtime no dpdk
> devices are found.
Which example/test fails? I tried my best to test
On 05.06.2017 16:06, Elo, Matias (Nokia - FI/Espoo) wrote:
>
>> On 5 Jun 2017, at 16:04, Dmitry Eremin-Solenikov
>> <dmitry.ereminsoleni...@linaro.org> wrote:
>>
>> On 05.06.2017 15:27, Elo, Matias (Nokia - FI/Espoo) wrote:
>>> Hi,
>>>
>>
On 05.06.2017 02:45, Bill Fischofer wrote:
> On Sun, Jun 4, 2017 at 6:17 PM, Dmitry Eremin-Solenikov
> <dmitry.ereminsoleni...@linaro.org> wrote:
>> On 04.06.2017 22:18, Bill Fischofer wrote:
>>> Signed-off-by: Bill Fischofer <bill.fischo...@linaro.org
serie is visible as PR #34.
Dmitry Eremin-Solenikov (23):
validation: crypto: explicitly pass auth_digest_len to crypto
subsystem
validation: crypto: explicitly pass AAD to crypto subsystem
test: odp_crypto: update performance test to set auth_digest_length
example: ipsec: set
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index a99354
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index a99354
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/performance/odp_crypto.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/test/common_plat/performance/odp_crypto.c
b/test/common_plat/performance/odp_crypto.c
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/validation/api/crypto/crypto.h| 2 +
.../validation/api/crypto/odp_crypto_test_inp.c| 71 ++
.../validation/api/crypto/test_vectors.h | 12
.../vali
There is no need to memcpy IV if it gets passed to EVP functions.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/platform/linux-g
There is no point in having separate cases for NULL algorithms. Add
capabilities returning 0 key/digest/iv length.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c| 14 ++
.../validation/api/
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../validation/api/crypto/odp_crypto_test_inp.c| 55 +-
.../validation/api/crypto/test_vectors.h | 65 --
2 files changed, 64 insertions(+), 56 deletions(-)
diff
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 3deec7de3f7c..ff3f1ac76780
Using single context for all operations is not thread safe: multiple
threads can access the same context in parallel, affecting its internal
state. Make AES-GCM functions use local context for en/decryption
operations.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.
There is no need to memcpy IV if it gets passed to EVP functions.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/platform/linux-g
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../validation/api/crypto/odp_crypto_test_inp.c| 57 +-
.../validation/api/crypto/test_vectors.h | 10
.../validation/api/crypto/test_vectors_len.h | 3 --
3 files c
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../validation/api/crypto/odp_crypto_test_inp.c| 57 +-
.../validation/api/crypto/test_vectors.h | 10
.../validation/api/crypto/test_vectors_len.h | 3 --
3 files c
In addition to truncated digests (used by IPsec) add full-length
capabilities to SHA* algos.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/platform
Make AES-GCM use recently introduced aad and auth_digest_len fields.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 58 ++---
1 file changed, 15 insertions(+), 43 deletions(-)
diff
In addition to truncated digests (used by IPsec) add full-length
capabilities to SHA* algos.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/platform
On 01.06.2017 11:22, Dmitry Eremin-Solenikov wrote:
> This is a cummulative patchset incorporating:
> - AAD/ auth_digest_len implementation
> - crypto engine working across packet segments
> - SHA-1/SHA-512 implementation
> - small fixes
>
> GitHub bot did not send this
On 31.05.2017 21:03, Honnappa Nagarahalli wrote:
> On 31 May 2017 at 03:02, Savolainen, Petri (Nokia - FI/Espoo)
> wrote:
>>
>>
>> Arch specific code is not commonly added into odp-linux, but when you do add
>> it you need to try hard not to break the code for others.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../validation/api/crypto/odp_crypto_test_inp.c| 55 +-
.../validation/api/crypto/test_vectors.h | 65 --
2 files changed, 64 insertions(+), 56 deletions(-)
diff
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
example/ipsec/odp_ipsec_cache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/example/ipsec/odp_ipsec_cache.c b/example/ipsec/odp_ipsec_cache.c
index b2a91c242fe0..dba0ea0ab0c6 100644
--- a/example
Make AES-GCM use recently introduced aad and auth_digest_len fields.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 58 ++---
1 file changed, 15 insertions(+), 43 deletions(-)
diff
On 31.05.2017 17:14, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>
>> -Original Message-----
>> From: Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org]
>> Sent: Wednesday, May 31, 2017 4:18 PM
>> To: Savolainen, Petri (Nokia - FI/Espo
If odp_crypto_session_create() failed, there is no point in
checking/freeing session, as it might not have been updated.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/performance/odp_crypto.c | 44 +++
1 file c
There is no point in having separate cases for NULL algorithms. Add
capabilities returning 0 key/digest/iv length.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c| 14 ++
.../validation/api/
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 184 +++-
1 file changed, 138 insertions(+), 46 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-g
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index ea7c702650f6..32fece
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 3117f6
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../validation/api/crypto/odp_crypto_test_inp.c| 55 +-
.../validation/api/crypto/test_vectors.h | 65 --
2 files changed, 64 insertions(+), 56 deletions(-)
diff
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 3deec7de3f7c..ff3f1ac76780
Using single context for all operations is not thread safe: multiple
threads can access the same context in parallel, affecting its internal
state. Make AES-GCM functions use local context for en/decryption
operations.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/validation/api/crypto/crypto.h| 2 +
.../validation/api/crypto/odp_crypto_test_inp.c| 71 ++
.../validation/api/crypto/test_vectors.h | 12
.../vali
In addition to truncated digests (used by IPsec) add full-length
capabilities to SHA* algos.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/platform
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 78 +
1 file changed, 45 insertions(+), 33 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_cr
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/validation/api/crypto/crypto.h| 3 +-
.../validation/api/crypto/odp_crypto_test_inp.c| 110 -
.../validation/api/crypto/test_vectors.h
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index 9e5a11
serie is visible as PR #34.
Dmitry Eremin-Solenikov (23):
validation: crypto: explicitly pass auth_digest_len to crypto
subsystem
validation: crypto: explicitly pass AAD to crypto subsystem
test: odp_crypto: update performance test to set auth_digest_length
example: ipsec: set
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../validation/api/crypto/odp_crypto_test_inp.c| 57 +-
.../validation/api/crypto/test_vectors.h | 10
.../validation/api/crypto/test_vectors_len.h | 3 --
3 files c
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/performance/odp_crypto.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/test/common_plat/performance/odp_crypto.c
b/test/common_plat/performance/odp_crypto.c
There is no need to memcpy IV if it gets passed to EVP functions.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 20 ++--
1 file changed, 2 insertions(+), 18 deletions(-)
diff --git a/platform/linux-g
Make AES-GCM use recently introduced aad and auth_digest_len fields.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 58 ++---
1 file changed, 15 insertions(+), 43 deletions(-)
diff
There is now nearly no difference between AES-CBC and 3DES-CBC code.
Merge it into generic 'cipher' support, easing adding support for other
ciphers in future.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../linux-generic/include/odp_crypto_internal.h
Rewrite 3DES-CBC to use generic EVP interface following AES-GCM
implementation.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../linux-generic/include/odp_crypto_internal.h| 5 +-
platform/linux-generic/odp_crypto.c
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
example/ipsec/odp_ipsec_cache.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/example/ipsec/odp_ipsec_cache.c b/example/ipsec/odp_ipsec_cache.c
index b2a91c242fe0..dba0ea0ab0c6 100644
--- a/example
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/odp_crypto.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/platform/linux-generic/odp_crypto.c
b/platform/linux-generic/odp_crypto.c
index a99354
Rewrite AES-CBC to use generic EVP interface following AES-GCM
implementation.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
.../linux-generic/include/odp_crypto_internal.h| 3 +-
platform/linux-generic/odp_crypto.c
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/validation/api/crypto/crypto.h| 3 +-
.../validation/api/crypto/odp_crypto_test_inp.c| 126 +++--
.../validation/api/crypto/test_vectors.h
On 08.06.2017 06:40, Brian Brooks wrote:
> The GCC 7 series introduces changes that expose ODP compilation
> issues. These include case statement fall through warnings, and
> stricter checks on potential string overflows and other semantic
> analysis.
>
> Fixes:
On 04.06.2017 22:18, Bill Fischofer wrote:
> Signed-off-by: Bill Fischofer
> ---
> CHANGELOG | 266
> ++
> 1 file changed, 266 insertions(+)
>
> diff --git a/CHANGELOG b/CHANGELOG
> index a550a723..bdb5ca49
On 13.06.2017 16:16, Elo, Matias (Nokia - FI/Espoo) wrote:
>
>> On 13 Jun 2017, at 16:00, Bill Fischofer wrote:
>>
>> Is the bug reported here detected by the validation or one of the
>> performance tests? Does this now show the issue fixed?
>
> The pktio validation
On 15.06.2017 05:53, Honnappa Nagarahalli wrote:
> This should be the only patch to review. Don't know why GitHub sent
> other patches in this series.
Because scripts will resend whole patch series when PR is updated.
--
With best wishes
Dmitry
On 15.06.2017 11:47, shally verma wrote:
> Does it mean that going further there would be certain limitation on
> gcc version to be used? I just tried to compile next branch and
> ./configure throws an error
>
> ./configure: line 22786: syntax error near unexpected token
>
Petri,
On 09.06.2017 13:51, Petri Savolainen wrote:
> Requires "[API-NEXT PATCH v2 0/2] IPsec API update".
>
> Input and output of IPSEC operations are packets. Parameter and
> result structures are cleaner when packet arrays are direct
> parameters to functions. Also API is more flexible for
>
On 09.06.2017 13:51, Petri Savolainen wrote:
> Input and output of IPSEC operations are packets. Parameter and
> result structures are cleaner when packet arrays are direct
> parameters to functions. Also API is more flexible for
> application or API pipelining when output is packets with
>
On 14.06.2017 12:53, Dmitry Eremin-Solenikov wrote:
> On 09.06.2017 15:32, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>>>> @@ -934,41 +926,70 @@ typedef struct odp_ipsec_op_status_t {
>>>> } odp_ipsec_op_status_t;
>>>>
>>>> /**
>>>&g
On 12.06.2017 14:11, Petri Savolainen wrote:
> Clean up function and parameter naming after modular interface
> patch. Queue_t type is referred as "queue internal": queue_int or
> q_int. Term "handle" is reserved for API level handles (e.g.
> odp_queue_t, odp_pktio_t, etc) through out linux-gen
On 14.06.2017 17:08, Petri Savolainen wrote:
> Input and output of IPSEC operations are packets. Parameter and
> result structures are cleaner when packet arrays are direct
> parameters to functions. Also API is more flexible for
> application and API pipelining when output is packets with
>
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/include/odp_buffer_inlines.h | 2 ++
platform/linux-generic/include/odp_buffer_internal.h | 3 +++
platform/linux-generic/odp_event.c | 5 +
platform/linux-g
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/validation/api/buffer/buffer.c | 37 +++--
test/common_plat/validation/api/packet/packet.c | 5
test/common_plat/validation/api/timer/timer.c | 14 --
3
Applies on top of [API-NEXT PATCH v2 0/3] IPSEC packet event
These patches provide event subtype implementation and tests. Ideally they
should be merged together with event subtypes API definitions.
Dmitry Eremin-Solenikov (2):
linux-generic: events subtype implementation
validation: test
On 15 June 2017 at 16:20, Maxim Uvarov <maxim.uva...@linaro.org> wrote:
> On 06/15/17 11:50, Dmitry Eremin-Solenikov wrote:
>> On 15.06.2017 11:47, shally verma wrote:
>>> Does it mean that going further there would be certain limitation on
>>> gcc version to be u
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/include/odp_buffer_inlines.h | 2 ++
platform/linux-generic/include/odp_buffer_internal.h | 3 +++
platform/linux-generic/odp_crypto.c | 14 --
platform
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/validation/api/buffer/buffer.c | 37 +++--
test/common_plat/validation/api/packet/packet.c | 5
test/common_plat/validation/api/timer/timer.c | 14 --
3
On 15.06.2017 14:21, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>
>> index d71f4464af48..3cd4a73cbefb 100644
>> --- a/platform/linux-generic/odp_event.c
>> +++ b/platform/linux-generic/odp_event.c
>> @@ -19,6 +19,11 @@ odp_event_type_t odp_event_type(odp_event_t event)
>> return
in odp_crypto.c
Dmitry Eremin-Solenikov (2):
linux-generic: events subtype implementation
validation: test correctness of events subtype implementation
.../linux-generic/include/odp_buffer_inlines.h | 2 ++
.../linux-generic/include/odp_buffer_internal.h| 3 ++
platform/linux-generic/odp_crypto.c
On 16.06.2017 12:37, Savolainen, Petri (Nokia - FI/Espoo) wrote:
switch (odp_event_type(event)) {
diff --git a/platform/linux-generic/odp_packet.c b/platform/linux-
generic/odp_packet.c
index eb66af2d3b9c..3789feca45f9 100644
--- a/platform/linux-generic/odp_packet.c
type and subtype
Changes since v1:
- Implement odp_event_types()
- Update event subtype properly in odp_crypto.c
Dmitry Eremin-Solenikov (2):
linux-generic: events subtype implementation
validation: test correctness of events subtype implementation
.../linux-generic/include
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
test/common_plat/validation/api/buffer/buffer.c| 50 --
.../validation/api/crypto/odp_crypto_test_inp.c| 14 ++
test/common_plat/validation/api/packet/packet.c| 21 -
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
platform/linux-generic/include/odp_buffer_inlines.h | 2 ++
platform/linux-generic/include/odp_buffer_internal.h | 3 +++
platform/linux-generic/odp_crypto.c | 15 +--
platform
On 09.06.2017 15:32, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>>> @@ -934,41 +926,70 @@ typedef struct odp_ipsec_op_status_t {
>>> } odp_ipsec_op_status_t;
>>>
>>> /**
>>> - * IPSEC operation input parameters
>>> + * IPSEC outbound operation options
>>> + *
>>> + * These may be used to
On 02.05.2017 11:27, Maxim Uvarov wrote:
> Updated github web hook:
>
> Changes:
>
> Now on merge request topic (title) of merge request automatic changed to:
> [PATCH vX] title
> or
> [PATCH API-NEXT vX] title
PR https://github.com/Linaro/odp/pull/10 was correctly renamed by your
hook, but
On 03.05.2017 07:43, Honnappa Nagarahalli wrote:
> Let us say:
>
> API spec v1.20 could define:
>
> typedef struct odp_foo_bar_t {
> /** This is foo*/
> uint8_t foo;
> } odp_foo_bar_t;
>
>
> API spec v1.30 could define:
>
> typedef struct odp_foo_bar_t {
> /**
Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
> ---
> include/odp/api/spec/crypto.h | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h
> index 181c0cc4.
Rename odp_crypto_data_range_t to odp_packet_data_range_t, as it is
relevant not only to the crypto interface.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
---
include/odp/api/spec/crypto.h | 17 +++--
include/odp/ap
On 04.05.2017 09:34, Peltonen, Janne (Nokia - FI/Espoo) wrote:
>
> Dmitry Eremin-Solenikov [mailto:dmitry.ereminsoleni...@linaro.org] wrote:
>>
>> On 03.05.2017 17:17, Peltonen, Janne (Nokia - FI/Espoo) wrote:
>>> Hi,
>>>
>>> I think there is a probl
rg
>> Subject: [lng-odp] [PATCH] api: ipsec: factor out IP protocol version
>> parameter
>>
>> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
>>
>> Both tunnel and lookup parameters refer IP protocol version. Factor that
>> ou
org
>> Subject: [lng-odp] [PATCH API-NEXT v1 1/2] api: ipsec: add soft limit
>> expiration event
>>
>> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
>>
>> If outbound packet was processed in inline mode, soft limit expira
On 06.05.2017 00:29, Bill Fischofer wrote:
> On Fri, May 5, 2017 at 4:24 PM, Dmitry Eremin-Solenikov
> <dmitry.ereminsoleni...@linaro.org> wrote:
>> On 05.05.2017 11:17, Savolainen, Petri (Nokia - FI/Espoo) wrote:
>>>
>>>
>>>> -Original Mess
On 05.05.2017 15:34, Petri Savolainen wrote:
> Added maximum number of packets per result event to make it easy
> for application to prepare enough storage for packets.
I'm still not sure that this is a good idea.
Patches 1 and 3 are:
Reviewed-by: Dmitry Eremin-Solenikov <dmitry.ere
org
>> Subject: [lng-odp] [PATCH API-NEXT v1 2/2] api: ipsec: move soft limits
>> expiration to flags, rather than errors
>>
>> From: Dmitry Eremin-Solenikov <dmitry.ereminsoleni...@linaro.org>
>>
>> Soft limit expiration isn't an error per se. It does not mean
201 - 300 of 430 matches
Mail list logo