[lng-odp] ODP crypto API

2015-12-08 Thread Bogdan Pricope
Hi, I have some questions on ODP crypto API: 1. Where can I find an ODP crypto API manual/document? 2. Some crypto APIs have a way to associate a crypto session with a "device": create a crypto session in the context of that "device". Is that possible with ODP crypto API? 3.

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Maxim Uvarov
On 12/08/2015 10:50, Savolainen, Petri (Nokia - FI/Espoo) wrote: Bill, hash_tbl_entry is now uintptr_t, which is 64 bits on a 64 bit build and 32 bits on a 32 bit build. These shifts and all other lines that expect that hash_tbl_entry (pointer size) is 64 bits should be updated also. -Petri

Re: [lng-odp] [API-NEXT PATCH v5 0/7] Multi-queue packet io APIs

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
ping. I have a flow on scheduler integration patch set which improves l2fwd scheduler mode packet rate ~25x (8 cores, 2x10GE interfaces). > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Petri Savolainen > Sent: Thursday, November 26,

Re: [lng-odp] [API-NEXT PATCH v2 0/5] netmap pktio multi queue support

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
Ping. Applies on top of [API-NEXT PATCH v5 0/7] Multi-queue packet io APIs. > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Matias Elo > Sent: Wednesday, November 25, 2015 3:16 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp]

Re: [lng-odp] [API-NEXT PATCH v5 0/7] Multi-queue packet io APIs

2015-12-08 Thread Bill Fischofer
We can discuss this during today's ODP public call and hopefully wrap it up. Thanks. On Tue, Dec 8, 2015 at 2:00 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > ping. > > I have a flow on scheduler integration patch set which improves l2fwd > scheduler mode

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Elo, Matias (Nokia - FI/Espoo)
Hi Ilya, I had completely missed your previous patch. You could also remove the two errno value checks in pktio_test_send_failure(). They are not defined in the API, so they should not be tested. -Matias > -Original Message- > From: EXT Ilya Maximets [mailto:i.maxim...@samsung.com] >

[lng-odp] [API-NEXT/PATCHv1 3/4] validation: classification: add class of service create api

2015-12-08 Thread Balasubramanian Manoharan
Replaces odp_cos_create() function with odp_cls_cos_create() function Signed-off-by: Balasubramanian Manoharan --- test/validation/classification/classification.h| 1 + .../classification/odp_classification_basic.c | 137 +++-

Re: [lng-odp] [API-NEXT PATCH v7 0/9] api: time: update local time to be monotonic

2015-12-08 Thread Maxim Uvarov
That patch serries looks ok, instead of one overrun of 32 bit counter. I can fix it just in place. Petri, agree? time.c: In function 'time_test_monotony': time.c:60:15: error: comparison is always true due to limited range of data type [-Werror=type-limits] while (count <

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

2015-12-08 Thread Maxim Uvarov
Peng, can you please send version with buffers pool to the list. Might be something wrong in implementation. Maxim. On 12/08/2015 14:42, Bill Fischofer wrote: This is an interesting topic. I'd like to discuss this a bit during today's ODP public call. I think the issue is that while a ring

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

2015-12-08 Thread Stuart Haslam
On Tue, Dec 08, 2015 at 02:51:40PM +0300, Ilya Maximets wrote: > On 08.12.2015 14:24, Stuart Haslam wrote: > > On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote: > >> Creates a new pktio type that allows for creating and > >> sending/receiving packets through TAP interface. > >> It is

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

2015-12-08 Thread Ilya Maximets
On 08.12.2015 14:24, Stuart Haslam wrote: > On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote: >> Creates a new pktio type that allows for creating and >> sending/receiving packets through TAP interface. >> It is intended for use as a simple conventional communication >> method between

Re: [lng-odp] [PATCH 00/10] Pktio checks

2015-12-08 Thread Stuart Haslam
On Tue, Nov 10, 2015 at 04:49:39PM +0100, Nicolas Morey-Chaisemartin wrote: > This series add several tests for pktios and fixes the issue they raised. > The main features checked are: > * RONLY pktio cannot be sent to > * WONLY pktio cannot be read from > * stopped pktio cannot be stopped > *

Re: [lng-odp] ODP crypto API

2015-12-08 Thread Bill Fischofer
You can find the current crypto API documentation at http://docs.opendataplane.org/master/linux-generic-doxygen-html/group__odp__crypto.html We are working on updating the ODP User Guide (see http://docs.opendataplane.org/master/linux-generic/output/users-guide.html) but the crypto section of

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Maxim Uvarov
On 12/08/2015 14:27, Bill Fischofer wrote: The cast plus the uint64_t typedef is the v1 patch. So is that one now good? For me v1 was good if I remember. And v2 with that fix also is good. Petri do you have any notes? Maxim. On Tue, Dec 8, 2015 at 4:45 AM, Maxim Uvarov

Re: [lng-odp] [PATCH] linux-generic: socket: set up __odp_errno on ioctl failures

2015-12-08 Thread Stuart Haslam
On Mon, Dec 07, 2015 at 05:25:03PM +0300, Ilya Maximets wrote: > Also debug output enhanced. > > Signed-off-by: Ilya Maximets Reviewed-by: Stuart Haslam > --- > platform/linux-generic/pktio/socket.c | 16 > 1 file changed, 12

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

2015-12-08 Thread Bill Fischofer
This is an interesting topic. I'd like to discuss this a bit during today's ODP public call. I think the issue is that while a ring is a very useful implementation construct its semantics are very SW centric. Perhaps there's opportunity here for a new Queue type that would permit an

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

2015-12-08 Thread Stuart Haslam
On Tue, Dec 08, 2015 at 03:25:01PM +0300, Ilya Maximets wrote: > > > On 08.12.2015 15:16, Stuart Haslam wrote: > > On Tue, Dec 08, 2015 at 02:51:40PM +0300, Ilya Maximets wrote: > >> On 08.12.2015 14:24, Stuart Haslam wrote: > >>> On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote: >

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Ilya Maximets
Matias, I think, better to make separate patch for that. It will not intersect with mine in case of only 2 deletions. Would you prepare it? Best regards, Ilya Maximets. On 08.12.2015 15:21, Elo, Matias (Nokia - FI/Espoo) wrote: > Hi Ilya, > > I had completely missed your previous patch. You

[lng-odp] [API-NEXT/PATCHv1 4/4] example: classifier: add class of service create api

2015-12-08 Thread Balasubramanian Manoharan
Replaces odp_cos_create() function with odp_cls_cos_create() function Signed-off-by: Balasubramanian Manoharan --- example/classifier/odp_classifier.c | 42 + 1 file changed, 24 insertions(+), 18 deletions(-) diff --git

[lng-odp] [API-NEXT/PATCHv1 2/4] linux-generic: classification: implement class of service create api

2015-12-08 Thread Balasubramanian Manoharan
Implements odp_cls_cos_create() and odp_cls_cos_param_init() functions Signed-off-by: Balasubramanian Manoharan --- platform/linux-generic/odp_classification.c | 31 ++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Ilya Maximets
Matias, please check out my patch ( https://lists.linaro.org/pipermail/lng-odp/2015-December/018057.html ) from my 'TAP pktio' patch set. Best regards, Ilya Maximets. On 08.12.2015 13:36, Elo, Matias (Nokia - FI/Espoo) wrote: > In both tests set MAC addresses to test packets to enable > testing

[lng-odp] [API-NEXT/PATCHv1 1/4] api: classification: add class of serivce create api

2015-12-08 Thread Balasubramanian Manoharan
class of service create function now takes pool, queue, drop policy and name as input parameters. Adds class of service parameter structure odp_cls_cos_param_t and initialization function odp_cls_cos_param_init() Signed-off-by: Balasubramanian Manoharan ---

Re: [lng-odp] [PATCH] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Elo, Matias (Nokia - FI/Espoo)
Can be discarded. Already fixed in Ilya Maximets' patch. -Matias > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Matias > Elo > Sent: Tuesday, December 08, 2015 12:37 PM > To: lng-odp@lists.linaro.org > Subject: [lng-odp] [PATCH]

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

2015-12-08 Thread Stuart Haslam
On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote: > Creates a new pktio type that allows for creating and > sending/receiving packets through TAP interface. > It is intended for use as a simple conventional communication > method between applications that use kernel network stack >

[lng-odp] [PATCH] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Matias Elo
In both tests set MAC addresses to test packets to enable testing with real pktio interfaces. In pktio_test_send_failure() don't check for errno values as they are not defined in the API. Signed-off-by: Matias Elo --- test/validation/pktio/pktio.c | 26

Re: [lng-odp] [API-NEXT PATCH v7 0/9] api: time: update local time to be monotonic

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
OK, it's the 32 bit build again (which was not tested). I have had trouble lately to install 32 bit libraries of OpenSSL into Ubuntu, which makes it hard to test linux-generic with -m32. So currently, I'm not testing 32 bit build either. -Petri > -Original Message- > From: lng-odp

Re: [lng-odp] [API-NEXT PATCH v7 0/9] api: time: update local time to be monotonic

2015-12-08 Thread Maxim Uvarov
Merged, Maxim. On 12/08/2015 14:11, Savolainen, Petri (Nokia - FI/Espoo) wrote: OK, it's the 32 bit build again (which was not tested). I have had trouble lately to install 32 bit libraries of OpenSSL into Ubuntu, which makes it hard to test linux-generic with -m32. So currently, I'm not

Re: [lng-odp] [PATCH] queue: fix memory corruption in reorder_enq()

2015-12-08 Thread Maxim Uvarov
Patch merged, Maxim. On 12/07/2015 21:44, Zoltan Kiss wrote: On 07/12/15 17:52, Bill Fischofer wrote: You're seeing this because in linux-dpdk the next field of the odp_buffer_hdr_t is not at offset 0. In linux-generic next is at offset zero so this code is slightly more efficient. So this

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] > Sent: Tuesday, December 08, 2015 10:44 AM > To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org > Subject: Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use > odp_hash_crc32c() api to

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Maxim Uvarov
On 12/08/2015 13:09, Savolainen, Petri (Nokia - FI/Espoo) wrote: -Original Message- From: EXT Maxim Uvarov [mailto:maxim.uva...@linaro.org] Sent: Tuesday, December 08, 2015 10:44 AM To: Savolainen, Petri (Nokia - FI/Espoo); lng-odp@lists.linaro.org Subject: Re: [lng-odp] [API-NEXT

Re: [lng-odp] [API-NEXT PATCH v7 0/9] api: time: update local time to be monotonic

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
Agree, it's a bug and the test would spin forever. Is this a build error? Ivan should have built the code successfully before sending... or do we have different warning levels enabled on different make targets? -Petri > -Original Message- > From: EXT Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCHv2] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Bill Fischofer
The cast plus the uint64_t typedef is the v1 patch. So is that one now good? On Tue, Dec 8, 2015 at 4:45 AM, Maxim Uvarov wrote: > On 12/08/2015 13:09, Savolainen, Petri (Nokia - FI/Espoo) wrote: > >> >> -Original Message- >>> From: EXT Maxim Uvarov

Re: [lng-odp] [API-NEXT PATCH v3] api: atomic: added atomic_lock_free_u64

2015-12-08 Thread Bill Fischofer
Can we resolve any outstanding issues with this during today's ODP call? This has been on the list for a while. On Tue, Dec 8, 2015 at 1:53 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > ping. > > > -Original Message- > > From: Savolainen, Petri (Nokia -

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

2015-12-08 Thread Ilya Maximets
On 08.12.2015 15:16, Stuart Haslam wrote: > On Tue, Dec 08, 2015 at 02:51:40PM +0300, Ilya Maximets wrote: >> On 08.12.2015 14:24, Stuart Haslam wrote: >>> On Mon, Dec 07, 2015 at 01:55:31PM +0300, Ilya Maximets wrote: Creates a new pktio type that allows for creating and

Re: [lng-odp] ODP crypto API

2015-12-08 Thread Ola Liljedahl
On 8 December 2015 at 09:53, Bogdan Pricope wrote: > Hi, > > > > I have some questions on ODP crypto API: > > 1. Where can I find an ODP crypto API manual/document? > > 2. Some crypto APIs have a way to associate a crypto session with a > „device”: create a

[lng-odp] [PATCHv4 3/3] linux-generic: pktio: add test for tap pktio

2015-12-08 Thread Ilya Maximets
Signed-off-by: Ilya Maximets --- platform/linux-generic/test/Makefile.am | 1 + platform/linux-generic/test/pktio/Makefile.am | 3 +- platform/linux-generic/test/pktio/pktio_run_tap | 114 3 files changed, 117 insertions(+), 1

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

2015-12-08 Thread Ola Liljedahl
On 8 December 2015 at 06:39, HePeng wrote: > Hi Maxim, > I implement a new version of cuckoo hash based on the ODP > buffer/pool. > > As I’ve mentioned earlier, the use of ring in cuckoo hash is like > to the use of > a container, e.g. a queue in C++ STL. In

Re: [lng-odp] [PATCH 00/10] Pktio checks

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
Could you merge this into api-next ASAP. Just lost couple of hours in debugging these same malfunctioning tests. -Petri > -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Maxim Uvarov > Sent: Tuesday, December 08, 2015 4:14 PM > To:

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-08 Thread Ola Liljedahl
On 3 December 2015 at 14:14, Ivan Khoronzhuk wrote: > It's in master already but I wonder how checkpatch missed it. > > On 05.11.15 13:20, huanggaoyang wrote: > >> Signed-off-by: huanggaoyang >> --- >> helper/hashtable.c | 346 >>

Re: [lng-odp] [PATCH] linux-generic: socket: set up __odp_errno on ioctl failures

2015-12-08 Thread Maxim Uvarov
Merged, Thanks. On 12/08/2015 14:29, Stuart Haslam wrote: On Mon, Dec 07, 2015 at 05:25:03PM +0300, Ilya Maximets wrote: Also debug output enhanced. Signed-off-by: Ilya Maximets Reviewed-by: Stuart Haslam ---

Re: [lng-odp] ODP crypto API

2015-12-08 Thread Bogdan Pricope
Hi, I imagine that it can be a good reason behind this API model: some boards may have multiple HW resources identifiable in same way and some applications may prefer to allocate by hand sessions to those resources (resource partitioning). OK, round robin allocation may work in most of the

[lng-odp] [PATCHv4 1/3] validation: pktio: initialize mac addresses for all packets

2015-12-08 Thread Ilya Maximets
For the purpose of testing of real-world interfaces the packet's content should be valid or kernel will throw them away. Signed-off-by: Ilya Maximets --- test/validation/pktio/pktio.c | 46 --- 1 file changed, 39 insertions(+), 7

[lng-odp] [PATCHv4 2/3] linux-generic: pktio: add tap pktio type

2015-12-08 Thread Ilya Maximets
Creates a new pktio type that allows for creating and sending/receiving packets through TAP interface. It is intended for use as a simple conventional communication method between applications that use kernel network stack (ping, ssh, iperf, etc.) and ODP applications for the purpose of functional

Re: [lng-odp] ODP crypto API

2015-12-08 Thread Ola Liljedahl
On 8 December 2015 at 15:44, Bogdan Pricope wrote: > Hi, > > > > I imagine that it can be a good reason behind this API model: some boards > may have multiple HW resources identifiable in same way and some > applications may prefer to allocate by hand sessions to those

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Mike Holmes
On 8 December 2015 at 10:17, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolai...@nokia.com> wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > > Ilya Maximets > > Sent: Tuesday, December 08, 2015 4:48 PM > > To: Stuart

Re: [lng-odp] [PATCHv3 2/3] linux-generic: pktio: add tap pktio type

2015-12-08 Thread Ilya Maximets
On 08.12.2015 15:35, Stuart Haslam wrote: > On Tue, Dec 08, 2015 at 03:25:01PM +0300, Ilya Maximets wrote: >> >> >> On 08.12.2015 15:16, Stuart Haslam wrote: >>> On Tue, Dec 08, 2015 at 02:51:40PM +0300, Ilya Maximets wrote: On 08.12.2015 14:24, Stuart Haslam wrote: > On Mon, Dec 07, 2015

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Ilya Maximets
On 08.12.2015 17:38, Stuart Haslam wrote: > On Tue, Dec 08, 2015 at 12:21:06PM +, Elo, Matias (Nokia - FI/Espoo) > wrote: >> Hi Ilya, >> >> I had completely missed your previous patch. You could also remove the two >> errno value checks in pktio_test_send_failure(). They are not defined in

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Savolainen, Petri (Nokia - FI/Espoo)
> -Original Message- > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > Ilya Maximets > Sent: Tuesday, December 08, 2015 4:48 PM > To: Stuart Haslam; Elo, Matias (Nokia - FI/Espoo) > Cc: lng-odp@lists.linaro.org > Subject: Re: [lng-odp] validation: pktio: fix

[lng-odp] [PATCHv4 0/3] TAP pktio

2015-12-08 Thread Ilya Maximets
Creates a new pktio type that allows for creating and sending/receiving packets through TAP interface. Detailed description in commit-message of patch "[PATCHv4 2/3] linux-generic: pktio: add tap pktio type". Changelog: Version 4: * changed error handling part in tap_pktio_send. (Stuart

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

2015-12-08 Thread Ola Liljedahl
On 8 December 2015 at 12:42, Bill Fischofer wrote: > This is an interesting topic. I'd like to discuss this a bit during > today's ODP public call. > > I think the issue is that while a ring is a very useful implementation > construct its semantics are very SW

Re: [lng-odp] [API-NEXTv6 1/7] api: buffer: add functions to alloc/free multiple buffers at once

2015-12-08 Thread Ola Liljedahl
On 3 December 2015 at 16:01, Bill Fischofer wrote: > > > On Thu, Dec 3, 2015 at 8:30 AM, Zoltan Kiss > wrote: > >> Hi, >> >> I know it's a late cry, but I've found two problems while implementing >> this for ODP-DPDK, and the apply for

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Stuart Haslam
On Tue, Dec 08, 2015 at 12:21:06PM +, Elo, Matias (Nokia - FI/Espoo) wrote: > Hi Ilya, > > I had completely missed your previous patch. You could also remove the two > errno value checks in pktio_test_send_failure(). They are not defined in the > API, so they should not be tested. > >

Re: [lng-odp] [PATCH 00/10] Pktio checks

2015-12-08 Thread Maxim Uvarov
On 12/08/2015 17:20, Savolainen, Petri (Nokia - FI/Espoo) wrote: Could you merge this into api-next ASAP. Just lost couple of hours in debugging these same malfunctioning tests. -Petri If you can merge that master and api-next I can. But for now after time things 2 branches out of sync in

Re: [lng-odp] validation: pktio: fix start_stop and send_failure tests

2015-12-08 Thread Stuart Haslam
On Tue, Dec 08, 2015 at 03:17:46PM +, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > > > -Original Message- > > From: lng-odp [mailto:lng-odp-boun...@lists.linaro.org] On Behalf Of EXT > > Ilya Maximets > > Sent: Tuesday, December 08, 2015 4:48 PM > > To: Stuart Haslam; Elo, Matias

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-08 Thread Stuart Haslam
On Thu, Dec 03, 2015 at 08:39:26AM -0500, Mike Holmes wrote: > It does miss it apparently - just shows you we still need a human eye > I have this in my ~/.gitconfig [core] whitespace = trailing-space,space-before-tab,indent-with-non-tab and it warns about it: Applying: helper: table:

Re: [lng-odp] [PATCHv4 2/5] helper: table: add impl of hashtable

2015-12-08 Thread Mike Holmes
On 8 December 2015 at 10:49, Stuart Haslam wrote: > On Thu, Dec 03, 2015 at 08:39:26AM -0500, Mike Holmes wrote: > > It does miss it apparently - just shows you we still need a human eye > > > > I have this in my ~/.gitconfig > [core] > whitespace =

Re: [lng-odp] [PATCH 00/10] Pktio checks

2015-12-08 Thread Mike Holmes
The process states that API-NEXT takes master on master release points only. https://docs.google.com/drawings/d/1kWkr2qBV4xbqOCXMDVsoINhdxaNeHC-8sCm6SBVFI8o/edit On 8 December 2015 at 09:48, Maxim Uvarov wrote: > On 12/08/2015 17:20, Savolainen, Petri (Nokia -

Re: [lng-odp] [API-NEXT PATCH] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Maxim Uvarov
Merged this patch. Now only issue left is fix: hash_main: no such file I think something wrong in Makefile.am, not sure if CI also captures that issues, but we will see. That is different issue. Maxim. On 12/03/2015 00:56, Bill Fischofer wrote: Change the internal hash_name_and_kind()

Re: [lng-odp] [API-NEXT PATCH v3] api: atomic: added atomic_lock_free_u64

2015-12-08 Thread Ola Liljedahl
The patch doesn't apply. It depends on this patch [API-NEXT,v3,7/7] api: atomic: added 32 bit acquire and release As can be seen here in the patch: diff --git a/include/odp/api/atomic.h b/include/odp/api/atomic.h index 316f13a..5e897c1 100644 ---

[lng-odp] [PATCHv4] helper : Fix UDP checksum computation

2015-12-08 Thread ion.grigore
From: Grigore Ion This patch fixes the following problems: - checksum computation for LE platforms - checksum is computed in the CPU endianness. The returned result must be converted to the BE ordering when it is used to update the UDP checksum in a packet. - checksum

Re: [lng-odp] [PATCHv3] helper : Fix UDP checksum computation

2015-12-08 Thread Ion Grigore
Hi Ilya, You are right, the comparison was in BE . I changed and I submitted a new patch (V4) Thanks, Grig -Original Message- From: Ilya Maximets [mailto:i.maxim...@samsung.com] Sent: Tuesday, December 08, 2015 9:47 AM To: Grigore Ion-B17953 ;

Re: [lng-odp] [API-NEXT PATCH] api: init: allow implementation to use private ways for its own configuration

2015-12-08 Thread Zoltan Kiss
Hi Petri, Did you have time to think on this? Mike added it to tomorrow's arch call to discuss, unless you are happy with what I've proposed. Zoli On 01/12/15 11:30, Zoltan Kiss wrote: On 01/12/15 08:38, Savolainen, Petri (Nokia - FI/Espoo) wrote: // Fill defaults (from config file) //

Re: [lng-odp] [API-NEXT PATCH] linux-generic: tm: use odp_hash_crc32c() api to avoid arch issues

2015-12-08 Thread Bill Fischofer
hash_main is the binary output from compiling the hash CUnit test. That's should have nothing to do with TM. On Tue, Dec 8, 2015 at 9:35 AM, Maxim Uvarov wrote: > Merged this patch. > > Now only issue left is fix: > hash_main: no such file > I think something wrong in

[lng-odp] [PATCH] validation/config/Makefile: change install location

2015-12-08 Thread Anders Roxell
All tests should be installed under testdir variable and not in the bin directory. Signed-off-by: Anders Roxell --- test/validation/config/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/validation/config/Makefile.am

Re: [lng-odp] api-next broken?

2015-12-08 Thread Bill Fischofer
Well, I've verified that if you do similar mods to test/validation/pktio/pktio.c and test/validation/time/time.c then all is good, however what this means is that we've just broken ODP API portability because we now require that ODP applications include this #define when compiling for

Re: [lng-odp] api-next broken?

2015-12-08 Thread Mike Holmes
Patch sent that works for me, it depends on the compiler in use and the c99 vs posix standard I think On 8 December 2015 at 17:14, Bill Fischofer wrote: > git bisect shows: > > 3164ccfe7e6dc548852b8f6f681069cd6d524bfc is the first bad commit > commit

[lng-odp] [API-NEXT] add _POSIX_C_SOURCE 200809 to fix build

2015-12-08 Thread Mike Holmes
fixes api-next CC odp_schedule.lo odp_schedule.c: In function 'schedule_loop': odp_schedule.c:589:13: error: storage size of 'next' isn't known odp_time_t next, wtime; ^ Signed-off-by: Mike Holmes --- platform/linux-generic/odp_schedule.c | 2 ++

Re: [lng-odp] api-next broken?

2015-12-08 Thread Bill Fischofer
That helps but it looks incomplete. With that patch applied ODP compiles but the CUnit tests fail: Making all in pktio make[3]: Entering directory '/home/bill/linaro/api-next/test/validation/pktio' CC pktio.lo pktio.c: In function 'queue_deq_wait_time': pktio.c:339:13: error: storage

Re: [lng-odp] api-next broken?

2015-12-08 Thread Mike Holmes
Yep, I just compiled what I had, but it is the same root cause, just needs to be told to allow POSIX in that SRC. Maxim do you just want to fix in your morning, I dont have time now tonight so dont wait for me but you could add me as Suggested-by On 8 December 2015 at 18:17, Bill Fischofer

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

2015-12-08 Thread HePeng
> 在 2015年12月8日,下午9:34,Ola Liljedahl 写道: > > On 8 December 2015 at 12:42, Bill Fischofer > wrote: > This is an interesting topic. I'd like to discuss this a bit during today's > ODP public call. > > I

Re: [lng-odp] [API-NEXT PATCH v2] helper: add cuckoo hash implementation

2015-12-08 Thread HePeng
Let me further explain this. Cuckoo hash is a hash table, and as a hash table, it needs to store the key-value paris. For any input, e.g. a key ( a byte string with some size), a hash table needs to calculate the hash value from the key, find the right bucket, and compare the input key with

Re: [lng-odp] [PATCHv2] doc: userguide: add application programming section

2015-12-08 Thread Mike Holmes
Using patch: lng-odp_PATCHv2_doc_userguide_add_application_programming_section.mbox Trying to apply patch Patch applied Applying: doc: userguide: add application programming section /home/mike/git/check-odp/build/odp-apply/.git/rebase-apply/patch:446: indent with spaces. odp_event_t

Re: [lng-odp] api-next broken?

2015-12-08 Thread Bill Fischofer
git bisect shows: 3164ccfe7e6dc548852b8f6f681069cd6d524bfc is the first bad commit commit 3164ccfe7e6dc548852b8f6f681069cd6d524bfc Author: Ivan Khoronzhuk Date: Fri Dec 4 19:51:29 2015 +0200 linux-generic: odp_time: don't use cpu cycle API to get time The

[lng-odp] api-next broken?

2015-12-08 Thread Bill Fischofer
Trying to compile a fresh clone of api-next I'm seeing the following: CC odp_schedule.lo odp_schedule.c: In function 'schedule_loop': odp_schedule.c:589:13: error: storage size of 'next' isn't known odp_time_t next, wtime; ^ odp_schedule.c:589:19: error: storage size of