Re: [lng-odp] Driver registration: object version control

additional API related to device management and not "packetio" related: https://lwn.net/Articles/677967/ FF On 29 November 2016 at 20:35, Christophe Milard < christophe.mil...@linaro.org> wrote: > > > On 29 November 2016 at 20:00, Francois Ozog > wrote: > >> >> >> On

Re: [lng-odp] [PATCH] test: linux-gen: fix termination in mmap_vlan_ins

On Fri, Nov 25, 2016 at 8:06 AM, Maxim Uvarov wrote: > exit variable has to be volatile to be visible from thread. Without > that background process is not killed with default optimization level. > > Signed-off-by: Maxim Uvarov Reviewed-by: Bill

Re: [lng-odp] [PATCH] linux-gen: sysinfo: check for overflow

On Tue, Nov 29, 2016 at 11:25 AM, Maxim Uvarov wrote: > Coverity also does not like such division: > > *** CID 1382604: Incorrect expression (UNINTENDED_INTEGER_DIVISION) > /platform/linux-generic/arch/x86/odp_sysinfo_parse.c: 75 in > odp_cpu_hz_current() > 69

[lng-odp] [API-NEXT PATCH] linux-generic: pool: reset origin_qe on buffer allocation

Resolve bug https://bugs.linaro.org/show_bug.cgi?id=2622 by re-initializing origin_qe to NULL when a buffer is allocated. This step was omitted in the switch to ring pool allocation introduced in commit ID c8cf1d87783d4b4c628f219803b78731b8d4ade4 Signed-off-by: Bill Fischofer

Re: [lng-odp] Driver registration: object version control

On 29 November 2016 at 20:00, Francois Ozog wrote: > > > On 29 November 2016 at 19:03, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> >> >> On 29 November 2016 at 18:13, Francois Ozog >> wrote: >> >>> >>> >>> On 29 November

Re: [lng-odp] Driver registration: object version control

On 29 November 2016 at 19:03, Christophe Milard < christophe.mil...@linaro.org> wrote: > > > On 29 November 2016 at 18:13, Francois Ozog > wrote: > >> >> >> On 29 November 2016 at 16:44, Christophe Milard < >> christophe.mil...@linaro.org> wrote: >> >>> >>> >>> On 29

[lng-odp] sick

Hello team, I got seek and did not finally recover. So I might skip some meetings today. Maxim.

Re: [lng-odp] [API-NEXT PATCH 3/3] linux-gen: add interests query (iquery) scheduler

Thanks Bill I'll check this once back to office in Thursday. Best Regards, Yi On 29 November 2016 at 10:59, Bill Fischofer wrote: > Attempting to compile this with clang I get: > > odp_schedule_iquery.c:170:3: error: redefinition of typedef >

[lng-odp] Driver registration: object version control

Hi, In our last meeting, yesterday, we agreed on the following objects: 1) enumerator class 2) enumerator 3) enumerated_device 4) devio 5) driver and to come: pktio_interface... At registration time, the driver have to tell: - The enumerator class it expects devices from (string E) - The devio

[lng-odp] [Bug 2622] scheduler test fails in api-next

https://bugs.linaro.org/show_bug.cgi?id=2622 Bill Fischofer changed: What|Removed |Added Status|CONFIRMED |IN_PROGRESS

[lng-odp] [Bug 2644] Event order doesn't always hold when new events are allocated within an ordered context

https://bugs.linaro.org/show_bug.cgi?id=2644 --- Comment #1 from Bill Fischofer --- I believe this is a duplicate of Bug 2622 and should be resolved by the patch I just posted to fix that: http://patches.opendataplane.org/patch/7476/ Please confirm and if this is

[lng-odp] [Bug 2652] drvshmem_main fails and segfaults

https://bugs.linaro.org/show_bug.cgi?id=2652 Mike Holmes changed: What|Removed |Added Assignee|maxim.uva...@linaro.org

Re: [lng-odp] [PATCH] test: tm: do lookup first then open

Bala, can you review this one as TM lead On 18 November 2016 at 14:38, Maxim Uvarov wrote: > First tests will open pktio and all others will look up > handle by name. Change order of open/lookup to not call > fail opens. > > Signed-off-by: Maxim Uvarov

Re: [lng-odp] Driver registration: object version control

Hi, comments inline On 29 November 2016 at 10:58, Christophe Milard < christophe.mil...@linaro.org> wrote: > Hi, > > In our last meeting, yesterday, we agreed on the following objects: > 1) enumerator class > 2) enumerator > 3) enumerated_device > 4) devio > [FF] we have defined two types of

[lng-odp] [Bug 2622] scheduler test fails in api-next

https://bugs.linaro.org/show_bug.cgi?id=2622 Bill Fischofer changed: What|Removed |Added CC|

[lng-odp] [Bug 2652] New: drvshmem_main fails and segfaults

https://bugs.linaro.org/show_bug.cgi?id=2652 Bug ID: 2652 Summary: drvshmem_main fails and segfaults Product: OpenDataPlane - linux- generic reference Version: api-next Hardware: Other OS: Linux Status: UNCONFIRMED

Re: [lng-odp] [PATCH 0/2] calling term functions from pktio_perf

Merged, Maxim. On 11/29/16 05:53, Bill Fischofer wrote: For this series: Reviewed-by: Bill Fischofer On Fri, Nov 25, 2016 at 11:14 AM, Christophe Milard wrote: The term functions were not called in odp_pktio_perf.c. Fixing this

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: added IPSEC API

Hi, > I am wonder how will be calculate lifetime in bytes for asynchronous > inbound operations and how the application can figure it out from output > packets: it is only output packet data or should contain ESP header/trailer > + outer IP header? RFC 4301 says this about byte based SA

Re: [lng-odp] [PATCHv7 0/3] changelog: summary of changes for odp v1.12.0.0

On 11/28/16 18:45, Bogdan Pricope wrote: ./configure --help | grep ABI --disable-abi-compat disables ABI compatible mode, enables inline code in header files while in CHANGELOG: +`--enable-abi-compat=yes`:: and +`--enable-abi-compat=no`:: but no: --disable-abi-compat good find. v8

[lng-odp] [API-NEXT PATCH] test: drvshm: removing invalid test

The test trying to free a unallocated address is now erroneous since ODP is using ishm too: unknown drvshm addresses may well be valid ODP addresses, in which case the test frees someone else memory! The test is simply suppressed. Signed-off-by: Christophe Milard

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: added IPSEC API

Regards, Bala On 24 November 2016 at 18:24, Savolainen, Petri (Nokia - FI/Espoo) wrote: > > >> -Original Message- >> From: Bala Manoharan [mailto:bala.manoha...@linaro.org] >> Sent: Thursday, November 24, 2016 9:50 AM >> To: Savolainen, Petri (Nokia

Re: [lng-odp] [PATCHv7 3/3] configure.ac update version numbers

On 2016-11-24 23:24, Maxim Uvarov wrote: > Default is abi compat mode, all interface functions changed, > so increase first number of .so > > Signed-off-by: Maxim Uvarov > --- > configure.ac | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [lng-odp] [PATCHv7 3/3] configure.ac update version numbers

On 11/29/16 17:14, Anders Roxell wrote: On 2016-11-24 23:24, Maxim Uvarov wrote: Default is abi compat mode, all interface functions changed, so increase first number of .so Signed-off-by: Maxim Uvarov --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [lng-odp] [PATCH v2] travis.yml: add coverity support

Merged, I tested on my github and it works. But takes 2-3 business days for Coverity team to confirm match project to open source. Maxim. On 11/28/16 18:04, Mike Holmes wrote: ping, are you happy to merge this or do I respin it ? I think you are the only other user so far unless Christophe

Re: [lng-odp] [API-NEXT PATCH] api: ipsec: added IPSEC API

In this API version, ODP is keeping counters for SA lifetime, so maybe is not a good example. What if we will need to transfer some other info from IPsec engine to application: some flags, sizes etc.? This is why I proposed to have some extensible metadata with the packet and not only L3 and L4

Re: [lng-odp] [API-NEXT PATCH] linux-gen: _fdserver: request sigterm if parent dies

ping This should be straightforward to review and would help (partly) avoiding hanging processes when killing ODP (e.g. ctrl-C) Thanks On 2016-11-25 15:39, Christophe Milard wrote: > _fdserver now request SIGTERM if parent process (ODP instantiation > process) dies, hence avoiding it to become

[lng-odp] cannot create multiple threads for traffic management

Hi Spinney, I noticed you add a tm group to the traffic management and create thread for the group. However, I cannot create multiple tm threads with system less than 24 cores. In this case, multiple tms are attached to the same group and serviced by a single thread. Is it too big? Can I remove

Re: [lng-odp] Driver registration: object version control

On 29 November 2016 at 13:22, Francois Ozog wrote: > Hi, > > comments inline > > On 29 November 2016 at 10:58, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> Hi, >> >> In our last meeting, yesterday, we agreed on the following objects: >> 1) enumerator

[lng-odp] [PATCHv8 0/3] changelog: summary of changes for odp v1.12.0.0

v8: update changelog --disable-abi-compat option (Mike) v7: more accurate define disable option (Anders) Bill Fischofer (1): changelog: summary of changes for odp v1.12.0.0 Maxim Uvarov (2): configure.ac: disable shared library for non abi compat mode configure.ac update version numbers

[lng-odp] [PATCHv8 1/3] configure.ac: disable shared library for non abi compat mode

original configure.ac enables abi compat mode by default, even without --enable-abi-compat provided. And has broken logic to disable abi compat mode. Correct logic to build abi compat mode and option to disable it. Shared library is not needed for non abi compat mode, so turn it off.

Re: [lng-odp] [PATCH] example: packet: correct size print

needed review-by for this patch. ping. Maxim. On 11/07/16 18:43, Maxim Uvarov wrote: looks like typo in print, delete it. Signed-off-by: Maxim Uvarov --- example/packet/pktio_run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [lng-odp] Driver registration: object version control

On 29 November 2016 at 16:44, Christophe Milard < christophe.mil...@linaro.org> wrote: > > > On 29 November 2016 at 13:22, Francois Ozog > wrote: > >> Hi, >> >> comments inline >> >> On 29 November 2016 at 10:58, Christophe Milard < >> christophe.mil...@linaro.org>

Re: [lng-odp] Driver registration: object version control

On 29 November 2016 at 18:13, Francois Ozog wrote: > > > On 29 November 2016 at 16:44, Christophe Milard < > christophe.mil...@linaro.org> wrote: > >> >> >> On 29 November 2016 at 13:22, Francois Ozog >> wrote: >> >>> Hi, >>> >>> comments

Re: [lng-odp] [PATCHv8 3/3] configure.ac update version numbers

On 29 November 2016 at 11:32, Maxim Uvarov wrote: > Default is abi compat mode, all interface functions changed, > so increase first number of .so > > Signed-off-by: Maxim Uvarov > --- > configure.ac | 6 +++--- > 1 file changed, 3

Re: [lng-odp] Driver registration: object version control

On 29 November 2016 at 13:03, Christophe Milard < christophe.mil...@linaro.org> wrote: > On 29 November 2016 at 18:13, Francois Ozog > wrote: > > > > > > > On 29 November 2016 at 16:44, Christophe Milard < > > christophe.mil...@linaro.org> wrote: > > > >> > >> > >> On

[lng-odp] [PATCHv8 2/3] changelog: summary of changes for odp v1.12.0.0

From: Bill Fischofer Signed-off-by: Bill Fischofer Signed-off-by: Maxim Uvarov --- CHANGELOG | 177 ++ 1 file changed, 177 insertions(+) diff --git

[lng-odp] [PATCHv8 3/3] configure.ac update version numbers

Default is abi compat mode, all interface functions changed, so increase first number of .so Signed-off-by: Maxim Uvarov --- configure.ac | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index b460a65..e7b8f8a 100644

Re: [lng-odp] [PATCH] linux-gen: sysinfo: check for overflow

Coverity also does not like such division: *** CID 1382604: Incorrect expression (UNINTENDED_INTEGER_DIVISION) /platform/linux-generic/arch/x86/odp_sysinfo_parse.c: 75 in odp_cpu_hz_current() 69 } 70 } 71 72 fclose(file); 73 if (mhz) { 74 /* check for

[lng-odp] [Bug 2652] drvshmem_main fails and segfaults

https://bugs.linaro.org/show_bug.cgi?id=2652 --- Comment #1 from Christophe Milard --- patch on list, https://lists.linaro.org/pipermail/lng-odp/2016-November/026687.html possibly -Hopefully- fixing this. cannot reproduce the problem here, so patch is based on

Re: [lng-odp] [PATCHv8 3/3] configure.ac update version numbers

More detailed flow on how to figure out the number https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html On 29 November 2016 at 13:09, Mike Holmes wrote: > > > On 29 November 2016 at 11:32, Maxim Uvarov > wrote: > >>

Re: [lng-odp] [PATCHv8 3/3] configure.ac update version numbers

On 11/29/16 21:29, Mike Holmes wrote: More detailed flow on how to figure out the number https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html I take into account that all other odp platfroms will inherit configure.ac from linux-generic. And might be will be