Re: Joran, RollingFileAppender, and Rollover failure warnings

2004-12-08 Thread Jacob Kjome
At 11:48 PM 12/7/2004 -0600, you wrote: >At 08:29 PM 12/7/2004 +0100, you wrote: > >At 08:30 AM 12/4/2004, Jacob Kjome wrote: > > > >>I'm not completely clear on what should be happening, but it seems to me > >>that... > >> > >>1. The rolling shouldn't be happening every time I restart the > >>ser

Re: Make Configurators stateless again

2004-12-08 Thread Mark Womack
My recent commits don't have anything to do with this issue. They certainly don't extend the Configurator api to include a getErrorList method or a doConfigure method that takes a list to put errors into. Just from this description, it appears that only JoranConfigurator has this "stateful" fe

null pointer in FixedWindowRollingPolicy

2004-12-08 Thread Jacob Kjome
At 03:33 PM 12/8/2004 +, you wrote: >ceki2004/12/08 07:33:23 > > Modified:src/java/org/apache/log4j/rolling/helper >FileNamePattern.java IntegerTokenConverter.java > tests/src/java/org/apache/log4j/rolling >SizeBasedRoll

Test Update

2004-12-08 Thread Mark Womack
I had a heck of a time with the test cases. First it was complaining that it could not find a ./test/lib directory. Then it was complaining that it could not find jetty related classes. Then it was complaining about the test cases being invalid with JUnit. AGH! I know I have been out of it

cvs commit: logging-log4j/tests build.properties.sample build.xml README

2004-12-08 Thread mwomack
mwomack 2004/12/08 21:59:08 Modified:testsbuild.properties.sample build.xml README Log: Updated files to reflect usage of ./tests/lib directory for external jars required for test cases. Updated README to explicitly mention the lib dir, what jars are required, and where to ge

Make Configurators stateless again

2004-12-08 Thread Curt Arnold
I mentioned this a couple of days ago in http://nagoya.apache.org/eyebrowse/ReadMsg?listName=log4j- [EMAIL PROTECTED]&msgNo=8225. JoranConfigurator had changed the configuration pattern from: JoranConfigurator.configure(filename) to JoranConfigurator config = new JoranConfigurator(); config.

cvs commit: logging-log4j/src/java/org/apache/log4j/varia ReloadingPropertyConfigurator.java

2004-12-08 Thread mwomack
mwomack 2004/12/08 21:23:14 Modified:src/java/org/apache/log4j/varia ReloadingPropertyConfigurator.java Log: Updating to impelement new doConfigure(InputStream, LoggingRepository) method required by updated Configurator interface. Revision ChangesPa

cvs commit: logging-log4j/src/java/org/apache/log4j PropertyConfigurator.java

2004-12-08 Thread mwomack
mwomack 2004/12/08 21:22:59 Modified:src/java/org/apache/log4j PropertyConfigurator.java Log: Updating to impelement new doConfigure(InputStream, LoggingRepository) method required by updated Configurator interface. Revision ChangesPath 1.72 +25 -0 logging-log4

cvs commit: logging-log4j/src/java/org/apache/log4j/spi Configurator.java

2004-12-08 Thread mwomack
mwomack 2004/12/08 21:22:05 Modified:src/java/org/apache/log4j/spi Configurator.java Log: Adding doConfigure(InputStream, LoggingRepository) to Configurator interface. Revision ChangesPath 1.13 +16 -0 logging-log4j/src/java/org/apache/log4j/spi/Configurator.java

cvs commit: logging-log4j/src/java/org/apache/log4j/rolling RollingPolicyBase.java FixedWindowRollingPolicy.java TimeBasedRollingPolicy.java RollingPolicySkeleton.java

2004-12-08 Thread ceki
ceki2004/12/08 13:21:33 Modified:src/java/org/apache/log4j/rolling FixedWindowRollingPolicy.java TimeBasedRollingPolicy.java Added: src/java/org/apache/log4j/rolling RollingPolicyBase.java Removed: src/java/org/apache/log4

cvs commit: logging-log4j/tests/witness/rolling sbr-test3.0.gz sbr-test3.1.gz sbr-test3.log

2004-12-08 Thread ceki
ceki2004/12/08 13:03:13 Modified:tests/src/java/org/apache/log4j/rolling SizeBasedRollingTest.java Added: tests/witness/rolling sbr-test3.0.gz sbr-test3.1.gz sbr-test3.log Log: Work in progress. Revision ChangesPat

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/rolling SizeBasedRollingTest.java

2004-12-08 Thread ceki
ceki2004/12/08 12:23:35 Modified:testsbuild.xml tests/src/java/org/apache/log4j/rolling SizeBasedRollingTest.java Log: SizeBased triggering works now on Linux. Revision ChangesPath 1.68 +1 -1 logging-log4j/tests/bui

cvs commit: logging-log4j/tests/witness sizeBased-test1.1 sizeBased-test1.2 sizeBased-test1.3

2004-12-08 Thread ceki
ceki2004/12/08 12:22:49 Removed: tests/witness sizeBased-test1.1 sizeBased-test1.2 sizeBased-test1.3 Log: Removing unused files. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

cvs commit: logging-log4j/tests/witness/rolling sbr-test2.0 sbr-test2.1 sbr-test2.log

2004-12-08 Thread ceki
ceki2004/12/08 12:21:51 Added: tests/witness/rolling sbr-test2.0 sbr-test2.1 sbr-test2.log Log: added new witness files for size-based triggering/rolling Revision ChangesPath 1.1 logging-log4j/tests/witness/rolling/sbr-test2.0 Index: sbr-test2.

cvs commit: logging-log4j/tests/input/joran conversionRule.xml parser3.xml

2004-12-08 Thread ceki
ceki2004/12/08 10:49:24 Modified:testsbuild.xml tests/input/joran conversionRule.xml parser3.xml Log: SlidingWindowRollingPolicy renamed as FixedWindowRollingPolicy Revision ChangesPath 1.67 +3 -1 logging-log4j/tests/build.xml Index:

cvs commit: logging-log4j/src/xdocs documentation.xml contributors.xml

2004-12-08 Thread ceki
ceki2004/12/08 09:36:15 Modified:docs contributors.html documentation.html manual.html src/xdocs documentation.xml contributors.xml Log: Updated links, removed stale ones. Revision ChangesPath 1.14 +3 -4 logging-log4j/docs/contributors.htm

cvs commit: logging-log4j/src/xdocs documentation.xml faq.xml

2004-12-08 Thread ceki
ceki2004/12/08 09:22:20 Modified:docs faq.html codes.html documentation.html src/xdocs documentation.xml faq.xml Log: - Updated links, codes.xml Revision ChangesPath 1.6 +1 -1 logging-log4j/docs/faq.html Index: faq.html ===

Re: Adding method to o.a.l.spi.Configurator

2004-12-08 Thread Ceki Gülcü
At 05:18 PM 12/8/2004, Mark Womack wrote: I will make the change later tonight. I don't think we should be making lots of changes to public interfaces like Configurator, but I also don't think we should be permanently hemmed in by them either. My concern is not only about the public interface as

Re: Adding method to o.a.l.spi.Configurator

2004-12-08 Thread Mark Womack
I think most users will just file and http, but I don't want to prevent them from using other sources as well. I have thought about socket and JMS, but I'm sure someone will come up with something very novel here. I will make the change later tonight. I don't think we should be making lots of

cvs commit: logging-log4j/src/java/org/apache/joran/action Action.java

2004-12-08 Thread ceki
ceki2004/12/08 07:58:18 Modified:examples/src/joran/implicit PrintMe.java tests/src/java/org/apache/joran InterpreterTest.java src/java/org/apache/joran/action Action.java Added: tests/src/java/org/apache/log4j/joran NOPAction.java Log: - Add

cvs commit: logging-log4j/tests/src/java/org/apache/joran InterpreterTest.java

2004-12-08 Thread ceki
ceki2004/12/08 07:48:25 Modified:tests/src/java/org/apache/joran InterpreterTest.java Log: - Renamed SlidingWindowRollingPolicy as FixedWindowRollingPolicy. Revision ChangesPath 1.11 +2 -2 logging-log4j/tests/src/java/org/apache/joran/InterpreterTest.java

cvs commit: logging-log4j/examples/src/joran/implicit NOPAction.java

2004-12-08 Thread ceki
ceki2004/12/08 07:47:23 Added: examples/src/joran/implicit NOPAction.java Log: NOPAction is part of the joran tutorial. It should not be removed. Revision ChangesPath 1.3 +0 -0 logging-log4j/examples/src/joran/implicit/NOPAction.java

cvs commit: logging-log4j/tests/src/java/org/apache/log4j/rolling SizeBasedRollingTest.java

2004-12-08 Thread ceki
ceki2004/12/08 07:33:23 Modified:src/java/org/apache/log4j/rolling/helper FileNamePattern.java IntegerTokenConverter.java tests/src/java/org/apache/log4j/rolling SizeBasedRollingTest.java Added: src/java/org/apach

cvs commit: logging-log4j/src/java/org/apache/log4j/selector ContextJNDISelector.java

2004-12-08 Thread ceki
ceki2004/12/08 06:28:26 Modified:src/java/org/apache/log4j/selector ContextJNDISelector.java Log: Documentation update Revision ChangesPath 1.15 +15 -13 logging-log4j/src/java/org/apache/log4j/selector/ContextJNDISelector.java Index: ContextJNDISelector.

RE: Joran, RollingFileAppender, and Rollover failure warnings

2004-12-08 Thread Ceki Gülcü
On Windows, opening the log file from a different process is known to cause trouble duing rollover. In 1.3, the rollover mechanism tries to deal with this by first renaming the file file, and only if that fails, it copies the file. However, this strategy does not always succeed, in which case a Rol

RE: Adding method to o.a.l.spi.Configurator

2004-12-08 Thread Ceki Gülcü
Mark, IMHO, watching files and urls (including http://) covers most needs whereas watching sockets is a non-essential feature. As intimated previously, I am not extremely thrilled with changing the Configurator interface. However, if you think an additional method would help, then so be it. My pre

cvs commit: logging-log4j/src/java/org/apache/log4j/chainsaw Generator.java

2004-12-08 Thread sdeboy
sdeboy 2004/12/08 01:17:42 Modified:src/java/org/apache/log4j/chainsaw/icons LevelIconFactory.java src/java/org/apache/log4j/chainsaw Generator.java Log: Using ERROR icon for fatal events Adding entries to generator Revision Changes