Re: Thread safety issue in LoggingEvent (1.3 code)

2005-12-01 Thread Curt Arnold
Looks like it to me, also appears in the 1.2 branch. Is className typically null, resulting in the offending path only taken with a custom level? If not, could checks for "org.apache.log4j.Level" and "org.apache.log4j.Priority" avoiding the reflection overhead except where really needed?

svn commit: r351606 - /logging/chainsaw/trunk/zeroconf/org/apache/log4j/chainsaw/zeroconf/ZeroConfPlugin.java

2005-12-01 Thread psmith
Author: psmith Date: Thu Dec 1 21:58:49 2005 New Revision: 351606 URL: http://svn.apache.org/viewcvs?rev=351606&view=rev Log: Added an icon to the ZeroConf plugin's tab when it detects a discovered device. Modified: logging/chainsaw/trunk/zeroconf/org/apache/log4j/chainsaw/zeroconf/ZeroConf

Thread safety issue in LoggingEvent (1.3 code)

2005-12-01 Thread Paul Smith
Umm, am I missing something or is this thread unsafe in LoggingEvent? static final Integer[] PARAM_ARRAY = new Integer[1];in readLevel(ObjectInputStream){.        PARAM_ARRAY[0] = new Integer(p);        level = (Level)m.invoke(null, (Object[]) PARAM_ARRAY);Is there some synchronization done

DO NOT REPLY [Bug 29719] - Log4JMini does not build

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r351601 - in /logging/sandbox/log4j/log4jMini/trunk/src/java/org/apache/log4j: Logger.java spi/RootLogger.java

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 21:21:04 2005 New Revision: 351601 URL: http://svn.apache.org/viewcvs?rev=351601&view=rev Log: Bug 29719: log4jMini does not build Added: logging/sandbox/log4j/log4jMini/trunk/src/java/org/apache/log4j/Logger.java logging/sandbox/log4j/log4jMini/trunk/src

svn commit: r351600 - in /logging/sandbox/log4j/log4jMini: branches/ tags/ trunk/build.xml trunk/src/java/org/apache/log4j/Category.java trunk/src/java/org/apache/log4j/spi/RootCategory.java

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 21:20:15 2005 New Revision: 351600 URL: http://svn.apache.org/viewcvs?rev=351600&view=rev Log: Bug 29719: log4jMini does not build Added: logging/sandbox/log4j/log4jMini/branches/ logging/sandbox/log4j/log4jMini/tags/ Modified: logging/sandbox/log4j/lo

svn commit: r351588 - /logging/sandbox/log4j/log4jMini/trunk/

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 21:06:00 2005 New Revision: 351588 URL: http://svn.apache.org/viewcvs?rev=351588&view=rev Log: New sandbox home for log4jMini Added: logging/sandbox/log4j/log4jMini/trunk/ - copied from r351587, logging/log4j/trunk/log4jMini/ --

svn commit: r351585 - /logging/sandbox/log4j/log4jMini/

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 21:05:02 2005 New Revision: 351585 URL: http://svn.apache.org/viewcvs?rev=351585&view=rev Log: New sandbox home for log4jMini Added: logging/sandbox/log4j/log4jMini/ - To unsubscribe, e-mail

DO NOT REPLY [Bug 37747] - Deadlock between SMTPAppender and RootLogger

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37738] - Problems with ULogger when running Ant

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r351531 - /logging/log4j/trunk/build.xml

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 16:05:49 2005 New Revision: 351531 URL: http://svn.apache.org/viewcvs?rev=351531&view=rev Log: Bug 37738: slf4j support files not included in distribution Modified: logging/log4j/trunk/build.xml Modified: logging/log4j/trunk/build.xml URL: http://svn.apache.

Recent sandbox commits

2005-12-01 Thread Curt Arnold
I started some sandbox proposed as described in http:// marc.theaimsgroup.com/?l=apache-logging-general&m=112649550919155&w=2 and have to take a break before I pick up later this evening. What I've done so far is add another directory in the sandbox to separate the classic "log4j_sandbox" p

DO NOT REPLY [Bug 37747] New: - Deadlock between SMTPAppender and RootLogger

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r351501 - in /logging/sandbox/log4j: log4j_sandbox/trunk/ trunk/

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 14:08:52 2005 New Revision: 351501 URL: http://svn.apache.org/viewcvs?rev=351501&view=rev Log: Adding new root directory for classic sandbox project Added: logging/sandbox/log4j/log4j_sandbox/trunk/ - copied from r351500, logging/sandbox/log4j/trunk/ Rem

svn commit: r351500 - in /logging/sandbox/log4j: log4j_sandbox/tags/ tags/

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 14:08:27 2005 New Revision: 351500 URL: http://svn.apache.org/viewcvs?rev=351500&view=rev Log: Adding new root directory for classic sandbox project Added: logging/sandbox/log4j/log4j_sandbox/tags/ - copied from r351499, logging/sandbox/log4j/tags/ Remov

svn commit: r351499 - in /logging/sandbox/log4j: branches/ log4j_sandbox/branches/

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 14:08:00 2005 New Revision: 351499 URL: http://svn.apache.org/viewcvs?rev=351499&view=rev Log: Adding new root directory for classic sandbox project Added: logging/sandbox/log4j/log4j_sandbox/branches/ - copied from r351498, logging/sandbox/log4j/branche

svn commit: r351497 - /logging/sandbox/log4j/log4j_sandbox/

2005-12-01 Thread carnold
Author: carnold Date: Thu Dec 1 14:03:58 2005 New Revision: 351497 URL: http://svn.apache.org/viewcvs?rev=351497&view=rev Log: Adding new root directory for classic sandbox project Added: logging/sandbox/log4j/log4j_sandbox/ -

Re: log4jMini/log4jME

2005-12-01 Thread Yoav Shapira
Ralph, You're doing the right thing to get this project moving: all it takes is one person who's interested and willing to contribute patches. Update the relevant Bugzilla issues you list below and open new ones if needed. We'll look at the patches and commit them, hopefully quickly... Yoav On

Re: [VOTE] Release of log4j 1.2.13

2005-12-01 Thread Curt Arnold
On Nov 28, 2005, at 10:50 PM, Mark Womack wrote: This is a vote to release the 1.2.13rc2 as the official release for 1.2.13. If accepted by the committers and the PMC, then I will build the official version from the current 1.2 branch head. +1 +1 Was able to reproduce rc2 on my JDK 1

Re: Log4j and Java 5

2005-12-01 Thread Jess Holle
Paul Smith wrote: I guess what I was thinking was an incremental approach in 1.3 that does not break backwards compatibility. [I'd think that would be a better use of time/energy than the Priority vs. Level and Category vs. Logger mess...] I'm against requiring Java 5 for log4j 1.3. 2.0

Re: Log4j and Java 5

2005-12-01 Thread Paul Smith
I guess what I was thinking was an incremental approach in 1.3 that does not break backwards compatibility. [I'd think that would be a better use of time/energy than the Priority vs. Level and Category vs. Logger mess...] I'm against requiring Java 5 for log4j 1.3. 2.0 though is fine.

Re: log4jMini/log4jME

2005-12-01 Thread Curt Arnold
I've seen log4jMini or log4jME but haven't investigated them and have been curious about their status, deviations from log4j proper, etc. Can anyone give a quick overview or a reference. Should we add them to the Gump builds? ---

RE: log4j RSS/ATOM Appender

2005-12-01 Thread Scott Deboy
ASL 2.0 Section 5 specifically says any intentionally submitted contribution falls under the license - I would think that would be sufficient (email list, bug tracking system, etc.). -Original Message- From: Curt Arnold [mailto:[EMAIL PROTECTED] Sent: Thu 12/1/2005 9:31 AM To: Log4J Dev

Re: log4j RSS/ATOM Appender

2005-12-01 Thread Curt Arnold
Thanks. Could you review the Apache Contributors License Agreement (CLA) at http://www.apache.org/licenses/ and see if you'd be in a position to sign one? I haven't had a chance to review the code yet, but there are a couple of areas that concern me: duplication of existing functionality

Re: Log4j and Java 5

2005-12-01 Thread Elias Ross
On Thu, 2005-12-01 at 10:22 -0600, Curt Arnold wrote: > > I have suggested targeting Java 5 in log4j 2.0. However, I plan on > experimenting with substantially reducing the scope of locks in > log4j > 2.0 instead of just incrementally using new locking features with > the > current approach

Re: log4jMini/log4jME

2005-12-01 Thread Yoav Shapira
Ralph, Thanks for contributing these changes and reporting them. You can open a new Bugzilla issue (http://issues.apache.org/bugzilla), selecting log4j as the product and describing your work. You can then attach diff files comparing your patch to the existing files: use the diff -u format. Than

log4jMini/log4jME

2005-12-01 Thread Ralph Curtis
I hope this is the right place to ask this question... I checked out the latest version (v1_3alpha_6) for this J2ME (Foundation/J9) log4j implementation. Found it doesn't build. I fixed the build problems and would like to get the changes checked in. I am not a contributor to date. Can someone dir

DO NOT REPLY [Bug 37740] New: - HierarchyEventListener is both incompatible with 1.2 version and unused

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Log4j and Java 5

2005-12-01 Thread Jess Holle
Curt Arnold wrote: On Dec 1, 2005, at 9:22 AM, Jess Holle wrote: Has anyone tried replacing the synchronization in log4j with Java 5 locks to and done any benchmarks? I'm curious as I think it would be interesting to have a lock factory which produces something like the existing locks for

DO NOT REPLY [Bug 35452] - 1.3 alpha 7 not compatible with older versions of log4j i.e 1.2.8

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37735] - 1.3 compatible sources are binary incompatible with 1.3 if compiled with 1.2

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 35452] - 1.3 alpha 7 not compatible with older versions of log4j i.e 1.2.8

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Log4j and Java 5

2005-12-01 Thread Curt Arnold
On Dec 1, 2005, at 9:22 AM, Jess Holle wrote: Has anyone tried replacing the synchronization in log4j with Java 5 locks to and done any benchmarks? I'm curious as I think it would be interesting to have a lock factory which produces something like the existing locks for pre- Java-5 JVMs a

DO NOT REPLY [Bug 37738] - Problems with ULogger when running Ant

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37738] New: - Problems with ULogger when running Ant

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Log4j and Java 5

2005-12-01 Thread Jess Holle
Has anyone tried replacing the synchronization in log4j with Java 5 locks to and done any benchmarks? I'm curious as I think it would be interesting to have a lock factory which produces something like the existing locks for pre-Java-5 JVMs and Java 5 locks in Java 5. We purely use and requi

DO NOT REPLY [Bug 37735] - 1.3 compatible sources are binary incompatible with 1.3 if compiled with 1.2

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Log4j 1.3 and 1.2 Binary Incompatibility

2005-12-01 Thread Jess Holle
Okay, I've read all the back threads Curt noted I must strongly disagree with the notion that log4j 1.3 should invert the class hierarchy between Logger/Category and Level/Priority in log4j 1.3. This completely breaks binary compatibility with 100% 1.3 compatible sources compiled against

DO NOT REPLY [Bug 37736] - LoggerEventListener's appenderRemovedEvent() and levelChangedEvent() methods are never called

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37736] New: - LoggerEventListener's appenderRemovedEvent() and levelChangedEvent() methods are never called

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Log4j 1.3 Woes (Partial Fix and Suggested Patch)

2005-12-01 Thread Jess Holle
Jess Holle wrote: Finally, I hope to get a chance to chase the lack of appender removal and log level change event firings and propose patches for these issues as well. Attached is a patch that adds event firing upon appender removal and log level change. Please take this patch.  The only

DO NOT REPLY [Bug 37735] - 1.3 compatible sources are binary incompatible with 1.3 if compiled with 1.2

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37735] - 1.3 compatible sources are binary incompatible with 1.3 if compiled with 1.2

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Re: Log4j 1.3 Woes (Partial Fix and Suggested Patch)

2005-12-01 Thread Jess Holle
P.S.  I filed bug #37735 on this and attached the patch to it. Jess Holle wrote: Okay, first off, I must apologize for going off half-cocked and somewhat rudely after running into issues earlier this week. Secondly, I must admit that I was way offbase on some of my analysis of the binar

DO NOT REPLY [Bug 37735] - 1.3 compatible sources are binary incompatible with 1.3 if compiled with 1.2

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37735] New: - 1.3 compatible sources are binary incompatible with 1.3 if compiled with 1.2

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r350224 - in /logging/chainsaw/trunk: tests/org/apache/log4j/net/ zeroconf/org/apache/log4j/chainsaw/zeroconf/ zeroconf/org/apache/log4j/net/

2005-12-01 Thread psmith
Author: psmith Date: Thu Dec 1 02:40:10 2005 New Revision: 350224 URL: http://svn.apache.org/viewcvs?rev=350224&view=rev Log: ZeroConfPlugin now getting some basic model details, and can save/restore it's preferences via XStream. Tweaked the HTML help file. When a device that has been register

DO NOT REPLY [Bug 37734] New: - Customize Event ID and Event Category with NTEVentLogAppender

2005-12-01 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r350218 - /logging/chainsaw/trunk/src/java/org/apache/log4j/chainsaw/LogPanel.java

2005-12-01 Thread psmith
Author: psmith Date: Thu Dec 1 01:29:01 2005 New Revision: 350218 URL: http://svn.apache.org/viewcvs?rev=350218&view=rev Log: Now any column's location or width, even if it's not part of the standard Chainsaw columns will be saved in the preferences. I have to say I didn't think it would be tha