[jira] [Updated] (LOG4J2-1504) RollingFileAppender should be able to create files on-demand

2016-08-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1504: - Fix Version/s: 2.7 > RollingFileAppender should be able to create files on-demand >

[jira] [Updated] (LOG4J2-1504) RollingFileAppender should be able to create files on-demand

2016-08-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1504: - Description: RollingFileAppender should be able to create files lazily. Add a

[jira] [Resolved] (LOG4J2-1504) RollingFileAppender should be able to create files on-demand

2016-08-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-1504. -- Resolution: Fixed In Git master. > RollingFileAppender should be able to create files

[jira] [Updated] (LOG4J2-1501) FileAppender should be able to create files on-demand

2016-08-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated LOG4J2-1501: - Description: FileAppender should be able to create files lazily. Add a {{createOnDemand}}

[jira] [Commented] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

2016-08-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429590#comment-15429590 ] Gary Gregory commented on LOG4J2-1518: -- We should stop using deprecated APIs from the Disruptor IMO.

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Gary Gregory
If you use the command line, call: git config --global core.autocrlf true I'm not sure if EGit picks that up automagically, but mine says Core -> autocrlf -> true Gary On Sat, Aug 20, 2016 at 5:35 PM, Matt Sicker wrote: > Ideally, we should just do an all at once conversion

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Gary Gregory
I thought Git did the conversion since I installed it that way (check out as Windows EOL and commit as Unix EOL)... hm... but yes I use Eclipse... and EGit which has "core autocrlf" set to true in my user settings. On the command line "git config --global core.autocrlf" says true. What's going on

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Matt Sicker
I use a similar setting in IntelliJ. It usually has a banner on the top of the file when you open it to let you know if the file isn't formatted with the same basic settings as the project (e.g., line endings, tabs versus spaces, number of spaces to an indent). On 20 August 2016 at 19:46, Remko

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Remko Popma
Looks like my IDE is set to use "system-dependent" line endings for new files. (I think that means that for existing files it will use the existing line endings.) Perhaps this is a formatter issue then? Gary, do you use Eclipse to format before committing? Perhaps the formatter has some setting

Re: build fail

2016-08-20 Thread Remko Popma
Getting this error on another branch too now after merging master into it. Gary, are you seeing this too? Could this be related to one of the recent FileAppender changes? On Sat, Aug 20, 2016 at 10:42 AM, Matt Sicker wrote: > I just got that error, too, while trying to apply

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Matt Sicker
Ideally, we should just do an all at once conversion to unix line endings or windows line endings to all branches. Then the line ending fixes won't come in anymore. We could add an EditorConfig file to enforce it automatically in IDEs even. On 20 August 2016 at 19:33, Remko Popma

Re: logging-log4j2 git commit: Use Log4jThread to name the thread.

2016-08-20 Thread Remko Popma
Gary, can you please check your IDE settings for line endings? It is really difficult to see what changed if the whole file is marked as modified in the commit mail. I suspect this is because your IDE converts the unix line endings to windows CRLF or something. On Sun, Aug 21, 2016 at 9:30 AM,

[jira] [Commented] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

2016-08-20 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429543#comment-15429543 ] Remko Popma commented on LOG4J2-1518: - Leon, I finally took a closer look at this and I see now that

[jira] [Updated] (LOG4J2-1518) Deadlock when using pure async and toString logs another message

2016-08-20 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remko Popma updated LOG4J2-1518: Fix Version/s: 2.7 > Deadlock when using pure async and toString logs another message >

Re: ThreadContextMap2

2016-08-20 Thread Gary Gregory
On Aug 20, 2016 4:47 PM, "Remko Popma" wrote: > > Do you have anything specific in mind? > Otherwise something may come out of my ongoing work for LOG4J2-1010, LOG4J2-1447, LOG4J2-1349, so I would prefer to wait until that takes shape. Nothing specific since we have putAll

[jira] [Commented] (LOG4J2-1537) Experience of a newbie to logging

2016-08-20 Thread Remko Popma (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429540#comment-15429540 ] Remko Popma commented on LOG4J2-1537: - I'm fine with answering questions on Jira as well as the

Re: ThreadContextMap2

2016-08-20 Thread Remko Popma
Do you have anything specific in mind? Otherwise something may come out of my ongoing work for LOG4J2-1010, LOG4J2-1447, LOG4J2-1349, so I would prefer to wait until that takes shape. On Sun, Aug 21, 2016 at 8:04 AM, Gary Gregory wrote: > All right, topic closed for Map

Re: ThreadContextMap2

2016-08-20 Thread Gary Gregory
All right, topic closed for Map then. Since we have TCM2, now is the time to add anything else. Check? Gary On Aug 20, 2016 3:05 PM, "Remko Popma" wrote: > I agree with Ralph. > > I am working on custom implementations of ThreadContextMap (LOG4J2-1010, > LOG4J2-1447,

Re: ThreadContextMap2

2016-08-20 Thread Remko Popma
I agree with Ralph. I am working on custom implementations of ThreadContextMap (LOG4J2-1010, LOG4J2-1447, LOG4J2-1349) and I'm very glad the interface is small. My rule of thumb for API design is YAGNI: don't add until you really need it, otherwise it'll get in the way. Remko Sent from my

[jira] [Comment Edited] (LOG4J2-1537) Experience of a newbie to logging

2016-08-20 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429501#comment-15429501 ] Ralph Goers edited comment on LOG4J2-1537 at 8/20/16 8:17 PM: -- Please see

[jira] [Commented] (LOG4J2-1537) Experience of a newbie to logging

2016-08-20 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429501#comment-15429501 ] Ralph Goers commented on LOG4J2-1537: - Please see

[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts

2016-08-20 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429497#comment-15429497 ] Ralph Goers commented on LOG4J2-1522: - I have mixed feelings about this. Conceptually they do belong

[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts

2016-08-20 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429496#comment-15429496 ] Gary Gregory commented on LOG4J2-1522: -- In the 1.2 module IMO. Gary > Log4j 1 layouts >

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429494#comment-15429494 ] Ralph Goers commented on LOG4J2-1531: - If you do the above you have to allow arbitrary objects. This

Re: ThreadContextMap2

2016-08-20 Thread Ralph Goers
1. Why? 2. Why do you need to implement equals and hashcode? What other map are you going to compare it with? 2. Which version? Java 8 added a bunch of new methods. I don’t really view the thread context map as a Map. It is really nothing more than a bunch of keys and values that I want to

Jenkins build is back to stable : Log4j 2.x #2186

2016-08-20 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Created] (LOG4J2-1537) Experience of a newbie to logging

2016-08-20 Thread d (JIRA)
d created LOG4J2-1537: - Summary: Experience of a newbie to logging Key: LOG4J2-1537 URL: https://issues.apache.org/jira/browse/LOG4J2-1537 Project: Log4j 2 Issue Type: Improvement Environment:

Jenkins build is still unstable: Log4j 2.x #2185

2016-08-20 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread Roger Kapsi (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429476#comment-15429476 ] Roger Kapsi commented on LOG4J2-1531: - Please notice that the Patch I submitted doesn't change

[jira] [Commented] (LOG4J2-1522) Log4j 1 layouts

2016-08-20 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429472#comment-15429472 ] Mikael Ståldal commented on LOG4J2-1522: Also updated the constant in PatternLayout. > Log4j 1

[jira] [Commented] (LOG4J2-1528) Serialize configuration into a log4j2.xml file

2016-08-20 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429468#comment-15429468 ] Mikael Ståldal commented on LOG4J2-1528: Reminding [~ralphgoers]... > Serialize configuration

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429467#comment-15429467 ] Mikael Ståldal commented on LOG4J2-1531: Not arbitrary objects. My proposal is to add this to

Jenkins build became unstable: Log4j 2.x #2184

2016-08-20 Thread Apache Jenkins Server
See - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Re: ThreadContextMap2

2016-08-20 Thread Gary Gregory
Fair enough. I am wondering if there is a design reason not to implement Map now that we have the opportunity with the TCM2 interface. I'd take a crack at it. Gary On Aug 20, 2016 10:39 AM, "Ralph Goers" wrote: > Because Map has a lot more methods that weren’t

Re: ThreadContextMap2

2016-08-20 Thread Ralph Goers
Because Map has a lot more methods that weren’t needed and I didn’t want to implement? Ralph > On Aug 20, 2016, at 10:16 AM, Gary Gregory wrote: > > Hi All: > > Now that we have ThreadContextMap2: > > Why don't we do ThreadContextMap2 extends Map? >

[jira] [Comment Edited] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429453#comment-15429453 ] Ralph Goers edited comment on LOG4J2-1531 at 8/20/16 5:35 PM: -- I like what

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429455#comment-15429455 ] Ralph Goers commented on LOG4J2-1531: - Mikael,I don't know that I would want to move in this

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429453#comment-15429453 ] Ralph Goers commented on LOG4J2-1531: - I like what this patch is trying to do, however, I have some

ThreadContextMap2

2016-08-20 Thread Gary Gregory
Hi All: Now that we have ThreadContextMap2: Why don't we do ThreadContextMap2 extends Map? Why did ThreadContextMap initially not extends Map? Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429440#comment-15429440 ] Mikael Ståldal commented on LOG4J2-1531: Why would my proposal be more API breaking than yours?

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread Roger Kapsi (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429381#comment-15429381 ] Roger Kapsi commented on LOG4J2-1531: - Looking at it as an outsider... You have a working plugin

[jira] [Commented] (LOG4J2-1531) Change attribute and component values from String to Object

2016-08-20 Thread JIRA
[ https://issues.apache.org/jira/browse/LOG4J2-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15429322#comment-15429322 ] Mikael Ståldal commented on LOG4J2-1531: I think that this is a misuse of the {{@Plugin}}