Re: ThreadContextMap2

2016-08-23 Thread Gary Gregory
TCM2 extending TCM cannot affect BC. Now, some classes now implement TCM2, which should also be OK. Gary On Tue, Aug 23, 2016 at 12:20 PM, Matt Sicker wrote: > I know we added TCM2 to preserve backwards compatibility. By making TCM2 > extend TCM and the other changes, this won't affect binary o

Re: ThreadContextMap2

2016-08-23 Thread Matt Sicker
I know we added TCM2 to preserve backwards compatibility. By making TCM2 extend TCM and the other changes, this won't affect binary or source compatibility, will it? On 23 August 2016 at 13:58, Gary Gregory wrote: > I made the change for ThreadContextMap2 to extend ThreadContextMap > (yesterday)

Re: ThreadContextMap2

2016-08-23 Thread Gary Gregory
I made the change for ThreadContextMap2 to extend ThreadContextMap (yesterday). Gary On Mon, Aug 22, 2016 at 1:48 PM, Gary Gregory wrote: > Why doesn't ThreadContextMap2 extend ThreadContextMap? This feels highly > unusual. > > Gary > > On Sat, Aug 20, 2016 at 5:10 PM, Gary Gregory > wrote: >

Re: ThreadContextMap2

2016-08-22 Thread Gary Gregory
Why doesn't ThreadContextMap2 extend ThreadContextMap? This feels highly unusual. Gary On Sat, Aug 20, 2016 at 5:10 PM, Gary Gregory wrote: > > On Aug 20, 2016 4:47 PM, "Remko Popma" wrote: > > > > Do you have anything specific in mind? > > Otherwise something may come out of my ongoing work f

Re: ThreadContextMap2

2016-08-20 Thread Gary Gregory
On Aug 20, 2016 4:47 PM, "Remko Popma" wrote: > > Do you have anything specific in mind? > Otherwise something may come out of my ongoing work for LOG4J2-1010, LOG4J2-1447, LOG4J2-1349, so I would prefer to wait until that takes shape. Nothing specific since we have putAll in there now. Gary > >

Re: ThreadContextMap2

2016-08-20 Thread Remko Popma
Do you have anything specific in mind? Otherwise something may come out of my ongoing work for LOG4J2-1010, LOG4J2-1447, LOG4J2-1349, so I would prefer to wait until that takes shape. On Sun, Aug 21, 2016 at 8:04 AM, Gary Gregory wrote: > All right, topic closed for Map then. Since we have TCM2,

Re: ThreadContextMap2

2016-08-20 Thread Gary Gregory
All right, topic closed for Map then. Since we have TCM2, now is the time to add anything else. Check? Gary On Aug 20, 2016 3:05 PM, "Remko Popma" wrote: > I agree with Ralph. > > I am working on custom implementations of ThreadContextMap (LOG4J2-1010, > LOG4J2-1447, LOG4J2-1349) and I'm very g

Re: ThreadContextMap2

2016-08-20 Thread Remko Popma
I agree with Ralph. I am working on custom implementations of ThreadContextMap (LOG4J2-1010, LOG4J2-1447, LOG4J2-1349) and I'm very glad the interface is small. My rule of thumb for API design is YAGNI: don't add until you really need it, otherwise it'll get in the way. Remko Sent from my

Re: ThreadContextMap2

2016-08-20 Thread Ralph Goers
1. Why? 2. Why do you need to implement equals and hashcode? What other map are you going to compare it with? 2. Which version? Java 8 added a bunch of new methods. I don’t really view the thread context map as a Map. It is really nothing more than a bunch of keys and values that I want to sto

Re: ThreadContextMap2

2016-08-20 Thread Gary Gregory
Fair enough. I am wondering if there is a design reason not to implement Map now that we have the opportunity with the TCM2 interface. I'd take a crack at it. Gary On Aug 20, 2016 10:39 AM, "Ralph Goers" wrote: > Because Map has a lot more methods that weren’t needed and I didn’t want > to imp

Re: ThreadContextMap2

2016-08-20 Thread Ralph Goers
Because Map has a lot more methods that weren’t needed and I didn’t want to implement? Ralph > On Aug 20, 2016, at 10:16 AM, Gary Gregory wrote: > > Hi All: > > Now that we have ThreadContextMap2: > > Why don't we do ThreadContextMap2 extends Map? > > Why did ThreadContextMap initially not