Re: Would it be useful to implement nio channel-based appenders?

2014-04-27 Thread Matt Sicker
The neat feature is non-blocking IO. We could use the Channel API for non-blocking IO in appenders. On 26 April 2014 23:35, Ralph Goers wrote: > 1. Why would it be a neat feature? > 2. The FileManager uses NIO to lock the file if it was requested. > 3. Many of the Appenders use Streams. I happe

Bug report for Log4j [2014/04/27]

2014-04-27 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Re: Would it be useful to implement nio channel-based appenders?

2014-04-27 Thread Ralph Goers
OK, but again, why? The articles I've sen say it is harder to implement and slower. I might be able to see using it for sockets but I have a hard time seeing what benefit there would be for file appenders. Ralph > On Apr 27, 2014, at 12:16 AM, Matt Sicker wrote: > > The neat feature is non-

Solr Appender

2014-04-27 Thread Markus Klose
Hi everyone, I just finished the development of the SolrAppender. It is a NoSQLAppender implementation. You can get the code from guthub: https://github.com/scherziglu/log4j Feedback would be great. If you are interessted I would contribute that appender to log4j regards Markus

Re: Would it be useful to implement nio channel-based appenders?

2014-04-27 Thread Remko Popma
AFAIK the only way to do non-blocking file IO is by doing it asynchronously via a non-blocking queue like the disruptor. For networking IO the channel/selector stuff is interesting when you need to scale up to tens of thousands of connections and you get beyond the place where you can have a dedic

RE: Solr Appender

2014-04-27 Thread Gary Gregory
Is this for http to solr? Embedded solr? Did you plan on wanting this integrated in log4j2 or as your own add on? Gary Original message From: Markus Klose Date:04/27/2014 07:17 (GMT-05:00) To: Log4J Developers List Subject: Solr Appender Hi everyone, I just finished th

Re: What's left before we can release RC2?

2014-04-27 Thread Remko Popma
I wouldn't mind if we rolled out another RC release. What is our next action on the logo contest? (I forget, it's been a while... :-) ) Remko Sent from my iPhone > On 2014/04/08, at 8:32, Matt Sicker wrote: > > Alright, so far, it looks like the list of things we want to get done for RC2 >

Re: Solr Appender

2014-04-27 Thread Remko Popma
Hi Markus, Thanks for offering to contribute. Would you be willing to submit a signed Contributors License Agreement (http://www.apache.org/licenses/#clas)? This helps the ASF prevent legal issues (e.g. states that this your own work and you have the right to open-source it, that kind of thin

Re: What's left before we can release RC2?

2014-04-27 Thread Ralph Goers
Select one! Ralph > On Apr 27, 2014, at 5:42 AM, Remko Popma wrote: > > I wouldn't mind if we rolled out another RC release. > What is our next action on the logo contest? (I forget, it's been a while... > :-) ) > > Remko > > Sent from my iPhone > >> On 2014/04/08, at 8:32, Matt Sicker wr

Re: What's left before we can release RC2?

2014-04-27 Thread Gary Gregory
IIRC we already had the 1st round of voting. Gary Original message From: Ralph Goers Date:04/27/2014 10:35 (GMT-05:00) To: Log4J Developers List Subject: Re: What's left before we can release RC2? Select one! Ralph On Apr 27, 2014, at 5:42 AM, Remko Popma wrote: I wou

Re: Solr Appender

2014-04-27 Thread Markus Klose
HI everyone, Thanks for your first non technical feedback. @remko I will send you that CLAS as sson as possible and of course I can create a patch within a jira ticket. @gary this appender supports so far HttpSolrServer, LBHttpSolrServer, CloudSolrServer and EmbeddedSolrServer regards Markus

Re: Would it be useful to implement nio channel-based appenders?

2014-04-27 Thread Matt Sicker
Good to know! The only thing from NIO I've ever used are the buffer APIs anyway, so I was curious about the channels. At least we can use that as you suggested, though. On 27 April 2014 06:43, Remko Popma wrote: > AFAIK the only way to do non-blocking file IO is by doing it > asynchronously via

Re: What's left before we can release RC2?

2014-04-27 Thread Matt Sicker
Reminder link: https://wiki.apache.org/logging/Log4jLogoNominations Can we use Apache Steve for handling voting? :-P On 27 April 2014 10:15, Gary Gregory wrote: > IIRC we already had the 1st round of voting. > > Gary > > > Original message > From: Ralph Goers > Date:04/27/201

Re: Unit test failures

2014-04-27 Thread Ralph Goers
Now the build is failing in the taglib project due to a missing MANIFEST.MF, which I find unusual because the jar plugin normally creates that. Ralph On Apr 26, 2014, at 10:51 PM, Ralph Goers wrote: > FileOutputTest was failing because the status level was changed to OFF and > the test is e

Re: Unit test failures

2014-04-27 Thread Matt Sicker
Now that's a weird one. I'll figure that out right after I finish running the log4j-core unit tests before a new commit. On 27 April 2014 14:30, Ralph Goers wrote: > > > Now the build is failing in the taglib project due to a missing > MANIFEST.MF, which I find unusual because the jar plugin n

Re: Unit test failures

2014-04-27 Thread Matt Sicker
Fixed it. On 27 April 2014 14:38, Matt Sicker wrote: > Now that's a weird one. I'll figure that out right after I finish running > the log4j-core unit tests before a new commit. > > > On 27 April 2014 14:30, Ralph Goers wrote: > >> >> >> Now the build is failing in the taglib project due to a

Re: Unit test failures

2014-04-27 Thread Ralph Goers
OK, but now the Flume samples are failing with the same error. Do you think you could run the full build and get it to work? Ralph On Apr 27, 2014, at 12:40 PM, Matt Sicker wrote: > Fixed it. > > > On 27 April 2014 14:38, Matt Sicker wrote: > Now that's a weird one. I'll figure that out ri

[jira] [Created] (LOG4J2-616) Upgrade Jackson to 2.3.3

2014-04-27 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-616: -- Summary: Upgrade Jackson to 2.3.3 Key: LOG4J2-616 URL: https://issues.apache.org/jira/browse/LOG4J2-616 Project: Log4j 2 Issue Type: Dependency upgrade Affec

[jira] [Closed] (LOG4J2-616) Upgrade Jackson to 2.3.3

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed LOG4J2-616. -- Resolution: Done Upgraded in r1590477. > Upgrade Jackson to 2.3.3 > > >

[jira] [Created] (LOG4J2-617) Upgrade SLF4J to 1.7.7

2014-04-27 Thread Matt Sicker (JIRA)
Matt Sicker created LOG4J2-617: -- Summary: Upgrade SLF4J to 1.7.7 Key: LOG4J2-617 URL: https://issues.apache.org/jira/browse/LOG4J2-617 Project: Log4j 2 Issue Type: Dependency upgrade Affects

Re: Unit test failures

2014-04-27 Thread Matt Sicker
On it. On 27 April 2014 14:48, Ralph Goers wrote: > OK, but now the Flume samples are failing with the same error. Do you > think you could run the full build and get it to work? > > Ralph > > On Apr 27, 2014, at 12:40 PM, Matt Sicker wrote: > > Fixed it. > > > On 27 April 2014 14:38, Matt Si

[jira] [Closed] (LOG4J2-617) Upgrade SLF4J to 1.7.7

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker closed LOG4J2-617. -- Resolution: Done Upgraded in r1590478. > Upgrade SLF4J to 1.7.7 > -- > >

Re: Unit test failures

2014-04-27 Thread Matt Sicker
Done. Looks like any jar-type project needs to include the maven-bundle-plugin in their build section. org.apache.felix maven-bundle-plugin On 27 April 2014 14:55, Matt Sicker wrote: > On it. > > > On 27 April 2014 14:48, Ralph Goers wrote: > >> OK, but now the

[jira] [Assigned] (LOG4J2-604) Audit use of ClassLoader, Class.forName, etc.

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker reassigned LOG4J2-604: -- Assignee: Matt Sicker > Audit use of ClassLoader, Class.forName, etc. > ---

[jira] [Updated] (LOG4J2-604) Audit use of ClassLoader, Class.forName, etc.

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-604: --- Priority: Critical (was: Blocker) > Audit use of ClassLoader, Class.forName, etc. >

[jira] [Updated] (LOG4J2-546) Commons logging integration does not work in WildFly 8.0

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-546: --- Summary: Commons logging integration does not work in WildFly 8.0 (was: Commons logging integration

[jira] [Commented] (LOG4J2-604) Audit use of ClassLoader, Class.forName, etc.

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982445#comment-13982445 ] Matt Sicker commented on LOG4J2-604: This is taken care of for the most part. This mig

[jira] [Commented] (LOG4J2-461) ERROR StatusLogger Unable to locate a logging implementation, using SimpleLogger

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982448#comment-13982448 ] Matt Sicker commented on LOG4J2-461: I've made a bunch of updates to the OSGi handling

[jira] [Updated] (LOG4J2-461) ERROR StatusLogger Unable to locate a logging implementation, using SimpleLogger

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Sicker updated LOG4J2-461: --- Affects Version/s: 2.0-rc1 > ERROR StatusLogger Unable to locate a logging implementation, using >

Re: Unit test failures

2014-04-27 Thread Ralph Goers
I thought they all did - or it used to be in the parent pom. Ralph On Apr 27, 2014, at 12:57 PM, Matt Sicker wrote: > Done. Looks like any jar-type project needs to include the > maven-bundle-plugin in their build section. > > > org.apache.felix > maven-bundle-plugin >

[jira] [Commented] (LOG4J2-373) Classloader issue in OSGi-environment

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982452#comment-13982452 ] Matt Sicker commented on LOG4J2-373: This issue may be solved with the recent OSGi upd

[jira] [Commented] (LOG4J2-400) Provide Appender-Bundles

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982453#comment-13982453 ] Matt Sicker commented on LOG4J2-400: So that BundleTracker class is in R5, not R4.2 or

Re: Unit test failures

2014-04-27 Thread Matt Sicker
It's specified in the pluginManagement section now. I might have changed that when I was cleaning up the OSGi stuff. On 27 April 2014 15:15, Ralph Goers wrote: > I thought they all did - or it used to be in the parent pom. > > Ralph > > On Apr 27, 2014, at 12:57 PM, Matt Sicker wrote: > > Done

Re: What's left before we can release RC2?

2014-04-27 Thread Gary Gregory
We already voted! Gary On Sun, Apr 27, 2014 at 2:21 PM, Matt Sicker wrote: > Reminder link: https://wiki.apache.org/logging/Log4jLogoNominations > > Can we use Apache Steve for handling voting? :-P > > > On 27 April 2014 10:15, Gary Gregory wrote: > >> IIRC we already had the 1st round of vot

Re: svn commit: r1590443 - in /logging/log4j/log4j2/trunk/log4j-core: pom.xml src/main/java/org/apache/logging/log4j/core/config/plugins/osgi/Activator.java

2014-04-27 Thread Gary Gregory
I for one am glad to see all of this OSGi stuff layered on top of our current modules instead of separate ones. So thank you for that Matt! Now let's see what pops up in Java 9 WRT Jigsaw... ;) Gary On Sun, Apr 27, 2014 at 2:24 PM, wrote: > Author: mattsicker > Date: Sun Apr 27 18:24:47 2014

Re: svn commit: r1590443 - in /logging/log4j/log4j2/trunk/log4j-core: pom.xml src/main/java/org/apache/logging/log4j/core/config/plugins/osgi/Activator.java

2014-04-27 Thread Matt Sicker
Yeah, OSGi is supposed to just be overlaid like this anyhow. I don't even know if the other method of extra bundles even worked properly. From what I know about Jigsaw so far, it's not as powerful as OSGi yet, so it might end up being rather simple to integrate with in comparison. On 27 April 201

[jira] [Commented] (LOG4J2-400) Provide Appender-Bundles

2014-04-27 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982457#comment-13982457 ] Gary Gregory commented on LOG4J2-400: - Can we document in the manual which OSGi versio

Re: svn commit: r1590443 - in /logging/log4j/log4j2/trunk/log4j-core: pom.xml src/main/java/org/apache/logging/log4j/core/config/plugins/osgi/Activator.java

2014-04-27 Thread Gary Gregory
More complex than OSGi would be painful ;) Gary On Sun, Apr 27, 2014 at 4:33 PM, Matt Sicker wrote: > Yeah, OSGi is supposed to just be overlaid like this anyhow. I don't even > know if the other method of extra bundles even worked properly. From what I > know about Jigsaw so far, it's not as

[jira] [Commented] (LOG4J2-400) Provide Appender-Bundles

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982461#comment-13982461 ] Matt Sicker commented on LOG4J2-400: We've got 4.3.0 in our dependencies, and consider

Re: svn commit: r1590443 - in /logging/log4j/log4j2/trunk/log4j-core: pom.xml src/main/java/org/apache/logging/log4j/core/config/plugins/osgi/Activator.java

2014-04-27 Thread Matt Sicker
Indeed! I don't even know if it's possible to get more complex than OSGi without violating Java standards. You can dynamically add or remove JARs at runtime, and other JARs that depend on them can react accordingly to avoid having to restart where possible. Jigsaw, on the other hand, is supposed to

[jira] [Created] (LOG4J2-618) Solr Appender

2014-04-27 Thread Markus Klose (JIRA)
Markus Klose created LOG4J2-618: --- Summary: Solr Appender Key: LOG4J2-618 URL: https://issues.apache.org/jira/browse/LOG4J2-618 Project: Log4j 2 Issue Type: New Feature Components: Cor

[jira] [Updated] (LOG4J2-618) Solr Appender

2014-04-27 Thread Markus Klose (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus Klose updated LOG4J2-618: Attachment: LOG4J2-618.patch I hope the patch is ok. I am not an expert creating patches > Solr Ap

[jira] [Commented] (LOG4J2-618) Solr Appender

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982465#comment-13982465 ] Matt Sicker commented on LOG4J2-618: To make it easier to merge, you could fork [the g

[jira] [Commented] (LOG4J2-618) Solr Appender

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982468#comment-13982468 ] Matt Sicker commented on LOG4J2-618: Initial feedback on the patch: * Don't include I

Re: What's left before we can release RC2?

2014-04-27 Thread Matt Sicker
I mean like round 2. On 27 April 2014 15:25, Gary Gregory wrote: > We already voted! > > Gary > > > On Sun, Apr 27, 2014 at 2:21 PM, Matt Sicker wrote: > >> Reminder link: https://wiki.apache.org/logging/Log4jLogoNominations >> >> Can we use Apache Steve for handling voting? :-P >> >> >> On 27

Re: What's left before we can release RC2?

2014-04-27 Thread Remko Popma
We voted but did not make a decision on the logo yet. Sent from my iPhone > On 2014/04/28, at 5:58, Matt Sicker wrote: > > I mean like round 2. > > >> On 27 April 2014 15:25, Gary Gregory wrote: >> We already voted! >> >> Gary >> >> >>> On Sun, Apr 27, 2014 at 2:21 PM, Matt Sicker wrote

Re: What's left before we can release RC2?

2014-04-27 Thread Ralph Goers
http://wiki.apache.org/logging/Log4jLogoNominations has a list of the logos and who likes what. I would hardly call that a vote. It is more like a poll. We currently have 18 logos on that wiki page that at least 1 person supports. I would suggest we whittle that down to the 9 that have at leas

[jira] [Updated] (LOG4J2-618) Solr Appender

2014-04-27 Thread Markus Klose (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Markus Klose updated LOG4J2-618: Attachment: LOG4J2-618.patch next try :) > Solr Appender > - > > Key:

[jira] [Commented] (LOG4J2-618) Solr Appender

2014-04-27 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982478#comment-13982478 ] Ralph Goers commented on LOG4J2-618: I only have two comments, neither of which has mu

[jira] [Commented] (LOG4J2-618) Solr Appender

2014-04-27 Thread Matt Sicker (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982500#comment-13982500 ] Matt Sicker commented on LOG4J2-618: Now when you say into its own package, are you th

[jira] [Commented] (LOG4J2-618) Solr Appender

2014-04-27 Thread Ralph Goers (JIRA)
[ https://issues.apache.org/jira/browse/LOG4J2-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982695#comment-13982695 ] Ralph Goers commented on LOG4J2-618: I was only thinking in terms of moving them out o

Re: svn commit: r1590447 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/helpers/CachedClock.java

2014-04-27 Thread Remko Popma
Hi Matt, I don't mind this change, but why do you think this is better? This is all private internal & the previous code was shorter... Remko Sent from my iPhone > On 2014/04/28, at 3:31, mattsic...@apache.org wrote: > > Author: mattsicker > Date: Sun Apr 27 18:31:20 2014 > New Revision: 1590

Re: svn commit: r1590447 - /logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/helpers/CachedClock.java

2014-04-27 Thread Ralph Goers
I wondered the same thing myself. I think Matt stated he preferred Runnable to extending Thread in the past, but I really don’t like changes like this just for the sake of someone’s personal preference. While we do have sort of an unwritten list of coding guidelines this one isn’t on that list