Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Gary Gregory
Great, TY.

Gary
On May 29, 2016 8:20 PM, "Ralph Goers"  wrote:

> I added the same information to the main site page.
>
> Ralph
>
> On May 29, 2016, at 2:08 PM, Gary Gregory  wrote:
>
> On Sun, May 29, 2016 at 1:41 PM, Ralph Goers 
> wrote:
>
>> Here is the text that I propose to add to the announcement. I would also
>> add something similar to the web site.
>>
>> Note that subsequent to the release a minor source incompatibility was
>> found due to the addition of new methods to
>> the Logger interface. If you have code that does:
>>
>> logger.error(null, “This is the log message”, throwable);
>>
>> or similar with any log level you will get a compiler error saying the
>> reference is ambiguous.  To correct this either do:
>>
>> logger.error(“This is the log message”, throwable);
>>
>> or
>>
>> logger.error((Marker) null, “This is the log message”, throwable);
>>
>>
> I would add that the 2.6 code is _binary_ compatible with previous
> releases.
>
> Gary
>
>
>>
>> Ralph
>>
>> On May 29, 2016, at 11:14 AM, Matt Sicker  wrote:
>>
>> Yet another reason to hate null! ;)
>>
>> On 29 May 2016 at 13:13, Ralph Goers  wrote:
>>
>>> When you pass null as the first argument it doesn't know which is better
>>>
>>> Sent from my iPhone
>>>
>>> On May 29, 2016, at 11:07 AM, Matt Sicker  wrote:
>>>
>>> Wait, how are error(Marker, String, Object) and error(String, Object,
>>> Object) even confused by the compiler?
>>>
>>> On 29 May 2016 at 13:02, Ralph Goers  wrote:
>>>
 Only if the compatibility issue can be fixed. I don't think it can. We
 will just update the site and announcement.

 Sent from my iPhone

 On May 29, 2016, at 10:56 AM, Matt Sicker  wrote:

 So what do we do, follow up with 2.6.1 right away?

 On 29 May 2016 at 12:29, Ralph Goers 
 wrote:

> Can’t do that. That would require a re-release.
>
> Speaking of which, the archives directory only lists a couple of
> releases. I thought they were all supposed to be there.
>
> Ralph
>
> On May 29, 2016, at 10:19 AM, Gary Gregory 
> wrote:
>
> I think the RELEASE-NOTES.txt in the dist area needs to be updated as
> well.
>
> Gary
>
> On Sun, May 29, 2016 at 10:15 AM, Ralph Goers <
> ralph.go...@dslextreme.com> wrote:
>
>> I will add something to the announcement text when I send out the
>> emails.  Those will go out in a few hours.
>>
>> Ralph
>>
>> On May 29, 2016, at 9:53 AM, Gary Gregory 
>> wrote:
>>
>> We are going to need to update the release notes and/or site for 2.6
>> to note that the 2.6 is not source compatible with previous releases. I
>> tested going from 2.5 to 2.6 at work and got:
>>
>> [ERROR] COMPILATION ERROR :
>> [INFO] -
>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>   both method
>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) 
>> in
>> org.apache.logging.log4j.Logger and method
>> error(java.lang.String,java.lang.Object,java.lang.Object) in
>> org.apache.logging.log4j.Logger match
>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>   both method
>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) 
>> in
>> org.apache.logging.log4j.Logger and method
>> trace(java.lang.String,java.lang.Object,java.lang.Object) in
>> org.apache.logging.log4j.Logger match
>> [INFO] 2 errors
>>
>> with source code like:
>>
>> public void xyz(final String message, final Throwable t) {
>> ...
>> logger.error(null, message, t);
>> ...
>> logger.trace(null, message, t);
>> ...
>> }
>>
>> Next time, I'll remember to test with a "real" client.
>>
>> Gary
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 

Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Ralph Goers
I added the same information to the main site page.

Ralph

> On May 29, 2016, at 2:08 PM, Gary Gregory  wrote:
> 
> On Sun, May 29, 2016 at 1:41 PM, Ralph Goers  > wrote:
> Here is the text that I propose to add to the announcement. I would also add 
> something similar to the web site.
> 
> Note that subsequent to the release a minor source incompatibility was found 
> due to the addition of new methods to
> the Logger interface. If you have code that does:
> 
> logger.error(null, “This is the log message”, throwable);
> 
> or similar with any log level you will get a compiler error saying the 
> reference is ambiguous.  To correct this either do:
> 
> logger.error(“This is the log message”, throwable);
> 
> or 
> 
> logger.error((Marker) null, “This is the log message”, throwable);
> 
> I would add that the 2.6 code is _binary_ compatible with previous releases.
> 
> Gary
>  
> 
> Ralph
> 
>> On May 29, 2016, at 11:14 AM, Matt Sicker > > wrote:
>> 
>> Yet another reason to hate null! ;)
>> 
>> On 29 May 2016 at 13:13, Ralph Goers > > wrote:
>> When you pass null as the first argument it doesn't know which is better
>> 
>> Sent from my iPhone
>> 
>> On May 29, 2016, at 11:07 AM, Matt Sicker > > wrote:
>> 
>>> Wait, how are error(Marker, String, Object) and error(String, Object, 
>>> Object) even confused by the compiler?
>>> 
>>> On 29 May 2016 at 13:02, Ralph Goers >> > wrote:
>>> Only if the compatibility issue can be fixed. I don't think it can. We will 
>>> just update the site and announcement.
>>> 
>>> Sent from my iPhone
>>> 
>>> On May 29, 2016, at 10:56 AM, Matt Sicker >> > wrote:
>>> 
 So what do we do, follow up with 2.6.1 right away?
 
 On 29 May 2016 at 12:29, Ralph Goers > wrote:
 Can’t do that. That would require a re-release.
 
 Speaking of which, the archives directory only lists a couple of releases. 
 I thought they were all supposed to be there.
 
 Ralph
 
> On May 29, 2016, at 10:19 AM, Gary Gregory  > wrote:
> 
> I think the RELEASE-NOTES.txt in the dist area needs to be updated as 
> well.
> 
> Gary
> 
> On Sun, May 29, 2016 at 10:15 AM, Ralph Goers  > wrote:
> I will add something to the announcement text when I send out the emails. 
>  Those will go out in a few hours.
> 
> Ralph
> 
>> On May 29, 2016, at 9:53 AM, Gary Gregory > > wrote:
>> 
>> We are going to need to update the release notes and/or site for 2.6 to 
>> note that the 2.6 is not source compatible with previous releases. I 
>> tested going from 2.5 to 2.6 at work and got:
>> 
>> [ERROR] COMPILATION ERROR :
>> [INFO] -
>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>   both method 
>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) 
>> in org.apache.logging.log4j.Logger and method 
>> error(java.lang.String,java.lang.Object,java.lang.Object) in 
>> org.apache.logging.log4j.Logger match
>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>   both method 
>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) 
>> in org.apache.logging.log4j.Logger and method 
>> trace(java.lang.String,java.lang.Object,java.lang.Object) in 
>> org.apache.logging.log4j.Logger match
>> [INFO] 2 errors
>> 
>> with source code like:
>> 
>> public void xyz(final String message, final Throwable t) {
>> ...
>> logger.error(null, message, t);
>> ...
>> logger.trace(null, message, t);
>> ...
>> }
>> 
>> Next time, I'll remember to test with a "real" client.
>> 
>> Gary
>> 
>> -- 
>> E-Mail: garydgreg...@gmail.com  | 
>> ggreg...@apache.org  
>> Java Persistence with Hibernate, Second Edition 
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com 
>>  
>> Home: http://garygregory.com/ 
>> Tweet! 

Re: org.apache.logging.log4j.util.Unbox.isBoxedPrimitive(StringBuilder)

2016-05-29 Thread Remko Popma
It prevents primitives from being auto-boxed in a Number object. Common usage 
would be static import of the methods in this class, so the class name is not 
visible in the code. 

The code then looks like 
logger.debug("...{}", box(3.14));

Which communicates to the reader that we are manually wrapping the primitive 
into an object instead of auto-boxing. Hence the "box" method name. It's also 
really short which is important. 

The class name Unbox again is a nice short name that reminds users this class 
helps prevent auto-boxing. 

It is in the util package but is intended for use by users, so this class 
should actually not be "considered private".

Sent from my iPhone

> On 2016/05/30, at 3:58, Gary Gregory  wrote:
> 
> Why is it called Unbox? Seems like a misleading and confusing name when all 
> the methods are called "box"! "Boxer" might be better.
> 
> Gary
> 
>> On Thu, May 26, 2016 at 6:32 PM, Gary Gregory  wrote:
>> There are no callers of the method within Log4j ATM.
>> 
>> Gary
>> 
>>> On Thu, May 26, 2016 at 6:20 PM, Remko Popma  wrote:
>>> Where is this method used?
>>> It is intended to allow the caller to find out if the specified 
>>> StringBuilder instance is managed by Unbox. 
>>> 
>>> Sent from my iPhone
>>> 
 On 2016/05/27, at 9:50, Gary Gregory  wrote:
 
 Ok, so let's drop it from master. I'm AFK ATM.
 
 Gary
 
> On May 26, 2016 12:26 PM, "Matt Sicker"  wrote:
> Most of the classes in that package start with the italicized words 
> Consider this class private.
> 
>> On 26 May 2016 at 14:19, Gary Gregory  wrote:
>>> On Thu, May 26, 2016 at 11:36 AM, Matt Sicker  wrote:
>>> Everything in that util package is log4j-private, so there's no worries 
>>> about removing things.
>> 
>> Ah, yes, now I see:
>> 
>> "Internal utility classes for the Log4j 2 API. Note that the use of any 
>> classes in this package is not supported. There are no guarantees for 
>> binary or logical compatibility in this package."
>> 
>> I wonder if we should *bold* some of that text.
>> 
>> Gary
>>  
>>> 
 On 26 May 2016 at 12:13, Gary Gregory  wrote:
 The method:
 
 org.apache.logging.log4j.util.Unbox.isBoxedPrimitive(StringBuilder)
 
 is unused and undocumented. Can we drop it?
 
 I guess it's already in the 2.6 RC1, which is too bad.
 
 Gary
 
 -- 
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
 Java Persistence with Hibernate, Second Edition
 JUnit in Action, Second Edition
 Spring Batch in Action
 Blog: http://garygregory.wordpress.com 
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory
>>> 
>>> 
>>> 
>>> -- 
>>> Matt Sicker 
>> 
>> 
>> 
>> -- 
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com 
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> -- 
> Matt Sicker 
>> 
>> 
>> 
>> -- 
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
>> Java Persistence with Hibernate, Second Edition
>> JUnit in Action, Second Edition
>> Spring Batch in Action
>> Blog: http://garygregory.wordpress.com 
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> -- 
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory


[ANNOUNCEMENT] Log4j 2.6 released

2016-05-29 Thread Ralph Goers

  Apache Log4j 2.6 RELEASE NOTES

The Apache Log4j 2 team is pleased to announce the Log4j 2.6 release!

Apache log4j is a well known framework for logging application behavior. Log4j 
2 is an upgrade to
Log4j that provides significant improvements over its predecessor, Log4j 1.x, 
and provides
many other modern features such as support for Markers, property substitution 
using Lookups, multiple patterns on
a PatternLayout and asynchronous Loggers. In addition, Log4j 2 will not lose 
events while reconfiguring.

This is the tenth GA release. It contains several bugfixes and new features. 
The new features include
the ability to be "garbage-free" (avoid allocating temporary objects) while 
logging if certain conditions are met,
a new YAML Layout, the ability to merge configuration files, and documenting 
Log4j's performance against other logging
frameworks and in various logging configurations. More details on the features 
and bugfixes are itemized below.

Note that subsequent to the release a minor source incompatibility was found 
due to the addition of new methods to
the Logger interface. If you have code that does:

logger.error(null, “This is the log message”, throwable);

or similar with any log level you will get a compiler error saying the 
reference is ambiguous.  To correct this either do:

logger.error(“This is the log message”, throwable);

or 

logger.error((Marker) null, “This is the log message”, throwable);

Log4j 2.6 maintains binary compatibility with previous releases.

GA Release 2.6

Changes in this version include:

New features:
o LOG4J2-1270:  (GC) Added support for garbage-free logging in steady state.
This includes Async Loggers and logging synchronously to the console 
and to a file,
but does not include the AsyncAppender. This release makes the 
GelfLayout and
the main patterns in the PatternLayout garbage-free. 
o LOG4J2-1297:  (GC) Added manual page on garbage-free logging. 
o LOG4J2-1373:  (GC) Update Logger wrapper Generator tool to generate methods 
for the new Logger methods. 
o LOG4J2-1326:  (GC) Added methods to the Logger interface for logging 
CharSequence messages. 
o LOG4J2-1344:  (GC) FileAppender, RollingFileAppender and 
MemoryMappedFileAppender are now also garbage-free by default. 
o LOG4J2-1278:  (GC) Added unrolled varargs methods to Logger API, added Unbox 
utility to avoid auto-boxing when logging primitive values. 
o LOG4J2-1271:  (GC) Add MessageFactory that avoid allocation by reusing a 
cached ParameterizedMessage instance. 
o LOG4J2-1293:  (GC) Add interface StringBuilderFormattable to enable 
converting Messages and parameters to text without allocating temporary objects.
ParameterizedMessage, ObjectMessage, SimpleMessage and 
ThreadDumpMessage now implement StringBuilderFormattable. 
o LOG4J2-1274:  (GC) Add encode(LogEvent, ByteBufferDestination) method to 
Layout API to enable converting LogEvents to bytes without creating temporary 
objects. 
o LOG4J2-1362:  Added a YAML layout. Thanks to Gary Gregory. 
o LOG4J2-1179:  Documented benchmark results comparing Log4j 2 performance to 
other logging libraries. 
o LOG4J2-1011:  Document dependencies for layouts. 
o LOG4J2-621:  Pattern to drop first N package parts. Thanks to Lee Theobald, 
Kamal Mettananda, Gary Gregory. 
o LOG4J2-494:  Support merging configurations to for a composite configuration. 
Thanks to Philipp Knobel. 
o LOG4J2-1357:  Option to not log stack traces for logged Throwables in 
GelfLayout. 
o LOG4J2-1348:  Add an AutoCloseable ThreadContext class: 
CloseableThreadContext. Thanks to Greg Thomas, Gary Gregory. 
o LOG4J2-1299:  Add pattern converter for thread id and priority in 
PatternLayout. 
o LOG4J2-124:  Add shutdown methods to LogManager. 
o LOG4J2-1221:  Added async logger Timeout wait strategy and made this the 
default wait strategy for async loggers.
This prevents a rare deadlock that may occur on Solaris. Thanks to 
Michael Barker. 
o LOG4J2-1080:  Added option to discard events below a certain log level if the 
async logger ring buffer
or async appender queue is full. 
o LOG4J2-1237:  Make PatternLayout header and footer accept a pattern. Thanks 
to Mike Calmus, Gary Gregory. 
o LOG4J2-1244:  Make header and footer values customizable in JSONLayout. 
Thanks to Anshu Garg, Remko Popma, Gary Gregory. 
o LOG4J2-1245:  Make CSV Layout header and footers accept patterns. 
o LOG4J2-1192:  Dynamic Subject for SMTP Appender. Thanks to Jörg 
Bretschneider, Gary Gregory. 
o LOG4J2-1277:  FormattedMessage, MessageFormatMessage and 
StringFormattedMessage should support passing in a Locale to ensure appropriate 
formatting. Thanks to Gary Gregory, Ludovic Hochet. 
o LOG4J2-1303:  Add documentation links to runtime dependencies in each 
component intro page. 
o LOG4J2-1252:  JeroMqAppender should support layouts. 
o LOG4J2-1217:  PatternLayout option to limit length of text. Thanks to Thies 
Wellpott. 
o LOG4J2-1133:  Add 

Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Gary Gregory
On Sun, May 29, 2016 at 1:41 PM, Ralph Goers 
wrote:

> Here is the text that I propose to add to the announcement. I would also
> add something similar to the web site.
>
> Note that subsequent to the release a minor source incompatibility was
> found due to the addition of new methods to
> the Logger interface. If you have code that does:
>
> logger.error(null, “This is the log message”, throwable);
>
> or similar with any log level you will get a compiler error saying the
> reference is ambiguous.  To correct this either do:
>
> logger.error(“This is the log message”, throwable);
>
> or
>
> logger.error((Marker) null, “This is the log message”, throwable);
>
>
I would add that the 2.6 code is _binary_ compatible with previous releases.

Gary


>
> Ralph
>
> On May 29, 2016, at 11:14 AM, Matt Sicker  wrote:
>
> Yet another reason to hate null! ;)
>
> On 29 May 2016 at 13:13, Ralph Goers  wrote:
>
>> When you pass null as the first argument it doesn't know which is better
>>
>> Sent from my iPhone
>>
>> On May 29, 2016, at 11:07 AM, Matt Sicker  wrote:
>>
>> Wait, how are error(Marker, String, Object) and error(String, Object,
>> Object) even confused by the compiler?
>>
>> On 29 May 2016 at 13:02, Ralph Goers  wrote:
>>
>>> Only if the compatibility issue can be fixed. I don't think it can. We
>>> will just update the site and announcement.
>>>
>>> Sent from my iPhone
>>>
>>> On May 29, 2016, at 10:56 AM, Matt Sicker  wrote:
>>>
>>> So what do we do, follow up with 2.6.1 right away?
>>>
>>> On 29 May 2016 at 12:29, Ralph Goers  wrote:
>>>
 Can’t do that. That would require a re-release.

 Speaking of which, the archives directory only lists a couple of
 releases. I thought they were all supposed to be there.

 Ralph

 On May 29, 2016, at 10:19 AM, Gary Gregory 
 wrote:

 I think the RELEASE-NOTES.txt in the dist area needs to be updated as
 well.

 Gary

 On Sun, May 29, 2016 at 10:15 AM, Ralph Goers <
 ralph.go...@dslextreme.com> wrote:

> I will add something to the announcement text when I send out the
> emails.  Those will go out in a few hours.
>
> Ralph
>
> On May 29, 2016, at 9:53 AM, Gary Gregory 
> wrote:
>
> We are going to need to update the release notes and/or site for 2.6
> to note that the 2.6 is not source compatible with previous releases. I
> tested going from 2.5 to 2.6 at work and got:
>
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>   both method
> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) 
> in
> org.apache.logging.log4j.Logger and method
> error(java.lang.String,java.lang.Object,java.lang.Object) in
> org.apache.logging.log4j.Logger match
> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>   both method
> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) 
> in
> org.apache.logging.log4j.Logger and method
> trace(java.lang.String,java.lang.Object,java.lang.Object) in
> org.apache.logging.log4j.Logger match
> [INFO] 2 errors
>
> with source code like:
>
> public void xyz(final String message, final Throwable t) {
> ...
> logger.error(null, message, t);
> ...
> logger.trace(null, message, t);
> ...
> }
>
> Next time, I'll remember to test with a "real" client.
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 Java Persistence with Hibernate, Second Edition
 
 JUnit in Action, Second Edition 
 Spring Batch in Action 
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory



>>>
>>>
>>> --
>>> Matt Sicker 
>>>
>>>
>>
>>
>> --
>> Matt Sicker 
>>
>>
>
>
> --
> Matt Sicker 
>
>
> - To
> unsubscribe, e-mail: 

Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Ralph Goers
Here is the text that I propose to add to the announcement. I would also add something similar to the web site.Note that subsequent to the release a minor source incompatibility was found due to the addition of new methods tothe Logger interface. If you have code that does:logger.error(null, “This is the log message”, throwable);or similar with any log level you will get a compiler error saying the reference is ambiguous.  To correct this either do:logger.error(“This is the log message”, throwable);or logger.error((Marker) null, “This is the log message”, throwable);RalphOn May 29, 2016, at 11:14 AM, Matt Sicker  wrote:Yet another reason to hate null! ;)On 29 May 2016 at 13:13, Ralph Goers  wrote:When you pass null as the first argument it doesn't know which is betterSent from my iPhoneOn May 29, 2016, at 11:07 AM, Matt Sicker  wrote:Wait, how are error(Marker, String, Object) and error(String, Object, Object) even confused by the compiler?On 29 May 2016 at 13:02, Ralph Goers  wrote:Only if the compatibility issue can be fixed. I don't think it can. We will just update the site and announcement.Sent from my iPhoneOn May 29, 2016, at 10:56 AM, Matt Sicker  wrote:So what do we do, follow up with 2.6.1 right away?On 29 May 2016 at 12:29, Ralph Goers  wrote:Can’t do that. That would require a re-release.Speaking of which, the archives directory only lists a couple of releases. I thought they were all supposed to be there.RalphOn May 29, 2016, at 10:19 AM, Gary Gregory  wrote:I think the RELEASE-NOTES.txt in the dist area needs to be updated as well.GaryOn Sun, May 29, 2016 at 10:15 AM, Ralph Goers  wrote:I will add something to the announcement text when I send out the emails.  Those will go out in a few hours.RalphOn May 29, 2016, at 9:53 AM, Gary Gregory  wrote:We are going to need to update the release notes and/or site for 2.6 to note that the 2.6 is not source compatible with previous releases. I tested going from 2.5 to 2.6 at work and got:[ERROR] COMPILATION ERROR :[INFO] -[ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous  both method error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in org.apache.logging.log4j.Logger and method error(java.lang.String,java.lang.Object,java.lang.Object) in org.apache.logging.log4j.Logger match[ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous  both method trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in org.apache.logging.log4j.Logger and method trace(java.lang.String,java.lang.Object,java.lang.Object) in org.apache.logging.log4j.Logger match[INFO] 2 errorswith source code like:    public void xyz(final String message, final Throwable t) {        ...        logger.error(null, message, t);        ...        logger.trace(null, message, t);        ...    }Next time, I'll remember to test with a "real" client.Gary-- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second EditionJUnit in Action, Second EditionSpring Batch in ActionBlog: http://garygregory.wordpress.com Home: http://garygregory.com/Tweet! http://twitter.com/GaryGregory

-- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second EditionJUnit in Action, Second EditionSpring Batch in ActionBlog: http://garygregory.wordpress.com Home: http://garygregory.com/Tweet! http://twitter.com/GaryGregory

-- Matt Sicker 

-- Matt Sicker 

-- Matt Sicker 



-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Jenkins build is back to stable : Log4j 2.x #1983

2016-05-29 Thread Apache Jenkins Server
See 


-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Jenkins build became unstable: Log4j 2.x #1982

2016-05-29 Thread Apache Jenkins Server
See 


-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: org.apache.logging.log4j.util.Unbox.isBoxedPrimitive(StringBuilder)

2016-05-29 Thread Gary Gregory
Why is it called Unbox? Seems like a misleading and confusing name when all
the methods are called "box"! "Boxer" might be better.

Gary

On Thu, May 26, 2016 at 6:32 PM, Gary Gregory 
wrote:

> There are no callers of the method within Log4j ATM.
>
> Gary
>
> On Thu, May 26, 2016 at 6:20 PM, Remko Popma 
> wrote:
>
>> Where is this method used?
>> It is intended to allow the caller to find out if the specified
>> StringBuilder instance is managed by Unbox.
>>
>> Sent from my iPhone
>>
>> On 2016/05/27, at 9:50, Gary Gregory  wrote:
>>
>> Ok, so let's drop it from master. I'm AFK ATM.
>>
>> Gary
>> On May 26, 2016 12:26 PM, "Matt Sicker"  wrote:
>>
>>> Most of the classes in that package start with the italicized words 
>>> *Consider
>>> this class private.*
>>>
>>> On 26 May 2016 at 14:19, Gary Gregory  wrote:
>>>
 On Thu, May 26, 2016 at 11:36 AM, Matt Sicker  wrote:

> Everything in that util package is log4j-private, so there's no
> worries about removing things.
>

 Ah, yes, now I see:

 "Internal utility classes for the Log4j 2 API. Note that the use of
 any classes in this package is not supported. There are no guarantees for
 binary or logical compatibility in this package."

 I wonder if we should *bold* some of that text.

 Gary


>
> On 26 May 2016 at 12:13, Gary Gregory  wrote:
>
>> The method:
>>
>> org.apache.logging.log4j.util.Unbox.isBoxedPrimitive(StringBuilder)
>>
>> is unused and undocumented. Can we drop it?
>>
>> I guess it's already in the 2.6 RC1, which is too bad.
>>
>> Gary
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker 
>



 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 Java Persistence with Hibernate, Second Edition
 
 JUnit in Action, Second Edition 
 Spring Batch in Action 
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory

>>>
>>>
>>>
>>> --
>>> Matt Sicker 
>>>
>>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[jira] [Closed] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1385.

Resolution: Fixed

In Git master.

> (GC) CSV layouts should not create a new CSVPrinter for each log event
> --
>
> Key: LOG4J2-1385
> URL: https://issues.apache.org/jira/browse/LOG4J2-1385
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Layouts
>Affects Versions: 2.5
>Reporter: Gary Gregory
>Assignee: Gary Gregory
> Fix For: 2.6.1
>
> Attachments: logging-log4j2.patch
>
>
> CSV layouts should not create a new CSVPrinter for each log event. This will 
> likely require a new version of Apache Commons CVS, see [CSV-182].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1385) (GC) CSV layouts should not create a new CSVPrinter for each log event

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1385:
-
Summary: (GC) CSV layouts should not create a new CSVPrinter for each log 
event  (was: CSV layouts should not create a new CSVPrinter for each log event)

> (GC) CSV layouts should not create a new CSVPrinter for each log event
> --
>
> Key: LOG4J2-1385
> URL: https://issues.apache.org/jira/browse/LOG4J2-1385
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Layouts
>Affects Versions: 2.5
>Reporter: Gary Gregory
>Assignee: Gary Gregory
> Fix For: 2.6.1
>
> Attachments: logging-log4j2.patch
>
>
> CSV layouts should not create a new CSVPrinter for each log event. This will 
> likely require a new version of Apache Commons CVS, see [CSV-182].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Closed] (LOG4J2-1399) Update Apache Commons CSV from 1.3 to 1.4

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory closed LOG4J2-1399.

   Resolution: Fixed
Fix Version/s: 2.6.1

In Git master.

> Update Apache Commons CSV from 1.3 to 1.4
> -
>
> Key: LOG4J2-1399
> URL: https://issues.apache.org/jira/browse/LOG4J2-1399
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.6
>Reporter: Gary Gregory
>Assignee: Gary Gregory
> Fix For: 2.6.1
>
>
> Update Apache Commons CSV from 1.3 to 1.4. This will let us address 
> [LOG4J2-1385].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Matt Sicker
Yet another reason to hate null! ;)

On 29 May 2016 at 13:13, Ralph Goers  wrote:

> When you pass null as the first argument it doesn't know which is better
>
> Sent from my iPhone
>
> On May 29, 2016, at 11:07 AM, Matt Sicker  wrote:
>
> Wait, how are error(Marker, String, Object) and error(String, Object,
> Object) even confused by the compiler?
>
> On 29 May 2016 at 13:02, Ralph Goers  wrote:
>
>> Only if the compatibility issue can be fixed. I don't think it can. We
>> will just update the site and announcement.
>>
>> Sent from my iPhone
>>
>> On May 29, 2016, at 10:56 AM, Matt Sicker  wrote:
>>
>> So what do we do, follow up with 2.6.1 right away?
>>
>> On 29 May 2016 at 12:29, Ralph Goers  wrote:
>>
>>> Can’t do that. That would require a re-release.
>>>
>>> Speaking of which, the archives directory only lists a couple of
>>> releases. I thought they were all supposed to be there.
>>>
>>> Ralph
>>>
>>> On May 29, 2016, at 10:19 AM, Gary Gregory 
>>> wrote:
>>>
>>> I think the RELEASE-NOTES.txt in the dist area needs to be updated as
>>> well.
>>>
>>> Gary
>>>
>>> On Sun, May 29, 2016 at 10:15 AM, Ralph Goers <
>>> ralph.go...@dslextreme.com> wrote:
>>>
 I will add something to the announcement text when I send out the
 emails.  Those will go out in a few hours.

 Ralph

 On May 29, 2016, at 9:53 AM, Gary Gregory 
 wrote:

 We are going to need to update the release notes and/or site for 2.6 to
 note that the 2.6 is not source compatible with previous releases. I tested
 going from 2.5 to 2.6 at work and got:

 [ERROR] COMPILATION ERROR :
 [INFO] -
 [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
   both method
 error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
 org.apache.logging.log4j.Logger and method
 error(java.lang.String,java.lang.Object,java.lang.Object) in
 org.apache.logging.log4j.Logger match
 [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
   both method
 trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
 org.apache.logging.log4j.Logger and method
 trace(java.lang.String,java.lang.Object,java.lang.Object) in
 org.apache.logging.log4j.Logger match
 [INFO] 2 errors

 with source code like:

 public void xyz(final String message, final Throwable t) {
 ...
 logger.error(null, message, t);
 ...
 logger.trace(null, message, t);
 ...
 }

 Next time, I'll remember to test with a "real" client.

 Gary

 --
 E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
 Java Persistence with Hibernate, Second Edition
 
 JUnit in Action, Second Edition 
 Spring Batch in Action 
 Blog: http://garygregory.wordpress.com
 Home: http://garygregory.com/
 Tweet! http://twitter.com/GaryGregory



>>>
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> 
>>> JUnit in Action, Second Edition 
>>> Spring Batch in Action 
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>>
>>>
>>
>>
>> --
>> Matt Sicker 
>>
>>
>
>
> --
> Matt Sicker 
>
>


-- 
Matt Sicker 


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Ralph Goers
When you pass null as the first argument it doesn't know which is better

Sent from my iPhone

> On May 29, 2016, at 11:07 AM, Matt Sicker  wrote:
> 
> Wait, how are error(Marker, String, Object) and error(String, Object, Object) 
> even confused by the compiler?
> 
>> On 29 May 2016 at 13:02, Ralph Goers  wrote:
>> Only if the compatibility issue can be fixed. I don't think it can. We will 
>> just update the site and announcement.
>> 
>> Sent from my iPhone
>> 
>>> On May 29, 2016, at 10:56 AM, Matt Sicker  wrote:
>>> 
>>> So what do we do, follow up with 2.6.1 right away?
>>> 
 On 29 May 2016 at 12:29, Ralph Goers  wrote:
 Can’t do that. That would require a re-release.
 
 Speaking of which, the archives directory only lists a couple of releases. 
 I thought they were all supposed to be there.
 
 Ralph
 
> On May 29, 2016, at 10:19 AM, Gary Gregory  wrote:
> 
> I think the RELEASE-NOTES.txt in the dist area needs to be updated as 
> well.
> 
> Gary
> 
>> On Sun, May 29, 2016 at 10:15 AM, Ralph Goers 
>>  wrote:
>> I will add something to the announcement text when I send out the 
>> emails.  Those will go out in a few hours.
>> 
>> Ralph
>> 
>>> On May 29, 2016, at 9:53 AM, Gary Gregory  
>>> wrote:
>>> 
>>> We are going to need to update the release notes and/or site for 2.6 to 
>>> note that the 2.6 is not source compatible with previous releases. I 
>>> tested going from 2.5 to 2.6 at work and got:
>>> 
>>> [ERROR] COMPILATION ERROR :
>>> [INFO] -
>>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>>   both method 
>>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object)
>>>  in org.apache.logging.log4j.Logger and method 
>>> error(java.lang.String,java.lang.Object,java.lang.Object) in 
>>> org.apache.logging.log4j.Logger match
>>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>>   both method 
>>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object)
>>>  in org.apache.logging.log4j.Logger and method 
>>> trace(java.lang.String,java.lang.Object,java.lang.Object) in 
>>> org.apache.logging.log4j.Logger match
>>> [INFO] 2 errors
>>> 
>>> with source code like:
>>> 
>>> public void xyz(final String message, final Throwable t) {
>>> ...
>>> logger.error(null, message, t);
>>> ...
>>> logger.trace(null, message, t);
>>> ...
>>> }
>>> 
>>> Next time, I'll remember to test with a "real" client.
>>> 
>>> Gary
>>> 
>>> -- 
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
>>> Java Persistence with Hibernate, Second Edition
>>> JUnit in Action, Second Edition
>>> Spring Batch in Action
>>> Blog: http://garygregory.wordpress.com 
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> -- 
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>>> 
>>> 
>>> 
>>> -- 
>>> Matt Sicker 
> 
> 
> 
> -- 
> Matt Sicker 


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Ralph Goers
Only if the compatibility issue can be fixed. I don't think it can. We will 
just update the site and announcement.

Sent from my iPhone

> On May 29, 2016, at 10:56 AM, Matt Sicker  wrote:
> 
> So what do we do, follow up with 2.6.1 right away?
> 
>> On 29 May 2016 at 12:29, Ralph Goers  wrote:
>> Can’t do that. That would require a re-release.
>> 
>> Speaking of which, the archives directory only lists a couple of releases. I 
>> thought they were all supposed to be there.
>> 
>> Ralph
>> 
>>> On May 29, 2016, at 10:19 AM, Gary Gregory  wrote:
>>> 
>>> I think the RELEASE-NOTES.txt in the dist area needs to be updated as well.
>>> 
>>> Gary
>>> 
 On Sun, May 29, 2016 at 10:15 AM, Ralph Goers  
 wrote:
 I will add something to the announcement text when I send out the emails.  
 Those will go out in a few hours.
 
 Ralph
 
> On May 29, 2016, at 9:53 AM, Gary Gregory  wrote:
> 
> We are going to need to update the release notes and/or site for 2.6 to 
> note that the 2.6 is not source compatible with previous releases. I 
> tested going from 2.5 to 2.6 at work and got:
> 
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>   both method 
> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) 
> in org.apache.logging.log4j.Logger and method 
> error(java.lang.String,java.lang.Object,java.lang.Object) in 
> org.apache.logging.log4j.Logger match
> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>   both method 
> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) 
> in org.apache.logging.log4j.Logger and method 
> trace(java.lang.String,java.lang.Object,java.lang.Object) in 
> org.apache.logging.log4j.Logger match
> [INFO] 2 errors
> 
> with source code like:
> 
> public void xyz(final String message, final Throwable t) {
> ...
> logger.error(null, message, t);
> ...
> logger.trace(null, message, t);
> ...
> }
> 
> Next time, I'll remember to test with a "real" client.
> 
> Gary
> 
> -- 
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>>> 
>>> 
>>> 
>>> -- 
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org 
>>> Java Persistence with Hibernate, Second Edition
>>> JUnit in Action, Second Edition
>>> Spring Batch in Action
>>> Blog: http://garygregory.wordpress.com 
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
> 
> 
> 
> -- 
> Matt Sicker 


I've written a blog post about 2.6

2016-05-29 Thread Matt Sicker
http://musigma.org/java/log4j/2016/05/29/log4j-2.6.html

Let me know what you think. I haven't blogged in a long time, but I'm
starting to get back into it partly to help motivate a friend of mine to
keep writing himself.

-- 
Matt Sicker 


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Matt Sicker
So what do we do, follow up with 2.6.1 right away?

On 29 May 2016 at 12:29, Ralph Goers  wrote:

> Can’t do that. That would require a re-release.
>
> Speaking of which, the archives directory only lists a couple of releases.
> I thought they were all supposed to be there.
>
> Ralph
>
> On May 29, 2016, at 10:19 AM, Gary Gregory  wrote:
>
> I think the RELEASE-NOTES.txt in the dist area needs to be updated as well.
>
> Gary
>
> On Sun, May 29, 2016 at 10:15 AM, Ralph Goers 
> wrote:
>
>> I will add something to the announcement text when I send out the
>> emails.  Those will go out in a few hours.
>>
>> Ralph
>>
>> On May 29, 2016, at 9:53 AM, Gary Gregory  wrote:
>>
>> We are going to need to update the release notes and/or site for 2.6 to
>> note that the 2.6 is not source compatible with previous releases. I tested
>> going from 2.5 to 2.6 at work and got:
>>
>> [ERROR] COMPILATION ERROR :
>> [INFO] -
>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>   both method
>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
>> org.apache.logging.log4j.Logger and method
>> error(java.lang.String,java.lang.Object,java.lang.Object) in
>> org.apache.logging.log4j.Logger match
>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>   both method
>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
>> org.apache.logging.log4j.Logger and method
>> trace(java.lang.String,java.lang.Object,java.lang.Object) in
>> org.apache.logging.log4j.Logger match
>> [INFO] 2 errors
>>
>> with source code like:
>>
>> public void xyz(final String message, final Throwable t) {
>> ...
>> logger.error(null, message, t);
>> ...
>> logger.trace(null, message, t);
>> ...
>> }
>>
>> Next time, I'll remember to test with a "real" client.
>>
>> Gary
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>>
>>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
Matt Sicker 


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Ralph Goers
Can’t do that. That would require a re-release.

Speaking of which, the archives directory only lists a couple of releases. I 
thought they were all supposed to be there.

Ralph

> On May 29, 2016, at 10:19 AM, Gary Gregory  wrote:
> 
> I think the RELEASE-NOTES.txt in the dist area needs to be updated as well.
> 
> Gary
> 
> On Sun, May 29, 2016 at 10:15 AM, Ralph Goers  > wrote:
> I will add something to the announcement text when I send out the emails.  
> Those will go out in a few hours.
> 
> Ralph
> 
>> On May 29, 2016, at 9:53 AM, Gary Gregory > > wrote:
>> 
>> We are going to need to update the release notes and/or site for 2.6 to note 
>> that the 2.6 is not source compatible with previous releases. I tested going 
>> from 2.5 to 2.6 at work and got:
>> 
>> [ERROR] COMPILATION ERROR :
>> [INFO] -
>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>   both method 
>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in 
>> org.apache.logging.log4j.Logger and method 
>> error(java.lang.String,java.lang.Object,java.lang.Object) in 
>> org.apache.logging.log4j.Logger match
>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>   both method 
>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in 
>> org.apache.logging.log4j.Logger and method 
>> trace(java.lang.String,java.lang.Object,java.lang.Object) in 
>> org.apache.logging.log4j.Logger match
>> [INFO] 2 errors
>> 
>> with source code like:
>> 
>> public void xyz(final String message, final Throwable t) {
>> ...
>> logger.error(null, message, t);
>> ...
>> logger.trace(null, message, t);
>> ...
>> }
>> 
>> Next time, I'll remember to test with a "real" client.
>> 
>> Gary
>> 
>> -- 
>> E-Mail: garydgreg...@gmail.com  | 
>> ggreg...@apache.org  
>> Java Persistence with Hibernate, Second Edition 
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com  
>> Home: http://garygregory.com/ 
>> Tweet! http://twitter.com/GaryGregory 
> 
> 
> 
> -- 
> E-Mail: garydgreg...@gmail.com  | 
> ggreg...@apache.org  
> Java Persistence with Hibernate, Second Edition 
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com  
> Home: http://garygregory.com/ 
> Tweet! http://twitter.com/GaryGregory 


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Gary Gregory
I think the RELEASE-NOTES.txt in the dist area needs to be updated as well.

Gary

On Sun, May 29, 2016 at 10:15 AM, Ralph Goers 
wrote:

> I will add something to the announcement text when I send out the emails.
> Those will go out in a few hours.
>
> Ralph
>
> On May 29, 2016, at 9:53 AM, Gary Gregory  wrote:
>
> We are going to need to update the release notes and/or site for 2.6 to
> note that the 2.6 is not source compatible with previous releases. I tested
> going from 2.5 to 2.6 at work and got:
>
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>   both method
> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
> org.apache.logging.log4j.Logger and method
> error(java.lang.String,java.lang.Object,java.lang.Object) in
> org.apache.logging.log4j.Logger match
> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>   both method
> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
> org.apache.logging.log4j.Logger and method
> trace(java.lang.String,java.lang.Object,java.lang.Object) in
> org.apache.logging.log4j.Logger match
> [INFO] 2 errors
>
> with source code like:
>
> public void xyz(final String message, final Throwable t) {
> ...
> logger.error(null, message, t);
> ...
> logger.trace(null, message, t);
> ...
> }
>
> Next time, I'll remember to test with a "real" client.
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Matt Sicker
That would be good. I try to remember to add @since everywhere I can
remember to, but an automated tool would help a lot.

On 29 May 2016 at 12:02, Gary Gregory  wrote:

> On Sun, May 29, 2016 at 9:57 AM, Gary Gregory 
> wrote:
>
>> And to make it more difficult to see what's changed, we do not have
>> @since 2.6 Javadoc markers for the new methods in Logger that expand
>> arguments up to 10 Objects :-(
>>
>
> I wonder which one of Clirr or Checkstyle could be extended to issue
> warnings if @since tags are missing on public methods?
>
> Gary
>
>>
>> Gary
>>
>> On Sun, May 29, 2016 at 9:53 AM, Gary Gregory 
>> wrote:
>>
>>> We are going to need to update the release notes and/or site for 2.6 to
>>> note that the 2.6 is not source compatible with previous releases. I tested
>>> going from 2.5 to 2.6 at work and got:
>>>
>>> [ERROR] COMPILATION ERROR :
>>> [INFO] -
>>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>>   both method
>>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
>>> org.apache.logging.log4j.Logger and method
>>> error(java.lang.String,java.lang.Object,java.lang.Object) in
>>> org.apache.logging.log4j.Logger match
>>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>>   both method
>>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
>>> org.apache.logging.log4j.Logger and method
>>> trace(java.lang.String,java.lang.Object,java.lang.Object) in
>>> org.apache.logging.log4j.Logger match
>>> [INFO] 2 errors
>>>
>>> with source code like:
>>>
>>> public void xyz(final String message, final Throwable t) {
>>> ...
>>> logger.error(null, message, t);
>>> ...
>>> logger.trace(null, message, t);
>>> ...
>>> }
>>>
>>> Next time, I'll remember to test with a "real" client.
>>>
>>> Gary
>>>
>>> --
>>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>>> Java Persistence with Hibernate, Second Edition
>>> 
>>> JUnit in Action, Second Edition 
>>> Spring Batch in Action 
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>>
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker 


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Ralph Goers
I will add something to the announcement text when I send out the emails.  
Those will go out in a few hours.

Ralph

> On May 29, 2016, at 9:53 AM, Gary Gregory  wrote:
> 
> We are going to need to update the release notes and/or site for 2.6 to note 
> that the 2.6 is not source compatible with previous releases. I tested going 
> from 2.5 to 2.6 at work and got:
> 
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>   both method 
> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in 
> org.apache.logging.log4j.Logger and method 
> error(java.lang.String,java.lang.Object,java.lang.Object) in 
> org.apache.logging.log4j.Logger match
> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>   both method 
> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in 
> org.apache.logging.log4j.Logger and method 
> trace(java.lang.String,java.lang.Object,java.lang.Object) in 
> org.apache.logging.log4j.Logger match
> [INFO] 2 errors
> 
> with source code like:
> 
> public void xyz(final String message, final Throwable t) {
> ...
> logger.error(null, message, t);
> ...
> logger.trace(null, message, t);
> ...
> }
> 
> Next time, I'll remember to test with a "real" client.
> 
> Gary
> 
> -- 
> E-Mail: garydgreg...@gmail.com  | 
> ggreg...@apache.org  
> Java Persistence with Hibernate, Second Edition 
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com  
> Home: http://garygregory.com/ 
> Tweet! http://twitter.com/GaryGregory 


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Ralph Goers
I suspect most people would have coded logger.error(message, t) though so 
hopefully it won’t be too bad.

Ralph

> On May 29, 2016, at 9:53 AM, Gary Gregory  wrote:
> 
> We are going to need to update the release notes and/or site for 2.6 to note 
> that the 2.6 is not source compatible with previous releases. I tested going 
> from 2.5 to 2.6 at work and got:
> 
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>   both method 
> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in 
> org.apache.logging.log4j.Logger and method 
> error(java.lang.String,java.lang.Object,java.lang.Object) in 
> org.apache.logging.log4j.Logger match
> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>   both method 
> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in 
> org.apache.logging.log4j.Logger and method 
> trace(java.lang.String,java.lang.Object,java.lang.Object) in 
> org.apache.logging.log4j.Logger match
> [INFO] 2 errors
> 
> with source code like:
> 
> public void xyz(final String message, final Throwable t) {
> ...
> logger.error(null, message, t);
> ...
> logger.trace(null, message, t);
> ...
> }
> 
> Next time, I'll remember to test with a "real" client.
> 
> Gary
> 
> -- 
> E-Mail: garydgreg...@gmail.com  | 
> ggreg...@apache.org  
> Java Persistence with Hibernate, Second Edition 
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com  
> Home: http://garygregory.com/ 
> Tweet! http://twitter.com/GaryGregory 


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Ralph Goers
Darn. I wish you had caught that before the vote.  That is not good.

Ralph

> On May 29, 2016, at 10:02 AM, Gary Gregory  wrote:
> 
> On Sun, May 29, 2016 at 9:57 AM, Gary Gregory  > wrote:
> And to make it more difficult to see what's changed, we do not have @since 
> 2.6 Javadoc markers for the new methods in Logger that expand arguments up to 
> 10 Objects :-(
> 
> I wonder which one of Clirr or Checkstyle could be extended to issue warnings 
> if @since tags are missing on public methods?
> 
> Gary
> 
> Gary
> 
> On Sun, May 29, 2016 at 9:53 AM, Gary Gregory  > wrote:
> We are going to need to update the release notes and/or site for 2.6 to note 
> that the 2.6 is not source compatible with previous releases. I tested going 
> from 2.5 to 2.6 at work and got:
> 
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>   both method 
> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in 
> org.apache.logging.log4j.Logger and method 
> error(java.lang.String,java.lang.Object,java.lang.Object) in 
> org.apache.logging.log4j.Logger match
> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>   both method 
> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in 
> org.apache.logging.log4j.Logger and method 
> trace(java.lang.String,java.lang.Object,java.lang.Object) in 
> org.apache.logging.log4j.Logger match
> [INFO] 2 errors
> 
> with source code like:
> 
> public void xyz(final String message, final Throwable t) {
> ...
> logger.error(null, message, t);
> ...
> logger.trace(null, message, t);
> ...
> }
> 
> Next time, I'll remember to test with a "real" client.
> 
> Gary
> 
> -- 
> E-Mail: garydgreg...@gmail.com  | 
> ggreg...@apache.org  
> Java Persistence with Hibernate, Second Edition 
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com  
> Home: http://garygregory.com/ 
> Tweet! http://twitter.com/GaryGregory 
> 
> 
> -- 
> E-Mail: garydgreg...@gmail.com  | 
> ggreg...@apache.org  
> Java Persistence with Hibernate, Second Edition 
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com  
> Home: http://garygregory.com/ 
> Tweet! http://twitter.com/GaryGregory 
> 
> 
> -- 
> E-Mail: garydgreg...@gmail.com  | 
> ggreg...@apache.org  
> Java Persistence with Hibernate, Second Edition 
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com  
> Home: http://garygregory.com/ 
> Tweet! http://twitter.com/GaryGregory 


Re: Logo themes

2016-05-29 Thread Ralph Goers

Gary, 

The logo is a jpeg on the site so I had to convert the png to a jpeg so that I 
wouldn’t have to modify the html on every page. Not a big deal though.

Ralph

> On May 27, 2016, at 10:30 PM, Gary Gregory  wrote:
> 
> Here is the one logo you mentioned with a 2.6 version stamp: 
> https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=blob_plain;f=src/site/resources/logo/logo-blue-web-r2.6.png;hb=HEAD
>  
> 
> 
> Gary
> 
> On Fri, May 27, 2016 at 3:44 PM, Ralph Goers  > wrote:
> Yes, the last slide. OTOH, if we don’t have each release have its own logo we 
> could add them all and add some javascript to pick one at random every time 
> you hit the page.
> 
> Ralph
> 
> 
>> On May 27, 2016, at 2:50 PM, Gary Gregory > > wrote:
>> 
>> Sure, why not, I'll put the XCF files in Git later and do that version 
>> thing. Unfortunately I do not see a XCF file for the logo so I had to use a 
>> PNG as the base. To be precise, you like the _last_ file in the slideshow?
>> 
>> Gary
>> 
>> Even though our current cup is white I actually like the ones you have where 
>> it isn’t better, but they all look cool.
>> 
>> Would it be possible to pick one (say the bottom right) and add the version 
>> number to it?  Then with each version we can change the logo and include the 
>> version number in it.
>> 
>> Ralph
>> 
>>> On May 27, 2016, at 12:26 AM, Gary Gregory >> > wrote:
>>> 
>>> New URL: https://home.apache.org/~ggregory/log4j/log4j-logos.html# 
>>> 
>>> 
>>> 
>>> On Thu, May 26, 2016 at 11:58 PM, Gary Gregory >> > wrote:
>>> I added a bunch more, just for fun.
>>> 
>>> Gary
>>> 
>>> On Thu, May 26, 2016 at 11:18 PM, Ralph Goers >> > wrote:
>>> Yeah, those are fun. You can always replace the logo after the site is 
>>> deployed. We can also fix individual errors by checking in just that page.
>>> 
>>> Ralph
>>> 
 On May 26, 2016, at 11:00 PM, Gary Gregory > wrote:
 
 I wish I had thought of it before the RC but it would be fun to tweak the 
 Log4j logo with a theme for each release. For example:
 
 https://home.apache.org/~ggregory/log4j/log4j-theme-logos.png 
 
 
 Gary
 
 -- 
 E-Mail: garydgreg...@gmail.com  | 
 ggreg...@apache.org  
 Java Persistence with Hibernate, Second Edition 
 
 JUnit in Action, Second Edition 
 Spring Batch in Action 
 Blog: http://garygregory.wordpress.com  
 Home: http://garygregory.com/ 
 Tweet! http://twitter.com/GaryGregory 
>>> 
>>> 
>>> 
>>> -- 
>>> E-Mail: garydgreg...@gmail.com  | 
>>> ggreg...@apache.org  
>>> Java Persistence with Hibernate, Second Edition 
>>> 
>>> JUnit in Action, Second Edition 
>>> Spring Batch in Action 
>>> Blog: http://garygregory.wordpress.com  
>>> Home: http://garygregory.com/ 
>>> Tweet! http://twitter.com/GaryGregory 
>>> 
>>> 
>>> -- 
>>> E-Mail: garydgreg...@gmail.com  | 
>>> ggreg...@apache.org  
>>> Java Persistence with Hibernate, Second Edition 
>>> 
>>> JUnit in Action, Second Edition 
>>> Spring Batch in Action 
>>> Blog: http://garygregory.wordpress.com  
>>> Home: http://garygregory.com/ 
>>> Tweet! http://twitter.com/GaryGregory 
> 
> 
> 
> 
> -- 
> E-Mail: garydgreg...@gmail.com  | 
> ggreg...@apache.org  
> Java Persistence with Hibernate, Second Edition 
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com  
> Home: http://garygregory.com/ 

Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Gary Gregory
On Sun, May 29, 2016 at 9:57 AM, Gary Gregory 
wrote:

> And to make it more difficult to see what's changed, we do not have @since
> 2.6 Javadoc markers for the new methods in Logger that expand arguments up
> to 10 Objects :-(
>

I wonder which one of Clirr or Checkstyle could be extended to issue
warnings if @since tags are missing on public methods?

Gary

>
> Gary
>
> On Sun, May 29, 2016 at 9:53 AM, Gary Gregory 
> wrote:
>
>> We are going to need to update the release notes and/or site for 2.6 to
>> note that the 2.6 is not source compatible with previous releases. I tested
>> going from 2.5 to 2.6 at work and got:
>>
>> [ERROR] COMPILATION ERROR :
>> [INFO] -
>> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>>   both method
>> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
>> org.apache.logging.log4j.Logger and method
>> error(java.lang.String,java.lang.Object,java.lang.Object) in
>> org.apache.logging.log4j.Logger match
>> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>>   both method
>> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
>> org.apache.logging.log4j.Logger and method
>> trace(java.lang.String,java.lang.Object,java.lang.Object) in
>> org.apache.logging.log4j.Logger match
>> [INFO] 2 errors
>>
>> with source code like:
>>
>> public void xyz(final String message, final Throwable t) {
>> ...
>> logger.error(null, message, t);
>> ...
>> logger.trace(null, message, t);
>> ...
>> }
>>
>> Next time, I'll remember to test with a "real" client.
>>
>> Gary
>>
>> --
>> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
>> Java Persistence with Hibernate, Second Edition
>> 
>> JUnit in Action, Second Edition 
>> Spring Batch in Action 
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


Re: 2.6 is not source compatible with 2.5

2016-05-29 Thread Gary Gregory
And to make it more difficult to see what's changed, we do not have @since
2.6 Javadoc markers for the new methods in Logger that expand arguments up
to 10 Objects :-(

Gary

On Sun, May 29, 2016 at 9:53 AM, Gary Gregory 
wrote:

> We are going to need to update the release notes and/or site for 2.6 to
> note that the 2.6 is not source compatible with previous releases. I tested
> going from 2.5 to 2.6 at work and got:
>
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
>   both method
> error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
> org.apache.logging.log4j.Logger and method
> error(java.lang.String,java.lang.Object,java.lang.Object) in
> org.apache.logging.log4j.Logger match
> [ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
>   both method
> trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
> org.apache.logging.log4j.Logger and method
> trace(java.lang.String,java.lang.Object,java.lang.Object) in
> org.apache.logging.log4j.Logger match
> [INFO] 2 errors
>
> with source code like:
>
> public void xyz(final String message, final Throwable t) {
> ...
> logger.error(null, message, t);
> ...
> logger.trace(null, message, t);
> ...
> }
>
> Next time, I'll remember to test with a "real" client.
>
> Gary
>
> --
> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
> Java Persistence with Hibernate, Second Edition
> 
> JUnit in Action, Second Edition 
> Spring Batch in Action 
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


2.6 is not source compatible with 2.5

2016-05-29 Thread Gary Gregory
We are going to need to update the release notes and/or site for 2.6 to
note that the 2.6 is not source compatible with previous releases. I tested
going from 2.5 to 2.6 at work and got:

[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR] /E:/vcs/svn/...XYZ..:[155,15] reference to error is ambiguous
  both method
error(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
org.apache.logging.log4j.Logger and method
error(java.lang.String,java.lang.Object,java.lang.Object) in
org.apache.logging.log4j.Logger match
[ERROR] /E:/vcs/svn/...XYZ...:[395,15] reference to trace is ambiguous
  both method
trace(org.apache.logging.log4j.Marker,java.lang.String,java.lang.Object) in
org.apache.logging.log4j.Logger and method
trace(java.lang.String,java.lang.Object,java.lang.Object) in
org.apache.logging.log4j.Logger match
[INFO] 2 errors

with source code like:

public void xyz(final String message, final Throwable t) {
...
logger.error(null, message, t);
...
logger.trace(null, message, t);
...
}

Next time, I'll remember to test with a "real" client.

Gary

-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition

JUnit in Action, Second Edition 
Spring Batch in Action 
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory


[jira] [Created] (LOG4J2-1399) Update Apache Commons CSV from 1.3 to 1.4

2016-05-29 Thread Gary Gregory (JIRA)
Gary Gregory created LOG4J2-1399:


 Summary: Update Apache Commons CSV from 1.3 to 1.4
 Key: LOG4J2-1399
 URL: https://issues.apache.org/jira/browse/LOG4J2-1399
 Project: Log4j 2
  Issue Type: Improvement
  Components: Appenders
Affects Versions: 2.6
Reporter: Gary Gregory
Assignee: Gary Gregory


Update Apache Commons CSV from 1.3 to 1.4. This will let us address 
[LOG4J2-1385].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1385) CSV layouts should not create a new CSVPrinter for each log event

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1385:
-
Fix Version/s: (was: 2.6)
   2.6.1

> CSV layouts should not create a new CSVPrinter for each log event
> -
>
> Key: LOG4J2-1385
> URL: https://issues.apache.org/jira/browse/LOG4J2-1385
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Layouts
>Affects Versions: 2.5
>Reporter: Gary Gregory
>Assignee: Gary Gregory
> Fix For: 2.6.1
>
> Attachments: logging-log4j2.patch
>
>
> CSV layouts should not create a new CSVPrinter for each log event. This will 
> likely require a new version of Apache Commons CVS, see [CSV-182].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1229) Error creating logger

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1229:
-
Fix Version/s: (was: 2.6)
   2.6.1

> Error creating logger
> -
>
> Key: LOG4J2-1229
> URL: https://issues.apache.org/jira/browse/LOG4J2-1229
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders
>Affects Versions: 2.4.1, 2.5
> Environment: Ubuntu 14.04
>Reporter: Dmitriy Dumanskiy
> Fix For: 2.6.1
>
>
> I have a lot of VMs where everything is fine. But on some of them  I get 
> below stack trace. I have a feeling it somehow related with access rights. 
> Here is stack trace :
> {code}
> 2015-12-21 08:05:06,036 AsyncLogger-1 ERROR Unable to invoke factory method 
> in class class org.apache.logging.log4j.core.appender.RollingFileAppender for 
> element RollingFile. java.lang.reflect.InvocationTargetException
> at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at 
> org.apache.logging.log4j.core.config.plugins.util.PluginBuilder.build(PluginBuilder.java:136)
> at 
> org.apache.logging.log4j.core.config.AbstractConfiguration.createPluginObject(AbstractConfiguration.java:813)
> at 
> org.apache.logging.log4j.core.config.AbstractConfiguration.createConfiguration(AbstractConfiguration.java:753)
> at 
> org.apache.logging.log4j.core.appender.routing.RoutingAppender.createAppender(RoutingAppender.java:152)
> at 
> org.apache.logging.log4j.core.appender.routing.RoutingAppender.getControl(RoutingAppender.java:136)
> at 
> org.apache.logging.log4j.core.appender.routing.RoutingAppender.append(RoutingAppender.java:110)
> at 
> org.apache.logging.log4j.core.config.AppenderControl.tryCallAppender(AppenderControl.java:152)
> at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender0(AppenderControl.java:125)
> at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppenderPreventRecursion(AppenderControl.java:116)
> at 
> org.apache.logging.log4j.core.config.AppenderControl.callAppender(AppenderControl.java:84)
> at 
> org.apache.logging.log4j.core.config.LoggerConfig.callAppenders(LoggerConfig.java:390)
> at 
> org.apache.logging.log4j.core.config.LoggerConfig.processLogEvent(LoggerConfig.java:378)
> at 
> org.apache.logging.log4j.core.config.LoggerConfig.log(LoggerConfig.java:362)
> at 
> org.apache.logging.log4j.core.config.AwaitCompletionReliabilityStrategy.log(AwaitCompletionReliabilityStrategy.java:79)
> at 
> org.apache.logging.log4j.core.async.AsyncLogger.actualAsyncLog(AsyncLogger.java:385)
> at 
> org.apache.logging.log4j.core.async.RingBufferLogEvent.execute(RingBufferLogEvent.java:103)
> at 
> org.apache.logging.log4j.core.async.RingBufferLogEventHandler.onEvent(RingBufferLogEventHandler.java:43)
> at 
> org.apache.logging.log4j.core.async.RingBufferLogEventHandler.onEvent(RingBufferLogEventHandler.java:28)
> at 
> com.lmax.disruptor.BatchEventProcessor.run(BatchEventProcessor.java:128)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.IllegalStateException: ManagerFactory 
> [org.apache.logging.log4j.core.appender.rolling.RollingFileManager$RollingFileManagerFactory@346629f5]
>  unable to create manager for [/data//1_v4.csv] with data 
> [org.apache.logging.log4j.core.appender.rolling.RollingFileManager$FactoryData@6d48f4b0]
> at 
> org.apache.logging.log4j.core.appender.AbstractManager.getManager(AbstractManager.java:73)
> at 
> org.apache.logging.log4j.core.appender.OutputStreamManager.getManager(OutputStreamManager.java:61)
> at 
> org.apache.logging.log4j.core.appender.rolling.RollingFileManager.getFileManager(RollingFileManager.java:79)
> at 
> org.apache.logging.log4j.core.appender.RollingFileAppender.createAppender(RollingFileAppender.java:193)
> ... 25 more
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1086) SizeBasedTriggeringPolicy is not working properly with Logj2 2.3 version jars

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1086:
-
Fix Version/s: (was: 2.6)
   2.6.1

> SizeBasedTriggeringPolicy is not working properly with Logj2 2.3 version jars
> -
>
> Key: LOG4J2-1086
> URL: https://issues.apache.org/jira/browse/LOG4J2-1086
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Appenders
>Affects Versions: 2.3, 2.4.1
> Environment: Windows 7 OS Websphere 8.5.5.6
>Reporter: Sharat
>Assignee: Ralph Goers
>Priority: Minor
>  Labels: features
> Fix For: 2.6.1
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> {code}
> 
> 
>  
>  filePattern="/logs/test-%i.log"> 
>
>   %d %-5p %class{36} (%M:%L) 
> -%msg%xEx%n 
>
>
>   
>   
>
>
>
>
>
>
>   
>   
>  
> 
>   
>   
> 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1130) CsvLogEventLayout NanoTime timestamp is always zero.

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1130:
-
Fix Version/s: (was: 2.6)
   2.6.1

> CsvLogEventLayout NanoTime timestamp is always zero.
> 
>
> Key: LOG4J2-1130
> URL: https://issues.apache.org/jira/browse/LOG4J2-1130
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Layouts
>Affects Versions: 2.4
>Reporter: Remko Popma
> Fix For: 2.6.1
>
>
> CsvLogEventLayout generates NanoTime timestamps but these are always zero.
> To fix this, add the below code to the CsvLogEventLayout constructor:
> {code}
>   // LOG4J2-1074 Switch to actual clock if nanosecond timestamps are 
> required in config.
>   // LoggerContext will notify known NanoClockFactory users that the 
> configuration has changed.
>   NanoClockFactory.setMode(NanoClockFactory.Mode.System);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1116) Web app-friendly thread locals for gc-free logging (was: upgrade to log4j2 causes too frequent minor gc)

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1116:
-
Fix Version/s: (was: 2.6)
   2.6.1

> Web app-friendly thread locals for gc-free logging (was: upgrade to log4j2 
> causes too frequent minor gc)
> 
>
> Key: LOG4J2-1116
> URL: https://issues.apache.org/jira/browse/LOG4J2-1116
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.3
> Environment: jdk1.6 
> slf4j 1.7.9
> log4j2.3
>Reporter: Mingjiang Shi
>Assignee: Ralph Goers
>Priority: Critical
> Fix For: 2.6.1
>
> Attachments: Log4jThreadLocal.java, Log4jThreadLocal.java
>
>
> We used slf4j+log1.2 in our spring web application. Due to the log4j1.0 
> performance issue, we upgrade it to log4j2. When it goes to production, it 
> experienced very frequent minor gc (once per second) even though the eden 
> area is not full. For example, the eden area just occupied 10%, the minor gc 
> also happens. The issue disappears when rolling back to log4j1.2. 
> Can anyone show some hints on diagnose this issue? Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1198) Add support for custom rollover strategy

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1198:
-
Fix Version/s: (was: 2.6)
   2.6.1

> Add support for custom rollover strategy
> 
>
> Key: LOG4J2-1198
> URL: https://issues.apache.org/jira/browse/LOG4J2-1198
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: Appenders
>Affects Versions: 2.4.1
>Reporter: Remko Popma
> Fix For: 2.6.1
>
>
> [DefaultRolloverStrategy|http://logging.apache.org/log4j/2.x/manual/appenders.html#DefaultRolloverStrategy]
>  has a very compact configuration, but as a trade-off has become a bit 
> monolithic. I find it difficult to unit test and maintain. 
> Continuing in the spirit of the work done for LOG4J2-435, I would like to 
> break out components for the different kinds of processing done by 
> DefaultRolloverStrategy so that they can be individually configured and 
> combined by users. Users would configure a CustomRolloverStrategy by 
> specifying nested actions that define what needs to be done during a rollover.
> The DefaultRolloverStrategy would still continue to work as current, but 
> under the hood can delegate to these components.
> _At this stage the above is still just a concept. The description is to be 
> updated when it becomes more clear if and how this would work._



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1013) Log4j2 Main Arguments Lookup by name doesn't work

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1013:
-
Fix Version/s: (was: 2.6)
   2.6.1

> Log4j2 Main Arguments Lookup by name doesn't work
> -
>
> Key: LOG4J2-1013
> URL: https://issues.apache.org/jira/browse/LOG4J2-1013
> Project: Log4j 2
>  Issue Type: Bug
>  Components: API, Core, Lookups
>Affects Versions: 2.2
> Environment: Windows 7 x64 Ultimate and Java 8U31 x64. Project 
> created using Eclipse.
>Reporter: Ioan Mihaila
>Priority: Critical
> Fix For: 2.6.1
>
>
> Accessing Main Arguments by using index based look up works : $\{main:0}
> Accessing Main Arguments by using name based look up doesn't work : 
> $\{main:--file}
> When trying to access by name it doesn't retrieve the argument but retrieves 
> "-file".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-1381) Documentation for LoggerNameLevelRewritePolicy is wrong

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-1381:
-
Fix Version/s: (was: 2.6)
   2.6.1

> Documentation for LoggerNameLevelRewritePolicy is wrong
> ---
>
> Key: LOG4J2-1381
> URL: https://issues.apache.org/jira/browse/LOG4J2-1381
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Documentation
>Affects Versions: 2.5
>Reporter: Remko Popma
> Fix For: 2.6.1
>
>
> The docs for [LoggerNameLevelRewritePolicy 
> |http://logging.apache.org/log4j/2.x/manual/appenders.html#RewriteAppender] 
> are wrong:
> * property {{loggerName}} (both in the parameter table and in the example 
> configuration): looking at the code, this should be {{logger}} instead.
> * property {{LevelPair}} (in the parameter table) should be {{KeyValuePair}} 
> instead. The example configuration is correct here.
>  (Or should the code be modified to match the docs instead?)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-915) Wrong timestamp of filename when SizeBasedTriggering and TimeBasedTrigger used simultaniously with RollingFileAppender

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-915:

Fix Version/s: (was: 2.6)
   2.6.1

> Wrong timestamp of filename when SizeBasedTriggering and TimeBasedTrigger 
> used simultaniously with RollingFileAppender
> --
>
> Key: LOG4J2-915
> URL: https://issues.apache.org/jira/browse/LOG4J2-915
> Project: Log4j 2
>  Issue Type: Bug
>  Components: Core
>Affects Versions: 2.1
>Reporter: Daniel Stuckert
> Fix For: 2.6.1
>
> Attachments: JIRA_915.diff
>
>
> When using the SizedBasedTrigger and TimeBasedTrigger simultaniously the 
> timestamp for the filename generated by the SizeBasedTrigger is not the 
> current time but the next timestamp calculated by the TimeBasedTrigger.
> The bug can be reproduced with the sample configuration in the manual.
> Likely cause of the problem is that the TimeBasedTrigger sets the time of the 
> next rollover and the SizeBasedTrigger uses the set time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



[jira] [Updated] (LOG4J2-849) [Perf] Add performance tests to compare overhead of various logging APIs

2016-05-29 Thread Gary Gregory (JIRA)

 [ 
https://issues.apache.org/jira/browse/LOG4J2-849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gary Gregory updated LOG4J2-849:

Fix Version/s: (was: 2.6)
   2.6.1

> [Perf] Add performance tests to compare overhead of various logging APIs
> 
>
> Key: LOG4J2-849
> URL: https://issues.apache.org/jira/browse/LOG4J2-849
> Project: Log4j 2
>  Issue Type: Improvement
>  Components: API, JCL Bridge, JUL adapter, log4j 1.2 emulation, 
> Performance Benchmarks, SLF4J Bridge
>Affects Versions: 2.1
>Reporter: Remko Popma
> Fix For: 2.6.1
>
>
> Compare overhead of using various APIs with log4j-core-2.x.
> * Log4j2 API
> * Log4j-1.2 API
> * Commons Logging
> * SLF4J
> * JUL



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: [VOTE][RESULT] Log4j 2.6 rc1

2016-05-29 Thread Matt Sicker
Thanks for doing the release!

On 29 May 2016 at 11:25, Gary Gregory  wrote:

> On May 29, 2016 7:01 AM, "Remko Popma"  wrote:
> >
> > Ralph, thank you for doing the release work!
>
> +1
>
> Gary
> >
> > Remko
> >
> > Sent from my iPhone
> >
> > On 2016/05/29, at 15:48, Ralph Goers  wrote:
> >
> >> The artifacts have been released. I will update the web site in the
> morning.
> >>
> >> Ralph
> >>
> >>> On May 28, 2016, at 11:10 PM, Ralph Goers 
> wrote:
> >>>
> >>> The vote has passed with binding +1 votes from Remko Popma, Ralph
> Goers, Gary Gregory and Matt Sicker. Mikael Ståldal also cast a +1 vote.
> >>>
> >>> Thanks to all who voted.
> >>>
> >>> I will continue on with the release process.
> >>>
> >>> Ralph
> >>
> >>
>



-- 
Matt Sicker 


Re: [VOTE][RESULT] Log4j 2.6 rc1

2016-05-29 Thread Gary Gregory
On May 29, 2016 7:01 AM, "Remko Popma"  wrote:
>
> Ralph, thank you for doing the release work!

+1

Gary
>
> Remko
>
> Sent from my iPhone
>
> On 2016/05/29, at 15:48, Ralph Goers  wrote:
>
>> The artifacts have been released. I will update the web site in the
morning.
>>
>> Ralph
>>
>>> On May 28, 2016, at 11:10 PM, Ralph Goers 
wrote:
>>>
>>> The vote has passed with binding +1 votes from Remko Popma, Ralph
Goers, Gary Gregory and Matt Sicker. Mikael Ståldal also cast a +1 vote.
>>>
>>> Thanks to all who voted.
>>>
>>> I will continue on with the release process.
>>>
>>> Ralph
>>
>>


Re: [VOTE][RESULT] Log4j 2.6 rc1

2016-05-29 Thread Remko Popma
Ralph, thank you for doing the release work!

Remko

Sent from my iPhone

> On 2016/05/29, at 15:48, Ralph Goers  wrote:
> 
> The artifacts have been released. I will update the web site in the morning.
> 
> Ralph
> 
>> On May 28, 2016, at 11:10 PM, Ralph Goers  wrote:
>> 
>> The vote has passed with binding +1 votes from Remko Popma, Ralph Goers, 
>> Gary Gregory and Matt Sicker. Mikael Ståldal also cast a +1 vote.
>> 
>> Thanks to all who voted. 
>> 
>> I will continue on with the release process.
>> 
>> Ralph
> 


[jira] [Commented] (LOG4J2-1397) Support ByteBufferLayout

2016-05-29 Thread Remko Popma (JIRA)

[ 
https://issues.apache.org/jira/browse/LOG4J2-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305883#comment-15305883
 ] 

Remko Popma commented on LOG4J2-1397:
-

Example no-frills implementation: 
https://gist.github.com/remkop/715fcd6035c4f798c264e21450106399

> Support ByteBufferLayout
> 
>
> Key: LOG4J2-1397
> URL: https://issues.apache.org/jira/browse/LOG4J2-1397
> Project: Log4j 2
>  Issue Type: New Feature
>  Components: Layouts
>Affects Versions: 2.6
>Reporter: Remko Popma
>
> As requested by Kirk Pepperdine on the Mechanical Sympathy [mailing 
> list|https://groups.google.com/d/msg/mechanical-sympathy/klefjRqlpQE/-1WF59IGAwAJ]:
> Support a new Layout that takes ObjectMessages containing a ByteBuffer 
> payload and write them to the appender without modification.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



Re: [VOTE][RESULT] Log4j 2.6 rc1

2016-05-29 Thread Ralph Goers
The artifacts have been released. I will update the web site in the morning.

Ralph

> On May 28, 2016, at 11:10 PM, Ralph Goers  wrote:
> 
> The vote has passed with binding +1 votes from Remko Popma, Ralph Goers, Gary 
> Gregory and Matt Sicker. Mikael Ståldal also cast a +1 vote.
> 
> Thanks to all who voted. 
> 
> I will continue on with the release process.
> 
> Ralph



[VOTE][RESULT] Log4j 2.6 rc1

2016-05-29 Thread Ralph Goers
The vote has passed with binding +1 votes from Remko Popma, Ralph Goers, Gary 
Gregory and Matt Sicker. Mikael Ståldal also cast a +1 vote.

Thanks to all who voted. 

I will continue on with the release process.

Ralph