Re: [LTP] LTP release

Hi, as you mentioned, the problem in ns_exec was setns'ing the "user" namespace, I think it would be sufficient to just comment/remove this line: rf |= open_ns_fd(argv[1], "user"); from ns_exec.c or even all calls to open_ns_fd() function except for the network namespace as it is used in netns

Re: [LTP] [PATCH v2] ltp/pounder: Don't let the testing log output to /dev/tty

Hi, On Tue, Sep 1, 2015 at 9:44 PM, Cyril Hrubis wrote: > Hi! > > + out = fdopen(3, "w+"); > > This is just complicated way of doing out = stderr; > > And I doubt that this will fail under normal circumstances. > > So what about doing just out = stderr; or out = stdout

Re: [LTP] Test Anything Protocal output

On Mon, Aug 31, 2015 at 12:22:44PM +0200, Cyril Hrubis wrote: > Hi! > > I read your January 2015 article where someone asked if TAP test output > > would be supported. It sounded like > > you were going to look into it. Did you make any progress? > > Unfortunately not yet. > > > The reason I

Re: [LTP] LTP release

Hi! > > I've did my release testing and pushed a few fixes, mosty minor ones. > > > > Now the only problem that that blocks the release on my side are > > failures of the newly rewritten netns testcases that were discussed > > last week. > > > > In RHEL5.11GA, ns_ifmove.c gives compilation

Re: [LTP] LTP release

Hi! > as you mentioned, the problem in ns_exec was setns'ing the "user" namespace, > I think it would be sufficient to just comment/remove this line: > rf |= open_ns_fd(argv[1], "user"); > from ns_exec.c or even all calls to open_ns_fd() function except for the > network > namespace as it is used

Re: [LTP] LTP release

Hi! On 2015/09/01 23:35, Cyril Hrubis wrote: > Hi! >>> Now the only problem that that blocks the release on my side are >>> failures of the newly rewritten netns testcases that were discussed >>> last week. >>> >> >> In RHEL5.11GA, ns_ifmove.c gives compilation error since 'IFLA_NET_NS_PID' >>

Re: [LTP] [PATCH v2] ltp/pounder: Don't let the testing log output to /dev/tty

Hi! > + out = fdopen(3, "w+"); This is just complicated way of doing out = stderr; And I doubt that this will fail under normal circumstances. So what about doing just out = stderr; or out = stdout instead? Otherwise it looks fine and I'm OK with applying this before the release. --

Re: [LTP] LTP release

Hi, another solution could be to let ns_ifmove.c as it is (so it won't build) and only add a check for binaries: tst_check_cmds ns_create ns_exec ns_ifmove to the netns test code. On the other hand, this will produce unclear output from the netns testcases, you will only know that ns_ifmove

Re: [LTP] LTP release

Hi! > another solution could be to let ns_ifmove.c as it is (so it won't build) > and only add a check for binaries: > tst_check_cmds ns_create ns_exec ns_ifmove We would have to ingore the return value from the ns_ifmove build, which means custom rule in the Makefile, which is ugly. > to the

Re: [LTP] LTP release

Hi! > > Now the only problem that that blocks the release on my side are > > failures of the newly rewritten netns testcases that were discussed > > last week. > > > > In RHEL5.11GA, ns_ifmove.c gives compilation error since 'IFLA_NET_NS_PID' > undeclared in the kernel. Should be fixed in