Re: [lxc-devel] [PATCH] Set umask before populating /dev and restore it after.

2013-01-08 Thread Stéphane Graber
://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Master SQL Server Development, Administration, T-SQL, SSAS, SSIS

Re: [lxc-devel] [PATCH] oracle template: drop additional capabilities

2013-01-08 Thread Stéphane Graber
- learn more at: http://p.sf.net/sfu/learnmore_122512 ___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc

Re: [lxc-devel] [PATCH] oracle template: use url arg to wget repo file

2013-01-08 Thread Stéphane Graber
://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Master SQL Server Development, Administration, T-SQL

Re: [lxc-devel] [PATCH] fixed RELEASE_URL for fedora releases higher than 16

2013-01-04 Thread Stéphane Graber
mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH 14/21] Make utmpx.h optional

2013-01-04 Thread Stéphane Graber
On 01/03/2013 04:18 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): This adds code detecting the presence of utmpx.h and in its absence, turns the utmp related functions into no-ops. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 2 +- src

[lxc-devel] [PATCH 06/21] Replace get_current_dir_name by getcwd

2013-01-03 Thread Stéphane Graber
get_current_dir_name appears to be specific to glibc. Replace that call by an equivalent getcwd call. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc_attach.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_attach.c b/src/lxc/lxc_attach.c index

[lxc-devel] [PATCH 08/21] conf.c: Define LO_FLAGS_AUTOCLEAR if it's not

2013-01-03 Thread Stéphane Graber
LO_FLAGS_AUTOCLEAR isn't defined on bionic, so add an extra ifndef and set it to its usual value if it's not. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index 4f041dc..7e1d10a

[lxc-devel] [PATCH 00/21] Enable building with bionic (Android C library)

2013-01-03 Thread Stéphane Graber
those functions. This also does a bit of cleaning up of configure.ac. Stéphane Graber (21): configure.ac: Add code to detect bionic C library configure.ac: Cleanup, comments, indent, ... Replace all reference to ushort by unsigned short Support both getline and fgetln No need to link

[lxc-devel] [PATCH 09/21] clone: Support bionic's clone() defintion

2013-01-03 Thread Stéphane Graber
The clone() call in bionic is very slightly different. This updates namespace.h to support both glibc and bionic. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/namespace.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/lxc/namespace.h b/src/lxc/namespace.h index

[lxc-devel] [PATCH 11/21] Don't hard depend on capability.h and libcap

2013-01-03 Thread Stéphane Graber
In the effort to make LXC work with non-standard Linux distros, this change allows for the user to build LXC without capability support. This effectively will cause LXC not to link against libcap and will turn all the _cap_ functions into no-ops. Signed-off-by: Stéphane Graber stgra

[lxc-devel] [PATCH 02/21] configure.ac: Cleanup, comments, indent, ...

2013-01-03 Thread Stéphane Graber
highlighter much happier). Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 133 +++ 1 file changed, 70 insertions(+), 63 deletions(-) diff --git a/configure.ac b/configure.ac index 1a3f271..9b4c4b2 100644 --- a/configure.ac

[lxc-devel] [PATCH 12/21] personality.h: Make the personality code optional

2013-01-03 Thread Stéphane Graber
Some platforms don't have personality.h in their C library, this change adds buildtime detection for the header and turns off the personality setting code in those cases. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 4 ++-- src/lxc/conf.c | 7 ++- src

[lxc-devel] [PATCH 05/21] No need to link against rt and util on bionic

2013-01-03 Thread Stéphane Graber
When building on bionic, -lrt and -lutil only cause a build failure. Dropping those fixes the build, so it appears that the symbols are defined in the main library. This commit moves -lrt and -lutil under a !IS_BIONIC check. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc

[lxc-devel] [PATCH 18/21] Add local implementation of mntent.h

2013-01-03 Thread Stéphane Graber
Bionic (at least) is missing some of the usual mntent functions. This adds code defining those that we need when they're missing from the C library. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/include/mntent.c | 49 + src/include

[lxc-devel] [PATCH 10/21] tty.h: Ship our own minimal openpty.h

2013-01-03 Thread Stéphane Graber
bionic is missing an openpty() function, so ship our own and only build it and use it on bionic. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 12 - src/include/openpty.c | 72 +++ src/include/openpty.h | 14

[lxc-devel] [PATCH 17/21] caps.h: Rename __errno to ___errno

2013-01-03 Thread Stéphane Graber
At least bionic defines __errno, so this was causing a conflict in caps.h leading to build failure. Renaming to ___errno avoids that duplicate definition. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 5 - src/lxc/caps.h | 12 ++-- 2 files changed, 10

[lxc-devel] [PATCH 01/21] configure.ac: Add code to detect bionic C library

2013-01-03 Thread Stéphane Graber
This adds a new IS_BIONIC define that can be used to detect whether we are building with eglibc or with bionic. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 14 ++ 1 file changed, 14 insertions(+) diff --git a/configure.ac b/configure.ac index 2add6a3

[lxc-devel] [PATCH 16/21] Replace strdupa call by standard strdup

2013-01-03 Thread Stéphane Graber
strdupa appears to only exist in the standard glibc but at least not in bionic. Replace the two strdupa calls we have by a standard strdup. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/confile.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[lxc-devel] [PATCH 19/21] conf.c: Cleanup __S_ISTYPE

2013-01-03 Thread Stéphane Graber
__S_ISTYPE doesn't exist in all C libraries, so define it if it's missing. Additionaly, replace one occurence where it wasn't actually needed. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/lxc

[lxc-devel] [PATCH 04/21] Support both getline and fgetln

2013-01-03 Thread Stéphane Graber
Some libc implementations don't have the getline function but instead have an equivalent fgetln function. Add code to detect both and use whatever is available. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 3 +++ src/lxc/attach.c | 5 + src/lxc/parse.c | 5

[lxc-devel] [PATCH 13/21] Workaround missing functions in other libc

2013-01-03 Thread Stéphane Graber
Some libc implementation (bionic) is lacking some of the syscall functions that are present in the glibc. For those, detect at build time the they are missing and implement a minimal syscall() wrapper that will essentially give the same result as the glibc function. Signed-off-by: Stéphane

[lxc-devel] [PATCH] tests/Makefile.am: Update for bionic

2013-01-03 Thread Stéphane Graber
-lpthread doesn't exist and isn't necessary on bionic. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/tests/Makefile.am | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/tests/Makefile.am b/src/tests/Makefile.am index fa61f70..90fcafe 100644 --- a/src

Re: [lxc-devel] [PATCH] fix lxc-wait waiting forever for FREEZING, FROZEN, THAWED states

2013-01-03 Thread Stéphane Graber
, the lxc-wait will never see the new state. This change has lxc send the new state to the lxc-monitor socket. Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/freezer.c | 6 ++ src/lxc/lxc_wait.c | 2 +- 2 files changed, 7

Re: [lxc-devel] [PATCH] oracle template: add support for creating ol4 container from ovm template

2013-01-03 Thread Stéphane Graber
-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-oracle.in | 123 1 file changed, 83 insertions(+), 40 deletions(-) diff --git a/templates/lxc-oracle.in b/templates/lxc-oracle.in index

[lxc-devel] Reviews

2013-01-02 Thread Stéphane Graber
packages As being taken care off. I'll push updates to the staging branch and replies to the mailing-list a few hours after I land back in Canada. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] cleanup: use lxc-info --state-is

2013-01-02 Thread Stéphane Graber
--state-is. Diff updated and applied. Thanks. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-clone.in| 2 +- src/lxc/lxc-destroy.in | 5 ++--- src/lxc/lxc-netstat.in | 3 +-- src/lxc/lxc-shutdown.in | 6 +- 4 files changed, 5 insertions(+), 11 deletions(-) diff

Re: [lxc-devel] [PATCH 3/5] lxc-alpine: add --repository option

2013-01-02 Thread Stéphane Graber
On 12/31/2012 02:49 PM, Natanael Copa wrote: This allows specifying what repository to use for the container. Signed-off-by: Natanael Copa nc...@alpinelinux.org Looks good. Pushed. Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-alpine.in | 10 +- 1 file changed

Re: [lxc-devel] [PATCH 5/5] lxc-alpine: add support for installing optional packages

2013-01-02 Thread Stéphane Graber
On 12/31/2012 02:49 PM, Natanael Copa wrote: Let users append a list of packages they want install in the container Signed-off-by: Natanael Copa nc...@alpinelinux.org Looks good. Pushed. Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-alpine.in | 11 --- 1 file

Re: [lxc-devel] [PATCH 4/5] lxc-alpine: add support for setting arch from command line

2013-01-02 Thread Stéphane Graber
On 12/31/2012 02:49 PM, Natanael Copa wrote: This allows us to lxc-create 32 bit guests on x86_64 hosts. Signed-off-by: Natanael Copa nc...@alpinelinux.org Comment below, though good enough. Pushed. Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-alpine.in | 28

Re: [lxc-devel] [PATCH 2/5] lxc-alpine: indent fixes

2013-01-02 Thread Stéphane Graber
On 12/31/2012 02:49 PM, Natanael Copa wrote: Signed-off-by: Natanael Copa nc...@alpinelinux.org Looks good. Pushed. Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-alpine.in | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git

Re: [lxc-devel] [PATCH] separate console device from console log

2013-01-02 Thread Stéphane Graber
, my_args.console_log) 0) { + ERROR(failed to ensure console log '%s', my_args.console_log); + return err; } if (my_args.pidfile != NULL) { -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] lxc-ps: use posix shell and awk instead of bash

2013-01-02 Thread Stéphane Graber
On 01/02/2013 01:00 PM, Stéphane Graber wrote: On 12/26/2012 04:31 PM, Natanael Copa wrote: Use awk to parse the output pf 'ps' and the tasks files for the containers. Use awk fields to find PID column rather than assume that the PID field is exactly 5 chars wide and has a leading space

Re: [lxc-devel] [PATCH] define MS_SHARED if needed

2012-12-25 Thread Stéphane Graber
100644 --- a/src/lxc/conf.c +++ b/src/lxc/conf.c @@ -87,6 +87,10 @@ lxc_log_define(lxc_conf, lxc); #define MNT_DETACH 2 #endif +#ifndef MS_SLAVE +#define MS_SLAVE (119) +#endif + #ifndef MS_RELATIME #define MS_RELATIME (1 21) #endif -- Stéphane Graber Ubuntu developer http

Re: [lxc-devel] [PATCH] lxc-checkconfig: fix colors when using dash

2012-12-25 Thread Stéphane Graber
On 12/25/2012 04:50 PM, Natanael Copa wrote: The \e did not work as expected on dash. Replace with proper posix \033 Signed-off-by: Natanael Copa nc...@alpinelinux.org Acked-by: Stéphane Graber stgra...@ubuntu.com Pushed to staging. Thanks. --- src/lxc/lxc-checkconfig.in | 8

Re: [lxc-devel] [PATCH 1/4] lxc-destroy: use posix shell instead of bash

2012-12-25 Thread Stéphane Graber
On 12/25/2012 05:08 PM, Natanael Copa wrote: - avoid use getopt --longoptions Signed-off-by: Natanael Copa nc...@alpinelinux.org Acked-by: Stéphane Graber stgra...@ubuntu.com Pushed to staging. Thanks. --- src/lxc/lxc-destroy.in | 41 + 1 file

Re: [lxc-devel] [PATCH 3/4] lxc-clone: use posix shell instead of bash

2012-12-25 Thread Stéphane Graber
On 12/25/2012 05:08 PM, Natanael Copa wrote: - avoid getopt --longoptions - use 'which' instead of 'type' to detect existance of tools - use 'grep -q -w' instead of bash substring variable expansion ${line:0:18} Signed-off-by: Natanael Copa nc...@alpinelinux.org Acked-by: Stéphane Graber

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2012-12-20 Thread Stéphane Graber
or is that a side effect of MS_SHARED that we can't workaround on our end? I didn't spend much time reviewing the code itself, but it applied to my local staging tree and built fine, so that's good enough for me :) Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra

Re: [lxc-devel] [PATCH] lxc-destroy container only if it is in the STOPPED state

2012-12-19 Thread Stéphane Graber
-- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices

Re: [lxc-devel] ignore lxc.rootfs when using lxc-execute

2012-12-17 Thread Stéphane Graber
-rootfs.path); + conf-rootfs.path = NULL; + } + return __lxc_start(name, conf, execute_start_ops, args); } -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [GIT] lxc tag, lxc-0.9.0.alpha2, created. 56655134e462ceaf86b51838e4e825c2f3964922

2012-12-14 Thread Stéphane Graber
--- hooks/post-receive Hey Daniel, What happened there? I wasn't expecting another pull from staging until early February and even less a tag of alpha2 ;) -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital

Re: [lxc-devel] [GIT] lxc tag, lxc-0.9.0.alpha2, created. 56655134e462ceaf86b51838e4e825c2f3964922

2012-12-14 Thread Stéphane Graber
On 12/14/2012 08:41 AM, Daniel Lezcano wrote: On 12/14/2012 02:30 PM, Stéphane Graber wrote: I wasn't expecting another pull from staging until early February and Crap ! I misunderstood your email. Shall I reset the tree to alpha1 (I am not really in favor of that) ? Or could we let

Re: [lxc-devel] LXC 0.9.alpha1 pull request

2012-12-13 Thread Stéphane Graber
On 12/13/2012 03:59 PM, Daniel Lezcano wrote: On 12/10/2012 11:36 PM, Stéphane Graber wrote: Hi Daniel, You'll find the 0.9.alpha1 pull request below. Based on what you had to do last time in Copenhagen, I believe the following actions are to be done on your side: - Properly tag 0.8

Re: [lxc-devel] LXC 0.9.alpha1 pull request

2012-12-11 Thread Stéphane Graber
On 12/11/2012 05:12 AM, Daniel Lezcano wrote: On 12/10/2012 11:36 PM, Stéphane Graber wrote: Hi Daniel, You'll find the 0.9.alpha1 pull request below. Based on what you had to do last time in Copenhagen, I believe the following actions are to be done on your side: - Properly tag 0.8

Re: [lxc-devel] API wishlist

2012-12-11 Thread Stéphane Graber
___ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] LXC 0.9.alpha1 pull request

2012-12-11 Thread Stéphane Graber
On 12/11/2012 10:07 AM, Frederic Crozat wrote: Le mardi 11 décembre 2012 à 09:56 -0500, Stéphane Graber a écrit : On 12/11/2012 09:35 AM, Frederic Crozat wrote: Le mardi 11 décembre 2012 à 09:23 -0500, Stéphane Graber a écrit : On 12/11/2012 05:12 AM, Daniel Lezcano wrote: On 12/10/2012 11:36

Re: [lxc-devel] [PATCH 1/2] Add mount hook script to provide systemd containers with minimal /dev

2012-12-10 Thread Stéphane Graber
-- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile

Re: [lxc-devel] API wishlist

2012-12-10 Thread Stéphane Graber
On 12/10/2012 09:30 AM, Dwight Engen wrote: On Fri, 07 Dec 2012 12:47:59 -0500 Stéphane Graber stgra...@ubuntu.com wrote: On 12/07/2012 12:25 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): ... - get_version() (not container specific) - get_lxc_path

Re: [lxc-devel] LXC 0.9.alpha1

2012-12-10 Thread Stéphane Graber
On 12/05/2012 11:54 AM, Stéphane Graber wrote: Hello, After discussing this briefly with Daniel, I wanted to make all of you aware that we are currently planning on sending a pull request of the staging branch on the 10th of December (next Monday). This pull request will very likely

Re: [lxc-devel] LXC 0.9.alpha1

2012-12-10 Thread Stéphane Graber
On 12/10/2012 12:30 PM, Michael H. Warfield wrote: On Mon, 2012-12-10 at 12:09 -0500, Dwight Engen wrote: On Mon, 10 Dec 2012 10:35:17 -0500 Stéphane Graber stgra...@ubuntu.com wrote: On 12/05/2012 11:54 AM, Stéphane Graber wrote: Hello, After discussing this briefly with Daniel, I wanted

Re: [lxc-devel] LXC 0.9.alpha1

2012-12-10 Thread Stéphane Graber
On 12/10/2012 12:59 PM, Michael H. Warfield wrote: On Mon, 2012-12-10 at 12:36 -0500, Stéphane Graber wrote: On 12/10/2012 12:30 PM, Michael H. Warfield wrote: On Mon, 2012-12-10 at 12:09 -0500, Dwight Engen wrote: On Mon, 10 Dec 2012 10:35:17 -0500 Stéphane Graber stgra...@ubuntu.com wrote

[lxc-devel] LXC 0.9.alpha1 pull request

2012-12-10 Thread Stéphane Graber
at shutdown lxc-create: refuse to use a custom rootfs (--dir) which already exists. api: add set_cgroup_item and get_cgroup_item (to c api) dont save loglevel if it is unset Stéphane Graber (77): Merge the liblxc API work by Serge Hallyn. When starting a container

[lxc-devel] [PATCH] python: Update add_device_node to use the new API

2012-12-09 Thread Stéphane Graber
Update add_device_node to use the new set_cgroup_item call instead of having to figure out the cgroup paths and update the entries manually. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/python-lxc/lxc/__init__.py.in | 40 ++- 1 file changed, 10

[lxc-devel] [PATCH] lxc-create: Allow for empty or unset template name

2012-12-07 Thread Stéphane Graber
This restores an old behaviour where lxc-create can be called without a template. In such case, only a minimal configuration is built and no rootfs is created. However the various backingstore code is still used. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-create.in | 22

Re: [lxc-devel] API wishlist

2012-12-07 Thread Stéphane Graber
On 12/07/2012 12:25 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): ... - get_version() (not container specific) - get_lxc_path() (not container specific) Returns the storage path for the containers. Defaults to LXCPATH. - set_lxc_path(path) (not container

[lxc-devel] [PATCH 1/3] python: get_keys() doesn't require a path

2012-12-07 Thread Stéphane Graber
The python binding was forcing the user to pass a base path to get_keys() even though the C binding doesn't require it. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/python-lxc/lxc/__init__.py.in | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/python

[lxc-devel] [PATCH 3/3] gitignore: Update for python files

2012-12-07 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- .gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.gitignore b/.gitignore index 79dd77a..a766716 100644 --- a/.gitignore +++ b/.gitignore @@ -66,6 +66,9 @@ src/lxc/lxc-version src/lxc/lxc-wait src/lxc/legacy/lxc-ls +src

[lxc-devel] [PATCH 2/3] python: Add binding for {get|set}_cgroup_item

2012-12-07 Thread Stéphane Graber
that we don't try to interpret lists as we do for the config entries. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/python-lxc/examples/api_test.py.in | 7 + src/python-lxc/lxc.c | 55 +- src/python-lxc/lxc/__init__.py.in

Re: [lxc-devel] [PATCH 2/4] lxc-archlinux: Don't hardcode /var/lib/lxc in help

2012-12-06 Thread Stéphane Graber
On 12/06/2012 12:07 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-archlinux.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-archlinux.in b/templates/lxc

Re: [lxc-devel] [PATCH 3/4] templates: Consistent use of locking

2012-12-06 Thread Stéphane Graber
On 12/06/2012 12:14 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Move to per-template lock (except for oracle that's per-container). Also ensure that the path used for the lock is relative to LOCALSTATEDIR. Signed-off-by: Stéphane Graber stgra...@ubuntu.com I

Re: [lxc-devel] [PATCH] oracle template: use @LOCALSTATEDIR@ instead of hardcoded /var for lock dir

2012-12-06 Thread Stéphane Graber
+) 200@LOCALSTATEDIR@/lock/subsys/lxc-oracle-$name } usage() -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- LogMeIn Rescue: Anywhere

Re: [lxc-devel] [PATCH] lxc.spec: add openssl and rsync as Required since both are used in lxc-clone

2012-12-06 Thread Stéphane Graber
On 12/06/2012 09:58 AM, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com And pushed to staging. Thanks --- lxc.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lxc.spec.in b/lxc.spec.in index

Re: [lxc-devel] [PATCH RFC] Enable use of user namespaces in containers

2012-12-06 Thread Stéphane Graber
, chown his ptys for + * him */ + if (uid_shift_ttys(handler-pid, handler-conf)) + DEBUG(Failed to chown ptys.\n); + if (handler-ops-post_start(handler, handler-data)) goto out_abort; -- Stéphane Graber Ubuntu developer http://www.ubuntu.com

Re: [lxc-devel] [PATCH v2] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-12-05 Thread Stéphane Graber
On 12/05/2012 12:33 PM, Dwight Engen wrote: Signed-off-by: Dwight Engen dwight.en...@oracle.com Acked-by: Stéphane Graber stgra...@ubuntu.com And applied to staging, thanks! I also noticed that lxc-archlinux.in was missing similar changes so I did the same changes there and pushed that commit

Re: [lxc-devel] [PATCH] make install should create /var/cache/lxc directory

2012-12-05 Thread Stéphane Graber
On 12/05/2012 03:05 PM, Dwight Engen wrote: On Thu, 29 Nov 2012 16:37:21 -0500 Stéphane Graber stgra...@ubuntu.com wrote: On 11/29/2012 04:24 PM, Dwight Engen wrote: The $LXCPATH (default /var/lib/lxc) directory was not being created by make install, so unless it gets created by some other

[lxc-devel] [PATCH 2/4] Minor documentation updates

2012-12-05 Thread Stéphane Graber
- Update COPYING to the current copy of the LPGL-2.1 license from common-licences (only difference is some indentation). - Remove mixed tabs/spaces in CONTRIBUTING - Make INSTALL fit on 79 cols. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- CONTRIBUTING | 7 +++ COPYING

[lxc-devel] [PATCH 1/4] Update README

2012-12-05 Thread Stéphane Graber
This adds a section about the staging branch to the README and updates the list of supported architectures. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- README | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/README b/README index b81e7a9..d7dacfd 100644

Re: [lxc-devel] oracle template: fixes when using fedora host

2012-12-05 Thread Stéphane Graber
-by: Stéphane Graber stgra...@ubuntu.com Looks like my tab/space consistency patch will need a bit of updating when applying to account for this change, but that's easy enough to do. Applied to staging. --- templates/lxc-oracle.in | 28 +++- 1 files changed, 23

[lxc-devel] [PATCH 2/4] lxc-archlinux: Don't hardcode /var/lib/lxc in help

2012-12-05 Thread Stéphane Graber
Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-archlinux.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/lxc-archlinux.in b/templates/lxc-archlinux.in index 5db5b85..cf274d4 100644 --- a/templates/lxc-archlinux.in +++ b/templates/lxc

[lxc-devel] [PATCH 3/4] templates: Consistent use of locking

2012-12-05 Thread Stéphane Graber
Move to per-template lock (except for oracle that's per-container). Also ensure that the path used for the lock is relative to LOCALSTATEDIR. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-altlinux.in | 4 ++-- templates/lxc-debian.in | 4 ++-- templates/lxc

[lxc-devel] [PATCH 1/4] lxc-ubuntu: Don't hardcode path to cache

2012-12-05 Thread Stéphane Graber
Use LOCALSTATEDIR to generate the path to the cache. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac| 1 + templates/lxc-ubuntu| 729 templates/lxc-ubuntu.in | 729

[lxc-devel] [PATCH 4/4] python: Remove hardcoded LXCPATH

2012-12-05 Thread Stéphane Graber
Switch the python scripts to using @LXCPATH@. According to grep, this was the last occurence of a /var/*/lxc path in the code. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- configure.ac | 2 + src/python-lxc/examples/api_test.py| 151 --- src

Re: [lxc-devel] [PATCH RFC] lxc_conf logfile and loglevel support

2012-12-04 Thread Stéphane Graber
it but the code matches what I think we should be doing. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c |3 +++ src/lxc/conf.h |3 +++ src/lxc/confile.c | 58 +++- src/lxc/log.c | 38

[lxc-devel] [PATCH] Install legacy scripts when built without python.

2012-12-04 Thread Stéphane Graber
Re-introduce the old lxc-ls script and manpage under a new legacy sub-directory. Those will be installed in place of their python equivalent when LXC is built without --enable-python. Any other script ported to python should be added to those lists. Signed-off-by: Stéphane Graber stgra

Re: [lxc-devel] [PATCH] Rewrite lxc-ls in python

2012-12-04 Thread Stéphane Graber
On 12/03/2012 09:01 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): This rewrite is mostly compatible with the shell version. --active and -1 still work and behave as they used to. This adds --running, --stopped and --frozen as state filters. A new fancy view is also

Re: [lxc-devel] [PATCH] Install legacy scripts when built without python.

2012-12-04 Thread Stéphane Graber
On 12/04/2012 12:35 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Re-introduce the old lxc-ls script and manpage under a new legacy sub-directory. Those will be installed in place of their python equivalent when LXC is built without --enable-python. Any other

Re: [lxc-devel] [PATCH] rename physical nics at shutdown

2012-12-04 Thread Stéphane Graber
://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1086244 Reported-by: Avijit Ghosh avijit.gh...@aricent.com Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com Just one comment below, but looks good. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c| 28

[lxc-devel] [PATCH 3/3] lxc-device: Show an error message when non-root

2012-12-04 Thread Stéphane Graber
Instead of returning a python stacktrace, check what the current euid is and show an argparse error message similar to that used in lxc-start-ephemeral. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-device | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/lxc/lxc

[lxc-devel] [PATCH 2/3] lxc-ls: Show a simple error message when non-root

2012-12-04 Thread Stéphane Graber
Instead of returning a python stacktrace, check what the current euid is and show an argparse error message similar to that used in lxc-start-ephemeral. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-ls | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/lxc/lxc-ls

[lxc-devel] [PATCH 0/3] Make python scripts deal better when non-root

2012-12-04 Thread Stéphane Graber
scripts to check whether the user is root before invoking the python module so that we can return a nicer error message to the user, suggesting the use of sudo to run the script as root. Stéphane Graber (3): lxc-start-ephemeral: Use argparse errors lxc-ls: Show a simple error message when non-root

[lxc-devel] [PATCH 1/3] lxc-start-ephemeral: Use argparse errors

2012-12-04 Thread Stéphane Graber
Use argparse's error function instead of our own print + exit. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-start-ephemeral.in | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/lxc/lxc-start-ephemeral.in b/src/lxc/lxc-start-ephemeral.in

[lxc-devel] [PATCH] python: Update to the device related functions

2012-12-04 Thread Stéphane Graber
setup to better cope with variable number of arguments - Add support for network devices (currently auto-detected) - Support for different names on the host and in the container Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-device | 48

[lxc-devel] [PATCH] lxc-ls: Update code to allow non-root listing

2012-12-04 Thread Stéphane Graber
-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-ls | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/src/lxc/lxc-ls b/src/lxc/lxc-ls index 2ad1f7f..98b7861 100644 --- a/src/lxc/lxc-ls +++ b/src/lxc/lxc-ls @@ -116,12 +116,6

[lxc-devel] [PATCH] lxc-create: Script cleanup

2012-12-03 Thread Stéphane Graber
- Removes the mixed tabs/spaces, replacing by standard 4 spaces indent. - Fix a bunch of bashisms. - Use shell syntax for and/or in if statements instead of the test syntax. - Improve block spacing a bit. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-create.in | 175

Re: [lxc-devel] [PATCH] lxc-create: Store template information in config

2012-11-30 Thread Stéphane Graber
On 11/30/2012 08:56 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): Change lxc-create to add the name of the template and any parameters to the container's configuration. This makes it easier to debug and figure out exactly how a container was built. Signed-off

Re: [lxc-devel] [PATCH] Use LXCPATH and LOCALSTATEDIR instead of hardcoded /var

2012-11-30 Thread Stéphane Graber
/lxc-ubucloud +) 200@LOCALSTATEDIR@/lock/subsys/lxc-ubucloud copy_configuration $path $rootfs $name $arch $release -- Stéphane Graber -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature

Re: [lxc-devel] [PATCH] Create busybox commands as symlinks instead of hardlinks

2012-11-30 Thread Stéphane Graber
of a hardcoded list in the template. Also set the root password to root, to match what other templates do. Signed-off-by: Dwight Engen dwight.en...@oracle.com Looks good, thanks. Acked-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-busybox.in | 49

Re: [lxc-devel] [PATCHv2] lxc-create: Store template information in config

2012-11-30 Thread Stéphane Graber
On 11/30/2012 05:23 PM, Natanael Copa wrote: On Fri, 30 Nov 2012 17:01:59 -0500 Stéphane Graber stgra...@ubuntu.com wrote: Change lxc-create to add the name of the template, checksum and any parameters to the container's configuration. This makes it easier to debug and figure out exactly

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Stéphane Graber
On 11/29/2012 09:49 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container, also try to scan the host and extra the list of langpacks installed there, then pass that list to debootstrap as additional packages

Re: [lxc-devel] [PATCH] Fix busybox template to not have extra aa_profile hunk

2012-11-29 Thread Stéphane Graber
Engen dwight.en...@oracle.com Looks like something went wrong with the last rebase. Acked-by: Stéphane Graber stgra...@ubuntu.com Pushed to staging. Thanks --- templates/lxc-busybox.in |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/templates/lxc-busybox.in b

Re: [lxc-devel] [PATCH 2/4] lxc-ubuntu: Guess a list of langpacks to install

2012-11-29 Thread Stéphane Graber
On 11/29/2012 10:18 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): On 11/29/2012 09:49 AM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): In addition to creating the current locale in the container, also try to scan the host and extra the list

Re: [lxc-devel] [PATCH] Fix build with --enable-tests on Fedora

2012-11-29 Thread Stéphane Graber
. Signed-off-by: Dwight Engen dwight.en...@oracle.com Drat, sounds like there's a bug in sem_getvalue(3) manpage, which says Link with -lrt or -pthread. Thanks. Acked-by: Serge E. Hallyn serge.hal...@ubuntu.com Acked-by: Stéphane Graber stgra...@ubuntu.com Applied to staging. Thanks

Re: [lxc-devel] [PATCH 1/1] Description: run MAKEDEV console when doing lxc.autodev

2012-11-29 Thread Stéphane Graber
exactly what log entry type we have ;)) Anyway. Acked-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/conf.c | 153 +++- 1 file changed, 106 insertions(+), 47 deletions(-) diff --git a/src/lxc/conf.c b/src/lxc/conf.c index eb0c07e

Re: [lxc-devel] [PATCH] Include lxc-ubuntu when doing make dist

2012-11-29 Thread Stéphane Graber
should remember to test make dist. I only tried a make install and as it worked here, I assumed that the change was correct. Is it the only file that's included in make install but not in make dist? (just wondering if I made that mistake somewhere else :)). Acked-by: Stéphane Graber stgra

[lxc-devel] API wishlist

2012-11-29 Thread Stéphane Graber
in the API so we can rebase the tools on the API and make things a bit more consistent. -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Keep yourself connected

Re: [lxc-devel] API wishlist

2012-11-29 Thread Stéphane Graber
On 11/29/2012 02:42 PM, Serge Hallyn wrote: Quoting Stéphane Graber (stgra...@ubuntu.com): So, I've been thinking a bit about what functions we're currently missing in the API which would make the bindings and scripts much easier. So far, I've been thinking of: - get_cgroup_item(cgroup, key

[lxc-devel] [PATCH] lxc-create: Store template information in config

2012-11-29 Thread Stéphane Graber
Change lxc-create to add the name of the template and any parameters to the container's configuration. This makes it easier to debug and figure out exactly how a container was built. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- src/lxc/lxc-create.in | 9 - 1 file changed, 8

[lxc-devel] [PATCH 4/4] lxc-ubuntu: Fix mixed indent

2012-11-28 Thread Stéphane Graber
Replace all remaining tabs by 8 spaces, to properly indent by 4 spaces. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-ubuntu | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/templates/lxc-ubuntu b/templates/lxc-ubuntu index ce1e065

[lxc-devel] [PATCH 1/4] lxc-ubuntu: Always create the needed locales

2012-11-28 Thread Stéphane Graber
Move some old code from the trim() function into the main configure_ubuntu function so that we always create a locale in the container. Signed-off-by: Stéphane Graber stgra...@ubuntu.com --- templates/lxc-ubuntu.in | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

Re: [lxc-devel] [PATCH v2] lxc-version: use POSIX shell instead of bash

2012-11-27 Thread Stéphane Graber
-version.in @@ -1,3 +1,3 @@ -#!/bin/bash +#!/bin/sh echo lxc version: @PACKAGE_VERSION@ -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Monitor your

Re: [lxc-devel] [PATCH v2] lxc-checkconfig: use POSIX shell instead of bash

2012-11-27 Thread Stéphane Graber
can check its configuration -- Stéphane Graber Ubuntu developer http://www.ubuntu.com signature.asc Description: OpenPGP digital signature -- Monitor your physical, virtual and cloud infrastructure from a single web

<    1   2   3   4   5   6   >