;
Your way is the better way to do it. I adjusted and squased the PR and
post the patch again here as well:
commit 21c3c7ace34eaf5f19074e33d050896b5cc3
Author: Christian Brauner christianvanbrau...@gmail.com
Date: Sun Feb 15 11:31:31 2015 +0100
Show cpu-average in /proc/stat and start cup
Quoting Christian Brauner (christianvanbrauner at gmail.com):
On Sun, Feb 15, 2015 at 05:21:19PM +0100, Christian Brauner wrote:
Hello,
I test the newest systemd from git on a regular basis by compiling it
and installing it into a container and booting it. I did
Here is the original problem which I'm still
experiencing with lxc 1.1:
w/ userns:
[root at fedora2 ~]# setcap 'cap_net_admin,cap_net_raw+ep' /usr/bin/ping
Failed to set capabilities on file `/usr/bin/ping' (Operation not permitted)
[root at fedora2 ~]# id
uid=0(root) gid=0(root)
Hello,
I test the newest systemd from git on a regular basis by compiling it
and installing it into a container and booting it. I did that with the
several current systemd versions from git for the last couple of weeks.
It seems that in the next version when booting a container with
lxc-start,
for that:
Signed-off-by: Christian Brauner christianvanbrau...@gmail.com
Date: Sun Feb 15 10:34:41 2015 +0100
Bring the cpu-average line to /proc/stat mounted by lxcfs and let the
core numbering start at 0.
diff --git a/lxcfs.c b/lxcfs.c
index d6fb101..ab296e7 100644
--- a/lxcfs.c
+++ b/lxcfs.c
Hello,
I think it would be a really good idea to provide the nsexec tools with
lxc per default. A lot of users (including myself) probably bootstrap a
new filesystem for various distributions. Hence, they do not necessarily
rely on templates or download templates provided with lxc. In order to
Hello,
since systemd 219 was released and included in Archlinux unprivileged Archlinux
containers work out of the box. Simply bootstrapping a barebone rootfs via
pacstrap and uidmapshifting it will suffice. However, it would be convenient to
be able to download unprivileged Archlinux containers
Updated PR on Github. Retains old behaviour of lxc executables.
___
lxc-devel mailing list
lxc-devel@lists.linuxcontainers.org
http://lists.linuxcontainers.org/listinfo/lxc-devel
Hi Serge,
hi Stéphane,
currently the struct lxc_arguments lacks quite a few options which are required
by e.g. lxc-snapshot and lxc-clone which leads to a non-uniform implementation
of some of the executables. Would you be open to adding new members to the
lxc_arguments struct in order to rewrite
Updated version as PR on github.
On Thu, Aug 06, 2015 at 03:47:04PM +0200, Christian Brauner wrote:
- lxc_snapshot.c lacked necessary members in the associated lxc_arguments
struct
in arguments.h. This commit extends the lxc_arguments struct to include
several parameters used by lxc
.
Signed-off-by: Christian Brauner christianvanbrau...@gmail.com
---
src/lxc/lxc_destroy.c | 74 ++-
1 file changed, 56 insertions(+), 18 deletions(-)
diff --git a/src/lxc/lxc_destroy.c b/src/lxc/lxc_destroy.c
index 955fc23..32bd2b4 100644
--- a/src
Signed-off-by: Christian Brauner christianvanbrau...@gmail.com
---
src/lxc/lxc_attach.c | 2 +-
src/lxc/lxc_cgroup.c | 2 +-
src/lxc/lxc_checkpoint.c | 2 +-
src/lxc/lxc_console.c| 2 +-
src/lxc/lxc_create.c | 4 ++--
src/lxc/lxc_device.c | 2 +-
src/lxc/lxc_execute.c| 2
Integrating lxc-clone with the standard lxc parser is not possible unless it is
allowed to change command line options. lxc-clone uses -n, -P and -o in a way
that is inconsistent with the standard lxc common options defined in
LXC_COMMON_OPTIONS in arguments.h and the parser in arguments.c. Since
to delete the original container if the file is not empty then it is not safe.
Signed-off-by: Christian Brauner christianvanbrau...@gmail.com
---
src/lxc/lxccontainer.c | 98 +++---
1 file changed, 61 insertions(+), 37 deletions(-)
diff --git a/src
On Wed, Oct 21, 2015 at 01:48:17PM +, Serge Hallyn wrote:
> Quoting Wolfgang Bumiller (w.bumil...@proxmox.com):
> > Otherwise [ interprets the ] as part of the path and also
> > errors about a missing ']'
>
> Thought this had already been applied, but not seeing it in master,
> so
I sent the
On Thu, Oct 22, 2015 at 02:15:18PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > On Thu, Oct 22, 2015 at 01:13:35PM +, Serge Hallyn wrote:
> > > Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > > > On T
Changes:
if ((s3 = strstr(s2, ":/")))
s2[strlen(s2) - strlen(s3)]
obviously simplifies to
if ((s3 = strstr(s2, ":/")))
*s3 = '\0';
Christian Brauner (1):
Parse rootfs->pat
kwards for the first occurrence of the delimiter pair ":/". We do
not simply search for ":" since it might be used in path names. If ":/" is not
found we assume the container is directory backed and simply return
strdup(rootfs->path).
Signed-off-by: Christian Brauner <
On Thu, Oct 22, 2015 at 03:33:30AM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create
> > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries
Instead of duplicating the cleanup-code, once for success and once for failure,
simply keep a variable fret which is -1 in the beginning and gets set to 0 on
success or stays -1 on failure.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/conf.c | 14 ++-
When no explicit workdir is given we simply create a random workdir using
mkdtemp().
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/conf.c | 31 ---
1 file changed, 24 insertions(+), 7 deletions(-)
diff --git a/src/lxc/conf.c b/s
().
Christian Brauner (2):
Simplify function
Create random workdir for overlay mounts
src/lxc/conf.c | 45 ++---
1 file changed, 30 insertions(+), 15 deletions(-)
--
2.6.2
___
lxc-devel mailing list
lxc-devel
e various temporary variables inside the lxc_list_for_each(iterator,
_conf->mount_list) {*/ do stuff */} per Serge's request.
(4) Use uniform exit strategy when the function fails or succeeds.
Christian Brauner (2):
Add clone_update_unexp_ovl_dir() function
Update absolute paths for over
On Tue, Oct 27, 2015 at 05:26:53PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > - When no explicit workdir is given we simply create a random workdir using
> > mkdtemp().
> > - The temporary workdir is not removed whe
According to my testing I'm making a miscalulation here somewhere...
On Tue, Oct 27, 2015 at 09:32:49PM +0100, Christian Brauner wrote:
> Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
> ---
> src/lxc
On Thu, Oct 22, 2015 at 02:59:28AM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > On Tue, Oct 20, 2015 at 09:21:48PM +0200, Christian Brauner wrote:
> > > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions
> >
On Wed, Oct 28, 2015 at 04:08:09PM +0900, Tycho Andersen wrote:
> Hi all,
>
> I'm seeing some (what seems to me to be) odd behavior, where only a
> task's init process is in its freezer cgroup:
>
> firedrill:~ sudo lxc-info -n proposed
> Name: proposed
> State: RUNNING
> PID:
Local variables should not have the same name as global variables to avoid
confusion.
Signed-off-by: Christian Brauner <christian.brau...@mailbox.org>
---
src/lxc/lxc_copy.c | 81 +++---
1 file changed, 41 insertions(+), 40 deletions(-)
diff
On Mon, Nov 09, 2015 at 07:55:31PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > This is a complete reimplementation of lxc-clone and lxc-start-ephemeral.
> > lxc-copy merges the functionalities of lxc-clone + lxc-start-ephemeral.
>
From: Christian Brauner <christianvanbrau...@gmail.com>
When we create a random container directory with mkdtemp() we set the mode to
0770 otherwise do_lxcapi_clone() will complain about not being able to create
the config.
Signed-off-by: Christian Brauner <christianvanbrau...@
Signed-off-by: Christian Brauner <christian.brau...@mailbox.org>
---
src/lxc/lxc_copy.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/src/lxc/lxc_copy.c b/src/lxc/lxc_copy.c
index e5f52d2..be2e3ee 100644
--- a/src/lxc/lxc_copy.c
+++ b/src/lxc/lxc_
(A trivial fix for lxc-copy is included.)
Signed-off-by: Christian Brauner <christian.brau...@mailbox.org>
---
configure.ac | 1 +
doc/Makefile.am | 1 +
doc/lxc-copy.sgml.in | 291 +++
src/lxc/lxc_copy.c | 2 +-
4
(A trivial fix for lxc-copy is included.)
Signed-off-by: Christian Brauner <christian.brau...@mailbox.org>
---
configure.ac | 1 +
doc/Makefile.am | 1 +
doc/lxc-copy.sgml.in | 291 +++
src/lxc/lxc_copy.c | 2 +-
4
On Mon, Nov 02, 2015 at 03:12:02PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > When using overlay and aufs mounts with lxc.mount.entry users have to
> > specify
> > absolute paths for upperdir and workdir which
On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > This functions updates absolute paths for overlay upper- and workdirs so
> > users
> > can simply clone and start new containers without wo
On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > This functions updates absolute paths for overlay upper- and workdirs so
> > users
> > can simply clone and start new containers without wo
On Nov 2, 2015 6:43 PM, "Serge Hallyn" <serge.hal...@ubuntu.com> wrote:
>
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > On Mon, Nov 02, 2015 at 03:52:25PM +0100, Christian Brauner wrote:
> > > On Mon, Nov 02, 2015 at 02:38:16PM +
This functions updates absolute paths for overlay upper- and workdirs so users
can simply clone and start new containers without worrying about absolute paths
in lxc.mount.entry overlay entries.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/confile.c
y_dirs() and
mount_entry_create_aufs_dirs() will still refuse to create upperdir and workdir
when the updated path is unclean. This happens easily when e.g. a user calls
lxc-clone -o OLD -n NEW -P //home//chb///.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/lxccont
_config by using a separate function
clone_update_unexp_ovl_dir() in confile.c.
(3) Move various temporary variables inside the lxc_list_for_each(iterator,
_conf->mount_list) {*/ do stuff */} per Serge's request.
(4) Use uniform exit strategy when the function fails or succeeds.
This functions updates absolute paths for overlay upper- and workdirs so users
can simply clone and start new containers without worrying about absolute paths
in lxc.mount.entry overlay entries.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/confile.c
On Oct 30, 2015 4:08 PM, "Serge Hallyn" <serge.hal...@ubuntu.com> wrote:
>
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > This functions updates absolute paths for overlay upper- and workdirs
so users
> > can simply clone and start new containe
-- Forwarded message --
From: "Christian Brauner" <christianvanbrau...@gmail.com>
Date: Oct 30, 2015 4:27 PM
Subject: Re: [PATCH 2/2 v2] Update absolute paths for overlay and aufs
mounts
To: "Serge E. Hallyn" <serge.hal...@ubuntu.
ity.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/confile.c | 60 +++
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/src/lxc/confile.c b/src/lxc/confile.c
index d584964..0565973 100644
--- a/src/lxc/c
gt;= lend)
continue;
This should deal better with invalid config files.
(3) Insert some spaces between operators to increase readability.
(4) Use gotos to simplify function and increase readability.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc
Serge, I wonder how many bugs you will find. :)
Christian Brauner (1):
Add lxc-copy executable
src/lxc/Makefile.am | 2 +
src/lxc/arguments.h | 2 +
src/lxc/lxc_copy.c | 744
3 files changed, 748 insertions(+)
create mode 10
use mkdtemp() to not just create the names but also directly
create the corresponding directories. This will give us more safety and make
the code considerably shorter.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/Makefile.am | 2 +
src/lxc/arguments.h
use mkdtemp() to not just create the names but also directly
create the corresponding directories. This will give us more safety and make
the code considerably shorter.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/Makefile.am | 2 +
src/lxc/arguments.h
. :)
Christian Brauner (1):
Add lxc-copy executable
src/lxc/Makefile.am | 2 +
src/lxc/arguments.h | 2 +
src/lxc/lxc_copy.c | 744
3 files changed, 748 insertions(+)
create mode 100644 src/lxc/lxc_copy.c
--
2.6.2
On Mon, Nov 02, 2015 at 03:52:25PM +0100, Christian Brauner wrote:
> On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote:
> > Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > > This functions updates absolute paths for overlay upper- and workdirs so
>
On Mon, Nov 02, 2015 at 02:38:16PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > This functions updates absolute paths for overlay upper- and workdirs so
> > users
> > can simply clone and start new containers without wo
still
refuse to create upperdir and workdir when the updated path is unclean. This
happens easily when e.g. a user calls lxc-clone -o OLD -n NEW -P
//home//chb///.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/lxcconta
.
(3) Move various temporary variables inside the lxc_list_for_each(iterator,
_conf->mount_list) {*/ do stuff */} per Serge's request.
(4) Use uniform exit strategy when the function fails or succeeds.
Christian Brauner (3):
Add clone_update_unexp_ovl_paths() function
Upda
hen using lxc-clone.
(2) Also we use the stricter check:
if (p >= lend)
continue;
This should deal better with invalid config files.
(3) Insert some spaces between operators to increase readability.
Signed-off-by: Christian Brauner <christianvanbrau...@gmai
the code
considerably shorter.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/Makefile.am | 2 +
src/lxc/arguments.h | 2 +
src/lxc/lxc_copy.c | 744
3 files changed, 748 insertions(+)
create mode 1006
brauner/lxc/tree/lxccopy
Serge, I wonder how many bugs you will find. :)
Christian Brauner (1):
Add lxc-copy executable
src/lxc/Makefile.am | 2 +
src/lxc/arguments.h | 2 +
src/lxc/lxc_copy.c | 744
3 files changed, 748 inserti
On Mon, Nov 02, 2015 at 02:36:13PM +0100, Christian Brauner wrote:
> (1) This commit fixes some long standing miscalculation when updating paths in
> lxc.hooks.* entries. We now also update conf->unexpandend_alloced which
> hasn't been done prior to this commit. According t
On Oct 16, 2015 19:11, "Serge Hallyn" <serge.hal...@ubuntu.com> wrote:
>
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > On Fri, Oct 16, 2015 at 03:52:04PM +, Serge Hallyn wrote:
> > > Quoting Christian Brauner (christianvanbrau...@gma
On Fri, Oct 16, 2015 at 05:11:02PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > On Fri, Oct 16, 2015 at 03:52:04PM +, Serge Hallyn wrote:
> > > Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > > > On T
On Mon, Oct 19, 2015 at 02:50:11PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create
> > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
share/lxc.mount.hook.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/share/lxc.mount.hook.in b/share/lxc.mount.hook.in
index 7194ab8..5ed2d60 100755
--- a/share/lxc.mount.hook.in
+++ b
kwards for the first occurrence of the delimiter pair ":/". We do
not simply search for ":" since it might be used in path names. If ":/" is not
found we assume the container is directory backed and simply return
strdup(rootfs->path).
Signed-off-by: Christian Brauner <
kwards for the first occurrence of the delimiter pair ":/". We do
not simply search for ":" since it might be used in path names. If ":/" is not
found we assume the container is directory backed and simply return
strdup(rootfs->path).
Signed-off-by: Christian Brauner <
- add NULL-pointer check
- initialize rootfslen
Christian Brauner (1):
Parse rootfs->path
src/lxc/conf.c | 115 -
1 file changed, 90 insertions(+), 25 deletions(-)
--
2.6.1
___
lxc-de
kwards for the first occurrence of the delimiter pair ":/". We do
not simply search for ":" since it might be used in path names. If ":/" is not
found we assume the container is directory backed and simply return
strdup(rootfs->path).
Signed-off-by: Christian Brauner <
A fresh set of eyes would be nice. :)
New solution:
Use strstr() to search for ":/".
If we find ":/" move the string to "/".
Check for a second ":/".
If we find it replace ':' with '\0'.
If we do not find ":/" return strdup(rootfs->path).
On Tue, Oct 20, 2015 at 04:31:19PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > On Tue, Oct 20, 2015 at 03:30:19PM +, Serge Hallyn wrote:
> > > Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > > >
On Tue, Oct 20, 2015 at 03:30:19PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create
> > workdirs and upperdirs for overlay and aufs lxc.mount.entry entries
On Tue, Oct 20, 2015 at 04:17:18PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > When using overlay and aufs mounts with lxc.mount.entry users have to
> > specify
> > absolute paths for upperdir and workdir which
On Tue, Oct 20, 2015 at 09:21:48PM +0200, Christian Brauner wrote:
> The mount_entry_overlay_dirs() and mount_entry_aufs_dirs() functions create
> workdirs and upperdirs for overlay and aufs lxc.mount.entry entries. They try
> to make sure that the workdirs and upperdirs can only be crea
On Fri, Oct 16, 2015 at 03:52:04PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > On Thu, Oct 15, 2015 at 08:32:25PM +, Serge Hallyn wrote:
> > > Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > > >
kdir
when the updated path is unclean. This happens easily when e.g. a user calls
lxc-clone -o OLD -n NEW -P //home//chb///.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/lxccontainer.c | 133 -
1 file changed,
Thanks for taking the time to investigate this. I noticed this as well
(https://github.com/lxc/lxc/issues/663). The new init.scope slice has been
introduced in systemd 226 in order to deal with unified cgroups which have been
introduced into the Kernel in version 4.2.1 or 4.2.2. The details why
to work. Hence, let's not make
that assumption. We now pass lxc_path and lxc_name to
mount_entry_create_*_dirs() and create the path directly. To prevent failure we
also have mount_entry_create_*_dirs() check that lxc_name and lxc_path are not
empty when they are passed in.
Signed-off-by: Chris
to being under the mounted rootfs dir).
>
> These paths would be relative to the containerdir. I think that's too
> confusing.
>
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > I now wonder if it wouldn't be smarter to force users to specify relative
>
,create=dir
will lead to a read-only overlay mount in accordance with the
kernel-documentation.
Specifying
lxc.mount.entry = /lower merged overlay lowerdir=/lower,create=dir
will fail when no upperdir and workdir options are given.
Signed-off-by: Christian Brauner <christianvanb
No changes apart from the ones Serge requested. Adding
Acked-by: Serge E. Hallyn <serge.hal...@ubuntu.com>
with Serge's permission. (see hist comments to [PATCH v4])
Christian Brauner (1):
Make overlayfs mounts work directly
src/lxc/conf.c
work out of the box when a clone of the container is made and
started... Thoughts?
On Tue, Oct 06, 2015 at 08:38:13PM +0200, Christian Brauner wrote:
> When users wanted to mount overlay directories with lxc.mount.entry they had
> to
> create upperdirs and workdirs beforehand in order
Updated version (v4) to follow.
On Mon, Oct 05, 2015 at 01:45:53PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > When users wanted to mount overlay directories with lxc.mount.entry they
> > had to
> > create upperdirs and workdir
I now included a check whether rootfs->path is empty in
mount_entry_create_overlay_dirs() mount_entry_create_aufs_dirs().
Christian Brauner (1):
Make overlayfs mounts work directly
src/lxc/conf.c | 156 -
1 file changed, 144 inserti
,create=dir
will lead to a read-only overlay mount in accordance with the
kernel-documentation.
Specifying
lxc.mount.entry = /lower merged overlay lowerdir=/lower,create=dir
will fail when no upperdir and workdir options are given.
Signed-off-by: Christian Brauner <christianvanb
o also restore
> those at snapshot restore.
>
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > Fair enough. Should we then adapt do_lxcapi_clone() to replace any
mountentries
> > that involve references to the original container with the name of the
new
> > cont
I already have a patch for do_lxcapi_clone() ready. I'll sent it later
tonight or tomorrow.
On Oct 8, 2015 4:59 PM, "Serge Hallyn" <serge.hal...@ubuntu.com> wrote:
>
> Yes, I think so. Worse, I think that'll mean we'll have to also restore
> those at snapshot resto
On Thu, Aug 27, 2015 at 04:17:28PM +, Serge Hallyn wrote:
Quoting Christian Brauner (christianvanbrau...@gmail.com):
This is rather a first-pass suggestion than a full commit to discuss:
The idea:
-
- If a container has clone-snapshots created by
lxc-clone
the corresponding line in the file
lxc_snapshot of the original container will be deleted and the file updated
via mmap() + memmove() + munmap().
- Adapt has_fs_snapshots().
- **If an lxc-snapshot file in the old format is found we'll keep using it.**
Signed-off-by: Christian Brauner christianvanbrau
This is the new version of my modifications to mod_rdep(). It's part of a series
of commits present as a PR on Github which also includes the changes necessary
to adapt lxc-destroy: https://github.com/lxc/lxc/pull/641
Christian Brauner (1):
mod_rdep(): Write path and name of clone to file
src
On Thu, Aug 27, 2015 at 03:41:03PM -0400, Stéphane Graber wrote:
On Sun, Aug 16, 2015 at 04:46:31PM +, Serge Hallyn wrote:
Quoting Christian Brauner (christianvanbrau...@gmail.com):
Integrating lxc-clone with the standard lxc parser is not possible unless
it is
allowed to change
On Fri, Aug 28, 2015 at 12:46:17AM +0200, Christian Brauner wrote:
> On Thu, Aug 27, 2015 at 03:41:03PM -0400, Stéphane Graber wrote:
> > On Sun, Aug 16, 2015 at 04:46:31PM +, Serge Hallyn wrote:
> > > Quoting Christian Brauner (christianvanbrau...@gmail.com):
> >
On Mon Aug 31, 2015 at 04:08:33PM +, Serge Hallyn wrote:
> Quoting Stéphane Graber (stgraber at ubuntu.com):
> > On Mon, Aug 31, 2015 at 01:43:07PM +, Serge Hallyn wrote:
> > > Quoting Christian Brauner (christianvanbrauner at gmail.com):
> > > > On Fri, Au
On Tue, Sep 08, 2015 at 02:36:20AM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
>
> Thanks, this looks good, but I'd like to give it another
> look w
On Mon, Sep 07, 2015 at 05:10:27PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
> >
> > 100.0% src/lxc/
> > diff --git a/src/lxc/lxccontainer.c b
On Mon, Sep 07, 2015 at 05:25:03PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > Now we can e.g. implement ephemeral containers in a consistent way.
> >
> > Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com&g
On Mon, Sep 07, 2015 at 05:10:27PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
> >
> > 100.0% src/lxc/
> > diff --git a/src/lxc/lxccontainer.c b
On Mon, Sep 07, 2015 at 05:13:56PM +, Serge Hallyn wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > Fixes for the return value checks.
> >
> > On Sun, Sep 06, 2015 at 10:38:21AM +0200, Christian Brauner wrote:
> > > Now we can e.g.
Yes, missed this. Updated patch follows after you reviewed the rest.
On Sep 8, 2015 9:19 PM, "Serge Hallyn" <serge.hal...@ubuntu.com> wrote:
> Quoting Christian Brauner (christianvanbrau...@gmail.com):
> > static do_bdev_destroy() and bdev_destroy_wrapper() from lxccontai
When lxc.ephemeral is set to 1 in the containers config it will be destroyed on
shutdown.
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/start.c | 58 +
1 file changed, 58 insertions(+)
diff --git a/s
static do_bdev_destroy() and bdev_destroy_wrapper() from lxccontainer.c become
public bdev_destroy() and bdev_destroy_wrapper() in bdev.c and bdev.h
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/bdev.c | 37 +
src/lxc/bdev.
These patches add the ability to destroy a container on shutdown when
lxc.ephemeral = 1 is set in the containers config file.
Tested with privileged and unprivileged btrfs-, overlayfs-, and aufs- containers
on Ubuntu Wily 15.04.
Christian Brauner (4):
Add lxc.ephemeral lxc.ephemeral
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/conf.h| 3 +++
src/lxc/confile.c | 20
2 files changed, 23 insertions(+)
diff --git a/src/lxc/conf.h b/src/lxc/conf.h
index dc5328a..5aebd91 100644
--- a/src/lxc/conf.h
+++ b/src/lxc/
Signed-off-by: Christian Brauner <christianvanbrau...@gmail.com>
---
src/lxc/lxccontainer.c | 62 --
1 file changed, 19 insertions(+), 43 deletions(-)
diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c
index fb99892..0eaf98e
1 - 100 of 515 matches
Mail list logo
