Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Jean-Marc Lasgouttes
Full day of teaching in Rouen. But yes, RER is on strike :) JMarc Le 14 juin 2016 21:41:12 GMT+02:00, Guillaume Munch a écrit : >Le 14/06/2016 20:16, Jean-Marc Lasgouttes a écrit : >> I will not be able to test until Thursday afternoon. >> > >RER is on strike ? ;)

Re: A tiny cedilla anomaly

2016-06-14 Thread Scott Kostyshak
On Thu, Jun 02, 2016 at 10:07:44PM -0400, Scott Kostyshak wrote: > On Tue, May 03, 2016 at 02:47:43PM +0100, Guillaume Munch wrote: > > Le 03/05/2016 06:09, Stephan Witt a écrit : > > > Am 03.05.2016 um 03:04 schrieb Guillaume Munch : > > > > > > > > Le 03/05/2016 01:40, Scott

Re: scrunched radio buttons on message pane

2016-06-14 Thread Scott Kostyshak
On Tue, Jun 14, 2016 at 06:19:27PM +, Paul A. Rubin wrote: > Scott Kostyshak lyx.org> writes: > > > > > Does anyone else see that the radio buttons are cut-off on the message > > pane? > > > > FWIW, they're find with LyX 2.2.0 /Qt 4.8.6 on Linux Mint Rebecca. > > Paul I forgot to

Re: One official build system?

2016-06-14 Thread Scott Kostyshak
On Tue, Jun 14, 2016 at 10:03:15PM +0200, Kornel Benko wrote: > Am Dienstag, 14. Juni 2016 um 14:56:21, schrieb Scott Kostyshak > > > On Tue, Jun 14, 2016 at 10:02:23AM +0200, Kornel Benko wrote: > > > Am Montag, 13. Juni 2016 um 19:09:04, schrieb Scott Kostyshak > > >

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

2016-06-14 Thread Scott Kostyshak
On Tue, Jun 14, 2016 at 10:24:18PM +0200, Georg Baum wrote: > Scott Kostyshak wrote: > > > Thanks to your comment, I realized that when I copy the master directory > > to e.g. master-mingw, the lyx-dependencies folder came with the copy. I > > removed that directory, and then removed the

Re: Tarballs for LyX 2.2.0 are on FTP

2016-06-14 Thread Enrico Forestieri
On Fri, Jun 10, 2016 at 10:20:32PM +0100, Guillaume Munch wrote: > As for lyx2lyx, I gave one example of a commit which explicitly said > that it would not be made round-trip, and another example where it had > to be fixed afterwards because a special case was not taken into > accountn because it

Re: lyx and dark color schemes

2016-06-14 Thread Cor Blom
Op 14-06-16 om 22:21 schreef Guillaume Munch: Le 14/06/2016 21:16, Cor Blom a écrit : Op 14-06-16 om 22:09 schreef Guillaume Munch: Le 14/06/2016 18:44, Cor Blom a écrit : Hi, Recently I tried lyx with a dark color scheme (breeze-dark under kde plasma 5). Ihe toolbar icons are problematic,

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Georg Baum
Guillaume Munch wrote: > What error is it? ../../src/MetricsInfo.cpp:61:4: error: type ‘lyx::MetricsBase’ is not a direct base of ‘lyx::MetricsBase’ BTW, if it is possible to keep gcc 4.6 supported for a while with little effort I am in favour of this as well, and I can do also some testing

Re: One official build system?

2016-06-14 Thread Georg Baum
Kornel Benko wrote: > The result is that cmake part misses > Makefile.in > automake misses > lib/fonts/*.sfd (11 files) > lib/images/ipa/*.svgz (30 files) > lib/images/oxygen/*.svgz (88 files) > src/mathed/InsetMathXYArrow.{cpp,h} >

Re: lyx and dark color schemes

2016-06-14 Thread Guillaume Munch
Le 14/06/2016 21:16, Cor Blom a écrit : Op 14-06-16 om 22:09 schreef Guillaume Munch: Le 14/06/2016 18:44, Cor Blom a écrit : Hi, Recently I tried lyx with a dark color scheme (breeze-dark under kde plasma 5). Ihe toolbar icons are problematic, but I know how to fix that (and the oxygen set

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

2016-06-14 Thread Georg Baum
Scott Kostyshak wrote: > Thanks to your comment, I realized that when I copy the master directory > to e.g. master-mingw, the lyx-dependencies folder came with the copy. I > removed that directory, and then removed the monolithic build option, > and now it works for me. To me it does rather look

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Guillaume Munch
Le 14/06/2016 20:55, Georg Baum a écrit : Guillaume Munch wrote: Le 14/06/2016 16:38, Jean-Marc Lasgouttes a écrit : but of course RefChange proved more difficult. I tried to define it as a subclass of unique_ptr, but then my C++11 default skills showed their weakness. What

Re: lyx and dark color schemes

2016-06-14 Thread Cor Blom
Op 14-06-16 om 22:09 schreef Guillaume Munch: Le 14/06/2016 18:44, Cor Blom a écrit : Hi, Recently I tried lyx with a dark color scheme (breeze-dark under kde plasma 5). Ihe toolbar icons are problematic, but I know how to fix that (and the oxygen set is not that bad against a dark

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Georg Baum
Guillaume Munch wrote: > Le 14/06/2016 16:38, Jean-Marc Lasgouttes a écrit : > >> but of course RefChange >> proved more difficult. I tried to define it as a subclass of >> unique_ptr, but then my C++11 default skills showed >> their weakness. > > What errors does it give with

Re: lyx and dark color schemes

2016-06-14 Thread Guillaume Munch
Le 14/06/2016 18:44, Cor Blom a écrit : Hi, Recently I tried lyx with a dark color scheme (breeze-dark under kde plasma 5). Ihe toolbar icons are problematic, but I know how to fix that (and the oxygen set is not that bad against a dark background). In general I'm happy about it. There is one

Re: #10214: Fail to Compile LyX with Visual C++ 2015

2016-06-14 Thread Georg Baum
Kornel Benko wrote: > I'd like to remove the file development/cmake/configCompiler.h.msvc. It > was meant as a cache-like set for compiler settings for msvc. +1 > As a first step I want to disable the possibility to select this bypass > (see attached) I expect this works for windows, but will

Re: One official build system?

2016-06-14 Thread Kornel Benko
Am Dienstag, 14. Juni 2016 um 14:56:21, schrieb Scott Kostyshak > On Tue, Jun 14, 2016 at 10:02:23AM +0200, Kornel Benko wrote: > > Am Montag, 13. Juni 2016 um 19:09:04, schrieb Scott Kostyshak > > > > > Note also that for me make package_source produces a

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Guillaume Munch
Le 14/06/2016 20:16, Jean-Marc Lasgouttes a écrit : Le 14/06/16 à 18:41, Guillaume Munch a écrit : but of course RefChange proved more difficult. I tried to define it as a subclass of unique_ptr, but then my C++11 default skills showed their weakness. What errors does it give

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Jean-Marc Lasgouttes
Le 14/06/16 à 18:41, Guillaume Munch a écrit : but of course RefChange proved more difficult. I tried to define it as a subclass of unique_ptr, but then my C++11 default skills showed their weakness. What errors does it give with the attached? I will not be able to test until

Re: One official build system?

2016-06-14 Thread Scott Kostyshak
On Tue, Jun 14, 2016 at 10:02:23AM +0200, Kornel Benko wrote: > Am Montag, 13. Juni 2016 um 19:09:04, schrieb Scott Kostyshak > > > Note also that for me make package_source produces a tar.gz, not a > > tar.xz as you suggested above. > > It depends on how you configure, so

Re: One official build system?

2016-06-14 Thread Pavel Sanda
Kornel Benko wrote: > (Select only one of them) > But, yes, .tar.xz is not created :( I know nothing of cmake, but we really want .xz. Not only it gets better compression ratio but it's standard already: http://henrich-on-debian.blogspot.cz/2016/06/which-compression-do-debian-packages-use.html

Re: scrunched radio buttons on message pane

2016-06-14 Thread Paul A . Rubin
Scott Kostyshak lyx.org> writes: > > Does anyone else see that the radio buttons are cut-off on the message > pane? > FWIW, they're find with LyX 2.2.0 /Qt 4.8.6 on Linux Mint Rebecca. Paul

lyx and dark color schemes

2016-06-14 Thread Cor Blom
Hi, Recently I tried lyx with a dark color scheme (breeze-dark under kde plasma 5). Ihe toolbar icons are problematic, but I know how to fix that (and the oxygen set is not that bad against a dark background). In general I'm happy about it. There is one issue. I don't know whether it's

Re: [LyX/master] Add perf comment

2016-06-14 Thread Guillaume Munch
Le 14/06/2016 17:31, Jean-Marc Lasgouttes a écrit : Le 14/06/2016 à 18:06, Guillaume Munch a écrit : Interesting. Is it only the loop in itself that is costly, or some of the functions it calls? The combined loop and recursion, I believe. But is the usual behavior is a no-op, except for

Re: [LyX/master] Add some comments to fix coverity #23386.

2016-06-14 Thread Richard Heck
On 06/14/2016 05:35 PM, Jean-Marc Lasgouttes wrote: Le 14/06/2016 à 18:29, Richard Heck a écrit : It's actually set by the call in createView to the GuiView constructor, which calls setCurrentView. Maybe we should add an assertion here? OK, maybe coverity does not know that guiapp is the

InPreamble Tag: Bug #10215

2016-06-14 Thread Richard Heck
Suppose you have a style like this: Style Test LaTeXType command LaTeXName whatever InPreamble 1 Preamble \newcommand\whatever[1]{#1} EndPreamble End Then LyX gives you: % LyX specific LaTeX commands. \whatever{this is a test} % Textclass specific LaTeX commands.

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Guillaume Munch
Le 14/06/2016 16:38, Jean-Marc Lasgouttes a écrit : Le 14/06/2016 à 16:39, Guillaume Munch a écrit : I am a little short on ideas so we could try the attached, and if it does not work try the commented version below it, and if it does not work, revert e87febd0 for the moment. What I am

Re: [LyX/master] Add some comments to fix coverity #23386.

2016-06-14 Thread Jean-Marc Lasgouttes
Le 14/06/2016 à 18:29, Richard Heck a écrit : It's actually set by the call in createView to the GuiView constructor, which calls setCurrentView. Maybe we should add an assertion here? OK, maybe coverity does not know that guiapp is the same GuiApplication object. I do not know what is the

Re: [LyX/master] Add perf comment

2016-06-14 Thread Jean-Marc Lasgouttes
Le 14/06/2016 à 18:06, Guillaume Munch a écrit : Interesting. Is it only the loop in itself that is costly, or some of the functions it calls? The combined loop and recursion, I believe. But is the usual behavior is a no-op, except for the few redefinitions done by the user, right? JMarc

Re: [LyX/master] Add some comments to fix coverity #23386.

2016-06-14 Thread Richard Heck
On 06/14/2016 05:17 PM, Jean-Marc Lasgouttes wrote: Le 12/06/2016 à 06:46, Richard Heck a écrit : commit 1bd5ef9a754a5b521f9d067b68fdac26035ef342 Author: Richard Heck Date: Sat Jun 11 23:26:02 2016 -0400 Add some comments to fix coverity #23386. diff --git

Re: [LyX/master] Add perf comment

2016-06-14 Thread Guillaume Munch
Le 14/06/2016 17:01, Jean-Marc Lasgouttes a écrit : Le 12/06/2016 à 20:23, Guillaume Munch a écrit : commit 89175ee0f10f75311e2a746dbd450fb23d6c2845 Author: Guillaume Munch Date: Sat Jun 11 09:14:38 2016 +0100 Add perf comment diff --git a/src/KeyMap.cpp b/src/KeyMap.cpp

Re: [LyX/master] Add some comments to fix coverity #23386.

2016-06-14 Thread Jean-Marc Lasgouttes
Le 12/06/2016 à 06:46, Richard Heck a écrit : commit 1bd5ef9a754a5b521f9d067b68fdac26035ef342 Author: Richard Heck Date: Sat Jun 11 23:26:02 2016 -0400 Add some comments to fix coverity #23386. diff --git a/src/frontends/qt4/GuiApplication.cpp

Re: [LyX/master] Add perf comment

2016-06-14 Thread Jean-Marc Lasgouttes
Le 12/06/2016 à 20:23, Guillaume Munch a écrit : commit 89175ee0f10f75311e2a746dbd450fb23d6c2845 Author: Guillaume Munch Date: Sat Jun 11 09:14:38 2016 +0100 Add perf comment diff --git a/src/KeyMap.cpp b/src/KeyMap.cpp index 7628d0d..32f9926 100644 --- a/src/KeyMap.cpp

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Jean-Marc Lasgouttes
Le 14/06/2016 à 16:39, Guillaume Munch a écrit : I am a little short on ideas so we could try the attached, and if it does not work try the commented version below it, and if it does not work, revert e87febd0 for the moment. What I am concerned about is future breakages, about which I will ask

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Guillaume Munch
Le 14/06/2016 10:38, Jean-Marc Lasgouttes a écrit : Le 13/06/2016 à 23:15, Guillaume Munch a écrit : I am not in charge for the machines around me and given 12.04 LTS ends up 2017-04 I don't expect any migration happening soon :) I am in a similar situation (although as I said, clang works).

Re: scrunched radio buttons on message pane

2016-06-14 Thread Andrew Parsloe
On 14/06/2016 6:52 p.m., Scott Kostyshak wrote: Does anyone else see that the radio buttons are cut-off on the message pane? Attached is a screenshot. Scott Attached is 2.2.0 on windows 7. No scrunching, but no colour. Andrew --- This email has been checked for viruses by Avast antivirus

Re: #10214: Fail to Compile LyX with Visual C++ 2015

2016-06-14 Thread Kornel Benko
Am Dienstag, 14. Juni 2016 um 02:24:02, schrieb LyX Ticket Tracker > #10214: Fail to Compile LyX with Visual C++ 2015 > -+-- > Reporter: zxvc | Owner: lasgouttes > Type: defect | Status: closed > Priority:

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Jean-Marc Lasgouttes
Le 13/06/2016 à 23:15, Guillaume Munch a écrit : I am not in charge for the machines around me and given 12.04 LTS ends up 2017-04 I don't expect any migration happening soon :) I am in a similar situation (although as I said, clang works). My fatest machine runs 12.04, only updated in terms

Re: scrunched radio buttons on message pane

2016-06-14 Thread Jean-Marc Lasgouttes
Le 14/06/2016 à 10:05, Kornel Benko a écrit : Am Dienstag, 14. Juni 2016 um 02:52:58, schrieb Scott Kostyshak Does anyone else see that the radio buttons are cut-off on the message pane? Attached is a screenshot. Scott I see the same. QT5.6. Same here with Qt 4.8.1,

Re: scrunched radio buttons on message pane

2016-06-14 Thread Kornel Benko
Am Dienstag, 14. Juni 2016 um 02:52:58, schrieb Scott Kostyshak > Does anyone else see that the radio buttons are cut-off on the message > pane? > > Attached is a screenshot. > > Scott I see the same. QT5.6. Kornel signature.asc Description: This is a digitally

Re: One official build system?

2016-06-14 Thread Kornel Benko
Am Montag, 13. Juni 2016 um 19:09:04, schrieb Scott Kostyshak > Note also that for me make package_source produces a tar.gz, not a > tar.xz as you suggested above. It depends on how you configure, so that 'make package' knows what to produce. 1.) -DCPACK_SOURCE_TGZ:BOOL=ON

Re: [PATCH] unique_ptr and some clean-up

2016-06-14 Thread Kornel Benko
Am Montag, 13. Juni 2016 um 22:15:02, schrieb Guillaume Munch > Le 13/06/2016 21:54, Pavel Sanda a écrit : > > Guillaume Munch wrote: > >> Starting from 2.3, LyX will require a C++11 compiler, and g++ 4.6 fails > >> (it seems) at a feature as elementary as generating a default move

scrunched radio buttons on message pane

2016-06-14 Thread Scott Kostyshak
Does anyone else see that the radio buttons are cut-off on the message pane? Attached is a screenshot. Scott signature.asc Description: PGP signature

Re: LyX 2.1.5 Tarballs

2016-06-14 Thread Jean-Pierre Chrétien
Le 13/06/2016 16:33, Richard Heck a écrit : The tarballs for the release of LyX 2.1.5 can be found here: ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.1/2.1.5/ Please prepare binaries. Compilation and installation run flawlessly as usual on Debian Jessie: Configuration Host type:

Re: LyX 2.1.5 Tarballs

2016-06-14 Thread Pavel Sanda
Richard Heck wrote: > > The tarballs for the release of LyX 2.1.5 can be found here: > ftp://ftp.lyx.org/pub/lyx/devel/lyx-2.1/2.1.5/ > Please prepare binaries. tested and seems to work on gentoo x86. p