Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 11:05:45AM -0500, Scott Kostyshak wrote: > Done in master at c5301a64. Riki, can this go to 2.3.x? Riki gave the OK (I accidentally sent an email without CC'ing devel). Pushed to 2.3.x at 4ea6d814. Scott signature.asc Description: PGP signature

Re: AICPA Support Case Created: Case #00005668

2018-12-28 Thread Richard Kimberly Heck
On 12/27/18 9:44 AM, Jürgen Spitzmüller wrote: > Am Freitag, den 05.10.2018, 11:49 -0400 schrieb Richard Kimberly Heck: >> I think it may have to do with lyx-cvs, rather than lyx-devel. I just >> tested this by pushing a commit, and I got the email. (That explains >> who >> gets them and who

Re: Windows build documentation

2018-12-28 Thread Richard Kimberly Heck
On 12/26/18 10:56 AM, Jürgen Womser-Schütz wrote: > Hi altogether :-) > > I am a newbi and I am trying to setup the LyX-build for my Win10/VS2017 > machine using "https://wiki.lyx.org/Windows/Compilation;. > It seems to me that the referred batch-file >

Re: Can't cancel suggestion context menu

2018-12-28 Thread Pavel Sanda
On Thu, Nov 29, 2018 at 01:33:17PM +0100, Pavel Sanda wrote: > On Wed, Nov 28, 2018 at 04:01:24PM +0100, Kornel Benko wrote: > > Am Montag, 26. November 2018 17:45:41 CET schrieb Pavel Sanda > > : > > > Hi, > > > > > > have english dictionary on, write "traces", leave cursor at the end of > > >

Layout/auto-nesting help

2018-12-28 Thread Paul A. Rubin
Hi, I'm working on a custom module, and I've bumped into unexpected difficulties getting autonesting to work. I've also run into a failure with Edit > Undo that baffles me. The attached MWE (give or take the "minimal" part) contains an explanation of what I'm trying to do and what is going

Re: lyx2lyx regression on master?

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 06:41:36PM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 12:12 -0500 schrieb Scott Kostyshak: > > > I seem to remember we agreed that lyx2lyx would be too hard to do > > > for > > > the cprotect thing. And indeed it would be very hard to track all > > >

Re: lyx2lyx regression on master?

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 12:12 -0500 schrieb Scott Kostyshak: > > I seem to remember we agreed that lyx2lyx would be too hard to do > > for > > the cprotect thing. And indeed it would be very hard to track all > > cases. > > Makes sense for not adding ERT. But would it be easy to at least >

Re: lyx2lyx regression on master?

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 05:55:09PM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 11:22 -0500 schrieb Scott Kostyshak: > > Indeed, the first problem seems to be a missing \cprotect here: > > > > \footnote{ASCII means \href{ > >

Re: lyx2lyx regression on master?

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 11:22 -0500 schrieb Scott Kostyshak: > Indeed, the first problem seems to be a missing \cprotect here: > > \footnote{ASCII means \href{ > https://en.wikipedia.org/wiki/ASCII\#Character_set}{this set} > > I guess it is too complicated to output the \cprotect in ERT?

Re: Strings to toggle table lines

2018-12-28 Thread Jean-Marc Lasgouttes
Le 28/12/2018 à 16:16, Kornel Benko a écrit : Am Freitag, 28. Dezember 2018 15:49:27 CET schrieb Jürgen Spitzmüller : Am Freitag, den 28.12.2018, 15:41 +0100 schrieb Kornel Benko: The menu strings in stdtoolbars.inc "Set bottom/top/left/right line" do not reflect the respective

Re: lyx2lyx regression on master?

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 09:55:08AM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 09:35 +0100 schrieb Jürgen Spitzmüller: > > Am Freitag, den 28.12.2018, 02:46 -0500 schrieb Scott Kostyshak: > > > Thanks, I no longer get those messages. However, there is a > > > compilation > > >

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 03:48:37PM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 09:44 -0500 schrieb Scott Kostyshak: > > Tested and works well. Do we also have to test that the inset's texts > > are the same? Just thinking about what you said above, it seems > > possible > > that

Re: Strings to toggle table lines

2018-12-28 Thread Kornel Benko
Am Freitag, 28. Dezember 2018 15:49:27 CET schrieb Jürgen Spitzmüller : > Am Freitag, den 28.12.2018, 15:41 +0100 schrieb Kornel Benko: > > The menu strings in stdtoolbars.inc > > "Set bottom/top/left/right line" > > do not reflect the respective function. > > > > Better seems to be for

Re: Strings to toggle table lines

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 15:41 +0100 schrieb Kornel Benko: > The menu strings in stdtoolbars.inc > "Set bottom/top/left/right line" > do not reflect the respective function. > > Better seems to be for instance > "Toggle bottom line" +1 Jürgen signature.asc Description: This

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 09:44 -0500 schrieb Scott Kostyshak: > Tested and works well. Do we also have to test that the inset's texts > are the same? Just thinking about what you said above, it seems > possible > that the pit and the cell could be the same, but be in different > inset's >

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Scott Kostyshak
On Fri, Dec 28, 2018 at 09:31:21AM +0100, Jürgen Spitzmüller wrote: > Am Freitag, den 28.12.2018, 02:29 -0500 schrieb Scott Kostyshak: > > Attached is a patch. It seems that the problem is: > > > > bool const in_last_par = (it.pit() == cur.selectionEnd().pit()); > > > > Apparently this doesn't

Strings to toggle table lines

2018-12-28 Thread Kornel Benko
The menu strings in stdtoolbars.inc "Set bottom/top/left/right line" do not reflect the respective function. Better seems to be for instance "Toggle bottom line" Kornel signature.asc Description: This is a digitally signed message part.

Re: lyx2lyx regression on master?

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 09:35 +0100 schrieb Jürgen Spitzmüller: > Am Freitag, den 28.12.2018, 02:46 -0500 schrieb Scott Kostyshak: > > Thanks, I no longer get those messages. However, there is a > > compilation > > error when compiling with pdflatex (with 2.3.x) the .lyx file that > > master

Re: lyx2lyx regression on master?

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 02:46 -0500 schrieb Scott Kostyshak: > Thanks, I no longer get those messages. However, there is a > compilation > error when compiling with pdflatex (with 2.3.x) the .lyx file that > master exports to 2.3.x format: > > ! Illegal parameter number in definition of

Re: [LyX/master] Fix crash when selecting text with changes

2018-12-28 Thread Jürgen Spitzmüller
Am Freitag, den 28.12.2018, 02:29 -0500 schrieb Scott Kostyshak: > Attached is a patch. It seems that the problem is: > > bool const in_last_par = (it.pit() == cur.selectionEnd().pit()); > > Apparently this doesn't always do what I thought it did. Replacing it > with > > bool const