Re: [PATCH] the dreaded work area patch again

2002-06-12 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | OK to apply ? yes. -- Lgb

Re: [PATCH] the dreaded work area patch again

2002-06-11 Thread John Levon
On Tue, Jun 11, 2002 at 10:41:16PM +0200, Asger K. Alstrup Nielsen wrote: > > 3. no core code is polluted with toolkit headers > > I see you added an X11-include into the pimpl.h file. > Why is that needed? For KeySym. It's a temporary step (my tree uses a struct instead). > So I'd say, depend

Re: [PATCH] the dreaded work area patch again

2002-06-11 Thread Asger K. Alstrup Nielsen
On Tue, 11 Jun 2002, John Levon wrote: > I'm going to try new "executive summaries" in the hope that this makes > the purpose AND the rationale of each patch clearer. > > o removes useless methods belowMouse() and active() from workarea > o hides access to the work area behind workarea() Good st

[PATCH] the dreaded work area patch again

2002-06-11 Thread John Levon
I'm going to try new "executive summaries" in the hope that this makes the purpose AND the rationale of each patch clearer. o removes useless methods belowMouse() and active() from workarea o hides access to the work area behind workarea() o makes workarea a scoped_ptr rather than a child The f