Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Angus Leeming
Bennett, I don't know if you saw this the first time round. Does it work? Angus Angus Leeming wrote: Angus Yes. I followed the prescription outlined in the bug report. Angus Without the patch, keyboard input went to the lyx screen. With Angus the patch, it went to the index dialog. And

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Bennett Helm
Bennett, I don't know if you saw this the first time round. Does it work? Sorry -- must have been asleep. Angus Leeming wrote: Angus Yes. I followed the prescription outlined in the bug report. Angus Without the patch, keyboard input went to the lyx screen. With Angus the patch, it went to the

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Jean-Marc Lasgouttes
Bennett == Bennett Helm [EMAIL PROTECTED] writes: Bennett The focus problem only occurs for Qt 3.1.2; it's not an issue Bennett for Qt 3.3.x -- for any version of LyX that I've tried. So Bennett the patch doesn't break anything, but I don't notice any Bennett difference with it. But would it be

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Angus Leeming
On Wednesday 09 June 2004 2:25 pm, Bennett Helm wrote: The focus problem only occurs for Qt 3.1.2; it's not an issue for Qt 3.3.x -- for any version of LyX that I've tried. So the patch doesn't break anything, but I don't notice any difference with it. Well, that's the version I'm running here

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus On Wednesday 09 June 2004 2:25 pm, Bennett Helm wrote: The focus problem only occurs for Qt 3.1.2; it's not an issue for Qt 3.3.x -- for any version of LyX that I've tried. So the patch doesn't break anything, but I don't notice any

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Jean-Marc Lasgouttes
Bennett == Bennett Helm [EMAIL PROTECTED] writes: Bennett On Jun 9, 2004, at 9:28 AM, Jean-Marc Lasgouttes wrote: Bennett == Bennett Helm [EMAIL PROTECTED] writes: Bennett The focus problem only occurs for Qt 3.1.2; it's not an issue Bennett for Qt 3.3.x -- for any version of LyX that I've

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Bennett == Bennett Helm [EMAIL PROTECTED] writes: Bennett On Jun 9, 2004, at 9:28 AM, Jean-Marc Lasgouttes wrote: Bennett == Bennett Helm [EMAIL PROTECTED] writes: Bennett The focus problem only occurs for Qt 3.1.2; it's not an issue Bennett for Qt 3.3.x -- for

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Angus On Wednesday 09 June 2004 2:25 pm, Bennett Helm wrote: The focus problem only occurs for Qt 3.1.2; it's not an issue for Qt 3.3.x -- for any version of LyX that I've tried. So the patch doesn't break anything, but I don't notice any difference with it.

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Angus Leeming
Bennett, I don't know if you saw this the first time round. Does it work? Angus > Angus Leeming wrote: >>> Angus> Yes. I followed the prescription outlined in the bug report. >>> Angus> Without the patch, keyboard input went to the lyx screen. >>> With Angus> the patch, it went to the index

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Bennett Helm
Bennett, I don't know if you saw this the first time round. Does it work? Sorry -- must have been asleep. Angus Leeming wrote: Angus> Yes. I followed the prescription outlined in the bug report. Angus> Without the patch, keyboard input went to the lyx screen. With Angus> the patch, it went to the

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> The focus problem only occurs for Qt 3.1.2; it's not an issue Bennett> for Qt 3.3.x -- for any version of LyX that I've tried. So Bennett> the patch doesn't break anything, but I don't notice any Bennett> difference with it.

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Angus Leeming
On Wednesday 09 June 2004 2:25 pm, Bennett Helm wrote: > The focus problem only occurs for Qt 3.1.2; it's not an issue for > Qt 3.3.x -- for any version of LyX that I've tried. So the patch > doesn't break anything, but I don't notice any difference with it. Well, that's the version I'm running

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> On Wednesday 09 June 2004 2:25 pm, Bennett Helm wrote: >> The focus problem only occurs for Qt 3.1.2; it's not an issue for >> Qt 3.3.x -- for any version of LyX that I've tried. So the patch >> doesn't break anything, but I don't

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> On Jun 9, 2004, at 9:28 AM, Jean-Marc Lasgouttes wrote: >>> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: >> Bennett> The focus problem only occurs for Qt 3.1.2; it's not an issue Bennett> for Qt 3.3.x -- for any

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: >> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: > > Bennett> On Jun 9, 2004, at 9:28 AM, Jean-Marc Lasgouttes wrote: "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: >>> > Bennett> The focus problem only occurs for Qt 3.1.2; it's not an

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-09 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> On Wednesday 09 June 2004 2:25 pm, Bennett Helm wrote: >>> The focus problem only occurs for Qt 3.1.2; it's not an issue for >>> Qt 3.3.x -- for any version of LyX that I've tried. So the patch >>> doesn't break anything, but I don't notice any difference with

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus Grand. Patch committed. Angus Jean-Marc, attached is the equivalent patch against 1.3.x. Angus Please add to your list of pending patches. Angus, I think you have been too fast for me there... I did not have time to tell you so, but I do

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Angus, I think you have been too fast for me there... I did not have time to tell you so, but I do not think this patch is appropriate after all. Then I'll revert it this evening. 1/ the focus problem that this patch fixes is gone with qt 3.3.x. This is good,

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus Jean-Marc Lasgouttes wrote: Angus, I think you have been too fast for me there... I did not have time to tell you so, but I do not think this patch is appropriate after all. Angus Then I'll revert it this evening. Thanks. 1/ the focus

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Angus Good. Note that this focus thing is not confined to the Mac. Angus The change worked also under linux. I take it that qt 3.3.x Angus does the right thing for all supported OSes? Did you notice a difference with your patch? I did not see any. Yes. I followed

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus Jean-Marc Lasgouttes wrote: Good. Note that this focus thing is Angus not confined to the Mac. The change worked also under linux. I Angus take it that qt 3.3.x does the right thing for all supported Angus OSes? Did you notice a difference

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus Jean-Marc Lasgouttes wrote: Good. Note that this focus thing is Angus not confined to the Mac. The change worked also under linux. I Angus take it that qt 3.3.x does the right thing for all supported Angus

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Bennett Helm
Jean-Marc Lasgouttes wrote: Angus Good. Note that this focus thing is not confined to the Mac. Angus The change worked also under linux. I take it that qt 3.3.x Angus does the right thing for all supported OSes? Did you notice a difference with your patch? I did not see any. Yes. I followed the

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Bennett Helm wrote: Jean-Marc Lasgouttes wrote: Angus Good. Note that this focus thing is not confined to the Mac. Angus The change worked also under linux. I take it that qt 3.3.x Angus does the right thing for all supported OSes? Did you notice a difference with your patch? I did not see

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: I've tried the patch on LyX/Mac. While it doesn't seem to affect the focus issue (which, as Jean-Marc noted, is not a problem with qt-3.3.x), it does change dialogs to be always on top -- to be modal -- which is not desirable on the Mac, at

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Bennett Helm
On Jun 2, 2004, at 10:45 AM, Jean-Marc Lasgouttes wrote: Angus == Angus Leeming [EMAIL PROTECTED] writes: I've tried the patch on LyX/Mac. While it doesn't seem to affect the focus issue (which, as Jean-Marc noted, is not a problem with qt-3.3.x), it does change dialogs to be always on top -- to

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Angus == Angus Leeming [EMAIL PROTECTED] writes: I've tried the patch on LyX/Mac. While it doesn't seem to affect the focus issue (which, as Jean-Marc noted, is not a problem with qt-3.3.x), it does change dialogs to be always on top -- to be modal -- which is

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus I'm not very good at bitwise fields, but a quick google turns Angus up this if you want to ensure that your dialog is always on Angus top. (QDialog dervies publicly from QWidget.) Angus QWidget::setWFlags(Qt::WType_Dialog |

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Angus Leeming wrote: Angus Yes. I followed the prescription outlined in the bug report. Angus Without the patch, keyboard input went to the lyx screen. With Angus the patch, it went to the index dialog. And does it give you a 'stay on top' behaviour? Yes, so I've reversed the patch. Am I

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Grand. Patch committed. Angus> Jean-Marc, attached is the equivalent patch against 1.3.x. Angus> Please add to your list of pending patches. Angus, I think you have been too fast for me there... I did not have time to tell you

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus, I think you have been too fast for me there... I did not have > time to tell you so, but I do not think this patch is appropriate > after all. Then I'll revert it this evening. > 1/ the focus problem that this patch fixes is gone with qt 3.3.x. > This is

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: >> Angus, I think you have been too fast for me there... I did not >> have time to tell you so, but I do not think this patch is >> appropriate after all. Angus> Then I'll revert it this evening.

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> Good. Note that this focus thing is not confined to the Mac. > Angus> The change worked also under linux. I take it that qt 3.3.x > Angus> does the right thing for all supported OSes? > > Did you notice a difference with your patch? I did not see any. Yes. I

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> Jean-Marc Lasgouttes wrote: Good. Note that this focus thing is Angus> not confined to the Mac. The change worked also under linux. I Angus> take it that qt 3.3.x does the right thing for all supported Angus> OSes? >> Did you

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: >> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > > Angus> Jean-Marc Lasgouttes wrote: Good. Note that this focus thing > is Angus> not confined to the Mac. The change worked also under > linux. I Angus> take it that qt 3.3.x does the right thing for all >

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Bennett Helm
Jean-Marc Lasgouttes wrote: Angus> Good. Note that this focus thing is not confined to the Mac. Angus> The change worked also under linux. I take it that qt 3.3.x Angus> does the right thing for all supported OSes? Did you notice a difference with your patch? I did not see any. Yes. I followed the

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Bennett Helm wrote: >> Jean-Marc Lasgouttes wrote: >>> Angus> Good. Note that this focus thing is not confined to the >>> Mac. Angus> The change worked also under linux. I take it that qt >>> 3.3.x Angus> does the right thing for all supported OSes? >>> >>> Did you notice a difference with your

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> I've tried the patch on LyX/Mac. While it doesn't seem to affect >> the focus issue (which, as Jean-Marc noted, is not a problem with >> qt-3.3.x), it does change dialogs to be always on top -- to be >> modal -- which is not desirable

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Bennett Helm
On Jun 2, 2004, at 10:45 AM, Jean-Marc Lasgouttes wrote: "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: I've tried the patch on LyX/Mac. While it doesn't seem to affect the focus issue (which, as Jean-Marc noted, is not a problem with qt-3.3.x), it does change dialogs to be always on top

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: >> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > >>> I've tried the patch on LyX/Mac. While it doesn't seem to affect >>> the focus issue (which, as Jean-Marc noted, is not a problem with >>> qt-3.3.x), it does change dialogs to be always on top -- to be

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> I'm not very good at bitwise fields, but a quick google turns Angus> up this if you want to ensure that your dialog is always on Angus> top. (QDialog dervies publicly from QWidget.) Angus> QWidget::setWFlags(Qt::WType_Dialog |

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-02 Thread Angus Leeming
Angus Leeming wrote: >> Angus> Yes. I followed the prescription outlined in the bug report. >> Angus> Without the patch, keyboard input went to the lyx screen. >> With Angus> the patch, it went to the index dialog. >> >> And does it give you a 'stay on top' behaviour? Yes, so I've reversed the

[patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-01 Thread Angus Leeming
Also the problem discussed in the thread lyx-1.3.4 dialogs not taking focus http://marc.theaimsgroup.com/?l=lyx-develm=108032034829874w=2 The solution is to tell the QDialog constructor who the parent is. Unfortunately, we have lots of dialogs, so this is a pain. I ran this little script over

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-01 Thread John Levon
On Tue, Jun 01, 2004 at 08:11:13PM +0100, Angus Leeming wrote: I ran this little script over the source to make the changes automatically. Patch for 1.4.x is attached. It fixes the problem described in the bug report but I think that some Qt guru should have a look. It's fine john

[patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-01 Thread Angus Leeming
Also the problem discussed in the thread "lyx-1.3.4 dialogs not taking focus" http://marc.theaimsgroup.com/?l=lyx-devel=108032034829874=2 The solution is to tell the QDialog constructor who the parent is. Unfortunately, we have lots of dialogs, so this is a pain. I ran this little script over

Re: [patch] bug 1530 --- Mac OS X dialogs often don't have focus

2004-06-01 Thread John Levon
On Tue, Jun 01, 2004 at 08:11:13PM +0100, Angus Leeming wrote: > I ran this little script over the source to make the changes > automatically. Patch for 1.4.x is attached. It fixes the problem > described in the bug report but I think that some Qt guru > should have a look. It's fine john