Georg Baum wrote:
Am Mittwoch, 5. Oktober 2005 23:22 schrieb Georg Baum:
Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller:
Did you also notice that if you insert the array which your fix in
math_parser
addresses at [1], save and reload, that the last \hline has vanished?
Georg Baum wrote:
Ping! We need to do something about this. I attach the patch again (ageinst
current CVS).
It fixes the two bugs I am aware of.
Jürgen
Georg Baum wrote:
> Am Mittwoch, 5. Oktober 2005 23:22 schrieb Georg Baum:
>> Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller:
>
>> > Did you also notice that if you insert the array which your fix in
>> math_parser
>> > addresses at [1], save and reload, that the last \hline has
Georg Baum wrote:
> Ping! We need to do something about this. I attach the patch again (ageinst
> current CVS).
It fixes the two bugs I am aware of.
Jürgen
Am Mittwoch, 5. Oktober 2005 23:22 schrieb Georg Baum:
Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller:
Did you also notice that if you insert the array which your fix in
math_parser
addresses at [1], save and reload, that the last \hline has vanished?
Almost: It does not
Am Mittwoch, 5. Oktober 2005 23:22 schrieb Georg Baum:
> Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller:
> > Did you also notice that if you insert the array which your fix in
> math_parser
> > addresses at [1], save and reload, that the last \hline has vanished?
>
> Almost: It
Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller:
Georg Baum wrote:
Yes, although my first thought was wrong. Actually the patch is almost
right, but it fails if you have a row with extra space (\\[2mm]).
Although there is no GUI for the latter and it is not documented, we
Am Montag, 3. Oktober 2005 18:09 schrieb Juergen Spitzmueller:
> Georg Baum wrote:
> > Yes, although my first thought was wrong. Actually the patch is almost
> > right, but it fails if you have a row with extra space (\\[2mm]).
> > Although there is no GUI for the latter and it is not documented,
Daniel Watkins wrote:
This stops the crash, but the undo does not work perfectly. If there is a
blank row at the bottom of the matrix, it is not restored. If there is more
than one empty row, only the bottom one is removed, but another one is
removed if the delete/undo is repeated, until there
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes:
Juergen Georg Baum wrote:
Why don't you put the code in MathNestInset? Since backspace at the
first position deletes the containing inset in every math inset I
think that recordUndoInset should also be called in general.
Juergen Yes,
Am Montag, 3. Oktober 2005 09:56 schrieb Juergen Spitzmueller:
This is a separate bug (# 2067 now). The bug is actually not in undo,
but in
MathGridInset::write. This means that a matrix with several empty rows
is
also exported to LaTeX incorrectly, because the end-of-line command was
not
Georg Baum wrote:
Unfortunately not :-( I changed the math parser some time ago to ignore
the last row if it is empty (see delEmptyLastRow). This is needed for
arrays with hlines after the last row.
If something has to be changed, then in the math parser (e.g. one could
only ignore the empty
Am Montag, 3. Oktober 2005 14:53 schrieb Juergen Spitzmueller:
Georg Baum wrote:
Unfortunately not :-( I changed the math parser some time ago to
ignore
the last row if it is empty (see delEmptyLastRow). This is needed for
arrays with hlines after the last row.
If something has to be
Georg Baum wrote:
Yes, although my first thought was wrong. Actually the patch is almost
right, but it fails if you have a row with extra space (\\[2mm]).
Although there is no GUI for the latter and it is not documented, we
should get this right.
OK.
I am working on this now (unfortunately
On Mon, Oct 03, 2005 at 09:56:09AM +0200, Juergen Spitzmueller wrote:
Does this look sensible?
Jürgen
P.S.: the context of the changes:
void MathGridInset::write(WriteStream os) const
{
[...]
string const s = verboseHLine(rowinfo_[nrows()].lines_);
if (!s.empty() s !=
Daniel Watkins wrote:
> This stops the crash, but the undo does not work perfectly. If there is a
> blank row at the bottom of the matrix, it is not restored. If there is more
> than one empty row, only the bottom one is removed, but another one is
> removed if the delete/undo is repeated, until
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Georg Baum wrote:
>> Why don't you put the code in MathNestInset? Since backspace at the
>> first position deletes the containing inset in every math inset I
>> think that recordUndoInset should also be called in
Am Montag, 3. Oktober 2005 09:56 schrieb Juergen Spitzmueller:
> This is a separate bug (# 2067 now). The bug is actually not in undo,
but in
> MathGridInset::write. This means that a matrix with several empty rows
is
> also exported to LaTeX incorrectly, because the end-of-line command was
Georg Baum wrote:
> Unfortunately not :-( I changed the math parser some time ago to ignore
> the last row if it is empty (see delEmptyLastRow). This is needed for
> arrays with hlines after the last row.
> If something has to be changed, then in the math parser (e.g. one could
> only ignore the
Am Montag, 3. Oktober 2005 14:53 schrieb Juergen Spitzmueller:
> Georg Baum wrote:
> > Unfortunately not :-( I changed the math parser some time ago to
ignore
> > the last row if it is empty (see delEmptyLastRow). This is needed for
> > arrays with hlines after the last row.
> > If something has
Georg Baum wrote:
> Yes, although my first thought was wrong. Actually the patch is almost
> right, but it fails if you have a row with extra space (\\[2mm]).
> Although there is no GUI for the latter and it is not documented, we
> should get this right.
OK.
> I am working on this now
On Mon, Oct 03, 2005 at 09:56:09AM +0200, Juergen Spitzmueller wrote:
> Does this look sensible?
>
> Jürgen
>
> P.S.: the context of the changes:
>
> void MathGridInset::write(WriteStream & os) const
> {
> [...]
> string const s = verboseHLine(rowinfo_[nrows()].lines_);
> if
Daniel Watkins wrote:
Bug 2058 (http://bugzilla.lyx.org/show_bug.cgi?id=2058): LyX crashes
when attempting to undo matrix deletion
Description:
When I attempt to undo (using Ctrl-Z) the deletion of a matrix (deleted
by pressing Backspace at the start of the top-left box), LyX crashes
with
Am Sonntag, 2. Oktober 2005 11:42 schrieb Juergen Spitzmueller:
The attached patch fixes it for me.
Why don't you put the code in MathNestInset? Since backspace at the first
position deletes the containing inset in every math inset I think that
recordUndoInset should also be called in
Georg Baum wrote:
Why don't you put the code in MathNestInset? Since backspace at the first
position deletes the containing inset in every math inset I think that
recordUndoInset should also be called in general.
Yes, why not (I was not aware of that feature, knowing mathed basically from
bug
On Sun, Oct 02, 2005 at 11:42:14AM +0200, Juergen Spitzmueller wrote:
Daniel Watkins wrote:
Bug 2058 (http://bugzilla.lyx.org/show_bug.cgi?id=2058): LyX crashes
when attempting to undo matrix deletion
Description:
When I attempt to undo (using Ctrl-Z) the deletion of a matrix (deleted
Daniel Watkins wrote:
> Bug 2058 (http://bugzilla.lyx.org/show_bug.cgi?id=2058): LyX crashes
> when attempting to undo matrix deletion
> Description:
> When I attempt to undo (using Ctrl-Z) the deletion of a matrix (deleted
> by pressing Backspace at the start of the top-left box), LyX crashes
>
Am Sonntag, 2. Oktober 2005 11:42 schrieb Juergen Spitzmueller:
> The attached patch fixes it for me.
Why don't you put the code in MathNestInset? Since backspace at the first
position deletes the containing inset in every math inset I think that
recordUndoInset should also be called in
Georg Baum wrote:
> Why don't you put the code in MathNestInset? Since backspace at the first
> position deletes the containing inset in every math inset I think that
> recordUndoInset should also be called in general.
Yes, why not (I was not aware of that feature, knowing mathed basically from
On Sun, Oct 02, 2005 at 11:42:14AM +0200, Juergen Spitzmueller wrote:
> Daniel Watkins wrote:
> > Bug 2058 (http://bugzilla.lyx.org/show_bug.cgi?id=2058): LyX crashes
> > when attempting to undo matrix deletion
> > Description:
> > When I attempt to undo (using Ctrl-Z) the deletion of a matrix
Bug 2058 (http://bugzilla.lyx.org/show_bug.cgi?id=2058): LyX crashes
when attempting to undo matrix deletion
Description:
When I attempt to undo (using Ctrl-Z) the deletion of a matrix (deleted
by pressing Backspace at the start of the top-left box), LyX crashes
with the appended CLI output.
Dan
Bug 2058 (http://bugzilla.lyx.org/show_bug.cgi?id=2058): LyX crashes
when attempting to undo matrix deletion
Description:
When I attempt to undo (using Ctrl-Z) the deletion of a matrix (deleted
by pressing Backspace at the start of the top-left box), LyX crashes
with the appended CLI output.
Dan
32 matches
Mail list logo