Re: [LyX/master] Add some comments to fix coverity #23386.

2016-06-14 Thread Richard Heck
On 06/14/2016 05:35 PM, Jean-Marc Lasgouttes wrote: Le 14/06/2016 à 18:29, Richard Heck a écrit : It's actually set by the call in createView to the GuiView constructor, which calls setCurrentView. Maybe we should add an assertion here? OK, maybe coverity does not know that guiapp is the

Re: [LyX/master] Add some comments to fix coverity #23386.

2016-06-14 Thread Jean-Marc Lasgouttes
Le 14/06/2016 à 18:29, Richard Heck a écrit : It's actually set by the call in createView to the GuiView constructor, which calls setCurrentView. Maybe we should add an assertion here? OK, maybe coverity does not know that guiapp is the same GuiApplication object. I do not know what is the

Re: [LyX/master] Add some comments to fix coverity #23386.

2016-06-14 Thread Richard Heck
On 06/14/2016 05:17 PM, Jean-Marc Lasgouttes wrote: Le 12/06/2016 à 06:46, Richard Heck a écrit : commit 1bd5ef9a754a5b521f9d067b68fdac26035ef342 Author: Richard Heck Date: Sat Jun 11 23:26:02 2016 -0400 Add some comments to fix coverity #23386. diff --git

Re: [LyX/master] Add some comments to fix coverity #23386.

2016-06-14 Thread Jean-Marc Lasgouttes
Le 12/06/2016 à 06:46, Richard Heck a écrit : commit 1bd5ef9a754a5b521f9d067b68fdac26035ef342 Author: Richard Heck Date: Sat Jun 11 23:26:02 2016 -0400 Add some comments to fix coverity #23386. diff --git a/src/frontends/qt4/GuiApplication.cpp