Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-27 Thread Pavel Sanda
On Thu, Aug 27, 2020 at 05:45:34PM +0200, Jürgen Spitzmüller wrote: > Am Donnerstag, den 27.08.2020, 17:30 +0200 schrieb Pavel Sanda: > > Didn't try yet, but I hope my shell script renamed to .py in $PATH > > would suffice to work ;) > > At least you will need to add (or swallow) the two viewer

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-27 Thread Jürgen Spitzmüller
Am Donnerstag, den 27.08.2020, 17:30 +0200 schrieb Pavel Sanda: > Didn't try yet, but I hope my shell script renamed to .py in $PATH > would suffice to work ;) At least you will need to add (or swallow) the two viewer options (-v and -w) which are now always passed to the script by LyX. And the

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-27 Thread Pavel Sanda
On Thu, Aug 27, 2020 at 08:47:55AM +0200, Jürgen Spitzmüller wrote: > Am Montag, den 24.08.2020, 14:24 +0200 schrieb Jürgen Spitzmüller: > > Am Montag, den 24.08.2020, 14:08 +0200 schrieb Pavel Sanda: > > > I saw that coming :) > > > I am all fine with that, except I don't want to be the one who >

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-27 Thread Jürgen Spitzmüller
Am Montag, den 24.08.2020, 14:24 +0200 schrieb Jürgen Spitzmüller: > Am Montag, den 24.08.2020, 14:08 +0200 schrieb Pavel Sanda: > > I saw that coming :) > > I am all fine with that, except I don't want to be the one who > > is commanded to implement it. > > I won't do it either. So let's keep

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Jürgen Spitzmüller
Am Montag, den 24.08.2020, 10:47 -0400 schrieb Richard Kimberly Heck: > On 8/24/20 8:24 AM, Jürgen Spitzmüller wrote: > > Am Montag, den 24.08.2020, 14:08 +0200 schrieb Pavel Sanda: > > > I saw that coming :) > > > I am all fine with that, except I don't want to be the one who > > > is commanded

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Richard Kimberly Heck
On 8/24/20 8:24 AM, Jürgen Spitzmüller wrote: > Am Montag, den 24.08.2020, 14:08 +0200 schrieb Pavel Sanda: >> I saw that coming :) >> I am all fine with that, except I don't want to be the one who >> is commanded to implement it. > I won't do it either. So let's keep this feature hidden under its

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Jürgen Spitzmüller
Am Montag, den 24.08.2020, 14:08 +0200 schrieb Pavel Sanda: > I saw that coming :) > I am all fine with that, except I don't want to be the one who > is commanded to implement it. I won't do it either. So let's keep this feature hidden under its stone. Jürgen signature.asc Description: This is

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Pavel Sanda
On Mon, Aug 24, 2020 at 01:58:47PM +0200, Jürgen Spitzmüller wrote: > Am Montag, den 24.08.2020, 13:13 +0200 schrieb Pavel Sanda: > > Tend to think that it has too many assumptions (like naming > > conventions of the files) that it's generally unlikely to > > work out of the box for people. > >

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Jürgen Spitzmüller
Am Montag, den 24.08.2020, 13:13 +0200 schrieb Pavel Sanda: > Tend to think that it has too many assumptions (like naming > conventions of the files) that it's generally unlikely to > work out of the box for people. We could at least make usage more convenient. As for the naming conventions:

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Pavel Sanda
On Mon, Aug 24, 2020 at 12:58:10PM +0200, Jürgen Spitzmüller wrote: > Sure, but we COULD make it using it (as we do for the other python > scripts). Sorry, misunderstood. I don't have strong opinion about this. Tend to think that it has too many assumptions (like naming convetions of the files)

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Jürgen Spitzmüller
Am Montag, den 24.08.2020, 12:45 +0200 schrieb Pavel Sanda: > > A python version could be launched directly from there, though. > > > The run won't be tried unless the RC variable is corretly set by > configure.py. > > And I hope configure won't find it in /share (at least it did not > find the

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Pavel Sanda
On Mon, Aug 24, 2020 at 11:59:00AM +0200, Jürgen Spitzmüller wrote: > Am Montag, den 24.08.2020, 11:48 +0200 schrieb Pavel Sanda: > > Correct. The template ends up usually in /usr/share/lyx/scripts/ > > which is not part of standard PATH. > > A python version could be launched directly from

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Jürgen Spitzmüller
Am Montag, den 24.08.2020, 11:48 +0200 schrieb Pavel Sanda: > Correct. The template ends up usually in /usr/share/lyx/scripts/ > which is not part of standard PATH. A python version could be launched directly from there, though. In that case, I'd rephrase the menu entry Item "Try Opening Cited

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Pavel Sanda
On Mon, Aug 24, 2020 at 09:33:19AM +0200, Jürgen Spitzmüller wrote: > Am Sonntag, den 23.08.2020, 22:23 +0200 schrieb Pavel Sanda: > > > Ok, adding to my todo list. P > > > > > > there there. p > > Am I right that users need to put the script in their paths themselves > in order to enable it?

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-24 Thread Jürgen Spitzmüller
Am Sonntag, den 23.08.2020, 22:23 +0200 schrieb Pavel Sanda: > > Ok, adding to my todo list. P > > > there there. p Am I right that users need to put the script in their paths themselves in order to enable it? (if so: good) Jürgen signature.asc Description: This is a digitally signed message

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-23 Thread Pavel Sanda
On Thu, Aug 20, 2020 at 01:09:06PM +0200, Pavel Sanda wrote: > On Thu, Aug 20, 2020 at 09:25:00AM +0200, Jürgen Spitzmüller wrote: > > Am Mittwoch, den 19.08.2020, 21:05 +0200 schrieb Pavel Sanda: > > > I know, but in that case external script still might be still > > > succesfull. > > > > > >

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-20 Thread Pavel Sanda
On Thu, Aug 20, 2020 at 09:25:00AM +0200, Jürgen Spitzmüller wrote: > Am Mittwoch, den 19.08.2020, 21:05 +0200 schrieb Pavel Sanda: > > I know, but in that case external script still might be still > > succesfull. > > > > The only option how to make it disabled for uninterested parties is > > to

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-20 Thread Jürgen Spitzmüller
Am Mittwoch, den 19.08.2020, 21:05 +0200 schrieb Pavel Sanda: > I know, but in that case external script still might be still > succesfull. > > The only option how to make it disabled for uninterested parties is > to put lyxpaperview script into configure script. Yes, please do that. It will be

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-20 Thread Pavel Sanda
On Wed, Aug 19, 2020 at 10:13:56PM -0400, Richard Kimberly Heck wrote: > I think it's fine to commit, and we can polish it as time permits. Thanks, initial version committed. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-19 Thread Richard Kimberly Heck
On 8/19/20 5:34 PM, Pavel Sanda wrote: > On Tue, Aug 18, 2020 at 10:21:23PM -0400, Richard Kimberly Heck wrote: > >>> +    if (is_bibtex_) { >>> +        doi = operator[]("doi"); >>> +        if (!doi.empty() && !prefixIs(doi,from_ascii("http"))) >>> +            doi = "https://doi.org/; + doi;

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-19 Thread Pavel Sanda
On Tue, Aug 18, 2020 at 10:21:23PM -0400, Richard Kimberly Heck wrote: > This does work with JabRef. Thanks for testing. > Space after the "&". Some other places for this, too, and spaces around > commas. Fixed. > > +    if (is_bibtex_) { > > +        doi = operator[]("doi"); > > +        if

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-19 Thread Pavel Sanda
On Wed, Aug 19, 2020 at 10:04:36AM +0200, Jürgen Spitzmüller wrote: > > > > + Item "Open citation content|O" "inset-edit" > > > > > > This should be an OptItem, and the function should be disabled if > > > the > > > citation in question does not have a target to follow. > > > > Not

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-19 Thread Jürgen Spitzmüller
Am Dienstag, den 18.08.2020, 22:06 +0200 schrieb Pavel Sanda: > On Tue, Aug 18, 2020 at 09:23:08AM +0200, Jürgen Spitzmüller wrote: > > > Item "Settings...|S" "inset-settings" > > > + Item "Open citation content|O" "inset-edit" > > > > This should be an OptItem, and

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-18 Thread Richard Kimberly Heck
This does work with JabRef. > diff --git a/src/BiblioInfo.cpp b/src/BiblioInfo.cpp > index e37d56389a..a9562c9170 100644 > --- a/src/BiblioInfo.cpp > +++ b/src/BiblioInfo.cpp > @@ -651,6 +651,72 @@ docstring const BibTeXInfo::getYear() const >  } >   >   > +void BibTeXInfo::getLocators(docstring

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-18 Thread Richard Kimberly Heck
On 8/18/20 12:37 PM, Pavel Sanda wrote: > On Mon, Aug 17, 2020 at 12:19:35PM -0400, Richard Kimberly Heck wrote: >>> There are several issues: >>> a) file= field is not standard bibtex, as I understood it's specific for >>> jabref, >>>which I do not use. Currenly it will work if full path is

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-18 Thread Pavel Sanda
On Tue, Aug 18, 2020 at 10:20:27AM -0400, Scott Kostyshak wrote: > One more thing: should the LFUN be disabled if the script is not found > in the PATH? I'm not suggesting it should be, just asking. If it should, > should this be done at run time or as part of the configure? It still should be

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-18 Thread Pavel Sanda
On Mon, Aug 17, 2020 at 12:19:35PM -0400, Richard Kimberly Heck wrote: > I see things like: > >   file = > {:/home/me/files/other_people/Antony/Antony-BeWhatISay.pdf:PDF}, > > but also > >   file = {:Antony-BeWhatISay.pdf:PDF}, > > if I put the file into the same directory as the bib

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-18 Thread Pavel Sanda
On Tue, Aug 18, 2020 at 09:23:08AM +0200, Jürgen Spitzmüller wrote: > > Item "Settings...|S" "inset-settings" > > + Item "Open citation content|O" "inset-edit" > > This should be an OptItem, and the function should be disabled if the > citation in question does not

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-18 Thread Pavel Sanda
On Mon, Aug 17, 2020 at 12:19:35PM -0400, Richard Kimberly Heck wrote: > > There are several issues: > > a) file= field is not standard bibtex, as I understood it's specific for > > jabref, > >which I do not use. Currenly it will work if full path is given but I > > have > >no clue what

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-18 Thread Scott Kostyshak
On Mon, Aug 17, 2020 at 08:16:44AM +0200, Pavel Sanda wrote: > On Mon, Aug 17, 2020 at 12:24:07AM -0400, Scott Kostyshak wrote: > > The script seems to be called whenever I choose *any* option from the > > context menu, not just the "Open citation content" option. > > Should be fixed now. > > >

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-18 Thread Jürgen Spitzmüller
Only some minor comments. Looks good in general. Am Montag, den 17.08.2020, 08:16 +0200 schrieb Pavel Sanda: > diff --git a/lib/ui/stdcontext.inc b/lib/ui/stdcontext.inc > index c2beb316f4..b47cd4d7f8 100644 > --- a/lib/ui/stdcontext.inc > +++ b/lib/ui/stdcontext.inc > @@ -128,6 +128,7 @@ Menuset

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-17 Thread Richard Kimberly Heck
On 8/16/20 6:10 PM, Pavel Sanda wrote: > On Sun, Aug 16, 2020 at 02:21:35PM -0400, Scott Kostyshak wrote: >> On Sun, Aug 16, 2020 at 04:34:36PM +0200, Pavel Sanda wrote: >>> On Sun, Aug 16, 2020 at 10:01:22AM -0400, Scott Kostyshak wrote: I like that idea a lot and would personally find it

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-17 Thread Pavel Sanda
On Mon, Aug 17, 2020 at 12:24:07AM -0400, Scott Kostyshak wrote: > The script seems to be called whenever I choose *any* option from the > context menu, not just the "Open citation content" option. Should be fixed now. > Regarding the hardcoding, it's hard to think of an alternative. If we >

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Scott Kostyshak
On Mon, Aug 17, 2020 at 12:10:24AM +0200, Pavel Sanda wrote: > Attached is updated patch. > For a given citation it does: > 1. check for existence of file= field in bib file, if found launch pdf viewer. > 2. else check for existence of DOI/URL in bib file. If found launch browser > with DOI/URL

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Pavel Sanda
On Sun, Aug 16, 2020 at 02:21:35PM -0400, Scott Kostyshak wrote: > On Sun, Aug 16, 2020 at 04:34:36PM +0200, Pavel Sanda wrote: > > On Sun, Aug 16, 2020 at 10:01:22AM -0400, Scott Kostyshak wrote: > > > > I like that idea a lot and would personally find it helpful. Here is a > > > related

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Scott Kostyshak
On Sun, Aug 16, 2020 at 04:34:36PM +0200, Pavel Sanda wrote: > On Sun, Aug 16, 2020 at 10:01:22AM -0400, Scott Kostyshak wrote: > > I like that idea a lot and would personally find it helpful. Here is a > > related request, although not many extra details: > > > > > >

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Pavel Sanda
On Sun, Aug 16, 2020 at 10:01:22AM -0400, Scott Kostyshak wrote: > > As a somewhat related issue I have very rough code (i.e. intended for my > > private patchset) which allows viewing papers cited in the document via > > the context menu of citation inset. > > > > ATM it is really shaped for my

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Pavel Sanda
On Fri, Aug 14, 2020 at 07:23:09PM +0200, Pavel Sanda wrote: > commit 48b1e8a0aca2f3f3faa8f1f800568e47792ba9a0 > Author: Pavel Sanda > Date: Fri Aug 14 19:46:13 2020 +0200 > > New attempt on #9906: allow following hyperlinks via context menu. > > Now safer version with the help of

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Scott Kostyshak
On Sat, Aug 15, 2020 at 08:01:04PM +0200, Pavel Sanda wrote: > On Fri, Aug 14, 2020 at 07:23:09PM +0200, Pavel Sanda wrote: > > commit 48b1e8a0aca2f3f3faa8f1f800568e47792ba9a0 > > Author: Pavel Sanda > > Date: Fri Aug 14 19:46:13 2020 +0200 > > > > New attempt on #9906: allow following