Jean-Marc Lasgouttes wrote:
Why should the quotation be OS-dependent?
quoteName is OS-dependent:
switch(style) {
case quote_shell:
// This does not work for filenames containing (windows)
// or ' (all other OSes). This can't be changed easily, since
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen OK, I can do a simple -quoting for the lfun argument. But
Jürgen then still the second problem needs to be solved:
Jürgen If I have file path/to/file name/file.ps dvips -t letter
Jürgen I can get target with getArg(0) and
Jean-Marc Lasgouttes wrote:
I would quote it too.
Excellent idea, as always.
OK for the attached?
Jürgen
Index: src/LyXFunc.cpp
===
--- src/LyXFunc.cpp (Revision 1)
+++ src/LyXFunc.cpp (Arbeitskopie)
@@ -989,21 +989,20 @@
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jean-Marc Lasgouttes wrote:
I would quote it too.
Jürgen Excellent idea, as always.
Note that this will fail if the commands already contain quotes. You
may want at least to add a FIXME in the code to this effect. It would
be
On Tuesday 26 June 2007 06:27:20 Jürgen Spitzmüller wrote:
Approved by Uwe. OK to commit?
OK.
Jürgen
--
José Abílio
Jean-Marc Lasgouttes wrote:
Note that this will fail if the commands already contain quotes. You
may want at least to add a FIXME in the code to this effect. It would
be possible to use LyXLex::quoteString to produce properly quoted
commands, but then FuncRequest::split would have to use Lexer
José Matos wrote:
Approved by Uwe. OK to commit?
OK.
done.
Jürgen
Jean-Marc Lasgouttes wrote:
> Why should the quotation be OS-dependent?
quoteName is OS-dependent:
switch(style) {
case quote_shell:
// This does not work for filenames containing " (windows)
// or ' (all other OSes). This can't be changed easily, since
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> OK, I can do a simple "-quoting for the lfun argument. But
Jürgen> then still the second problem needs to be solved:
Jürgen> If I have file "path/to/file name/file.ps" dvips -t letter
Jürgen> I can get target with
Jean-Marc Lasgouttes wrote:
> I would quote it too.
Excellent idea, as always.
OK for the attached?
Jürgen
Index: src/LyXFunc.cpp
===
--- src/LyXFunc.cpp (Revision 1)
+++ src/LyXFunc.cpp (Arbeitskopie)
@@ -989,21 +989,20 @@
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jean-Marc Lasgouttes wrote:
>> I would quote it too.
Jürgen> Excellent idea, as always.
Note that this will fail if the commands already contain quotes. You
may want at least to add a FIXME in the code to this effect. It
On Tuesday 26 June 2007 06:27:20 Jürgen Spitzmüller wrote:
> Approved by Uwe. OK to commit?
OK.
> Jürgen
--
José Abílio
Jean-Marc Lasgouttes wrote:
> Note that this will fail if the commands already contain quotes. You
> may want at least to add a FIXME in the code to this effect. It would
> be possible to use LyXLex::quoteString to produce properly quoted
> commands, but then FuncRequest::split would have to use
José Matos wrote:
> > Approved by Uwe. OK to commit?
>
> OK.
done.
Jürgen
Uwe Stöhr wrote:
The print dialog is currently unusable on Windows due to bug 3915:
http://bugzilla.lyx.org/show_bug.cgi?id=3915
While trying to find the reason for bug 3915 I found this crash bug:
http://bugzilla.lyx.org/show_bug.cgi?id=3916
Please try if the attached fixes the crash at
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen However, the attached patch should fix it (the fix for the
Jürgen crash is not included). If someone has a more elegant idea to
Jürgen strip out the target_name argument, please let me know.
What do the arguments of BUFFER_PRINT look
Jean-Marc Lasgouttes wrote:
What do the arguments of BUFFER_PRINT look like?
It's a string in the form file 'path/to/File Name/file.ps' dvips -t letter
We used to split up the string at each space, which gives:
- target: file
- target_name: 'path/to/File
- command: Name/file.ps' dvips -t
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jean-Marc Lasgouttes wrote:
What do the arguments of BUFFER_PRINT look like?
Jürgen It's a string in the form file 'path/to/File Name/file.ps'
Jürgen dvips -t letter
Jürgen We used to split up the string at each space, which gives:
Jean-Marc Lasgouttes wrote:
It seems to me that FuncRequest::getArg handles properly quoted
arguments. Can't you rely on that?
getArg handles only double-quoted arguments (the filename quoting is
OS-dependent). And it's difficult to get command with it, since that
includes alle the rest after
Jürgen Spitzmüller wrote:
Uwe Stöhr wrote:
The print dialog is currently unusable on Windows due to bug 3915:
http://bugzilla.lyx.org/show_bug.cgi?id=3915
Rather: printing to a file is completely broken when a path contains
spaces (not only on Windows).
I guess this went unnoticed since
Alfredo Braunstein wrote:
Maybe the quote handling stuff could go to support/ ?
Dunno. It's a rather specific case.
Jürgen
Alfredo Braunstein wrote:
Ah. How come it's not needed in other places where a filename is required
from the user? (Sorry if this is a stupid question :-) )
There we do not have to rip the filename off a complex string I guess.
Jürgen
Jürgen Spitzmüller wrote:
Alfredo Braunstein wrote:
Maybe the quote handling stuff could go to support/ ?
Dunno. It's a rather specific case.
Ah. How come it's not needed in other places where a filename is required
from the user? (Sorry if this is a stupid question :-) )
A/
Jürgen Spitzmüller wrote:
Please try if the attached fixes the crash
Approved by Uwe. OK to commit?
Jürgen
Jürgen Spitzmüller wrote:
The print dialog is currently unusable on Windows due to bug 3915:
http://bugzilla.lyx.org/show_bug.cgi?id=3915
the attached patch should fix it
Tested by Uwe. OK to commit?
Jürgen
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jürgen Spitzmüller wrote:
The print dialog is currently unusable on Windows due to bug
3915: http://bugzilla.lyx.org/show_bug.cgi?id=3915
the attached patch should fix it
Jürgen Tested by Uwe. OK to commit?
OK.
JMarc
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes:
Jürgen Jean-Marc Lasgouttes wrote:
It seems to me that FuncRequest::getArg handles properly quoted
arguments. Can't you rely on that?
Jürgen getArg handles only double-quoted arguments (the filename
Jürgen quoting is OS-dependent). And
Uwe Stöhr wrote:
> The print dialog is currently unusable on Windows due to bug 3915:
> http://bugzilla.lyx.org/show_bug.cgi?id=3915
> While trying to find the reason for bug 3915 I found this crash bug:
> http://bugzilla.lyx.org/show_bug.cgi?id=3916
Please try if the attached fixes the crash at
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> However, the attached patch should fix it (the fix for the
Jürgen> crash is not included). If someone has a more elegant idea to
Jürgen> strip out the target_name argument, please let me know.
What do the arguments of
Jean-Marc Lasgouttes wrote:
> What do the arguments of BUFFER_PRINT look like?
It's a string in the form "file 'path/to/File Name/file.ps' dvips -t letter"
We used to split up the string at each space, which gives:
- target: file
- target_name: 'path/to/File
- command: Name/file.ps' dvips -t
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jean-Marc Lasgouttes wrote:
>> What do the arguments of BUFFER_PRINT look like?
Jürgen> It's a string in the form "file 'path/to/File Name/file.ps'
Jürgen> dvips -t letter"
Jürgen> We used to split up the string at each
Jean-Marc Lasgouttes wrote:
> It seems to me that FuncRequest::getArg handles properly quoted
> arguments. Can't you rely on that?
getArg handles only double-quoted arguments (the filename quoting is
OS-dependent). And it's difficult to get command with it, since that
includes "alle the rest"
Jürgen Spitzmüller wrote:
> Uwe Stöhr wrote:
>> The print dialog is currently unusable on Windows due to bug 3915:
>> http://bugzilla.lyx.org/show_bug.cgi?id=3915
>
> Rather: printing to a file is completely broken when a path contains
> spaces (not only on Windows).
>
> I guess this went
Alfredo Braunstein wrote:
> Maybe the quote handling stuff could go to support/ ?
Dunno. It's a rather specific case.
Jürgen
Alfredo Braunstein wrote:
> Ah. How come it's not needed in other places where a filename is required
> from the user? (Sorry if this is a stupid question :-) )
There we do not have to rip the filename off a complex string I guess.
Jürgen
Jürgen Spitzmüller wrote:
> Alfredo Braunstein wrote:
>> Maybe the quote handling stuff could go to support/ ?
>
> Dunno. It's a rather specific case.
Ah. How come it's not needed in other places where a filename is required
from the user? (Sorry if this is a stupid question :-) )
A/
Jürgen Spitzmüller wrote:
> Please try if the attached fixes the crash
Approved by Uwe. OK to commit?
Jürgen
Jürgen Spitzmüller wrote:
> > The print dialog is currently unusable on Windows due to bug 3915:
> > http://bugzilla.lyx.org/show_bug.cgi?id=3915
> the attached patch should fix it
Tested by Uwe. OK to commit?
Jürgen
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jürgen Spitzmüller wrote:
>> > The print dialog is currently unusable on Windows due to bug
>> 3915: > http://bugzilla.lyx.org/show_bug.cgi?id=3915
>> the attached patch should fix it
Jürgen> Tested by Uwe. OK to commit?
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes:
Jürgen> Jean-Marc Lasgouttes wrote:
>> It seems to me that FuncRequest::getArg handles properly quoted
>> arguments. Can't you rely on that?
Jürgen> getArg handles only double-quoted arguments (the filename
Jürgen> quoting is
The print dialog is currently unusable on Windows due to bug 3915:
http://bugzilla.lyx.org/show_bug.cgi?id=3915
While trying to find the reason for bug 3915 I found this crash bug:
http://bugzilla.lyx.org/show_bug.cgi?id=3916
Due to these bugs I cannot test other print dialog bugs:
The print dialog is currently unusable on Windows due to bug 3915:
http://bugzilla.lyx.org/show_bug.cgi?id=3915
While trying to find the reason for bug 3915 I found this crash bug:
http://bugzilla.lyx.org/show_bug.cgi?id=3916
Due to these bugs I cannot test other print dialog bugs:
42 matches
Mail list logo
