Re: Linker error while building Lyx 2.2 on OSX

[Stephan Witt]

Am 15.09.2015 um 02:37 schrieb da...@dinh.io:

> Thanks for the suggestion about the messages window. I’ve found the error: 
> there is a typo on line 169 of Contents/Resources/configure.py, where ‘True' 
> is mis-capitalized as ‘true’. Fixing that solves the problem.

Oops. When I wrote this I was in Java-mode. Thanks. I've committed a fix now.

Stephan

> On Mon, Sep 14, 2015 at 2:07 PM, Stephan Witt  wrote:
> 
> Am 13.09.2015 um 21:39 schrieb da...@dinh.io: 
> 
> > The error message states “Lyx will only have minimal functionality because 
> > no textclasses have been found. You can either try to reconfigure LyX 
> > normally, try to reconfigure without checking your LaTeX installation, or 
> > continue.” Which ever choice (reconfigure, without latex, continue) I 
> > select, I get this message upon trying to create a new document: “The 
> > layout file: article could not be found. A default textclass with default 
> > layouts will be used. LyX will not be able to produce correct output." 
> > 
> > I’m using the 2015-06-13 version of mactex. The path settings for LyX (2.2 
> > above, 2.1 below) are here: https://i.imgur.com/28XrGLg.png 
> 
> These settings look ok. IMO, either your TeX engine couldn't 
> be found or LyX cannot detect a useful python interpreter. 
> 
> You may check the existence and/or contents of the file 
> $HOME/Library/Application\ Support/LyX-2.2/configure.log 
> to verify this. 
> 
> Another possibility to check for errors is to enable 
> debug messages (View -> Messages) and read the log 
> output there. 
> 
> Stephan 
> 
> > 
> > Thanks, 
> > ~David 
> > 
> > 
> > 
> > On Sun, Sep 13, 2015 at 3:00 AM, Stephan Witt  wrote: 
> > 
> > Am 12.09.2015 um 23:01 schrieb da...@dinh.io: 
> > 
> > > Thanks Stephan. 
> > > 
> > > When I launch this version of LyX, I got an error saying that textclasses 
> > > could not be found, which persisted even after I had updated the paths to 
> > > match my LyX 2.1 settings exactly. Are there any paths hardcoded into the 
> > > build? 
> > 
> > No, not that I'm aware of it. I've tested the LyX app on two additional 
> > different systems and didn't get any error message. Furthermore the paths 
> > of the 2.2 LyX preferences should have been copied from the 2.1 
> > preferences. What's the exact wording of the error message? 
> > 
> > Stephan 
> > 
> > PS. You've installed some TeX system like MacTeX? 
> > 
> > > On Sun, Sep 6, 2015 at 7:03 AM, Stephan Witt  wrote: 
> > > 
> > > > I’m having some difficulty building Lyx 2.2 (commit 0bbc80f) on OSX. 
> > > > Currently 
> > > > using Xcode 6.4 on OSX 10.10.5 and Qt 5.5.0 installed via Homebrew. 
> > > > automake.sh 
> > > > runs fine, and so does configure invoked as follows: 
> > > > 
> > > > 
> > > > ./configure --with-version-suffix=-2.2 --with-libiconv-prefix=/usr 
> > > > --with-x=no 
> > > > --disable-stdlib-debug --prefix=/Users/ddinh/Applications/Lyx-2.2.app 
> > > > --with-qt-dir=/usr/local/opt/qt5 --enable-qt5 --enable-cxx11 
> > > > 
> > > > 
> > > > which gives: 
> > > > 
> > > > 
> > > > Configuration 
> > > > Host type: x86_64-apple-darwin14.5.0 
> > > > Special build flags: build=development warnings assertions c++11-mode 
> > > > stdregex use-aspell use-enchant 
> > > > C++ Compiler: g++ 
> > > > C++ Compiler flags: -Wall -Wextra -fPIC -g -O -std=c++11 
> > > > -Wno-deprecated-register 
> > > > C++ Compiler user flags: 
> > > > Linker flags: 
> > > > Linker user flags: 
> > > > Qt Frontend: 
> > > > Qt version: 5.5.0 
> > > > Packaging: macosx 
> > > > LyX binary dir: /Users/ddinh/Applications/Lyx-2.2.app/Contents/MacOS 
> > > > LyX files dir: 
> > > > /Users/ddinh/Applications/Lyx-2.2.app/Contents/Resources 
> > > > 
> > > > 
> > > > On a call to make, compilation seems to work but linking fails as 
> > > > follows: 
> > > > 
> > > > 
> > > > rm -f hash-temp \ 
> > > > @echo " GEN lyx_commit_hash.h";hash=`cd ".." && git log -1 
> > > > --pretty=format:%H 2>/dev/null || echo none` ; \ 
> > > > sed s/@LYX_GIT_COMMIT_HASH@/$hash/ "."/lyx_commit_hash.h.in >hash-temp 
> > > > ; \ 
> > > > cmp -s lyx_commit_hash.h hash-temp || cp hash-temp lyx_commit_hash.h ; 
> > > > \ 
> > > > rm -f hash-temp 
> > > > CXXLD lyx 
> > > > clang: error: unknown argument: '-framework QtConcurrent' 
> > > > clang: error: unknown argument: '-framework QtSvg' 
> > > > clang: error: unknown argument: '-framework QtWidgets' 
> > > > clang: error: unknown argument: '-framework QtMacExtras' 
> > > > clang: error: unknown argument: '-framework QtGui' 
> > > > clang: error: unknown argument: '-framework QtCore' 
> > > > make[4]: *** [lyx] Error 1 
> > > > make[3]: *** [all-recursive] Error 1 
> > > > make[2]: *** [all] Error 2 
> > > > make[1]: *** [all-recursive] Error 1 
> > > > make: *** [all] Error 2 
> > > > 
> > > > 
> > > > Does anyone have experience with this error, or binaries of lyx 2.2? 
> > > 
> > > Hi David, 
> > > 
> > > I didn't use Homebrew before but 

Re: How to compile LyX in Win64?

[Georg Baum]

Kornel Benko wrote:

> Am Montag, 14. September 2015 um 10:17:02, schrieb Pål Næverlid Sævik
> 
>> Salutations!
>> 
>> I have been using LyX since writing my master's thesis. Now I've used it
>> for academic papers, coursework, my phd thesis and more. A big thank you
>> to the development team, the software has saved me a lot of work and
>> made writing academic documents much easier!
>> 
>> But, of course, there are always features I would like included and
>> certain improvements that I can envision. I know c++ pretty well, and am
>> curious if I would be able to make some contributions to the source
>> code. But I have never participated in an open source project before,
>> and the initial effort required to get involved is somewhat daunting...
>> I tried to compile LyX from the source code, but I use a 64-bit Windows
>> computer for work, and it seems like this platform is incompatible with
>> the source code package from the web site.

Your help would be very much appreciated!

> You may try to compile with help of cmake. There is a batch file
> "development/cmake/build.bat"
> which you may adapt to your need.
> Why do you think, the source code packaging is incompatible to 64bit
> Windows? Anyway, you can always use the git repository as source.

He probably refers to the precompiled dependencies (search 
LYX_DEPENDENCIES_DOWNLOAD in toplevel CMakeLists.txt). This is all the stuff 
we install on linux with a few clicks in the package manager like spell 
check libraries, iconv etc.

>> Is there any possibility for packaging the source code so that it would
>> work with Win64 and a collection of free (as in no-cost) software?

I believe there are three options:

- cygwin (works out of the box)
- MSVC (you need to compile the dependencies on your own for 64bit, but I 
don't know whether a 64bit MSVC version exists which is given away for free)
- mingw32 (IIRC Enrico knows how this works)

If you want to try to compile the dependencies on your own I can help 
answering questions, but I don't have a MSVC installation here, so I cannot 
try it out.


Georg

Re: Update on the patches

[Jean-Pierre Chrétien]

Le 15/09/2015 17:49, Guillaume Munch a écrit :

Le 14/09/2015 08:53, Jean-Marc Lasgouttes a écrit :



* Where should I commit po files? I vaguely remember reading somewhere
that
these should be against stable, do I remember correctly and in that
case is
it better to commit to master at the same time?


In general the po files of master are reinitialized from the stable ones
shortly before release. If you want to modify fr.po it is a good idea to
coordinate with Jean-Pierre Chretien.




CC: Jean-Pierre

These are just accelerator fixes that I've just pushed. I hope that it does not
interfere and that I did it in the right way.


Thanks for doing it, just mention it in the changelog, I send you an edited copy 
by separate mail.


Just keep me posted if you have to do similar changes.

--
Jean-Pierre

Testing Lyx 2.2

[Timo Roest]

Dear developers,

I read on the latex community forum that there might exist the possibility of 
testing lyx 2.2.
As I’m currently working from a macbook with retina display, I was hoping I 
could also be sent the installer when the installation files for mac OS have 
been compiled.

Kind regards,

Timo 

Re: Update on the patches

[Guillaume Munch]

Le 14/09/2015 09:03, Jean-Marc Lasgouttes a écrit :

Le 14/09/2015 02:22, Guillaume Munch a écrit :

One thing that would have helped was to have emacs configuration
files with the correct coding style that you use.

For instance my .emacs now reads (omitting irrelevant parts):


Such information could go in the relevant code rule file in
development/.


(custom-set-variables ;; custom-set-variables was added by Custom.
;; If you edit it by hand, you could mess it up, so be careful. ;;
Your init file should contain only one such instance. ;; If there
is more than one, they won't work right. '(c-basic-indent 2)
'(column-number-mode t) '(indent-tabs-mode nil)
'(safe-local-variable-values (quote ((c-set-offset (quote
innamespace) 0) (c-set-style . "bsd" '(save-place t nil
(saveplace)) '(shell-command-switch "-lc" t) '(show-paren-mode t)
'(tab-width 2))


This part is your generic part that is overwritten for LyX right?

Why is BSD a good style?


I can add the files to the repository, but has anybody something
better to suggest?


The best is probaly to cut and paste a slimmed down version to the
relevant file in development/.




I can remove more irrelevant parts and do that, but before that I am
hoping to get some better configuration if anybody else is using emacs.
BSD is just close to your style; the question is more: what is the
proper style to use?




As already pointed out, RELEASE-NOTES is to keep track of changes
that affect LyX configuration files (the markup is markdown,
actually). New features are here: http://wiki.lyx.org/LyX/NewInLyX22


Thanks, done.

Re: LyX on high resolution displays

[Guillaume Munch]

Le 14/09/2015 09:04, Jean-Marc Lasgouttes a écrit :

Le 14/09/2015 03:34, Guillaume Munch a écrit :

For the record, if Scott's indication on using CMake is not suitable, I
had to ./configure in Ubuntu as follows:

./configure --enable-qt5 --with-qt-dir=/usr/lib/x86_64-linux-gnu/qt5
--with-qt-libraries=/usr/lib/x86_64-linux-gnu/qt5
--with-qt-includes=/usr/include/x86_64-linux-gnu/qt5

Note the separate paths for libraries and includes, maybe Fedora makes
the same distinction. Maybe something would have to be fixed with the
autotools configuration.


What is the file layout in /usr/lib/x86_64-linux-gnu/qt5?



/usr/lib/x86_64-linux-gnu/qt5$ ls
bin  libexec  mkspecs  plugins  qml



Also, one can put qt5 in hi-dpi mode with:

  QT_DEVICE_PIXEL_RATIO=2 lyx

Then one can see for oneself that certain elements of the buffer view 
are scaled, other are left at 1px (at least in Linux). I don't have the 
colliding widgets though.

Re: How to compile LyX in Win64?

[Pål Næverlid Sævik]

Hello everyone,

And thanks for the interest! I am pleased to say that I am now able to compile 
and build LyX from the source code :-)

The thing I did differently on the second try, was to be extremely careful to 
install the correct versions of everything. In particular, I used the 32-bit 
versions of CMake, Python, Qt and MSVC, and used only 32-bit compilers. Using 
the 64-bit versions of some of these tools may also have been possible, but I 
just wanted to be on the safe side. Also, I used Qt4 instead of Qt5. Apart from 
this, I mostly followed the recipe containted in the INSTALL.Win32 file.

The resulting program looks a bit uglier than LyX 2.1 release version (e.g., a 
lot of toolbar options with no graphics), which I guess is because LyX 2.2 is 
work in progress.

My question now is what you would recommend as a good development workflow? Is 
it, for instance, possible to run LyX from within MSVC and apply breakpoints to 
step through the program? This is how I would usually debug my own small 
programming projects.

Pål

Kornel Benko wrote:


Am Montag, 14. September 2015 um 10:17:02, schrieb Pål Næverlid Sævik


Salutations!

I have been using LyX since writing my master's thesis. Now I've used it
for academic papers, coursework, my phd thesis and more. A big thank you
to the development team, the software has saved me a lot of work and
made writing academic documents much easier!

But, of course, there are always features I would like included and
certain improvements that I can envision. I know c++ pretty well, and am
curious if I would be able to make some contributions to the source
code. But I have never participated in an open source project before,
and the initial effort required to get involved is somewhat daunting...
I tried to compile LyX from the source code, but I use a 64-bit Windows
computer for work, and it seems like this platform is incompatible with
the source code package from the web site.


Your help would be very much appreciated!


You may try to compile with help of cmake. There is a batch file
"development/cmake/build.bat"
which you may adapt to your need.
Why do you think, the source code packaging is incompatible to 64bit
Windows? Anyway, you can always use the git repository as source.


He probably refers to the precompiled dependencies (search
LYX_DEPENDENCIES_DOWNLOAD in toplevel CMakeLists.txt). This is all the stuff
we install on linux with a few clicks in the package manager like spell
check libraries, iconv etc.


Is there any possibility for packaging the source code so that it would
work with Win64 and a collection of free (as in no-cost) software?


I believe there are three options:

- cygwin (works out of the box)
- MSVC (you need to compile the dependencies on your own for 64bit, but I
don't know whether a 64bit MSVC version exists which is given away for free)
- mingw32 (IIRC Enrico knows how this works)

If you want to try to compile the dependencies on your own I can help
answering questions, but I don't have a MSVC installation here, so I cannot
try it out.


Georg

Re: Update on the patches

[Guillaume Munch]

Le 14/09/2015 08:53, Jean-Marc Lasgouttes a écrit :



* Where should I commit po files? I vaguely remember reading somewhere
that
these should be against stable, do I remember correctly and in that
case is
it better to commit to master at the same time?


In general the po files of master are reinitialized from the stable ones
shortly before release. If you want to modify fr.po it is a good idea to
coordinate with Jean-Pierre Chretien.




CC: Jean-Pierre

These are just accelerator fixes that I've just pushed. I hope that it 
does not interfere and that I did it in the right way.



Guillaume

Re: How to compile LyX in Win64?

[Guillaume Munch]

Le 14/09/2015 09:17, Pål Næverlid Sævik a écrit :

But, of course, there are always features I would like included and
certain improvements that I can envision. I know c++ pretty well, and am
curious if I would be able to make some contributions to the source
code. But I have never participated in an open source project before,
and the initial effort required to get involved is somewhat daunting...



Aside from getting everything set up, a good advice which worked for me 
is to start with things simple to fix that annoy you personally, which 
is a good way to know the code. You can find a list of ideas on the bug 
tracker: 
, 
though you seem to have your own ideas. Once you get more familiar with 
the code it gets easier to think of bigger projects.

Re: Update on the patches

[Guillaume Munch]

Le 14/09/2015 23:39, Richard Heck a écrit :

On 09/13/2015 10:09 PM, Guillaume Munch wrote:

Le 13/09/2015 22:28, Richard Heck a écrit :

On 09/12/2015 09:31 PM, Guillaume Munch wrote:


* I would like to discuss another set of patches that makes it
convenient to navigate within floats: see
. To test the patch please
compare the behaviour, before and after, of the navigation menus and
of the outliner, in the presence of floats with 1) subfloats, 2)
multiple captions, 3) a total number of floats and subfloats of the
same type > 30. Detailed changes are in the patch header, as usual.
Would you prefer that I post directly the patches on the list in the
future?


I don't use floats much so am a bad person to test. But if you actually
want discussion of the patch, yes, post it here.



Here's a rebased version because it had already diverged...

1. Support for (std|boost)::make_shared.
I did not sense enough smart-pointer energy radiating from the code...
Sorry for the recompilation times.

2. Do not show subfigures in the menu (bug #9759)
The improvements to the navigation menu described in the original
message above.

3. Better construction of the TOC  for floats and captions using a new
TocBuilder class
Fixes the situation caused by 2. in the outliner.

4. New class InsetCaptionable
Generalisation to wraps and listings and some code factoring.


These looks all right to me. I'd go ahead. If there are problems,
they'll show up soon enough.

Richard




Thanks. Committed in master, please report any issue.

Re: How to compile LyX in Win64?

[Pål Næverlid Sævik]

It's not clear to me how to fix the dependencies... I'm going to leave 
it for now, and give it another try later on.  Just a summary:


- When I'm running LyX directly from MSVC (setting LyX as the startup 
project), all QT libraries are missing. After manually copying them into 
the Debug folder (MSVC output folder), I'm able to run LyX, but it does 
not know where to find .layout files and help files, for instance. And 
most of the toolbar graphics is gone. Which is weird since LyX is able 
to render SVG pictures within the document, as well as producing proper 
PDF output. So it has nothing to do with epstopdf missing.


- After compiling the Install project and copying the relevant QT files 
to the bin folder, I get a LyX distribution where the .layout files are 
placed where LyX can find them. But the toolbar graphics is still missing.


Pål

Den 15.09.2015 15:17, skrev Kornel Benko:

Am Dienstag, 15. September 2015 um 15:01:37, schrieb Pål Næverlid Sævik 


Thanks for the hint. I guess a quick fix would be to copy the missing
files from my LyX 2.1 installation.

It should be sufficient to install the missing QT part. No lyx recompilation 
needed.


I tried to copy everything from the
bin and Resources folders that was not already present in my compiled
version, but this does not solve the graphics issue. I can also add that
I'm able to insert .SVG and .PNG graphics in the lyx document and
preview the content in the editor, but not .EPS files.

You need a converter for the eps files. Look into
Tools->Preferences...->File Handling->Converters->Converter Definition: 
EPS->PDF (Graphics)

Probably missing exe like 'epstopdf'.

Kornel

Pål

Den 15.09.2015 14:25, skrev Kornel Benko:

Am Dienstag, 15. September 2015 um 14:03:11, schrieb Pål Næverlid Sævik 


Hello everyone,

And thanks for the interest! I am pleased to say that I am now able to compile 
and build LyX from the source code :-)

The thing I did differently on the second try, was to be extremely careful to 
install the correct versions of everything. In particular, I used the 32-bit 
versions of CMake, Python, Qt and MSVC, and used only 32-bit compilers. Using 
the 64-bit versions of some of these tools may also have been possible, but I 
just wanted to be on the safe side. Also, I used Qt4 instead of Qt5. Apart from 
this, I mostly followed the recipe containted in the INSTALL.Win32 file.

The resulting program looks a bit uglier than LyX 2.1 release version (e.g., a 
lot of toolbar options with no graphics), which I guess is because LyX 2.2 is 
work in progress.

This is because of missing libQtSvg lib. We are using svg version of our icons.
Don't know how to get this lib to Windows.
Under ubuntu it is part of 'libqt4-svg' package.


My question now is what you would recommend as a good development workflow? Is 
it, for instance, possible to run LyX from within MSVC and apply breakpoints to 
step through the program? This is how I would usually debug my own small 
programming projects.

Don't know, but feels reasonable.

Kornel

Re: How to compile LyX in Win64?

[Kornel Benko]

Am Dienstag, 15. September 2015 um 14:03:11, schrieb Pål Næverlid Sævik 

> Hello everyone,
> 
> And thanks for the interest! I am pleased to say that I am now able to 
> compile and build LyX from the source code :-)
> 
> The thing I did differently on the second try, was to be extremely careful to 
> install the correct versions of everything. In particular, I used the 32-bit 
> versions of CMake, Python, Qt and MSVC, and used only 32-bit compilers. Using 
> the 64-bit versions of some of these tools may also have been possible, but I 
> just wanted to be on the safe side. Also, I used Qt4 instead of Qt5. Apart 
> from this, I mostly followed the recipe containted in the INSTALL.Win32 file.
> 
> The resulting program looks a bit uglier than LyX 2.1 release version (e.g., 
> a lot of toolbar options with no graphics), which I guess is because LyX 2.2 
> is work in progress.

This is because of missing libQtSvg lib. We are using svg version of our icons.
Don't know how to get this lib to Windows.
Under ubuntu it is part of 'libqt4-svg' package.

> My question now is what you would recommend as a good development workflow? 
> Is it, for instance, possible to run LyX from within MSVC and apply 
> breakpoints to step through the program? This is how I would usually debug my 
> own small programming projects.

Don't know, but feels reasonable.

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: How to compile LyX in Win64?

[Kornel Benko]

Am Dienstag, 15. September 2015 um 15:01:37, schrieb Pål Næverlid Sævik 

> Thanks for the hint. I guess a quick fix would be to copy the missing 
> files from my LyX 2.1 installation.

It should be sufficient to install the missing QT part. No lyx recompilation 
needed.

> I tried to copy everything from the 
> bin and Resources folders that was not already present in my compiled 
> version, but this does not solve the graphics issue. I can also add that 
> I'm able to insert .SVG and .PNG graphics in the lyx document and 
> preview the content in the editor, but not .EPS files.

You need a converter for the eps files. Look into
Tools->Preferences...->File Handling->Converters->Converter Definition: 
EPS->PDF (Graphics)

Probably missing exe like 'epstopdf'.

Kornel
> Pål
> 
> Den 15.09.2015 14:25, skrev Kornel Benko:
> > Am Dienstag, 15. September 2015 um 14:03:11, schrieb Pål Næverlid Sævik 
> > 
> >> Hello everyone,
> >>
> >> And thanks for the interest! I am pleased to say that I am now able to 
> >> compile and build LyX from the source code :-)
> >>
> >> The thing I did differently on the second try, was to be extremely careful 
> >> to install the correct versions of everything. In particular, I used the 
> >> 32-bit versions of CMake, Python, Qt and MSVC, and used only 32-bit 
> >> compilers. Using the 64-bit versions of some of these tools may also have 
> >> been possible, but I just wanted to be on the safe side. Also, I used Qt4 
> >> instead of Qt5. Apart from this, I mostly followed the recipe containted 
> >> in the INSTALL.Win32 file.
> >>
> >> The resulting program looks a bit uglier than LyX 2.1 release version 
> >> (e.g., a lot of toolbar options with no graphics), which I guess is 
> >> because LyX 2.2 is work in progress.
> > This is because of missing libQtSvg lib. We are using svg version of our 
> > icons.
> > Don't know how to get this lib to Windows.
> > Under ubuntu it is part of 'libqt4-svg' package.
> >
> >> My question now is what you would recommend as a good development 
> >> workflow? Is it, for instance, possible to run LyX from within MSVC and 
> >> apply breakpoints to step through the program? This is how I would usually 
> >> debug my own small programming projects.
> > Don't know, but feels reasonable.
> >
> > Kornel
> 

signature.asc
Description: This is a digitally signed message part.

Re: How to compile LyX in Win64?

[Pål Næverlid Sævik]

Thanks for the hint. I guess a quick fix would be to copy the missing 
files from my LyX 2.1 installation. I tried to copy everything from the 
bin and Resources folders that was not already present in my compiled 
version, but this does not solve the graphics issue. I can also add that 
I'm able to insert .SVG and .PNG graphics in the lyx document and 
preview the content in the editor, but not .EPS files.


Pål

Den 15.09.2015 14:25, skrev Kornel Benko:

Am Dienstag, 15. September 2015 um 14:03:11, schrieb Pål Næverlid Sævik 


Hello everyone,

And thanks for the interest! I am pleased to say that I am now able to compile 
and build LyX from the source code :-)

The thing I did differently on the second try, was to be extremely careful to 
install the correct versions of everything. In particular, I used the 32-bit 
versions of CMake, Python, Qt and MSVC, and used only 32-bit compilers. Using 
the 64-bit versions of some of these tools may also have been possible, but I 
just wanted to be on the safe side. Also, I used Qt4 instead of Qt5. Apart from 
this, I mostly followed the recipe containted in the INSTALL.Win32 file.

The resulting program looks a bit uglier than LyX 2.1 release version (e.g., a 
lot of toolbar options with no graphics), which I guess is because LyX 2.2 is 
work in progress.

This is because of missing libQtSvg lib. We are using svg version of our icons.
Don't know how to get this lib to Windows.
Under ubuntu it is part of 'libqt4-svg' package.


My question now is what you would recommend as a good development workflow? Is 
it, for instance, possible to run LyX from within MSVC and apply breakpoints to 
step through the program? This is how I would usually debug my own small 
programming projects.

Don't know, but feels reasonable.

Kornel